The library Infection uses its own stream wrapper, see \Infection\StreamWrapper\IncludeInterceptor.

Because of that, the mutants created by the library are not used and that makes the whole library unusable if the tests use bypass-finals, because the stream wrapper is overriden.

I tried to guess how both stream wrappers could be used alongside each other but as I have no expertise at all in this topic it got hard very fast.

Do you think this could be possible? How could it be done? Can I help 🙂 ?

Hi, Is it possible that this package isn't ready for PHP 8.0 yet? I have problem using is_file() function. It executes url_stat(), which uses @$this->native(...), and when the file doesn't exist it throw some exception that is impossible to catch by try-catch block: "stat(): stat failed for 'filename'"

Reason behind this feature: Some frameworks stop working because of DIR and such, since the files are now served from tmp. This prompted me to add a more fine-grained control.

I added a test and documentation. The old behavior remains unaffected.

After upgrading to version 1.4.0 I get an error when running this command:

php -dxdebug.mode=coverage bin/phpunit

The error:

PHPUnit 9.5.24 #StandWithUkraine

Testing 
.Segmentation fault

This only occurs on 1.4.0, with version 1.3.1 everything works fine.

An idea is that only final followed by class or function is the keyword to remove. If followed by = (constant assigning value) or ( (method signature) it is a literal.

When \DG\BypassFinals::url_stat is called with the path of a file that does not exist on the filesystem, a warning is thrown: stat(): stat failed for /path/to/my/unexisting/file.

A check should be done before calling the native method with an invalid path.

This is a PR from comments made by @dg and @maks-rafalko in #9. It's confirmed to fix issues with using Infection and BypassFinals together, tested on two of my projects.

If a native function throws an exception, then we will not restore the stream wrapper. With this patch we will throw the exception AND restore the stream wrapper.

To reproduce:

BypassFinals::enable();

$customHandler = static function ($type, $msg, $file, $line) {
    throw new \ErrorException($msg, 0, $type, $file, $line);
};
set_error_handler($customHandler);

new Foo(); // This is rewritten
try {
    include 'non/existing/path.php';
} finally {
    restore_error_handler();
}

new Bar(); // This is still final!

It took me a good 2 hours to find this bug =)

The third argument has to be nullable. While the docs specify a signature lof public streamWrapper::stream_set_option ( int $option , int $arg1 , int $arg2 ) : bool they also say this: arg2: If option is STREAM_OPTION_BLOCKING: This option is not set.

The third argument has to be nullable. While the docs specify a signature lof public streamWrapper::stream_set_option ( int $option , int $arg1 , int $arg2 ) : bool they also say this: arg2: If option is STREAM_OPTION_BLOCKING: This option is not set.

We get errors like this TypeError: Argument 3 passed to DG\BypassFinals::stream_set_option() must be of the type int, null given because of this.

Hello, I am using the library for infection testing https://infection.github.io/guide/ and if the bypass-final library is enabled the infections are not working as expected - the coverage test is not working properly. example; the case where bypass is disabled; 100% coverage of infection

the case where the bypass is enabled; 20-30% coverage.

Could you please take a look at what might be wrong?

Other final classes mocked sucessfully. But \Closure from PHP core don't mocked =(

https://www.php.net/manual/en/class.closure.php

    public function test() {
       BypassFinals::enable(
       Mockery::mock(\Closure::class)
    }

Mockery\Exception: The class \Closure is marked final and its methods cannot be replaced. Classes marked final can be passed in to \Mockery::mock() as instantiated objects to create a partial mock, but only if the mock is not subject to type hinting checks.

/var/www/app/vendor/mockery/mockery/library/Mockery/Generator/MockConfiguration.php:332
/var/www/app/vendor/mockery/mockery/library/Mockery/Generator/MockConfiguration.php:434
/var/www/app/vendor/mockery/mockery/library/Mockery/Generator/StringManipulationGenerator.php:74
/var/www/app/vendor/mockery/mockery/library/Mockery/Generator/CachingGenerator.php:40
/var/www/app/vendor/mockery/mockery/library/Mockery/Container.php:221
/var/www/app/vendor/mockery/mockery/library/Mockery.php:114

    public function test() {
       BypassFinals::enable(
       $this->createMock(\Closure::class);
    }

Class "Closure" is declared "final" and cannot be mocked.

composer info | grep dg

dg/bypass-finals                                 v1.2.1                                Removes final keyword from source code on-the-fly and allows moc...

composer info | grep phpunit

phpunit/php-code-coverage                        8.0.2                                 Library that provides collection, processing, and rendering func...
phpunit/php-file-iterator                        3.0.4                                 FilterIterator implementation that filters files based on a list...
phpunit/php-invoker                              3.0.2                                 Invoke callables with a timeout
phpunit/php-text-template                        2.0.2                                 Simple template engine.
phpunit/php-timer                                3.1.4                                 Utility class for timing
phpunit/php-token-stream                         4.0.3                                 Wrapper around PHP's tokenizer extension.
phpunit/phpunit                                  9.1.5                                 The PHP Unit Testing framework.
rregeer/phpunit-coverage-check                   0.3.1                                 Check the code coverage using the clover report of phpunit

php -v

PHP 7.4.3 (cli) (built: Feb 18 2020 11:53:05) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.3, Copyright (c), by Zend Technologies
    with Xdebug v2.9.2, Copyright (c) 2002-2020, by Derick Rethans