Hi,

when using a non GMT DateTimezone and setting microseconds via

$this->setTime(
                idate('H', $this->getTimestamp()),
                idate('i', $this->getTimestamp()),
                idate('s', $this->getTimestamp()),
                (int) ClockMock::getFrozenDateTime()->format('u')
            );

the hour/minute is wrongly modified as idate() works on unix GMT-based timestamp. Example:

Let's assume 02.04.2022 18:00:00 as Berlin time.

$dt = (new DateTime('now', new DateTimeZone('Europe/Berlin')))

DateTime now contains:

date: 2022-04-02 18:00:00.0 Europe/Berlin (+02:00)

Now using

$dt->setTime(
                idate('H', $dt->getTimestamp()),
                idate('i', $dt->getTimestamp()),
                idate('s', $dt->getTimestamp())
);

$dt contains:

date: 2022-04-02 16:00:00.0 Europe/Berlin (+02:00).

This means the time is now set 2 hours back, but still the Europe/Berlin timezone.

Solution in DateTimeMock:

Use

$this->setTime(
                  (int) $this->format('H'),
                  (int) $this->format('i'),
                  (int) $this->format('s'),
                  (int) ClockMock::getFrozenDateTime()->format('u')
);

as this does't modify hour/minute/second when setting microseconds...

-mimo

Symfony 4.4 uses this strange construction to get the current time:

DateTime::createFromFormat('U', time())

In normal PHP that works fine, but the mocked version was throwing

TypeError: DateTime::createFromFormat() expects parameter 2 to be string, int given

This explicitly stringifies the $datetime parameter to match the behavior of the vanilla implementation. It also simplifies the workaround for createFromFormat returning the current time when the format doesn't contain any time parts. The prior overcomplicated version didn't work with the relative date structure returned for the 'U' format.

DateTimeImmutableMock is created by formatting a new DateTimeMock, and thus avoiding code duplication.

However, sometimes the timezone can be passed in the date format (for example: "2022-03-15 14:06:30+02:00").

The previous format used to create the immutable date from the mutable one (which was "Y-m-d H:i:s.u") doesn't include the date timezone. Because of this, the timezone of the immutable date is lost when it is passed in a formatted date.

Fixes https://github.com/slope-it/clock-mock/issues/17

Its pretty common with Symfonys time mocking to do \DateTime::createFromFormat('U', strval(time())); re: strict types Ive added the types otherwise you just get a type error from the int on time() also downstream from dateparse.

Hello, I have a problem that when I create an instance with $datetime and $timezone, it returns different results from Datetime.

Specifically, the case is as follows.

$expectedDatetimeFormat = '1986-06-05 12:13:14';
$timezone = new \DateTimeZone('Asia/Tokyo'); // +09:00

// not mocked Datetime
// This test succeed
$asiaTokyoTimezone = new \DateTime('1986-06-05 12:13:14', $timezone);
$this->assertSame($expectedDatetimeFormat, $asiaTokyoTimezone->format('Y-m-d H:i:s'));

// mocked Datetime
// This test fails
ClockMock::freeze(new \DateTime('2022-11-21 00:00:00'));
$asiaTokyoTimezone = new \DateTime('1986-06-05 12:13:14', $timezone);
$this->assertSame($expectedDatetimeFormat, $asiaTokyoTimezone->format('Y-m-d H:i:s')); // actual: 1986-06-05 21:13:14

Solution: Do try to set the $datetime with timezone when __construct. In src/DateTimeMock.php:

// ..
if ($datetime !== 'now' && $timezone !== null) {
    $datetime = $datetime . ' ' . $timezone->getName();
}
parent::__construct($datetime, $timezone);
// ...

Why PHP 7.1 is declared as not supported ? I see that uopz supports PHP 7.1+ , and nothing in the source code let me think that it's only compatible with PHP 7.4. Is there any particular reason ?

The following sequence of calls causes TypeError: DateTime::setTime() expects parameter 4 to be int, float given in clock-mock/src/ClockMock.php:177:

$now = new DateTime("2021-10-13 12:44:52.8549178");
ClockMock::freeze($now);

// next line throws
$datetime = DateTime::createFromFormat("Y-m-d H:i:s", "2021-10-13 12:44:52");

The reason is because date_parse returns this:

^ array:12 [
  "year" => 2021
  "month" => 10
  "day" => 13
  "hour" => 12
  "minute" => 44
  "second" => 52
  "fraction" => 0.0 <--- HERE
  "warning_count" => 0
  "warnings" => []
  "error_count" => 0
  "errors" => []
  "is_localtime" => false
]

Hello,

I'm having an issue when I want to instantiate a DateTime using the createFromFormat method if I specify the format as now and the datetime as a date with no time (ex: 2022-08-04).

Example:

ClockMock::freeze(new \DateTimeImmutable('1986-06-05 12:13:14'));
$dateTime = \DateTime::createFromFormat('\n\o\w', '2022-01-01');

Output:

Error: Call to a member function setTime() on bool

Expected: The createFromFormat method must return false if the date doesn't match the format.

Solution: Do not try to set the time when \DateTime::createFromFormat returns false. In src/ClockMock.php: Replace

private static function mock_date_create_from_format(): callable
{
// ...
if ($parsedDate['hour'] === false) {
// ..
}

With:

private static function mock_date_create_from_format(): callable
{
// ...
if ($parsedDate['hour'] === false && $dateTimeObject !== false) {
// ...
}

~ faille76

Hi,

Using the ClockMock::freeze influences my other test cases with PHPUnit, even doing a ClockMock::reset.

The specific case is when creating a DateTime with the createFromFormat method. But also via DateTimeImmutable, and the other php functions date_create_from_format, date_create_immutable_from_format.

Example:

ClockMock::freeze(new \DateTimeImmutable('1986-06-05 12:13:14'));
ClockMock::reset();

$dateTime = \DateTime::createFromFormat('\n\o\w', 'now');

Output:

Error: Call to a member function format() on null

Solution: Reset the functions and methods with uopz_unset_return and uopz_unset_return when calling ClockMock::reset()

In src/ClockMock.php: Add the following code in the reset method:

public static function reset(): void
{
      // ...
      uopz_unset_return('date_create_from_format');
      uopz_unset_return('date_create_immutable_from_format');
      uopz_unset_return(\DateTime::class, 'createFromFormat');
      uopz_unset_return(\DateTimeImmutable::class, 'createFromFormat');
      // ...
}

Test case:

public function test_date_create_from_format_freeze_reset_must_not_use_mock()
{
    ClockMock::freeze(new \DateTimeImmutable('1986-06-05 12:13:14'));
    ClockMock::reset();

    $dateTime = \DateTime::createFromFormat('\n\o\w', 'now');

    $this->assertInstanceOf(\DateTime::class, $dateTime);
}

~faille76

This likely need to be tagged with 0.4.x as removing deprecated functions shouldn't affect former php versions.

Not sure if there's a need to implement compatible mocks for these