Hi Mateus,

I believe this is related to what we already talked about, but it has happened to me because I was not attentive to linebreak and then ->magic(). I decided to write here just to have it.

When I make an assertion with a one line chained method $browser->visit('/')->magic();

<?php

namespace Tests\Browser;

use Illuminate\Foundation\Testing\DatabaseMigrations;
use Laravel\Dusk\Browser;
use Tests\DuskTestCase;

class danTest extends DuskTestCase
{
    /**
     * A Dusk test example.
     *
     * @return void
     */
    public function testExample()
    {
        $this->browse(function (Browser $browser) {
            $browser->visit('/')->magic();
        });
    }
}

....It results in:

<?php

namespace Tests\Browser;

use Illuminate\Foundation\Testing\DatabaseMigrations;
use Laravel\Dusk\Browser;
use Tests\DuskTestCase;

class danTest extends DuskTestCase
{
    /**
     * A Dusk test example.
     *
     * @return void
     */
    public function testExample()
    {
        $this->browse(function (Browser $browser) {
                    ->assertSee('Language')
            $browser->visit('/')->magic();
        });
    }
}

https://github.com/magic-test/magic-test-laravel/blob/b1d9d22951da5de941c3f65cfff9d9e1fcf34078/src/MagicTest.php#L38

When setting APP_DEBUG=false in my .env, MagicTest crashes on the above line of code. Looks like it could be fixed by replacing self::minify($scripts) with self::minify($script) (removing the last 's' of the variable name).

Can someone confirm that this would be the needed fix? Or, am I missing something :)

I might have this setup incorrectly (which is a separate issue) but I did find this problem.

When using Inertia, there are some included test helpers, assertInertia being one, that when the magic test middleware is enabled, will cause these tests to fail. I haven't dug into why, but I assume it has to do with the extra stuff that the middleware adds to a response. Removing the middleware fixes it.

As a side note, the documentation could be clearer around where the package should be installed/enabled. If it's a dev dependency, then adding a middleware seems like the wrong approach (since it will break in prod?) (also sorry for double dipping on twitter! I found this issue afterwards)

If I run "php artisan magic" on windows, I'm getting the following error:

Your Magic Test session is starting... 'DUSK_HEADLESS_DISABLED' is not recognized as an internal or external command, operable program or batch file.

I see the command is trying to shell_exec: DUSK_HEADLESS_DISABLED=1 MAGIC_TEST=1 php artisan dusk

I'm testing this on a Ubuntu 20.04 VM with Chrome (latest) and I get this javascript error: 1) Tests\Browser\ExampleTest::testBasicExample Facebook\WebDriver\Exception\JavascriptErrorException: javascript error: MagicTest is not defined (Session info: headless chrome=95.0.4638.69)

how can i fix this?

This PR aims to rewrite the current parser to use Nikita Popov's PHP-Parser.

One of the biggest issues with MT right now is that it never actually knows where methods start or end, since it relies on new line characters and expects each line to have only one method. Using PHP-Parser we gain more control over the code being rewritten.

Also, the biggest issue I'm facing is that I'm not 100% sure what I'm doing. I've never worked with PHP-Parser and there's some behavior that seems weird to me. For instance, imagine the following:

class ExampleTest extends DuskTestCase
{
    /**
     * A basic browser test example.
     *
     * @return void
     */
    public function testBasicExample()
    {
        $this->browse(function (Browser $browser) {
            $browser->visit('/')
                    ->clickLink('foo')
                    ->magic();
        });
    }
}

There's a PhpParser\Node\Stmt\ClassMethodthat is testBasicExample. Okay, that makes sense. There's a MethodCall that is the $this->browser call. Then there is the closure (a PhpParser\Node\Expr\Closure).

Now, inside the closure, there's a Node that corresponds to the magic() call and is a PhpParser\Node\Stmt\MethodCall. The issue is that the previous chained methods are nested inside it's var property. So if you had 3 method calls, you'd have 3 nested MethodCall, each one being the FOLLOWING var. So you end up with something like this:

MethodCall(
    name: 'magic',
    var: MethodCall(
        name: 'clickLink',
        var: MethodCall(
            name: visit
          )
      )
)

I'm unsure, but I think I was maybe expecting it to have an expression and several sibling nodes (or parent-child) for the chain.

Anyway, it works, but I'm doing some nasty old magic with the nodes.

Remaining:

• Heavily test this
• Try to properly understand how the nodes work
• Refactor the existing classes

Arrow functions

https://github.com/magic-test/magic-test-laravel/blob/1c7ea46ed8ffd881c282ad42f8281477e5c5f875/src/Parser/File.php#L63-L66

and typed properties

https://github.com/magic-test/magic-test-laravel/blob/1c7ea46ed8ffd881c282ad42f8281477e5c5f875/src/Parser/File.php#L12-L16

were introduced in php 7.4 https://www.php.net/releases/7_4_0.php

json_decode is called here: https://github.com/magic-test/magic-test-laravel/blob/1c7ea46ed8ffd881c282ad42f8281477e5c5f875/src/MagicTestManager.php#L52

This import breaks my code, since I use jquery, and this import at the end of the html code, it makes my packages that need jquery not work.

This can be solved using your own config file. This is just an idea, as I still can't do a PR with the complete solution. This PR is more in order to warn of this behavior, since it makes the devs import the jquery just to do the tests which is not ideal.

For those of us who run our Dusk tests in a dedicated environment, scripts aren't loaded by the middleware as it requires either local or testing. I've added dusk to allow them to be included.

I expect most people won't be affected by this, this is more niche for some apps which like to more clearly identify the execution context, but it saves having to override the middleware entirely.

Thanks!

Bumps postcss from 8.2.6 to 8.2.13.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Session info: chrome=95.0.4638.69

[
    {
        "level": "WARNING",
        "message": "chrome-error:\/\/chromewebdata\/ 928:22 \"crbug\/1173575, non-JS module files deprecated.\"",
        "source": "console-api",
        "timestamp": 1636308045214
    },
    {
        "level": "WARNING",
        "message": "chrome-error:\/\/chromewebdata\/ 1249:22 \"crbug\/1173575, non-JS module files deprecated.\"",
        "source": "console-api",
        "timestamp": 1636308045215
    },
    {
        "level": "WARNING",
        "message": "chrome-error:\/\/chromewebdata\/ 2133:10 \"crbug\/1173575, non-JS module files deprecated.\"",
        "source": "console-api",
        "timestamp": 1636308045222
    }
]

Very close to being able to use this wonderful tool, any help much appreciated.

I run: ./artisan magic, a Chrome is being controlled by automated test software browser window comes up, dev console shows:

Magic Test started

I log in, dev console looks ok, no errors. Nothing in network tab relating to magic-test-laravel or testing generally.

If I select text & press Ctrl + Shift + A the dialogue box pops up saying assertion generated.

I go into psy shell, type ok but get the message:

RuntimeException with message 'Too many arguments, expected arguments "command".' in: Psy Shell v0.10.12 (PHP 8.1.2 — cli)

No major changes are made to the ExampleTest.php which has the simplest initial test method in it:

    public function testBasicExample()
    {
        $this->browse(function (Browser $browser) {
            $browser->visit('/')
                //    ->assertSee('Laravel');
                ->magic();
        });
    }

What could be wrong? Full output here:

*** Starting a 🧙 Magic Test session...
PHPUnit 9.5.13 by Sebastian Bergmann and contributors.

Psy Shell v0.10.12 (PHP 8.1.2 — cli) by Justin Hileman
New version is available (current: v0.10.12, latest: v0.11.1)

*** Welcome to your 🧙 Magic Test session! ***

* To make a assertion press Ctrl + Shift + A on your browser.
* Type ok to magically write it to your test file.
  (make as many assertions as you wish)
* Type finish to finalize and save your test file.
* Type exit to leave.

💡 Tip: Do not close your browser window before finalizing this session here.
>>> ok
RuntimeException with message 'Too many arguments, expected arguments "command".'

Using https://chromedriver.storage.googleapis.com/97.0.4692.71/chromedriver_mac64_m1.zip for the installed browser Version 97.0.4692.99 (Official Build) (arm64)

./artisan tinker works fine for the same project.

./artisan dusk returns OK (1 test, 1 assertion) when I switch commenting on magic() and assetSee('Laravel').

Description

After installing Magic Test and following the installation and usage instructions I am receiving the following error after running the ok or finish commands.

TypeError: Typed property MagicTest/MagicTest/Parser/File::$initialMethodLine must be an instance of MagicTest/MagicTest/Parser/Line, null used

I am using the testBasicExample method of the ExampleTest in my browser tests as per the usage guide. The contents of my test is

<?php

namespace Tests\Browser;

use Illuminate\Foundation\Testing\DatabaseMigrations;
use Laravel\Dusk\Browser;
use Tests\DuskTestCase;

class ExampleTest extends DuskTestCase
{
    /**
     * A basic browser test example.
     *
     * @return void
     */
    public function testBasicExample()
    {
        $this->browse(function (Browser $browser) {
            $browser->visit('/')
                    ->magic();
        });
    }
}

Specifications

• PHP Version: 7.4.13
• Laravel Version: 8.9.0