:heavy_check_mark: PHP Test Framework for Freedom, Truth, and Justice

Hi,

Thanks for Kahlan brilliant project, however I have problems when it comes to debugging code I've written, breakpoints won't trigger in files outside of the file where the test is defined

I understand that kahlan recreates code referenced in tests due to it's implementation etc and thats why the breakpoints aren't reached (because that file isn't actually being run)

Is there anyway around this or anything I can do in my IDE so that breakpoints work whilst tests are being run?

I'm using vscode

It would be nice to be able to focus a single test or suite of test via command line arguments, rather then just having the fit(...), or fdescribe(...) notation. This feature exists in other BDD frameworks like Jest, and I think Pest, and could give us the ability to more easily create plugins for editors.

Currently I can exclude namespaces to patch via:

$this->commandLine()->set('exclude', [
    'com\example\someapp\etc'
]);

However what I want to do is exclude the vendor directory entirely. I even think that's probably a more common use-case requirement for excluding? Dunno.

A similar argument could be made for the include option, I think.

It's not a big problem for me in the bigger scheme of things, as I can just include my own namespace, and that "should" work.

I'm porting my tests from PHPUnit. Today I've been looking at dealing with incomplete (markTestIncomplete) and skipped (markTestSkipped) tests.

One can kinda mark a test incomplete at compile-time by using xdescribe and xit, but it would be good to have a runtime way of doing it as well, similar to PHPUnit. That said I think 95% of the time handling this at compile time is fine, so low impact.

I note there is a skipIf method, but was surprised to see its implementation was void function skipIf(boolean condition), where I might have expected void function skipIf(string message, callback condition) to match the implementations of it and describe, and using the same analogy. At the very least void function skipIf(boolean condition[, string message]).

I think a message is reasonably handy when skipping tests.

I checked to see if there was a precedent in other similar frameworks:

• Jasmine doesn't seem to have skip yet, based on https://github.com/jasmine/jasmine/issues/1709;
• however Mocha does (https://mochajs.org/#inclusive-tests), simply as skip().
• rspec handles skipping via in-code tags: https://relishapp.com/rspec/rspec-core/v/3-4/docs/pending-and-skipped-examples/skip-examples, with CLI options: https://relishapp.com/rspec/rspec-core/v/3-4/docs/command-line/tag-option

It would be nice to have a drop-in config for Kahlan for PHPStan. Currently, when run over a Kahlan project, PHPStan warns about:

• The DSL functions not existing.
• The $this keyword used in kahlan-config.php outside of a class context.

Here's my current config for handling the first point:

parameters:
  ignoreErrors:
    - /^Function context not found.$/
    - /^Function describe not found.$/
    - /^Function expect not found.$/
    - /^Function it not found.$/

But there's probably a better way to fix the problem that doesn't involve "ignoring" these errors. If PHPStan can be configured to understand the functions it could actually pick up on real errors when using them. Are the DSL functions dynamically defined? That would explain why PHPStan complains.

PHPStan uses Neon config files which allow you to include a definition from a vendor, which means that if you created a kahlan/phpstan-kahlan repo, users could require it, then add something like this to their PHPStan configuration:

includes:
  - vendor/kahlan/phpstan-kahlan/kahlan.neon

I just wrote a PHPStan integration for Phony, which is probably more complex than what's needed for Kahlan, but you can check it out here anyway.