Describe the bug orderByTranslation scope seems to ignore fallback locale.

To Reproduce

• Save model translation to 'fr'
• List models in 'fr' using orderByTranslation: list is OK
• Use app()->setLocale('en')
• List models in 'en' using orderByTranslation: list is empty (assuming no model was ever translated to en)

I'm supposed to write mostly in French, but some articles in English. As such, my main locale as well as my fallback_locale both are 'fr' in Laravel's config. In config/translatable.php, I set locale to null, use_fallback to true, use_property_fallback to true, and fallback_locale to null.

Expected behavior In the absence of translation in English, I would expect orderByTranslation to return the expected list with the French translations available, instead of nothing at all (still assuming I have only French Translations in my database at the moment).

Versions (please complete the following information)

• PHP: 7.3.9
• Database: MariaDB 10.3.17
• Laravel: 6.1.0
• Package: 11.5

Create trait Astrotomic\Translatable\Traits\TranslatableFormRequest for simplify validation rules on FormRequest.

class DummyFormRequest extends FormRequest
{
    use TranslatableFormRequest;
    
    public function rules()
    {
        return [
            'name' => 'required',
        ];
    }

    public function translatableRules()
    {
        return [
            'title' => 'string',
        ];
    }
}

This trait generate rules for all available locales :

• name : string
• title : required|array
• title.fr : string
• title.en : string

See the tests/TranslatableFormRequestTest.php for more details

Hi, First I want to thank you for the nice library. I used to use spatie/laravel-translatable to handle translations of my models and now i moved to Astrotomic/laravel-translatable Everything works fine except that Astrotomic/laravel-translatable doesn't detect accept-language automatically. In the past, I was able to specify which translation i want to get by setting accept-language to the required translation so if i want to get english translation i would set accept-language: en and the package would return the results in that language. Now this doesn't work, the package now returns only the first translation available. How can i make it detect accept-language automatically?

Thanks

Is there a method to Sync Translations on update?

I have one form for all languages and I want to sync all translations when user make changes. Lets say in the new edit French fields were removed/cleared so in this case sync should remove French entry instead of saving null/blank.

Is your feature request related to a problem? Please describe. I identified a need that the translatable fields in a form should be nullable, but not save an empty string in the translations related table of the model, because if the locale is available it would return an empty string instead of the configured default from the model.

When trying to save a request with request->all() the NULL values are not removed at all and the database fails to save.

Describe the solution you'd like The elegant solution would be for the trait to check and remove NULL values from the input request array and also if there were NULL values in a locale translation, to also remove from the model itself.

Describe alternatives you've considered For my application I developed a solution, that may point towards some good discussions and possible correct implementation of this in the package. I just don't have the skills to make a pull request of said feature myself, but I hope the following code may inspire you all:

1. The Model using Translatable must set the default language for this to work

namespace App\Models;

use Illuminate\Database\Eloquent\Model;
use Astrotomic\Translatable\Contracts\Translatable as TranslatableContract;
use Astrotomic\Translatable\Translatable;

class LocalizedModel extends Model implements TranslatableContract
{

    use Translatable;

    public function __construct(array $attributes = [])
    {
        parent::__construct($attributes);

        $lang = Language::find(1);
        $this->setDefaultLocale($lang->locale);
    }
}

1. Assuming Category extends LocalizedModel, the following is how I call my method from the Controller:

$data = Category::findOrFail($id);
$input = $this->removeEmptyTranslations($request->all(), $data);

1. Assuming I have the locales available in my application in $this->locales I will always have the default locale setup in the model, and therefore the method removeEmptyTranslations does not consider the default locale for removing. The implemented logic is the following:

/**
     * Remove Empty Translation fields from an input array and also delete
     * from a LocalizedModel instance
     *
     * The array is in the format:
     * "locale" =>  [
     *      "field" => "value"
     *  ]
     * @param array $input
     * @param LocalizedModel $model
     * @return array
     */
    public function removeEmptyTranslations(array $input, LocalizedModel $model = null)
    {
        $removed = [];

        foreach($this->locales as $locale) {
            if($locale->locale === $this->lang->locale) {
                continue;
            }

            if(isset($input[$locale->locale])) {
                $input[$locale->locale] = array_filter($input[$locale->locale]);
                if(empty($input[$locale->locale])) {
                    $removed[] = $locale->locale;
                    unset($input[$locale->locale]);
                }
            }
        }

        if($model) {
            $model->deleteTranslations($removed);
        }

        return $input;
    }

Additional context How the form input looks like. It is a tabbed interface, that changes the input according to the locales provided

I am trying to validate with Rule::unique , if it doesn't replace different column argument.

RuleFactory::make([
            '%name%' => [
                'required',
                Rule::unique('category_translation', '%name%')
            ],
        ])

Output is:

array:1 [▼
  "en.name" => array:2 [▼
    0 => "required"
    1 => Illuminate\Validation\Rules\Unique {#550 ▼
      #ignore: null
      #idColumn: "id"
      #table: "category_translation"
      #column: "%name%"
      #wheres: []
      #using: []
    }
  ]
]

#column must be "en.name"

I'm using Twill CMS, which uses the previous version of this package to translate models. (dimsav/translatable), however it's read only.

I have a multilingual website with a blog page that shows all my posts. However, if a blog post isn't translated (yet) to the current locale of the visitor, it just shows an empty post card without any content.

So how do I fetch all Posts that are translated to the current locale? Let's say my current locale is Spanish, I'd like to only show posts that are translated in the spanish language.

Describe the bug I am using this with Nova, but none of the translatable fields seem to be updating.

To Reproduce Install Nova v3 Setup a model and resource that is translatable Create a new resource, and then try and update its fields Only non-translatable fields are updated without any error

Expected behavior All fields are updated

Versions (please complete the following information)

• PHP: 7.4
• Database: mysql
• Laravel: 7.22
• Package: Nova v3.8.2

Exception None

Deleted event will fire after delete the parent record and it will make error while deleting returned from MySQL so we should set deleting event to fire this script before deleting the parent record.

Picking up from #113 the problem is not with the select()at all, it is with the datatable when using server-side mode.

When using server-side, we don't get the results from Eloquent, we let the datatable package make the queries and assemble the final result to send to the client-side, and that is why the translations are not loaded with the request.

The following code will be the example:

 $datas = Generalsetting::orderBy('id');
        //--- Integrating This Collection Into Datatables
        return Datatables::of($datas)
            ->filterColumn('title', function ($query, $keyword) {
                $query->whereTranslationLike('title', "%{$keyword}%", 'pt-br');
            })
            ->toJson(); //--- Returning Json Data To Client Side

The filterColumn is needed because without it when performing a search in the datatable, it would try to search the vanilla field of title. So the problem is just that we need to copy such filter logic in every table ^^'

One approach I can see is for Translatable package to notice that the model (Generalsetting in the example) does use the trait, or have the $translatedAttributes array, and modify the query to join the translated table so the field would be available in the query.

Other approach would be for withTranslation() to make the query without using get() as well, thus making the query available.

Another way that I can see this working is for the method listsTranslations() to accept an array of fields and return the query as well, so instead of doing like: Generalsetting::listsTranslations('title')->get() it would be just `Generalsetting::listsTranslations('title')' and we could chain the order and other eloquent calls, without getting the results right away, so the effect would be to only return the fields we care about in the particular table.

I guess the bottom line is in the fact that every method needs to call get() and can't be used in chain with other Eloquent methods.

Tried both methods and gettings the same objects with all translations instead of given in scope arguments

dd(Post::all(), Post::translatedIn('en')->get());

I use RulesFactory but on locally is work well on AWS don't work, this my rules:

$update_rules = RuleFactory::make([ '%title%' => ['required_with:%html_content_logo%,%html_content1%,%html_content2%,%html_content3%,%html_content4%,%html_content5%', 'present', 'string', 'nullable'], '%html_content_logo%' => ['string', 'nullable'], '%html_content1%' => ['string', 'nullable'], '%html_content2%' => ['string', 'nullable'], '%html_content3%' => ['string', 'nullable'], '%html_content4%' => ['string', 'nullable'], '%html_content5%' => ['string', 'nullable'], ]);

Hey guys, i have the problem that my orderByTranslation is getting ignored. I have the following:

    Cache::tags(['food', 'food-products'])->rememberForever('non-empty-products', function () {
        return Product::orderByTranslation('name', 'asc')->with(['places', 'brands', 'translations', 'product_images'])->withCount(['places', 'brands', 'translations', 'product_images'])->having('places_count', '>', 0)->orHaving('brands_count', '>', 0)->get();
    });

Do you have an idea what cause it can have?

Greets Talha

Bumps actions/stale from 6.0.1 to 7.0.0.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

On laravel 9 site I added astrotomic/laravel-translatable and getting set of data I see a bit different results I expected As I have 2 languages defined in config/translatable.php with default 'en' :

'locales' => [
    'en',
    'fr',
...
    'locale' => 'en',
...

I do request with 'fr' locale:

$banners           = Banner
    ::translatedIn(app()->getLocale())
    ->get(function ($banner);

I check logs :

            [id] => 5
            [text] => laravel library site
            [description] => laravel is a powerful php library
            ...
            [translations] => Array
                (
                    [0] => Array
                        (
                            [id] => 13
                            [text] => laravel library site
                            [description] => laravel is a powerful php library
                            ...
                        )

                    [1] => Array
                        (
                            [id] => 15
                            [text] => site de la bibliothèque laravel
                            [description] => laravel est une puissante bibliothèque php
                            ...
                        )

                )

)

Text in text, description fields(of banner, not translations] subarray...) are in ‘en’, not in 'fr', as I expected...

In file app/Models/Banner.php I have :

<?php

namespace App\Models;

use Illuminate\Database\Eloquent\Model;

use Spatie\MediaLibrary\HasMedia;
use Spatie\MediaLibrary\InteractsWithMedia;
use Astrotomic\Translatable\Contracts\Translatable as TranslatableContract;
use Astrotomic\Translatable\Translatable;

class Banner extends Model implements HasMedia, TranslatableContract
{
    use InteractsWithMedia;
    use Translatable;

    protected $table = 'banners';
    protected $primaryKey = 'id';
    public $timestamps = false;

    protected $fillable = [/*'text', 'description',*/ 'url', 'active', 'ordering', 'banner_bgimage_id', 'updated_at'];
    public $translatedAttributes = ['text', 'description'];

        "laravel/framework": "^9.19",
        "astrotomic/laravel-translatable": "^11.11",

and in app/Models/BannerTranslation.php :

<?php
namespace App\Models;

use DB;
use Illuminate\Database\Eloquent\Model;

class BannerTranslation extends Model
{
    public $timestamps = false;
    protected $fillable = ['text', 'description', 'updated_at'];
}

Seems I did not miss any config options, but what is wrong ?

"astrotomic/laravel-translatable": "^11.11",
"laravel/framework": "^9.19",

Thanks in advance!

Bumps actions/checkout from 3.1.0 to 3.2.0.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Describe the bug According to the docs, this is eager loading. Post::withTranslation()->get(); It actually is. But when do the foreach

            foreach ($rows as $key => $row) {            
                echo '<pre>', print_r($row->translation->name, 1), "</pre>";
            }

It does the sql query for every row. If 10 rows, it's 1 sql for my product table, 10 sql for product_relations table

But if I use laravel's default's with() Product::with('translation')->get(); It's really eager loading.

So, maybe there is something wrong with the function withTranslation() ?

To Reproduce

        //$products = (new Product)->with('translation')->get();
        $products = (new Product)->withTranslation()->get();
        // echo '<pre>', print_r($products, 1), "</pre>"; // This is always eager loading.
        foreach ($products as $key => $row) {
            echo '<pre>', print_r($row->translation->name, 1), "</pre>"; // This depends.
        }