It adapts a TemporaryFile source which encloses file contents as string, array or stream resource, and stores it in the temp directory until the end of the script

Hello to all watchers and contributors (paging @sebdesign),

With the new year approaching, I think it is time to start planning the next major version of this package. Most pressingly, with PHP 5.6 passing into security-only support tomorrow night, I think it is time to drop support for PHP 5.x branch and fully embrace the new features of PHP 7.x. I will be working on this over the next few weeks, as I have time.

A new major version presents an opportunity to add any number of other changes that we want to the codebase. So I would like to ask if there are any new features that should be incorporated into the package at the same time. Is there anything that you would like to see built into the package? Are there any methods that should really be moved or renamed? Noticed any code smells that I overlooked? Now is the time to ask.

Feel free to make any suggestions in this thread. Pull Requests also very much welcome!

Several trouble after upgrading to laravel version 6 and laravel-mediable version 3.

Please note that everything was passing before upgrading to V 3.

I am testing on local public disk. During test I was accessing $media->getUrl() and facing errors.

When I do Storage:fake(): Storage::fake(); $uploadedFile = UploadedFile::fake()->image('photo.jpeg', 20, 20);

I am getting following error (formatted): "message:" "strpos() expects parameter 1 to be string, bool given" "exception:" "Symfony\Component\Debug\Exception\FatalThrowableError" "file:" "/var/www/watchcrunch/vendor/plank/laravel-mediable/src/UrlGenerators/LocalUrlGenerator.php" "line:" 100 "trace-first:" array:3 [ "file" => "/var/www/watchcrunch/vendor/plank/laravel-mediable/src/UrlGenerators/LocalUrlGenerator.php" "line" => 100 "function" => "strpos" ]

When I don't fake Storage:fake() //Storage::fake(); $uploadedFile = UploadedFile::fake()->image('photo.jpeg', 20, 20);

I am getting following error (formatted): "message:" "Media file /var/www/watchcrunch/storage/app/public/photos/2019/09/O1TtRmb6kBfBCyQsfCgAXGiBCCFfOubbeoxgH0H2.jpeg is not part of the public path /var/www/watchcrunch/public" "exception:" "Plank\Mediable\Exceptions\MediaUrlException" "file:" "/var/www/watchcrunch/vendor/plank/laravel-mediable/src/Exceptions/MediaUrlException.php" "line:" 26 "trace-first:" array:5 [ "file" => "/var/www/watchcrunch/vendor/plank/laravel-mediable/src/UrlGenerators/LocalUrlGenerator.php" "line" => 44 "function" => "mediaNotPubliclyAccessible" "class" => "Plank\Mediable\Exceptions\MediaUrlException" "type" => "::" ]

After some further digging I found, my file is not considered as public at all although disk has public visibility and even adding makePublic() during upload.

Also I guess the issue may be in LocalUrlGenerated function isInWebroot().

However for S3 driver everything works well as expected.

Can anyone help? Thanks.

Introduce a HandlesMediaExceptions trait which can be used in the Exception\Handler to return more granular HTTP status codes when a MediaUploadException is thrown.

I have updated the docs, (spotted a few typos also), but I couldn't get Sphinx to work.

This can be extended to handle more exceptions like MediaMoveException or MediaUrlException in the future.

Also it would be interesting if we could throw Illuminate\Validation\ValidationExceptions instead of HttpExceptions in some cases, for better upload validation handling.

I thought I'd try to implement #67 as part of hacktoberfest, but I'm not overly happy with it. Any feedback you have would be great.

List of changes:

• Added MediaUploader::ON_DUPLICATE_UPDATE + a set method for it.

• Removed verifyDestination function. I found this function to be confusing as it appears to only check if the file exists and then calls handleDuplicate. However, handleDuplicate should always check if a file exists before doing anything, so I moved the check into the handDuplicate function and removed verifyDestination. As this was a private function, it should not break anyone's code (this was also updated in the MediaUploaderTest).

• Modified handleDuplicate to now return a Media model. If ON_DUPLICATE_UPDATE is set, it returns the model from the database, else it returns the input parameter $model.

• Added ON_DUPLICATE_UPDATE case in the handleDuplicate method which deletes the existing file on disk, then finds the existing media and updates the updated_at timestamp. This has to be done as the model is not dirty and thus does not actually save when $media->save() is called.

• Added test_it_can_update_duplicate_files to test it actually works.

• Added a function similar to deleteExistingMedia called deleteExistingFile which only deletes the file on disk, rather than the actual Media database record. As this function has the ability to knock the database and file system out of sync, I made it a private function.

• Last but not least, I added a function named findExistingMediaRecord to find existing media records which point to a position on disk that we are trying to use.

Docs

I'll update the docs once I know whether you want this merged or not.

Planning to add support for Intervention manipulations while uploading images.

Currently considering an API like the following:

MediaUploader::fromSource('example.jpg')
    ->applyManipulations(function(Image $image) {
         $image->resize(300, null);
    }, $quality = null)
    ->upload()

Presently this is just proof-of-concept PR, If I can get approval for this I'll add tests/update docs etc.

So @frasmage how does this look to you? I had contemplated adding a separate getTemporararyUrl method, but I prefer this as I can pass the timestamp through regardless of the driver, and if it's a local driver (local dev) it will just ignore it, and if it's the S3 driver it will generate the temporary url.

Example usage:

$media = Media::first(); // Assume this is a non-public S3 hosted file
$media->getUrl(); // throws MediaUrlException as currently does
$media->getUrl(now()->addMinutes(5)); // Generates temporary url

This PR adds a new copyFrom() function to the Media object.

The function behaves like this: It copies the associated file on the disk and assigns it to a Media object.

For example:

// lets assume we have a $media object

// now create a new media file
$newMedia = $media->replicate();
$newMedia->copyFrom($media, 'new/directory', 'filename');

This copyFrom() will, thereby, copy the file on the disk to /new/directory and update the $newMediato reflect these changes.

I have already added a test for this scenario

hi i've add a column on media table (custom_fields) in json format. i would like to cast custom_fields but if i extend the media model the cast is not reconized.

i've add my new class in config/mediable.php nothin happend.

how can i do? thanks

Hi,

I try to find a method to get only one media on posts collection and not all media attach on each post.

For exemple :

A post has many media, all with same tag. I wanna get only one of them. I suppose we need to use the join method, but how ?

Now a use $posts = Post::with('media')->get();, but I dont wanna all media.

Thank you.

Dear,

I am having an issue with the retrieval of media. I was originally using version 4.4.2. However after discovering my issue I have updated to version 5.2.1. My issue is present in both versions.

When calling firstMedia($tags, true) I get a TypeError:

TypeError App\Models\User::Plank\Mediable\{closure}(): Argument #2 ($media) must be of type Plank\Mediable\Media, array given, called in ...

I am saving the media as follows:

    public function setProfileImage(UploadedFile $image)
    {
        config(['mediable.model' => Media::class]);
        $media = MediaUploader::fromSource($image->getRealPath())
            ->toDisk('avatars')
            ->toDirectory("profile/")
            ->useFilename('profile_' . $this->id)
            ->onDuplicateUpdate()
            ->upload();
        $this->syncMedia($media, ['user', 'profile']);

        return $media;
    }

I am retrieving the profile image as follows:

 public function getProfileImage()
    {
        config(['mediable.model' => Media::class]);
        $image = $this->firstMedia(['user', 'profile'], true);
        return $image;
    }

I have also tried the getMedia and getMediaMatchAll methods. Both give the same TypeError. I am using Laravel in combination with Tailwind, Alpine and Livewire. I am getting the error when when my livewire components are updated, for example when switching a tab on the page.

Does anybody know where I could be making an error causing this issue?

Thank you in advance for your help!

I cannot upload a file to S3. S3 is configured correctly as this does work:

Storage::disk('s3')->put('uploads', $request->file('image'));

But this does not work (and no error message either):

MediaUploader::fromSource($request->file('image'))->toDisk('s3')->upload();

Also note, this does work when uploading locally.

Config:

<?php

return [
    /*
     * FQCN of the model to use for media
     *
     * Should extend `Plank\Mediable\Media`
     */
    'model' => App\Models\Media::class,

    /*
     * Name to be used for mediables joining table
     */
    'mediables_table' => 'mediables',

    /*
     * Filesystem disk to use if none is specified
     */
    'default_disk' => 's3',

    /*
     * Filesystems that can be used for media storage
     *
     * Uploader will throw an exception if a disk not in this list is selected
     */
    'allowed_disks' => [
        'public',
        's3',
    ],

    /*
     * The maximum file size in bytes for a single uploaded file
     */
    'max_size' => 1024 * 1024 * 8,

    /*
     * What to do if a duplicate file is uploaded.
     *
     * Options include:
     *
     * * `'increment'`: the new file's name is given an incrementing suffix
     * * `'replace'` : the old file and media model is deleted
     * * `'error'`: an Exception is thrown
     */
    'on_duplicate' => Plank\Mediable\MediaUploader::ON_DUPLICATE_ERROR,

    /*
     * Reject files unless both their mime and extension are recognized and both match a single aggregate type
     */
    'strict_type_checking' => false,

    /*
     * Reject files whose mime type or extension is not recognized
     * if true, files will be given a type of `'other'`
     */
    'allow_unrecognized_types' => false,

    /*
     * Only allow files with specific MIME type(s) to be uploaded
     */
    'allowed_mime_types' => [],

    /*
     * Only allow files with specific file extension(s) to be uploaded
     */
    'allowed_extensions' => [],

    /*
     * Only allow files matching specific aggregate type(s) to be uploaded
     */
    'allowed_aggregate_types' => [
        Plank\Mediable\Media::TYPE_IMAGE,
    ],

    /*
     * List of aggregate types recognized by the application
     *
     * Each type should list the MIME types and extensions
     * that should be recognized for the type
     */
    'aggregate_types' => [
        Plank\Mediable\Media::TYPE_IMAGE => [
            'mime_types' => [
                'image/jpeg',
                'image/png',
                'image/gif',
            ],
            'extensions' => [
                'jpg',
                'jpeg',
                'png',
                'gif',
            ]
        ],
        Plank\Mediable\Media::TYPE_IMAGE_VECTOR => [
            'mime_types' => [
                'image/svg+xml',
            ],
            'extensions' => [
                'svg',
            ]
        ],
        Plank\Mediable\Media::TYPE_PDF => [
            'mime_types' => [
                'application/pdf',
            ],
            'extensions' => [
                'pdf',
            ]
        ],
        Plank\Mediable\Media::TYPE_AUDIO => [
            'mime_types' => [
                'audio/aac',
                'audio/ogg',
                'audio/mpeg',
                'audio/mp3',
                'audio/mpeg',
                'audio/wav'
            ],
            'extensions' => [
                'aac',
                'ogg',
                'oga',
                'mp3',
                'wav',
            ]
        ],
        Plank\Mediable\Media::TYPE_VIDEO => [
            'mime_types' => [
                'video/mp4',
                'video/mpeg',
                'video/ogg',
                'video/webm'
            ],
            'extensions' => [
                'mp4',
                'm4v',
                'mov',
                'ogv',
                'webm'
            ]
        ],
        Plank\Mediable\Media::TYPE_ARCHIVE => [
            'mime_types' => [
                'application/zip',
                'application/x-compressed-zip',
                'multipart/x-zip',
            ],
            'extensions' => [
                'zip',
            ]
        ],
        Plank\Mediable\Media::TYPE_DOCUMENT => [
            'mime_types' => [
                'text/plain',
                'application/plain',
                'text/xml',
                'text/json',
                'application/json',
                'application/msword',
                'application/vnd.openxmlformats-officedocument.wordprocessingml.document'
            ],
            'extensions' => [
                'doc',
                'docx',
                'txt',
                'text',
                'xml',
                'json',
            ]
        ],
        Plank\Mediable\Media::TYPE_SPREADSHEET => [
            'mime_types' => [
                'application/vnd.ms-excel',
                'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet',
            ],
            'extensions' => [
                'xls',
                'xlsx',
            ]
        ],
        Plank\Mediable\Media::TYPE_PRESENTATION => [
            'mime_types' =>
            [
                'application/vnd.ms-powerpoint',
                'application/vnd.openxmlformats-officedocument.presentationml.presentation',
                'application/vnd.openxmlformats-officedocument.presentationml.slideshow'
            ],
            'extensions' =>
            [
                'ppt',
                'pptx',
                'ppsx',
            ]
        ],
    ],

    /*
     * List of adapters to use for various source inputs
     *
     * Adapters can map either to a class or a pattern (regex)
     */
    'source_adapters' => [
        'class' => [
            Symfony\Component\HttpFoundation\File\UploadedFile::class => Plank\Mediable\SourceAdapters\UploadedFileAdapter::class,
            Symfony\Component\HttpFoundation\File\File::class => Plank\Mediable\SourceAdapters\FileAdapter::class,
            Psr\Http\Message\StreamInterface::class => Plank\Mediable\SourceAdapters\StreamAdapter::class,
        ],
        'pattern' => [
            '^https?://' => Plank\Mediable\SourceAdapters\RemoteUrlAdapter::class,
            '^/' => Plank\Mediable\SourceAdapters\LocalPathAdapter::class,
            '^[a-zA-Z]:\\\\' => Plank\Mediable\SourceAdapters\LocalPathAdapter::class
        ],
    ],

    /*
     * List of URL Generators to use for handling various filesystem drivers
     *
     */
    'url_generators' => [
        'local' => Plank\Mediable\UrlGenerators\LocalUrlGenerator::class,
        's3' => Plank\Mediable\UrlGenerators\S3UrlGenerator::class,
    ],

    /**
     * Should mediable instances automatically reload their media relationships after modification are made to a tag.
     *
     * If true, will automatically reload media the next time `getMedia()`, `getMediaMatchAll()` or `getAllMediaByTag()` are called.
     */
    'rehydrate_media' => true,

    /**
     * Detach associated media when mediable model is soft deleted.
     */
    'detach_on_soft_delete' => false,

    /**
     * Variant sizes.
     */
    'variants' => [
        'x-small' => 500,
        'small' => 750,
        'medium' => 1000,
        'large' => 1500,
        'x-large' => 2000,
    ]
];

Added "ALT" field for medias , I customize the Mediable for every project of mine so i decide to open a pull request , it is so useful for images and videos on websites . Please consider it .

Migration was failing with unsigned integer definition for foreign key. It might be better to use foreignId() instead of the more verbose foreign()->references()->on() syntax, but this was the smallest changeset that fixes migration for me.

Hi,

I'd like to manipulate an uploaded file right away. For example: changing the file format from jpg to webp.

From what I gather you need to first store the uploaded file, then create a variant and promote it to original status and then remove the old file.

I'm looking to do that in one step right off the bat. Is that possible?

Hi all, I love what you have done and this fits my needs very well as I need the many-to-many functionality that is provided. However, there are a couple of features from MediaLibrary that I like:

• Responsive Images (https://spatie.be/docs/laravel-medialibrary/v8/responsive-images/getting-started-with-responsive-images)
• Optimization (https://spatie.be/docs/laravel-medialibrary/v8/converting-images/optimizing-converted-images)

I did not see anything like this currently in the project. Have I missed them, and if not, are they on the roadmap by chance?

Thanks, Gary