• [x] Infos what does each component (Compiler, Analyzer, CFG, Definitions?)
• [x] Infos what each analyzer does
• [x] Infos on configuration (PR from @K-Phoen )
• [x] How to write an own analyzer?
• [x] Update Readme.md (make it shorter, link to docs and contributing guide)
• [x] Check spelling and grammar (we have no native english speaker currently, so this would be really appreciated)
• [ ] Just try some things out we are happy for every PR to docs :cake:

What do you think? @ovr @K-Phoen I thought we'd do it like php-parser (doc directory)

Hey!

Type: documentation

Link to issue: per comment on PR #189

This pull request affects the following components (please check boxes):

• [ ] Core
• [ ] Analyzer
• [ ] Compiler
• [ ] Control Flow Graph
• [x] Documentation

In raising this pull request, I confirm the following (please check boxes):

• [x] I have read and understood the Contributing Guidelines.
• [x] I have checked that another pull request for this purpose does not exist.
• [ ] I wrote some tests for this PR.

Small description of change:

Thanks

Hey!

Type: code quality

Link to issue: #170

This pull request affects the following components: (please check boxes)

• [X] Core
• [ ] Analyzer
• [ ] Compiler
• [ ] Control Flow Graph
• [ ] Documentation

In raising this pull request, I confirm the following (please check boxes):

• [X] I have read and understood the Contributing Guidelines?
• [X] I have checked that another pull request for this purpose does not exist.
• [X] I wrote some tests for this PR.

Small description of change: Added core unit tests for IssuesCollector, ScopePointer and Application

Thanks

I implemented a simple way to make analyzers configurable.

They can define their own configuration, that will be merged in the global one. This configuration is used to determine if the analyzer pass is enabled or not. When the analyzer is instantiated, its configuration is injected through the constructor.

I also added a new command to dump the default configuration: ./bin/phpsa config:dump-reference

WDYT?

When I run phpsa ( >vendor/ovr/phpsa/bin/phpsa check file.php ) I get the findings from the analysis but I also get lines saying: fatal: Not a git repository (or any of the parent directories): .git. I am new to composer and phpsa so I could have something configured incorrectly. Any help would be great.

It seems that I cannot enable or disable the array_dim_fetch_on_non_array future of this tool, is this correct? I tried disabling array_illegal_offset_type as that is the only class that contains a reference to ArrayDimFetch, but that didn't disable the analysis.

Things I've tried to disable the analysis:

• Add array_dim_fetch to the config
  • This resulted in an error (Unrecognized option "array_dim_fetch" under "phpsa.analyzers")
• Disable all the array related actions
• Disable all analyzers

I did look through the codebase and I know that the config is handled by the Analyzer/Factory-class but I can't figure out where to go from there.

Type: new feature

Link to issue: https://github.com/ovr/phpsa/issues/344

This pull request affects the following components (please check boxes):

• [x] Core
• [ ] Analyzer
• [ ] Compiler
• [ ] Control Flow Graph
• [ ] Documentation

In raising this pull request, I confirm the following (please check boxes):

• [x] I have read and understood the Contributing Guidelines.
• [x] I have checked that another pull request for this purpose does not exist.
• [x] I wrote some tests for this PR.

Small description of change:

First attempt to provide files and folders ignoring mechanism

Thanks

<?php
class C
{
    // Notice:  Illegal array offset type unknown for key $key. [array.illegal_offset_type]
    public function testForeach(array $ary)
    {
        foreach ($ary as $key => $value) {
            $ary[$key] = 1;
        }
    }
    // Notice:  You are trying to use an undefined variable $_SERVER [undefined-variable]
    public function testUndefinedSuperglobals($subject)
    {
        sprintf('%s', implode(' ', $_SERVER['argv']));
    }
    // Warning:  Unused variable $var in method testUnusedInIssetInFetch() [unused-variable]
    public function testUnusedInIssetInFetch(array $ary)
    {
        $var = 0;
        isset($ary[$var]);
    }
    // Warning:  Unused variable $thisClass in method testUnusedInNewOp() [unused-variable]
    public function testUnusedInNewOp($value)
    {
        $thisClass = get_class($this);
        return new $thisClass($value);
    }
}

Hey!

Type: new feature| documentation

Link to issue: https://github.com/ovr/phpsa/issues/166

This pull request affects the following components (please check boxes):

• [ ] Core
• [x] Analyzer
• [ ] Compiler
• [ ] Control Flow Graph
• [x] Documentation

In raising this pull request, I confirm the following (please check boxes):

• [x] I have read and understood the Contributing Guidelines.
• [x] I have checked that another pull request for this purpose does not exist.
• [x] I wrote some tests for this PR.

Small description of change: This adds an analyzer which use of non-required default value for property. (PropertyProperty is not being registered)

Thanks

I started to work on an implementation of unexpected uses of $this (#68).

Most of the easy cases are covered and I'd like your feedback on this PR as I'm not familiar with this project (yet). Am I going in the right direction? If yes, I'll try to detect more error cases and add a few unit tests.

When I run vendor/bin/phpsa check I get the following error:

Fatal error: Uncaught TypeError: Argument 1 passed to PHPSA\Configuration::__construct() must be of the type array, null given, called in /app/vendor/ovr/phpsa/src/Command/AbstractCommand.php on line 48 and defined in /app/vendor/ovr/phpsa/src/Configuration.php:34
Stack trace:
#0 /app/vendor/ovr/phpsa/src/Command/AbstractCommand.php(48): PHPSA\Configuration->__construct(NULL, Array, NULL)
#1 /app/vendor/ovr/phpsa/src/Command/CheckCommand.php(75): PHPSA\Command\AbstractCommand->loadConfiguration('.phpsa.yml', '/app')
#2 /app/vendor/symfony/console/Command/Command.php(252): PHPSA\Command\CheckCommand->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#3 /app/vendor/symfony/console/Application.php(865): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#4 /app/vendor/symfony/console/Application.php(241): Symfony\Component\Console\Application->doRunCommand(Obj in /app/vendor/ovr/phpsa/src/Configuration.php on line 34

I don't have a .phpsa.yml in my project. Do I need one? Should PHPSA work without a .phpsa.yml?

Such as #286 , it was closed on 2016,but now i still can reproduce: Notice: Undefined property: PhpParser\Node\Expr\ArrayDimFetch::$name in C:\ProgramData\ComposerSetup\bin\vendor\ovr\phpsa\src\Analyzer\Pass\Statement\UnexpectedUseOfThis.php on line 186 Notice: It's not possible to fetch an array element on a non array in E:********* on 168 [language_error] unset($seatNewArr[$key]);**

If I run the --version command, phpsa is looking for git. If git is available, it will throw the error fatal: Not a git repository (or any of the parent directories): .git, which seems to be the same error as #102, but for another command.

• [x] Remove support for PHP version 5.6 (it seems we always support the last 3 php versions and so does php-parser)
• [x] Update PHPUnit to version 6.x (needs php 7.0 and up)
• [ ] Update php-parser to version 4.x (currently alpha and needs php 7.0 and up)

If I have a class that contains something like this:

class Something
{
    // ...
    private static $propOne, $propTwo;
    // ...
}

What happens is that after parsing, the resulting ClassDefinition contains both properties, but only one property statement (named for only $propTwo, incidentally).

So far, this partly seems to make sense, but the problem comes in PHPSA\Compiler\Expression\StaticPropertyFetch::compile() which has the following code:

// ...
if (!$classDefinition->hasProperty($name, true)) {
    // return;
}
$property = $classDefinition->getPropertyStatement($name, true);
if (!$property->isStatic()) { // <<<< LINE 46
    // ...
}
// ...

With the code sample given above, hasProperty() returns true for $propOne, making it skip the first if block. Then, because there is no property statement named for $propOne, calling getPropertyStatement() returns null. So, on line 46, $property is set to null, making the call to isStatic() cause a fatal error.