I posted the problem first in the PHPStorm tracker: http://youtrack.jetbrains.com/issue/WI-18654

I use PHPStorm as IDE which provides an interface to PMD.

Windows x64, php installed as standalone with all pear/pecl packages configured correctly as far as I can tell. PMD runs fine and also runs fine in PHPStorm. It just seems that it never cleans up after itself.

I was told to report this here as the PHPStorm devs won't fix it.

This is a bit tricky issue.

For start I know that this error is actually triggered by pdepend/pdepend package yet it happens when I'm using PHPMD so I decided to post this issue here.

I'm trying to run PHPMD on my PHP7 project. In most cases it fails with message:

Cannot create new nodes, when internal state is frozen.

I've tried to run PHPMD for some directories located inside my src dir and it worked. Yet again, when I tried to put them together separated by comma the fail message returned.

I'm not sure what's causing this problem. At first I've thought it's a problem of code written in PHP7 yet it seems to be unrelated (for single directories PHPMD works).

I'm using PHPMD in 2.3.2 version. Tried to run binary in PHP 5.6.15, and 7.0RC7

From the docs: "An if expression with an else branch is never necessary". It then goes on: "You can rewrite the conditions in a way that the else is not necessary and the code becomes simpler to read. To achieve this use early return statements."

I don't understand the reasoning. Why is an early return (or, I assume, continue) statement intrinsically simpler to read? Why should we avoid else statements simply because they are never necessary? (The if statement, I might add, is never necessary either!)

These factors are unchanged:

• There is still an if.
• The "else" condition is still evaluated in exactly the same cases, only now by "falling through" instead of branching to the else block. The rationale that the exact condition for evaluating the else code is not clear, persists.

New issues are introduced:

• When using early returns, postprocessing code that has to be run in both branches has to be duplicated, introducing the potential for later divergence.
• When using early returns, the "else" code is "promoted" to a shallower indentation level, suggesting to the casual reader that it is the default case, even if the cases may be 50/50.
• When moving the if/else into a separate method, that method then needs to use early returns as well, because it can't use else either. Does it make the code more readable to have that method simply for this single purpose?
• A ternary operator is often harder to read. The only advantage I see there is that it only allows expressions instead of statements.

I have had a spirited discussion with my coworkers, but fail to be convinced so far that this rule achieves its objectives. I understand that else statements often appear in bad code, but I see them as a symptom rather than a cause. I feel that encouraging less experienced developers to use early returns and ternary operators may cause them to write worse code, not better.

I have found only a few critiques of the else statement on Google, and all of them focus on bad uses of else, not on the use of else per se.

My suggestion is to either:

• Clarify some of these concerns in the docs, and improve the suggestions.
• Put this rule in the "controversial" set.

I haven't made my own version of the docs text yet, because first I would like to have a clear understanding of the reasoning behind the rule and make sure there is nothing I miss.

• PHPMD version: 2.10.0
• PHP Version: 8.0.3
• Installation type: composer
• Operating System / Distribution & Version: Ubuntu 20.04

Current Behavior

Getting "Avoid unused parameters such as '$createNewUser'" violation when declaring parameters in the constructor in php8.

Expected Behavior

No violation, as php8 introduces the possibility of declaring class prorieties in the constructor, like so: https://stitcher.io/blog/constructor-promotion-in-php-8

Steps To Reproduce:

• install the latest phpmd
• declare class proprieties in the constructor, for example:

 public function __construct(
        private CreateNewUser $createNewUser,
        private PasswordGenerator $passwordGenerator
    ) {
    }

• run vendor/bin/phpmd . xml phpmd.xml --reportfile ./test-results/php-mess-detector.xml
• see violations in the xml output file: Avoid unused parameters such as '$createNewUser'. Avoid unused parameters such as '$passwordGenerator'.

Checks before submitting

• [*] Be sure that there isn't already an issue about this. See: Issues list
• [*] Be sure that there isn't already a pull request about this. See: Pull requests
• [*] I have added every step to reproduce the bug.
• [*] If possible I added relevant code examples.
• [*] This issue is about 1 bug and nothing more.
• [*] The issue has a descriptive title. For example: "JSON rendering failed on Windows for filenames with space".

I got tired of the default styling of the HTML renderer, so I took some time to create something new and prettier. I think it looks fine, so I decided to share it back to the project as an additional renderer. :)

Sample

Old sample: https://user-images.githubusercontent.com/6860713/31499693-cd15ac5e-af65-11e7-811b-f157c47985ec.png

This PR contains a new renderer, selectable as pretty-html parameter in addition to existing html, xml, text output formats.

Usage is thus something like this:

./vendor/phpmd/phpmd/src/bin/phpmd /home/user/php-code-directory pretty-html codesize,cleancode --reportfile pretty-report.html

I don't know if I edited the licencing texts correctly, but that can be obviously fixed.

Following issue #50, I also have a warning about UnusedFormalParameters which I think should no be happening.

I created classes extending the base Symfony 2.0 Command class which includes an execute method :

class Command
{
    [...]
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        throw new \LogicException('You must override the execute() method in the concrete command class.');
    }
    [...]
}

My own classes are as follow :

class BaseCommand extends Command
{
    [...]
}

class ConfigCommand extends BaseCommand
{
    protected function configure()
    {
        [...]
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $this->loadContext();
        $output->writeln('<info>Current configuration is:</info>');
        $output->writeln(Yaml::dump(Context::getInstance()->getParam('config')));
    }
}

PHPMD is complaining about the $input parameter that is not used on the ConfigCommand, but there is nothing I can do about it since I really don't need it and I also cannot obviously call the parent method or redefine it since it is part of the Symfony2 framework.

Thanks for your great tool !

• PHPMD version: 2.10.0
• PHP Version: 8.0.3
• Installation type: phar
• Operating System / Distribution & Version: macOS

Current Behavior

I'm seeing multiple errors during a single lint execution.

./Bin/phpmd Test.php json cleancode,codesize,controversial,design,naming,unusedcode 
PHP Deprecated:  Function libxml_disable_entity_loader() is deprecated in phar:///<xxxxx>/Bin/phpmd/vendor/symfony/config/Util/XmlUtils.php on line 54

Deprecated: Function libxml_disable_entity_loader() is deprecated in phar:///<xxxxx>/Bin/phpmd/vendor/symfony/config/Util/XmlUtils.php on line 54
PHP Deprecated:  Function libxml_disable_entity_loader() is deprecated in phar:///<xxxxx>/Bin/phpmd/vendor/symfony/config/Util/XmlUtils.php on line 68

Deprecated: Function libxml_disable_entity_loader() is deprecated in phar:///<xxxxx>/Bin/phpmd/vendor/symfony/config/Util/XmlUtils.php on line 68
PHP Deprecated:  Function libxml_disable_entity_loader() is deprecated in phar:///<xxxxx>/Bin/phpmd/vendor/symfony/dependency-injection/Loader/XmlFileLoader.php on line 517

Deprecated: Function libxml_disable_entity_loader() is deprecated in phar:///<xxxxx>/Bin/phpmd/vendor/symfony/dependency-injection/Loader/XmlFileLoader.php on line 517
PHP Deprecated:  Function libxml_disable_entity_loader() is deprecated in phar:///<xxxxx>/Bin/phpmd/vendor/symfony/dependency-injection/Loader/XmlFileLoader.php on line 519

Deprecated: Function libxml_disable_entity_loader() is deprecated in phar:///<xxxxx>/Bin/phpmd/vendor/symfony/dependency-injection/Loader/XmlFileLoader.php on line 519
{
    "version": "2.10.0snapshot202104261849",
    "package": "phpmd",
    "timestamp": "2021-04-27T02:27:17+00:00",
    "files": [
        {
            "file": "\/Users\/mike\/Developer\/phpmd.novaextension\/Test.php",
            "violations": [
                {
                    "beginLine": 3,
                    "endLine": 6,
                    "package": "+global",
                    "function": null,
                    "class": "Testasfsdfsdafsdfsadfsdfsdfsdafsadfsafsdfsdfdsfdsfsdaf",
                    "method": null,
                    "description": "Avoid excessively long class names like Testasfsdfsdafsdfsadfsdfsdfsdafsadfsafsdfsdfdsfdsfsdaf. Keep class name length under 40.",
                    "rule": "LongClassName",
                    "ruleSet": "Naming Rules",
                    "externalInfoUrl": "https:\/\/phpmd.org\/rules\/naming.html#longclassname",
                    "priority": 3
                }
            ]
        }
    ]
}

Expected Behavior

• The errors make it difficult to parse the results programatically.
• I would expect libxml_disable_entity_loader() not to be referenced when running in PHP 8.

Steps To Reproduce:

Run the above command on the following file:

<?php

class Testasfsdfsdafsdfsadfsdfsdfsdafsadfsafsdfsdfdsfdsfsdaf
{
    //
}

Checks before submitting

• [X] Be sure that there isn't already an issue about this. See: Issues list
• [X] Be sure that there isn't already a pull request about this. See: Pull requests
• [X] I have added every step to reproduce the bug.
• [X] If possible I added relevant code examples.
• [X] This issue is about 1 bug and nothing more.
• [X] The issue has a descriptive title. For example: "JSON rendering failed on Windows for filenames with space".

I have a command line option interface, which formats the output for display to the user when the tool is called wrong. The options could be values in a config file (XML, INI) or even the command line similar to getopts.

The function below is being reported as a Cylomatic Complexity of 15, but a NPath Complexity over 300K.

The code will loop through each option and depending on how it is defined (must enter, has a value, value optional, etc..) it will build the usage output. This class is used to support options from various sources, not just the command line with getopts.

public function GetHelpOutput($Title, $Description)
{
    $HelpOutput  = $Title . self::TAB . $Description . self::NEW_LINE;
    $HelpOutput .= 'Available Parameters:' . self::NEW_LINE;

    $LargestWord = 0;
    $IsOptional  = FALSE;
    $IsNeedValue = FALSE;
    foreach ($this->CommandLineOptions_ as $Key => $CommandOption)
    {
        if( ! $CommandOption->Required)
        {
            $IsOptional = TRUE;
        }
        if( $CommandOption->ValueRequired)
        {
            $IsNeedValue = TRUE;
        }
        $Size        = strlen($CommandOption->WordParameter);
        $LargestWord = ($Size > $LargestWord) ? $Size : $LargestWord;
    }

    $MaxBuffer = ($IsOptional ? 4 : 0) + ($IsNeedValue ? 6 : 0) + 4 + $LargestWord;
    foreach ($this->CommandLineOptions_ as $Key => $CommandOption)
    {
        $Parameter  = (strlen($CommandOption->LetterParameter) > 0) ? '-' . $CommandOption->LetterParameter : '  ';
        $Parameter .= ($IsOptional && $CommandOption->Required) ? ' ' : NULL;
        if( strlen($CommandOption->WordParameter) > 0)
        {
            $Parameter .= (substr($Parameter, 0, 1) == '-') ? ' | ' : '   ';
            $Parameter .= '--' . $CommandOption->WordParameter;
        }

        if( $CommandOption->ValueRequired)
        {
            $Parameter .= ' value';
        }

        if( ! $CommandOption->Required )
        {
            $Parameter = '[' . $Parameter . ']';
        }

        $HelpOutput .= str_pad($Parameter, $MaxBuffer, ' ', STR_PAD_RIGHT);
        $HelpOutput .= ' - ' . $CommandOption->Description;
        $HelpOutput .= self::NEW_LINE;
    }
    return $HelpOutput;
}

Output from PHPMD 1.5.0

OPTIONS.class:307 The method GetHelpOutput() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10. OPTIONS.class:307 The method GetHelpOutput() has a n NPath complexity of 315525. The configured NPath complexity threshold is 200.

A 1.5.0 install at the moment will accept a 2.0.0 pdepend version, even though 2.x is not compatible with phpmd 1.5.x. This is due to phpmd depending on pdepend using a >= version constraint (no upper limit).

Broken:

$ cat composer.json
{
    "require": {
        "phpmd/phpmd": "~1.0"
    }
}

$ vendor/bin/phpmd
PHP Warning:  require_once(PHP/Depend/Autoload.php): failed to open stream: 
...etc...

Works (force pdepend to a 1.x release):

$ cat composer.json
{
    "require": {
        "phpmd/phpmd": "~1.0",
        "pdepend/pdepend": "~1.0"
    }
}

$ vendor/bin/phpmd
Mandatory arguments:
...etc...

See also: https://getcomposer.org/doc/01-basic-usage.md#package-versions https://getcomposer.org/doc/01-basic-usage.md#next-significant-release-tilde-operator- https://getcomposer.org/doc/faqs/why-are-unbound-version-constraints-a-bad-idea.md

• PHPMD version: 2.9.1
• PHP Version: 8.0
• Installation type: composer
• Operating System / Distribution & Version: Docker Image php:8.0-fpm-alpine

Current Behavior

It worked fine in PHP7.4, but in PHP8.0 it shows Unexpected token: in all the .php files it inspects.

Expected Behavior

The process is completed normally.

Steps To Reproduce:

• $ phpmd . text phpmd.xml

phpmd.xml

<?xml version="1.0"?>
<ruleset name="Custom_PHPMD">
    <description>Custom ruleset PHPMD</description>
    <rule ref="rulesets/codesize.xml" />
    <rule ref="rulesets/controversial.xml">
        <exclude name="CamelCasePropertyName" />
        <exclude name="CamelCaseParameterName" />
        <exclude name="CamelCaseVariableName" />
    </rule>
    <rule ref="rulesets/design.xml" />
    <rule ref="rulesets/unusedcode.xml" />
    <rule ref="rulesets/naming.xml">
        <exclude name="ShortVariable"/>
        <exclude name="LongVariable" />
    </rule>
    <rule ref="rulesets/naming.xml/ShortVariable">
        <properties>
            <property name="exceptions" value="id,e,tz"/>
        </properties>
    </rule>
    <rule ref="rulesets/cleancode.xml">
        <exclude name="BooleanArgumentFlag"/>
        <exclude name="ElseExpression"/>
        <exclude name="StaticAccess"/>
    </rule>
    <exclude-pattern>*/_ide_helper.php</exclude-pattern>
    <exclude-pattern>*/_ide_helper_models.php</exclude-pattern>
    <exclude-pattern>*/_ide_helper_redis.php</exclude-pattern>
    <exclude-pattern>*/database/*</exclude-pattern>
    <exclude-pattern>*/cache/*</exclude-pattern>
    <exclude-pattern>*/*.blade.php</exclude-pattern>
    <exclude-pattern>*/autoload.php</exclude-pattern>
    <exclude-pattern>*/storage/*</exclude-pattern>
    <exclude-pattern>*/docs/*</exclude-pattern>
    <exclude-pattern>*/vendor/*</exclude-pattern>
    <exclude-pattern>*/migrations/*</exclude-pattern>
    <exclude-pattern>*/tmp/*</exclude-pattern>
</ruleset>

output message

This is just one example, but other files are displayed as well.

/src/app/Console/Kernel.php     -       Unexpected token: App\Console, line: 3, col: 11, file: /src/app/Console/Kernel.php.
/src/app/Exceptions/Handler.php -       Unexpected token: App\Exceptions, line: 3, col: 11, file: /src/app/Exceptions/Handler.php.
...

As you can see in the file below, an Unexpected token is displayed at the time of the namespace.

https://github.com/laravel/laravel/blob/8.x/app/Console/Kernel.php https://github.com/laravel/laravel/blob/8.x/app/Exceptions/Handler.php

Checks before submitting

• [x] Be sure that there isn't already an issue about this. See: Issues list
• [x] Be sure that there isn't already a pull request about this. See: Pull requests
  • Searching for issues in PHP8 and 8.0 and Unexpected
• [x] I have added every step to reproduce the bug.
• [ ] If possible I added relevant code examples.
• [x] This issue is about 1 bug and nothing more.
• [x] The issue has a descriptive title. For example: "JSON rendering failed on Windows for filenames with space".

Hello, I was wondering what was the plan about making PHPMD works for PHP 7.4

So far I have tried and obviously type properties are not working we got:

-	Unexpected token:

but also destructuring does not make phpmd happy !

Thanks for maintaining!

• PHPMD version: 2.13.0
• PHP Version: 8.0.23
• Installation type: phive
• OS: Linux Alpine 3.15

Current Behavior

phpmd craches with the error "Unexpected token: (, ..."

Expected Behavior

The expected behavior should be a warning by phpmd for the extra parentheses

Steps To Reproduce:

The issue can be reproduced with the following valid php code.

<?php
$value = 1;
if (isset(($value))) {
  print "value = $value\n";
}

Checks before submitting

• [x] Be sure that there isn't already an issue about this. See: Issues list
• [x] Be sure that there isn't already a pull request about this. See: Pull requests
• [x] I have added every step to reproduce the bug.
• [x] If possible I added relevant code examples.
• [x] This issue is about 1 bug and nothing more.
• [x] The issue has a descriptive title. For example: "JSON rendering failed on Windows for filenames with space".

• PHPMD version: 2.13.0
• PHP Version: 8.1
• Installation type: composer
• Operating System / Distribution & Version: Ubuntu 22.04

Current Behavior

<?php
use SomeTrait;

class Example {
   use SomeTrait;

   public function test(){
     $bla = self::$someTraitVar['someKey'];
   }
}
?>

<?php

trait SomeTrait {
   protected static array $someTraitVar = [
      'someKey' => 12345
   ];
}
?>

This will mark self::$someTraitVar['someKey']; within the test method as "Avoid using undefined variables...".

Expected Behavior

Should not be marked as "Avoid using undefined variables...".

Steps To Reproduce:

See example code above

• PHPMD version: 2.12.0
• PHP Version: 7.4
• Installation type: (composer)
• Operating System / Distribution & Version: (Linux)

Current Behavior

For now you can use php-includepath setting as an alternative path. It means that you try to find a ruleset with pathes from get_include_path() ini setting then you try to find that with <php-includepath> setting.

Expected Behavior

Proposition to use <php-includepath> as priority path instead of alternative. It means that paths from this setting should be added at the beginning of the include_path ini setting.

Steps To Reproduce:

if you use ruleset path that exist with some path from get_include_path(). it make it impossible to use that with a path <php-includepath>. Anyway you return the path from existing pathes from get_include_path().

Checks before submitting

• [x] Be sure that there isn't already an issue about this. See: Issues list
• [x] Be sure that there isn't already a pull request about this. See: Pull requests
• [x] I have added every step to reproduce the bug.
• [x] If possible I added relevant code examples.
• [x] This issue is about 1 bug and nothing more.
• [x] The issue has a descriptive title. For example: "JSON rendering failed on Windows for filenames with space".

Code example.

PHPMD\RuleSetFactory::224 line Proposition to change $includePath = get_include_path() . PATH_SEPARATOR . $includePath; to $includePath .= PATH_SEPARATOR . get_include_path();.

• PHPMD version: 2.13.0 (and pdepend 2.12.1)
• PHP Version: 8.1.7
• Installation type: composer
• Operating System / Distribution & Version: Alpine 3.16 (docker container)

Current Behavior

When an enum contains a value named DEFAULT, phpmd crashes.

<?php

enum Example
{
    case DEFAULT;
}

Error message:

Unexpected token: DEFAULT, line: 5, col: 10, file: /var/www/html/dev/packages/module-dataflow/Component/Database/InsertMode.php.
#0 /var/www/html/vendor/pdepend/pdepend/src/main/php/PDepend/Source/Language/PHP/AbstractPHPParser.php(7966): PDepend\Source\Parser\UnexpectedTokenException->__construct(Object(PDepend\Source\Tokenizer\Token), Object(PDepend\Source\AST\ASTCompilationUnit))
#1 /var/www/html/vendor/pdepend/pdepend/src/main/php/PDepend/Source/Language/PHP/AbstractPHPParser.php(8116): PDepend\Source\Language\PHP\AbstractPHPParser->getUnexpectedTokenException()
#2 /var/www/html/vendor/pdepend/pdepend/src/main/php/PDepend/Source/Language/PHP/AbstractPHPParser.php(1099): PDepend\Source\Language\PHP\AbstractPHPParser->parseEnumCase()
#3 /var/www/html/vendor/pdepend/pdepend/src/main/php/PDepend/Source/Language/PHP/PHPParserVersion81.php(164): PDepend\Source\Language\PHP\AbstractPHPParser->parseTypeBody(Object(PDepend\Source\AST\ASTEnum))
#4 /var/www/html/vendor/pdepend/pdepend/src/main/php/PDepend/Source/Language/PHP/AbstractPHPParser.php(6578): PDepend\Source\Language\PHP\PHPParserVersion81->parseEnumDeclaration()
#5 /var/www/html/vendor/pdepend/pdepend/src/main/php/PDepend/Source/Language/PHP/AbstractPHPParser.php(516): PDepend\Source\Language\PHP\AbstractPHPParser->parseOptionalStatement()
#6 /var/www/html/vendor/pdepend/pdepend/src/main/php/PDepend/Engine.php(606): PDepend\Source\Language\PHP\AbstractPHPParser->parse()
#7 /var/www/html/vendor/pdepend/pdepend/src/main/php/PDepend/Engine.php(351): PDepend\Engine->performParseProcess()
#8 /var/www/html/vendor/phpmd/phpmd/src/main/php/PHPMD/Parser.php(99): PDepend\Engine->analyze()
#9 /var/www/html/vendor/phpmd/phpmd/src/main/php/PHPMD/PHPMD.php(240): PHPMD\Parser->parse(Object(PHPMD\Report))
#10 /var/www/html/vendor/phpmd/phpmd/src/main/php/PHPMD/TextUI/Command.php(136): PHPMD\PHPMD->processFiles('dev/packages/mo...', 'phpmd.xml.dist', Array, Object(PHPMD\RuleSetFactory), Object(PHPMD\Report))
#11 /var/www/html/vendor/phpmd/phpmd/src/main/php/PHPMD/TextUI/Command.php(184): PHPMD\TextUI\Command->run(Object(PHPMD\TextUI\CommandLineOptions), Object(PHPMD\RuleSetFactory))
#12 /var/www/html/vendor/phpmd/phpmd/src/bin/phpmd(61): PHPMD\TextUI\Command::main(Array)
#13 /var/www/html/vendor/bin/phpmd(120): include('/var/www/html/v...')
#14 {main}

Expected Behavior

Expected behavior is no error, just a successful analysis.

Steps To Reproduce:

1. Create a file with the enum in the above example.
2. Run phpmd on this file.

Type: feature

This PR add the exception property to the UnusedFormalParameter rule.

Some classes of some frameworks, such as Laravel ApiResource, uses some parameters that arent used by the method.

Type: refactoring Breaking change: yes (protected scope)

BC: getExceptionsList() can be called from custom rules that would extends StaticAccess, TooManyMethds, LongClassName, ShortClassName, LongVariable, ShortVariable, ShortMethodName or UnusedLocalVariable previously returned array and will now return a object implementing IteratorAggregate, ArrayAccess so if user iterates over it or call isset($exceptions[$key]) the resulting behavior will be the same, but if they expect exactly an array (strong typing or using some array_ method on it), they will need to replace $this->getExceptionList() with iterator_to_array($this->getExceptionList()) also if they overridden getExceptionList() in a sub-class, they will need to wrap the returned value in a class like:

class ArrayWrapper
{
    public function __construct(private array $list)
    {
    }

    public function contains(string $key): bool
    {
        return in_array($key, $this->list, true);
    }
}

Risk of BC for real users is low as users are encouraged to extends AbstractRule to create their own, there is little interest to extend an actual rule (BTW, they should likely be final in next major version, and have their methods private)

Motivation: we have all the listed rules above having a getExceptionList() method, all with very close code:

• 1 variant uses array_flip on the list then call isset instead of in_array, this variant add a fixed cost per activated rule but reduces to cost per iteration (method/class/function/variable). As per my benchmark it will benefit to each rule checking more than 13 times the exceptions list, so it would benefit to most of the projects/usages when PHPMD is given big code base, and it would make slower only analyses of very small project or partial analyze (such as a single-file check). So, in my opinion it makes sense to use the isset() variant for all rules.
• due to slightly different method of trim/filter, ,, would in some rules generate a blank exception, in some other not, in some case whitespace around comas will be ignored but not in all rules. It sounds those differences are not wanted and just edge-case bugs. Harmonizing them would ensure a given exceptions could be used for any rule in the config and be handled the same way.
• some rules also trim \ with whitespace, this makes sense only for class name, so I make it as a parameter and only exceptions list meant to be checked against class name have it, other get the default value "" so only whitespace is trimmed.

Apart the $trim parameter then now rules supporting exceptions config will all have the same method implementation with minimum code:

    protected $exceptions;

    protected function getExceptionsList()
    {
        if ($this->exceptions === null) {
            $this->exceptions = new ExceptionsList($this);
        }

        return $this->exceptions;
    }

After dropping PHP 5.3 this can became a trait and minimize the duplicate code accros rules.

#924 will also require to add this config.