Instead of new line characters it delimits the lables with "->" and "-->>" strings.

The reason I did it because the graphviz did contain only the first line of the label.

Trait are not parsed but method within trait are parsed.

Therefore they are added by ReflectionContext with an empty FQCN and generation fails at the digraph building (the second pass)

Need to process trait, at least, skip them in the first time

Hi there,

I'm getting the following error: PHP Catchable fatal error: Argument 2 passed to Trismegiste\Mondrian\Graph\Digraph::addEdge() must be an instance of Trismegiste\Mondrian\Graph\Vertex, null given, called in phar:///usr/local/bin/mondrian/src/Visitor/EdgeCollector.php on line 118 and defined in phar:///usr/local/bin/mondrian/src/Graph/Digraph.php on line 59

Any idea why this might happen?

In my project a class factory is used to create objects. This means, that in the code I have Factory::create('someName') and Factory::create('someOtherName'), which indirectly maps to actual object class, that will be created.

To make IDE auto-complete work I do this:

/** @var ActualClassName $object */
$object = Factory::create('someName');

Are such @var annotations being processed?

I'm using php 5.5 and getting: Warning: Invalid argument supplied for foreach() in /Mondrian/Transform/ReflectionContext.php on line 65

Warning: Invalid argument supplied for foreach() in /Mondrian/Transform/ReflectionContext.php on line 65

Catchable fatal error: Argument 1 passed to Trismegiste\Mondrian\Graph\Digraph::addEdge() must be an instance of Trismegiste\Mondrian\Graph\Vertex, null given, called in /Mondrian/Visitor/EdgeCollector.php on line 107 and defined in /Mondrian/Graph/Digraph.php on line 59

The PhpFile is not Modified after modified() when in the method afterTraversing

It does not make sense ?!? cloning in Traverser ? Otherwise, why other refactoring passes do work ?

To prevent this app to grow to its out-maintainbility point, it would be wise to create a system permitting to add third-party plugin.

zero config pleaz

So far, there could be a problem with autoloading of PHPParser

For reason I don't figure out, when you call

$ ../mondrian.phar 

autoloading fails for PHPParser_*

writing the .mondrian.yml is a boring task, make a default generation with a new command.

Is that parsing or refactoring ? Depending on the issue #16 this command will be inherit from AbstractParse or AbstractRefactor...

• Better design for refactor pass interface : too many if in Contractor
• Where to save the file ? in the "afterTraverse" visitor or in "leaveNode" for PhpFile node

Abstraction for the persistence to the filesystem ?

The 3 visitors for refactoring need to be fully unit and functional tested

When installing via composer, it currently complains that the package nikic/PHP-Parser is not stable. This forces you to set your minimum-stabilty to dev which is not good.

This was attempted to be fixed here, but it now looks to be outdated: https://github.com/Trismegiste/Mondrian/pull/35.

It's likely that we'll want to upgrade this package to version 1.1, as suggested by @Trismegiste in the PR.

I am using the PHP version 7 fork, and downloaded the bin/box/mondrian.phar. On executing mondrian.phar d --ignore=tests --ignore=vendor --format=html project-dir, I get the following warning, and the generated html is blank.

PHP Warning: file_get_contents(phar:///mondrian.phar/src/Transform/Format/template.html): failed to open stream: phar error: "src/Transform/Format/template.html" is not a file in phar "mondrian.phar" in phar:///mondrian.phar/src/Transform/Format/Html.php on line 20

Hello!

It appears you have an older version of nikic/php-parser as a dependency. Versions earlier than 1.3 cause the following error under PHP 7:

PHP Fatal error: Cannot use 'PhpParser\Node\Scalar\String' as class name as it is reserved in phar:///usr/local/bin/mondrian.phar/vendor/nikic/php-parser/lib/PhpParser/PrettyPrinter/Standard.php on line 86

More info: https://github.com/nikic/PHP-Parser/issues/182#issuecomment-109368749

Would it be possible to update to at least v1.3 of nikic/php-parser?

Thanks!

Ian

Downloaded the .phar thinking/hoping this would be real easy to use.

[39] 13:04:40 2585 .../htdocs/php.tools$ ./mondrian.phar digraph ../afp1
#!/usr/bin/env php
Parsing 3 files...
PHP Parse error:  parse error in phar:///Applications/MAMP/htdocs/php.tools/mondrian.phar/src/Transform/ReflectionContext.php on line 32

just a simple check to make sure the phar isn't corrupted or something:

[40] 13:04:51 2586 .../htdocs/php.tools$ ./mondrian.phar digraph wtf?
#!/usr/bin/env php

  [InvalidArgumentException]            
  The "wtf?" directory does not exist.  

digraph [-i|--ignore="..."] [-f|--format="..."] dir [report]

Is this a Mondrian problem or something in my environment? The message could be more informative.