| Q | A | ------------- | --- | Branch | master | Bug fix? | no | New feature? | yes | Tests pass? | yes/no | Documented? | no | Fixed tickets | #252

It is an experiment to get the #252 working, actually there is the problem that if we have a grumphp.yml like that:

parameters:
    git_dir: .
    bin_dir: vendor/bin
    ignore_unstaged_changes: false
    tasks: 
        codeception:
            config_file: ~
            fail_fast: false
            suite: ~
            test: ~
    testsuites:
        git_pre_push:
            tasks: 
                - codeception

It's working but codeception is executed also on commit, and I have no idea how to avoid that.

New Task Checklist:

• [x] Is the README.md file updated?
• [ ] Does the task run in the correct context?
• [ ] Are all CI services returning green?

| Q | A | ------------- | --- | Branch | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Documented? | yes | Fixed tickets | #423

This PR adds support for the newest version of Symfony 4.0.

Additional information

#SymfonyConHackday2017 :)

This PR will depend on the adoption of Symfony v4.0 in some of its dependencies:

• [x] composer/composer#6788
• [x] gitonomy/gitlib#122
• [x] phpspec/phpspec#1166

| Q | A | --------------- | --- | Version | vendor/bin/grumphp -V | Bug? | no | New feature? | no | Question? | no | Documentation? | no | Related tickets |

We added PHP 8.1 compatibility in #956. However, not all downstream packages are fully compatible yet. Therefore, you might still see some deprecation warnings. The tool itself should be working though!

Awaiting deps:

• [x] opis/closure: https://github.com/opis/closure/pull/105
• [x] opis/closure: https://github.com/opis/closure/issues/59
• [x] laravel/closure if amphp/parallel-functions wants to use that: https://github.com/amphp/parallel-functions/pull/29

Awaiting dev deps

• [x] phpspec: https://github.com/phpspec/phpspec/pull/1397

Awaiting shim deps (patched locally)

• [x] humbug/box & scoper: https://github.com/box-project/box/issues/562
• [x] scoper issue with serializable closure: https://github.com/humbug/php-scoper/issues/642
• [x] scoper issue with union return types https://github.com/humbug/php-scoper/issues/643
• [x] New shim build setup : https://github.com/phpro/grumphp-shim/pull/17

Broken Tests

• [ ] ~Fix skipped E2E tests~ - currently won't do. They seem buggy edge cases anyways. If there is any need for them to still work, time can be invested

| Q | A | | --- | --- | | Branch | master | | Bug? | no | | New feature? | no | | Question? | yes | | Documentation? | no |

In short: I'm developing php applications in docker containers. It's a lightweight vagrant box with a docker server. The OS X docker client connects with it as it was native.

This means:

• Everything related with git is on OS X cli.
• Everything related with composer and bin executables are on the PHP container.

I would like to extend grumphp in the way that the pre-commit hook command executes in the docker container.

Example to run grumphp using docker and docker-compose from OS X cli:

docker exec -it `docker-compose ps -q php` bash -c "cd /var/www/app && ./vendor/bin/grumphp run";

I can make something like the vagrant pre-commit settings: https://github.com/phpro/grumphp/blob/master/resources/hooks/vagrant/pre-commit

But I'll need some extra parameters, which container (php) and which docroot (/var/www/app). The git diff can be done on the OS X cli but the run should happen on the container.

Can I add a docker parameter, with all settings? Hooks can be installed local as default.

I'm currently using it by hardcoding this in the pre-commit hook.

# Run GrumPHP
#(cd "./" && echo "${DIFF}" | exec '/vendor/phpro/grumphp/bin/grumphp' 'git:pre-commit' '--skip-success-output')
(cd "./" && echo "${DIFF}" | docker exec -i `docker-compose ps -q php` bash -c "cd /var/www/app && ./vendor/bin/grumphp git:pre-commit --ansi --skip-success-output")

A gist: https://gist.github.com/jverdeyen/9c0b247bb8b34c7fae514315db36a23e

I would like to hear feedback about this :)

Thanks!

| Q | A | | --- | --- | | Branch | master for features and deprecations | | Bug fix? | no | | New feature? | yes | | BC breaks? | yes | | Deprecations? | no | | Tests pass? | yes | | Documented? | yes | | Fixed tickets | 17 |

Try to implement #17 but there is a BC break because TaskRunner::run no longer throws FailureException

The feature is already documented in https://github.com/phpro/grumphp/blob/master/doc/tasks.md#metadata

Hi. First of all - nice tool ! ;)

Maybe it's a matter of configuration, but please consider the following scenario:

• configure tool to use PHP CS Fixer, init git hooks
• create foo.php file with CS violations
• git add foo.php, git commit -m "foo" -> fails due to PHP CS Fixer violations
• fix violations without adding the file (so git status will show unfixed-files in stage and fixed one in non-stage)
• git commit -m "foo" will proceed, even if the file we are commiting is not valid

Please, could you help?

| Q | A | | --- | --- | | Branch | master for features and deprecations | | Bug fix? | no | | New feature? | yes | | BC breaks? | no | | Deprecations? | no | | Tests pass? | yes/no | | Documented? | yes | | Fixed tickets | #158 |

This PR add a new whitelist_patternsoption to Phpcs task. It will be used to filter files to be validated.

Example for a Symfony, validate PHP files only in src/ directory

phpcs:
    standard: "./vendor/leaphub/phpcs-symfony2-standard/leaphub/phpcs/Symfony2/"
    show_warnings: true
    whitelist_patterns: ["^src/(.*)"]
    triggered_by: [php]

| Q | A | ------------- | --- | Branch | master for features and deprecations | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Documented? | yes | Fixed tickets | #615

See #615 - support running grumphp on multiple locally installed PHP versions.

…hooks templates

| Q | A | ------------- | --- | Branch | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Documented? | yes | Fixed tickets | none

This feature allow users to specify 2 new config parameters :

vagrant_dir

The hook templates assume that the VagrantBox is at the root project dir, but if it isn't there (for example d:/VagrantBoxes/...) users were obliged to edit the hook after doing a grumphp git:init command

vagrant_project_dir

The documentation of the parameter hooks_preset describe how to make the vagrant box switching directly to the root project dir, to avoid any problems when launching the git hooks

I think it's a better idea to allow users configure it inside the GrumPHP configuration file. It's better when working with a team in my opinion, instead of having to update each on our own our vagrant .bashrc file

All is documented and have default values that should not create problems with existing configurations

| Q | A | --------------- | --- | Version | 0.14 | Bug? | yes | New feature? | no | Question? | no | Documentation? | no | Related tickets | comma-separated list of related tickets

When running composer install in a clean repository (no vendor folder exists yet), I'm getting this error:

Fatal error: Class 'Doctrine\Common\Collections\ArrayCollection' not found in /Users/rasta/DEV/BetterSerializer/vendor/phpro/grumphp/src/Collection/ProcessArgumentsCollection.php on line 8

This happens when running the GrumPHP\\Composer\\DevelopmentIntegrator::integrate composer post install command for the first time. When running composer install for the second time, the error isn't there anymore. Which is kind of ok, but this thing breaks my Travis build.

I'm using the composer --no-scripts flag as a workaround for now.

My configuration

parameters:
    git_dir: .
    bin_dir: vendor/bin
    process_timeout: 600
    tasks:
      phpcs:
        standard: PSR2
        tab_width: 4
        whitelist_patterns: []
        encoding: ~
        ignore_patterns: []
        sniffs: []
        triggered_by: [php]
      phpcsfixer2:
        allow_risky: true
        cache_file: .php_cs.cache
        config: .php_cs
        using_cache: true
        config_contains_finder: false
        verbose: true
        diff: false
        triggered_by: [php]
      phplint: ~
      phpmd:
        exclude: []
        ruleset: ['dev/phpmd.ruleset.xml']
        triggered_by: [php]
      phpparser: ~
      phpstan:
        autoload_file: ~
        configuration: dev/phpstan.neon
        level: 7
        triggered_by: [php]
      phpunit: ~
      infection:
        threads: 2
        test_framework: phpunit
        only_covered: true
        configuration: infection.json
        min_msi: ~
        min_covered_msi: ~
        mutators: []
        triggered_by: [php]
      phpversion: ~
      securitychecker: ~
      shell: ~

My composer.json file (minimised to the bare minimum to reproduced the error):

{
    "name": "whatever/whatever",
    "description": "whatever",
    "type": "library",
    "license": "MIT",
    "minimum-stability": "dev",
    "require": {
        "php": "^7.2"
    },
    "require-dev": {
        "doctrine/collections": "^1.5",
        "phpro/grumphp": "^v0.14"
    },

    "autoload": {
        "psr-4": {
            "BetterSerializer\\": "src/BetterSerializer/"
        }
    },

    "autoload-dev": {
        "psr-4": {
            "BetterSerializer\\": "tests/BetterSerializer/",
            "Integration\\": "tests/Integration/"
        }
    },

    "config": {
        "platform": {
            "php": "7.2"
        },
        "sort-packages": true
    }
}

Steps to reproduce:

# Generate empty folder
git clone https://github.com/better-serializer/better-serializer.git
cd better-serializer
git checkout faster_than_reflection
composer install -o --no-interaction  

Result:

Writing lock file
Generating optimized autoload files

Fatal error: Class 'Doctrine\Common\Collections\ArrayCollection' not found in /Users/rasta/DEV/BetterSerializer/vendor/phpro/grumphp/src/Collection/ProcessArgumentsCollection.php on line 8

Hook:

$ /bin/sh
$ cat ./.git/hooks/pre-commit
#!/bin/sh

#
# Run the hook command.
# Note: this will be replaced by the real command during copy.
#

# Fetch the GIT diff and format it as command input:
DIFF=$(git diff -r -p -m -M --full-index --staged | cat)
echo $DIFF;
echo "";
# Run GrumPHP
(cd "./" && echo "${DIFF}" | exec 'vendor/phpro/grumphp/bin/grumphp' 'git:pre-commit' '--skip-success-output')

# Validate exit code of above command
RC=$?
if [ "$RC" != 0 ]; then
  exit $RC;
fi

# Clean exit:
exit 0;

$ ./.git/hooks/pre-commit
diff --git a/demo/config/processor.php b/demo/config/processor.php index 9c2398bc43d2d5b39e31a4bb6c759848ccbb02ac..a740c15e751cdce83fc9aa20c14be7eeb2dd9ed2 100644 --- a/demo/config/processor.php +++ b/demo/config/processor.php @@ -5,7 +5,7 @@ namespace MailRu\QueueProcessor\Demo


  [Gitonomy\Git\Exception\RuntimeException]  
  Unable to find "                           
  "                                          


git:pre-commit [--skip-success-output] [-h|--help] [-q|--quiet] [-v|vv|vvv|--verbose] [-V|--version] [--ansi] [--no-ansi] [-n|--no-interaction] [-c|--config [CONFIG]] [--] <command>

It cuts diff:

$ git diff -r -p -m -M --full-index --staged | cat
diff --git a/demo/config/processor.php b/demo/config/processor.php
index 9c2398bc43d2d5b39e31a4bb6c759848ccbb02ac..a740c15e751cdce83fc9aa20c14be7eeb2dd9ed2 100644
--- a/demo/config/processor.php
+++ b/demo/config/processor.php
@@ -5,7 +5,7 @@ namespace MailRu\QueueProcessor\Demo\config;
 return [
     'testPool' => [
         'servers' => [
-            'mougrim-1215N',
+            php_uname('n'),
         ],
         'maxWorkersQty' => 2,
         'queues' => [
diff --git a/demo/shared/logs/.gitignore b/demo/shared/logs/.gitignore
new file mode 100644
index 0000000000000000000000000000000000000000..72e8ffc0db8aad71a934dd11e5968bd5109e54b4
--- /dev/null
+++ b/demo/shared/logs/.gitignore
@@ -0,0 +1 @@
+*

bash output:

$ bash -c 'echo $(git diff -r -p -m -M --full-index --staged | cat); echo "" '
diff --git a/demo/config/processor.php b/demo/config/processor.php index 9c2398bc43d2d5b39e31a4bb6c759848ccbb02ac..a740c15e751cdce83fc9aa20c14be7eeb2dd9ed2 100644 --- a/demo/config/processor.php +++ b/demo/config/processor.php @@ -5,7 +5,7 @@ namespace MailRu\QueueProcessor\Demo\config; return [ 'testPool' => [ 'servers' => [ - 'mougrim-1215N', + php_uname('n'), ], 'maxWorkersQty' => 2, 'queues' => [ diff --git a/demo/shared/logs/.gitignore b/demo/shared/logs/.gitignore new file mode 100644 index 0000000000000000000000000000000000000000..72e8ffc0db8aad71a934dd11e5968bd5109e54b4 --- /dev/null +++ b/demo/shared/logs/.gitignore @@ -0,0 +1 @@ +*

sh output:

$ sh -c 'echo $(git diff -r -p -m -M --full-index --staged | cat); echo "" '
diff --git a/demo/config/processor.php b/demo/config/processor.php index 9c2398bc43d2d5b39e31a4bb6c759848ccbb02ac..a740c15e751cdce83fc9aa20c14be7eeb2dd9ed2 100644 --- a/demo/config/processor.php +++ b/demo/config/processor.php @@ -5,7 +5,7 @@ namespace MailRu\QueueProcessor\Demo

I think, problem is with "\c":

$ bash -c 'echo "qwe\cqwe";echo ""'
qwe\cqwe
$ sh -c 'echo "qwe\cqwe";echo ""'
qwe

It's reporoducing in Ubuntu 14.04 for pre-commit and commit-msg hooks in master: https://github.com/phpro/grumphp/blob/master/resources/hooks/local/pre-commit https://github.com/phpro/grumphp/blob/master/resources/hooks/local/commit-msg

I don't try resources/hooks/vagrant/pre-commit and resources/hooks/vagrant/commit-msg.

I think fix is change #!/bin/sh to #!/bin/bash

| Q | A | --------------- | --- | Version | 1.5.1 | Bug? | yes | New feature? | no | Question? | no | Documentation? | no

My configuration

 git_branch_name:
            whitelist:
                # allowed branch names: 'feature/JIRA-1234', 'bugfix/JIRA-1234', 'hotfix/JIRA-1234', 'hotfix/v1.0.1', 'release/v1.1.10' etc
                - "/(hotfix|bugfix|feature)\/([JIRA]){4}-([0-9]+){4}$/"
                - "/(hotfix|release)\/([v])([0-9]+){1,2}.([0-9]){1,2}.([0-9]){1,2}$/"
                - "main"

Steps to reproduce:

./vendor/bin/grumphp run

Result:

git_branch_name
===============

Whitelist rule not matched: /(hotfix|bugfix|feature)/([JIRA]){4}-([0-9]+){4}$/
Whitelist rule not matched: /(hotfix|release)/([v])([0-9]+){1,2}.([0-9]){1,2}.([0-9]){1,2}$/

Here is the regex test: https://regex101.com/r/zlHJL6/1 which is passing the branch names.

| Q | A | ------------- | --- | Branch | master for features and deprecations | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Documented? | no | Fixed tickets | #912

This PR :

• adds a FilesCollection->ignoreDeleted() method
• uses this method in FileSize->run() to fix #912

NB: This dev was made on v1.5.1, due to my local PHP version.

| Q | A | ------------- | --- | Branch | master for features and deprecations | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Documented? | yes | Fixed tickets | https://github.com/phpro/grumphp/discussions/1037

Add allow-list config option to be able to ignore given vulns, see https://github.com/enlightn/security-checker#allow-vulnerabilities

| Q | A | --------------- | --- | Version | 1.13.0 | Bug? | maybe | New feature? | no | Question? | yes | Documentation? | no | Related tickets | #1040

A new issue to try and resolve my question in the final comment of #1040 as it's likely an unrelated issue.

As per your suggestion in https://github.com/phpro/grumphp/issues/1040#issuecomment-1228604767 I am trying to inject the value of an environment variable into the GrumPHP yaml configuration file.

I have encountered a strange issue trying to get this setup. Instead of making the actual value of my GITLAB_TOKEN env var available, I get a strange string which looks like env_e7937a168f382d27_GITLAB_TOKEN_4e06944bcec1f665r4a82bf0125e3f8d.

# .env.local

GITLAB_TOKEN=XXXXXX

# grumphp.yml

grumphp:
    tasks:
        gitlab_lint:
            api_token: '%env(GITLAB_TOKEN)%'
    environment:
        files:
            - .env.local

Any pointers much appreciated. Thank you.

| Q | A | --------------- | --- | Version | 1.13.0 | Bug? | yes | New feature? | no | Question? | no | Documentation? | no | Related tickets | comma-separated list of related tickets

My configuration

# grumphp.yml
    phpmd:
      ruleset: ['./dev/tests/static/testsuite/Magento/Test/Php/_files/phpmd/ruleset.xml']
      triggered_by: [ 'php' ]
      exclude: ['dev','vendor','generated','var','lib','update','bin','pub','setup','.docker','phpserver','scripts','docker']
      metadata:
        priority: 900

Steps to reproduce:

./vendor/bin/grumphp run

Result: