Hi! Your project is similar to our - check code style. We, on the other hand, also fix it in place! What about joining forces and work together on https://github.com/FriendsOfPHP/PHP-CS-Fixer ?

This issue is being raised on __construct:

Function __construct name should follow the pattern /^[a-z_][a-zA-Z0-9]$/.

The __construct method and any other magic methods should be exempt from this. Do you agree @tchule?

I am trying to integrate phpcheckstyle, sadly I could not find a way to separate two cases:

• function parameter (variable) naming
• local variable naming

We would like to use different namings for local vars and different namings for parameter namings. In JS and Java checkstyles this is handled independently, since they are also independent levels of definition. Is there a way to solve it in phpcheckstyle?

I would like to make sure that single quotes are preferred but allow the use of double quotes for encapsed variables. Is there a way to allow such a configuration?

Command

composer require phpcheckstyle/phpcheckstyle

Error

You are running composer with xdebug enabled. This has a major impact on runtime
 performance. See https://getcomposer.org/xdebug
Using version ^0.14.3 for phpcheckstyle/phpcheckstyle
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
  - Installing phpcheckstyle/phpcheckstyle (V0.14.3)
    Checking out /tags/V0.14.3/@331

Installation failed, reverting ./composer.json to its original content.


  [RuntimeException]
  Package could not be downloaded, Your configuration does not allow connecti
  ons to http://svn.code.sf.net/p/phpcheckstyle/code//tags/V0.14.3/@331. See
  https://getcomposer.org/doc/06-config.md#secure-http for details.

Composers "secure-http" default value is true. That's why only HTTPS URLs are allowed to be downloaded via Composer. https://getcomposer.org/doc/06-config.md#secure-http

How to fix this error without changing the default composer settings?

If you run PHPCheckstyle against the actual PHPCheckstyle.php file itself, it crashes. I don't know if this is related to a memory bug or something, but it's unable to process itself.

Hi,

I've been successfully using phpcheckstyle. Thank you for the great work. I noticed today the following: if you tag a local variable with a type, then the whole function reports incorrect parameters. Let me give you an example: The code below will show: The function test parameters must match those in its docblock @param.

<?php
class Example
{
    /**
    * @param string $param1
    * @param string $param2
    * @return void 
    **/
    public function test($param1, $param2)
    {
        /** @var SomeClass | null */
        $someObject = null;
    }
}

To resolve the error, I must remove the tag from the local variable. This will pass:

<?php
class Example
{
    /**
    * @param string $param1
    * @param string $param2
    * @return void 
    **/
    public function test($param1, $param2)
    {
        $someObject = null;
    }
}

It looks as if somehow the @var tag is added to the list of parameters already defined by the function ($param1, $param2). As a consequence, the linter reports a mismatch. I need the initial tag, so how could I work around this issue? Any thoughts?

Hi,

AFAIU the main repository for PHPCheckstyle is the one on sourceforge: https://sourceforge.net/projects/phpcheckstyle/

This is not immediately clear from the github page, and the user may end up fetching some outdated code with git, at least compared with the code fetched by composer.

Can you please try to improve this situation?

Thanks.

See : https://code.google.com/p/phpcheckstyle/issues/detail?id=89

We have added the vendor directory in .gitignore. We need to find a way to be compatible for people who use the project directly through GitHub and COmposer and for the people who download the source to use locally without Composer.

When a select or switch has multiple cases that join together:

case T_COMMENT:
case T_ML_COMMENT:
case T_DOC_COMMENT:
    $this->_processComment($token);
    break;

The The case statement must contain a break. warning is being returned. We need to add a check on the case token that it's not immediately followed by another case.

Hey guys!

Big fan of your codestyle-checker. Only thing is that it is quite hard in big projects to distinguish between "info" and "error" by scrolling through the tables. I did some quickfix for me and included bootstrap into your project which is quite nice for the eyes:

I'm setting up a test environment for my upcoming project (in CodeIgniter4, if it's relevant) and stumbled upon this weird behavior. I execute the following (in my CI4 project folder):

php /path/to/run.php --config /path/to/my.cfg.xml --src app/Views/ --exclude app/Views/welcome_message.php

But the excluded file is still parsed:

If I exclude the relative path portion of the exclusion, it does skip the file (but I assume it would also exclude other unintended files):

php /path/to/run.php --config /path/to/my.cfg.xml --src app/Views/ --exclude welcome_message.php

After searching the reported issues, I thought it could have something to do with Issue 78, so I tried executing from the installation directory:

php run.php --config /path/to/my.cfg.xml --src /full/path/to/app/Views/ --exclude /full/path/to/app/Views/welcome_message.php

And it still fails to exclude the indicated file.

Tested in:

• Version 0.14.8
• Commit b16777125e2023efbf47e5576cda32443091a9fd

With PHP 8.0.25. Manual installation.

Installed with

composer require phpcheckstyle/phpcheckstyle --dev

Installed version V0.14.7

Running vendor/bin/phpcheckstyle or vendor/bin/phpcheckstyle -h

Recieved: Could not open input file: vendor/bin/run.php

Changed version to dev-master - using commit 12794c040998979c8720ae80bfd29ddf7a88b566

Same error

Hi! I am using "new line" open curly brace position in my code. But in closure need position in same line.

$response->setCallback(function () use($path) {
    readfile($path);
});

First of all: big thanks for this awesome tool!

Trying it out however, I have run into a small problem with using relative paths. Running the following line:

php /composer/vendor/phpcheckstyle/phpcheckstyle/run.php --src "./src"

I receive the error

Fatal error: Uncaught Error: Class 'PHPCheckstyle\PHPCheckstyle' not found in /composer/vendor/phpcheckstyle/phpcheckstyle/run.php:172
Stack trace:
#0 {main}
  thrown in /composer/vendor/phpcheckstyle/phpcheckstyle/run.php on line 172

Trying to load the /composer/vendor/autoload.php solves this, but it will still complain about not finding the default config file, as it is defined relatively to the location the script is run from, not relatively to the script itself.

This dependency on the location where php is run from is found on other lines as well:

• to require the autoload file
• the default outdir
• the default config

Is there some way to update run.php to make the script run from anywhere? Or even make it possible to run it as a binary in /composer/vendor/bin (which might take advantage from these same changes)? Honestly, I'm not really sure if these would be the only changes needed to being able to run the above line, as --src "./src" is still using a relative path to the location the script has been called from...

Thanks for looking into this. I would be glad to help to provide further details if needed.