When phpcs reports only warnings but no errors, phpcs-baseliner create-baseline fails with PHP_CodeSniffer did not report any errors. and does not create any ignore comments for the warnings.

This seems to be caused by the ReportDeserializer which does not distinguish between errors and warnings. This PR adds the missing distinction.

When using the PHPCS baseliner, additions are added in an annotation of the swagger documentation. This ensures that l5-swagger cannot generate documentation.

In the code below there is an example where te baseliner adds an ignore to the swagger documentation. If the swagger code would be generated for testing it would give an error because it cant compile the baseliner ignore.

Is it possible that when the baseliner is used the swagger documentation is skipped so that no compile errors can occur?

Here is an example of the annotations in the code:

• @OA\ Property(
  • property = "order_lines[0][no]",
  • type = "string",
  • example = "1211-0110",
  • phpcs: ignore SlevomatCodingStandard.Files.LineLength.LineTooLong--baseline
  • description = "Order item0article number. To add more order lines, replace[0]with the correct incremental number", *),
• @OA\ Property(
• property = "order_lines[0][vpe]",
• type = "integer",
• example = 1,
• phpcs: ignore SlevomatCodingStandard.Files.LineLength.LineTooLong--baseline
• description = "Order item0packing unit. To add more order lines, replace[0]with the correct incremental number", *),

Our CI fails when phpcs returns warnings, however, this package does not add warnings to the baseline, only errors.

So when I run the baseliner I get;

Running PHP_CodeSniffer (this may take a while)...
PHP_CodeSniffer did not report any errors.

But when I run phpcs;

$ vendor/bin/grumphp run --tasks phpcs -n

GrumPHP is sniffing your code!                                                                                                               
                                                                                                                                             
Running tasks with priority 0!                                                                                                               
==============================                                                                                                               
                                                                                                                                             
Running task 1/1: phpcs... ✘                                                                                                                 
                                                                                                                                             
phpcs                                                                                                                                        
=====                                                                                                                                        
              
....

And it finds a lot of warnings and exits with non-zero error code, making our pipeline fail.

I could add <config name="ignore_warnings_on_exit" value="1" /> to phpcs.xml, but then there's no record of these errors in the baseline, which is what I prefer.

Is it possible to add a flag to also create a baseline for phpcs warnings, not just errors?

Hi Isaac,

It would be great to offer the possibility to generate a file with all the baseline like do phpstan, instead of writing it in the source code

Thanks by advance and respect for your work

Tom

Hi, @isaaceindhoven I installed your package, and it doesn't work almost.

I call your package via CLI like that: ./vendor/bin/phpcs-baseliner create-baseline ./app and I got errors

Running PHP_CodeSniffer (this may take a while)...
RuntimeException: ERROR: You must supply at least one file or directory to process. in /var/www/academy/current/vendor/isaac/php-code-sniffer-baseliner/src/PhpCodeSnifferRunner/Runner.php:28
Stack trace:
#0 /var/www/academy/current/vendor/isaac/php-code-sniffer-baseliner/src/BaselineCreator.php(65): ISAAC\CodeSnifferBaseliner\PhpCodeSnifferRunner\Runner->run('/var/www/academ...')
#1 /var/www/academy/current/vendor/isaac/php-code-sniffer-baseliner/src/Application.php(95): ISAAC\CodeSnifferBaseliner\BaselineCreator->create()
#2 /var/www/academy/current/vendor/isaac/php-code-sniffer-baseliner/src/Application.php(57): ISAAC\CodeSnifferBaseliner\Application->runCommand(Object(ISAAC\CodeSnifferBaseliner\Command\CreateBaseline))
#3 /var/www/academy/current/vendor/isaac/php-code-sniffer-baseliner/bin/phpcs-baseliner(18): ISAAC\CodeSnifferBaseliner\Application->run('./vendor/bin/ph...', 'create-baseline', './app')
#4 {main

The problem conclusion is not correct to use of embedded PhpCs command and passes arguments. For me, temp solutions as it changes your source code in vendor folder in file Runner.php:20 passes additional arguments which hold name folders that need to scans. So please fix your package do add a feature pass argument with name folders.

Error in runner. php-code-sniffer-baseliner\src\PhpCodeSnifferRunner\Runner.php line 20 should be $cliCommand = sprintf($basePath.'/vendor/bin/phpcs -q --report=json'); Otherwise throws error