I already did most of these steps in my fork because I want PHPStan to be ready for PHP 8 on day one or sonner.

This is what needs to be done in BetterReflection in order to fully support PHP 8:

• [x] Adapter signatures compatibility (https://github.com/ondrejmirtes/BetterReflection/commit/0acd4522bd500547cf2574acb3b1a04b177869ae)
• [x] mixed type (https://github.com/ondrejmirtes/BetterReflection/commit/fabd25923c2a1ec96e3bedbdd09267d88a150f15)
• [x] static type (https://github.com/ondrejmirtes/BetterReflection/commit/e6f9b722e8af66566caad705cd541c213bd4d106)
• [x] Reflecting union types (https://github.com/ondrejmirtes/BetterReflection/commit/ce858eba391542639e8d2ea725df27ffaeca4e01 - this commit needs to be broken up because it mixes more things)
• [x] ReflectionType::__toString breaking change in PHP 8 - nullable type includes ? again (https://3v4l.org/CmTA1)
• [x] ReflectionSourceStubber misses to generate return types (https://github.com/ondrejmirtes/BetterReflection/commit/6a87721f5c95792d754b30931b283c91897995a6)
• [x] isBuiltin() is supposed to be only on ReflectionNamedType in PHP 8 (https://github.com/ondrejmirtes/BetterReflection/commit/86c5ce76560c561209cc36f05d576d0bc761ede0)
• [x] Stringable (https://github.com/ondrejmirtes/BetterReflection/commit/e9f99da6586dab440cc4117379fdbdb912a1697e)
• [x] PhpStormStubsSourceStubberTest will fail a lot when building on PHP 8 because a lot of stuff changed between PHP 8 and PHP 7
• [x] Promoted properties in constructor - I plan to solve this by making ReflectionProperty an interface with two implementations - one based on Property node, the other based on Param node.
• [x] Only __construct methods can be considered constructors
• [x] Support for reading Attributes
• [x] Constant of value null as a default parameter value no longer makes the parameter type nullable

The Stringable commit and the obsoleted old-style constructors require an if based on the PHP version. I did that with a public static property on BetterReflection but a different way can be fine too.

Some of these items require a new major version, but some of them can be done in a minor version before that.

I'm creating this issue because I plan to send PRs for these (in case someone isn't faster than me) but I'd like to hear your opinions first :)

This is just a placeholder to make sure everyone is aware that 5.0.0 is around the corner: if nobody replies to this issue within a couple days, I will release 5.0.0 from 5.0.x (after attempting to put together some release notes @_@ )

If you need to break BC further, now is the time.

Hi, I'm in the process of reducing the memory amount consumed by PHPStan, and I have some promising results.

Current stable version consumes ~850 MB when runing PHPStan on PHPStan.

After I removed the NodeConnectingVisitor (this isn't related to BetterReflection) that creates cycles between nodes by setting parent/previous/next attributes, I saved around 100 MB. So now we're at ~750 MB.

I continued to debug the problem by using php-meminfo but there was a lot of noise because of CachedParser (equivalent of MemoizingParser). So I removed parser caching to see what else holds onto AST nodes. I also removed static reflection capabilities altogether to see if there's something else in PHPStan that leaks. I consider the floor of what's possible to achieve at around ~200 MB.

When I returned static reflection capabilities, it went back to ~750 MB. And most of the memory is held in AST nodes held by various reflection classes like ReflectionClass etc.

So I refactored some classes to extract all of the needed information in constructor so that the AST node is not saved in a property: https://github.com/ondrejmirtes/BetterReflection/compare/cc581ecece6e69674181ec456ecc5d846ad312d1...35db84f1abff5b3416daca4804901b0750da7610 (the work isn't done, there's still more to do)

Right now PHPStan consumes around 340 MB without a CachingParser and around 430 MB with a CachingParser.

The best part is that there's very little performance impact time-wise so it looks really promising. I don't have production-ready code yet as there are some problems to work out but I hope this will make PHPStan much more resource-effective.

One downside is that I had to remove some features that need the AST after a Reflection class is created - it can be seen in the diff.

Is this something you'd like to do here too?

We accumulated a few major improvements over the last months. @asgrim is anything worth holding off a release?

As far as I can see, we're pretty much on par with 7.2 once the current PRs are handled.

3.0.0 (or 2.1.0) could focus on performance, maybe.

Adapter for core Reflection classes, e.g.

<?php

namespace BetterReflection\CompatibleReflection;

use \ReflectionClass as CoreReflectionClass;
use BetterReflection\Reflection\ReflectionClass as BetterReflectionClass;

class ReflectionClass extends CoreReflectionClass
{
    /**
     * @var BetterReflectionClass
     */
    private $betterReflection;

    public function __construct()
    {
        throw new \Exception("Cannot instantiate like this...");
    }

    public static function createFromNode(
        ClassNode $node,
        NamespaceNode $namespace = null,
        $filename = null
    ) {
        $reflection = new self();
        $reflection->betterReflection = BetterReflectionClass::createFromNode($node, $namespace, $filename);
    }

    // Implement all the core methods
}

Alternatively, just make \BetterReflection\Reflection\ReflectionClass extend \ReflectionClass and ensure every method is implemented...

Why? So that something that is (incorrectly) type hinting for \ReflectionClass instead of \Reflector can use this library...

https://github.com/Roave/BetterReflection/issues/281

Note: I did not understand how testReflectionObjectOverridesAllMethodsInReflectionClass works, therefore I missed it.

class Demo
{
    public function test($value = null)
    {
    }
    public function isDefaultValueAvailable(): bool
    {
        return (new \ReflectionParameter([$this, 'test'], 0))->isDefaultValueAvailable();
    }
}

$demo = new Demo();
var_dump($demo->isDefaultValueAvailable()); // result: true

Roave\BetterReflection\Reflection\ReflectionParameter::isDefaultValueAvailable(): https://github.com/Roave/BetterReflection/blob/74aaf7e9a446590f5a461203c379d0580c614faa/src/Reflection/ReflectionParameter.php#L278

Currently ~150 tests are marked incomplete for the following reason:

152) BetterReflectionTest\SourceLocator\PhpInternalSourceLocatorTest::testCanReflectInternalClasses with data set "DateTimeInterface" ('DateTimeInterface')
Can't reflect class "DateTimeInterface" due to an internal reflection exception: "Cannot determine default value for internal functions". Consider adding a stub class

/home/james/workspace/better-reflection/test/unit/SourceLocator/PhpInternalSourceLocatorTest.php:61

This should be considered a bug and incompatibility.

At the moment the test are consuming a huge amount of memory. Local the test are consuming 2.5GB:

$ vendor/bin/phpunit
PHPUnit 9.1.5 by Sebastian Bergmann and contributors.

.............................................................   61 / 7358 (  0%)
.............................................................  122 / 7358 (  1%)
.............................................................  183 / 7358 (  2%)
.............................................................  244 / 7358 (  3%)
.............................................................  305 / 7358 (  4%)
.............................................................  366 / 7358 (  4%)
.............................................................  427 / 7358 (  5%)
.............................................................  488 / 7358 (  6%)
.............................................................  549 / 7358 (  7%)
.............................................................  610 / 7358 (  8%)
.............................................................  671 / 7358 (  9%)
.............................................................  732 / 7358 (  9%)
.............................................................  793 / 7358 ( 10%)
.............................................................  854 / 7358 ( 11%)
.............................................................  915 / 7358 ( 12%)
.............................................................  976 / 7358 ( 13%)
............................................................. 1037 / 7358 ( 14%)
............................................................. 1098 / 7358 ( 14%)
...............................................S............. 1159 / 7358 ( 15%)
............................................................. 1220 / 7358 ( 16%)
............................................................. 1281 / 7358 ( 17%)
............................................................. 1342 / 7358 ( 18%)
............................................................. 1403 / 7358 ( 19%)
............................................................. 1464 / 7358 ( 19%)
............................................................. 1525 / 7358 ( 20%)
............................................................. 1586 / 7358 ( 21%)
............................................................. 1647 / 7358 ( 22%)
............................................................. 1708 / 7358 ( 23%)
............................................................. 1769 / 7358 ( 24%)
............................................................. 1830 / 7358 ( 24%)
............................................................. 1891 / 7358 ( 25%)
............................................................. 1952 / 7358 ( 26%)
............................................................. 2013 / 7358 ( 27%)
............................................................. 2074 / 7358 ( 28%)
............................................................. 2135 / 7358 ( 29%)
............................................................. 2196 / 7358 ( 29%)
............................................................. 2257 / 7358 ( 30%)
............................................................. 2318 / 7358 ( 31%)
............................................................. 2379 / 7358 ( 32%)
............................................................. 2440 / 7358 ( 33%)
............................................................. 2501 / 7358 ( 33%)
............................................................. 2562 / 7358 ( 34%)
............................................................. 2623 / 7358 ( 35%)
............................................................. 2684 / 7358 ( 36%)
............................................................. 2745 / 7358 ( 37%)
............................................................. 2806 / 7358 ( 38%)
............................................................. 2867 / 7358 ( 38%)
............................................................. 2928 / 7358 ( 39%)
............................................................. 2989 / 7358 ( 40%)
............................................................. 3050 / 7358 ( 41%)
............................................................. 3111 / 7358 ( 42%)
............................................................. 3172 / 7358 ( 43%)
............................................................. 3233 / 7358 ( 43%)
............................................................. 3294 / 7358 ( 44%)
............................................................. 3355 / 7358 ( 45%)
............................................................. 3416 / 7358 ( 46%)
............................................................. 3477 / 7358 ( 47%)
............................................................. 3538 / 7358 ( 48%)
............................................................. 3599 / 7358 ( 48%)
............................................................. 3660 / 7358 ( 49%)
............................................................. 3721 / 7358 ( 50%)
............................................................. 3782 / 7358 ( 51%)
............................................................. 3843 / 7358 ( 52%)
............................................................. 3904 / 7358 ( 53%)
............................................................. 3965 / 7358 ( 53%)
............................................................. 4026 / 7358 ( 54%)
............................................................. 4087 / 7358 ( 55%)
............................................................. 4148 / 7358 ( 56%)
............................................................. 4209 / 7358 ( 57%)
............................................................. 4270 / 7358 ( 58%)
............................................................. 4331 / 7358 ( 58%)
............................................................. 4392 / 7358 ( 59%)
............................................................. 4453 / 7358 ( 60%)
............................................................. 4514 / 7358 ( 61%)
............................................................. 4575 / 7358 ( 62%)
............................................................. 4636 / 7358 ( 63%)
............................................................. 4697 / 7358 ( 63%)
............................................................. 4758 / 7358 ( 64%)
............................................................. 4819 / 7358 ( 65%)
............................................................. 4880 / 7358 ( 66%)
............................................................. 4941 / 7358 ( 67%)
............................................................. 5002 / 7358 ( 67%)
............................................................. 5063 / 7358 ( 68%)
............................................................. 5124 / 7358 ( 69%)
............................................................. 5185 / 7358 ( 70%)
............................................................. 5246 / 7358 ( 71%)
............................................................. 5307 / 7358 ( 72%)
............................................................. 5368 / 7358 ( 72%)
............................................................. 5429 / 7358 ( 73%)
............................................................. 5490 / 7358 ( 74%)
............................................................. 5551 / 7358 ( 75%)
............................................................. 5612 / 7358 ( 76%)
............................................................. 5673 / 7358 ( 77%)
............................................................. 5734 / 7358 ( 77%)
............................................................. 5795 / 7358 ( 78%)
............................................................. 5856 / 7358 ( 79%)
............................................................. 5917 / 7358 ( 80%)
............................................................. 5978 / 7358 ( 81%)
............................................................. 6039 / 7358 ( 82%)
............................................................. 6100 / 7358 ( 82%)
............................................................. 6161 / 7358 ( 83%)
............................................................. 6222 / 7358 ( 84%)
............................................................. 6283 / 7358 ( 85%)
............................................................. 6344 / 7358 ( 86%)
............................................................. 6405 / 7358 ( 87%)
............................................................. 6466 / 7358 ( 87%)
............................................................. 6527 / 7358 ( 88%)
............................................................. 6588 / 7358 ( 89%)
............................................................. 6649 / 7358 ( 90%)
............................................................. 6710 / 7358 ( 91%)
............................................................. 6771 / 7358 ( 92%)
............................................................. 6832 / 7358 ( 92%)
............................................................. 6893 / 7358 ( 93%)
............................................................. 6954 / 7358 ( 94%)
............................................................. 7015 / 7358 ( 95%)
............................................................. 7076 / 7358 ( 96%)
............................................................. 7137 / 7358 ( 96%)
............................................................. 7198 / 7358 ( 97%)
............................................................. 7259 / 7358 ( 98%)
............................................................. 7320 / 7358 ( 99%)
......................................                        7358 / 7358 (100%)

Time: 00:24.055, Memory: 2.50 GB

I just checked some CI jobs from the last days: 2.55 GB: https://github.com/Roave/BetterReflection/runs/717137271?check_suite_focus=true 1.41 GB: https://github.com/Roave/BetterReflection/pull/622/checks?check_run_id=716753844 212 MB: https://github.com/Roave/BetterReflection/pull/607/checks?check_run_id=714702198

Right now i could not pin down the culprit but I will investigate further..

UnableToCompileNode: Could not locate constant "LEVELDB_SNAPPY_COMPRESSION" while evaluating expression in LevelDB at line 22

The constant is defined in PhpStorm stubs in the same file as LevelDB class.

The problem is when I get ReflectionParameter for the $options parameter and ask for the default value.

The resolution does not go through ConstantReflector at all.

Build is failing because a lot of stubs is out of date...

The stubs searching is broken since https://github.com/Roave/BetterReflection/commit/3f9a4b317a6c1bc29ab207e4a6b259622bca5813 so it doesn't work almost two years.

May I remove the stubs functionality?

This PR contains the following updates:

| Update | Change | |---|---| | lockFileMaintenance | All locks refreshed |

🔧 This Pull Request updates lock files to use the latest dependency versions.

Configuration

📅 Schedule: Branch creation - "before 2am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

• [ ] If you want to rebase/retry this PR, check this box

Read more about the use of Renovate Bot within ocramius/* projects.

| datasource | package | from | to | | ---------- | --------------- | ------ | ------ | | packagist | phpstan/phpstan | 1.8.11 | 1.8.11 | | packagist | phpunit/phpunit | 9.5.25 | 9.5.26 |

Note: just realized that we only run CI on: [pr], which is NOT okay for renovate to perform background CI checks

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Edited/Blocked

These updates have been manually edited so Renovate will no longer make changes. To discard all commits and start over, click on a checkbox.

• [ ] Update all non-major dependencies (nikic/php-parser, phpstan/phpstan, phpstan/phpstan-phpunit, phpunit/phpunit, ramsey/composer-install, roave/backward-compatibility-check, roave/infection-static-analysis-plugin, vimeo/psalm)

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• [ ] Lock file maintenance

Detected dependencies

• [ ] Check this box to trigger a request for Renovate to run again on this repository

We currently have:

• Roave\BetterReflection\Reflection\ReflectionClass#getMethod(): ReflectionMethod|null
• Roave\BetterReflection\Reflection\ReflectionClass#hasMethod(): bool

This API is kinda dumb-ish, and we kinda went back on it in 6.0.0, IMO: an exception being thrown was probably a much nicer API here.

Either we make getMethod() throw, or we remove hasMethod() here. Relying on getMethod() throwing is not so bad here, but either way could work.

Let's say we have a file that looks like this:

class A
{
}

function b()
{
}

const C = 1;

Once the PHP runtime autoloads the class A, it also knows about b() and C which traditionally cannot be autoloaded and wouldn't be discovered otherwise.

AutoloadSourceLocator should parse the file with A before creating the Reflection and when asked about b() and C, it should report them as known.

I understand if you don't want this change - it makes the behaviour non-deterministic - if the user asks first about b(), it will not be known. But I needed this to make the static reflection's behaviour as close to runtime reflection as possible.

PoC implementation: https://github.com/phpstan/phpstan-src/commit/25c779159e528dfabde191731e6472a123dfecba#diff-b84fb81e70db3cdb6b4495c80b475a44