About 966d0fffd845a4e63a69fb157ed4e77b0ab1041b it is similar to https://github.com/phpmyadmin/sql-parser/commit/a20131487496892d4111c1cbe0025fee35180cce In Debian we need the tests folder to run auto-package tests on packages. Example: https://salsa.debian.org/php-team/pear/php-zumba-json-serializer/-/jobs/3521669#L312 or https://ci.debian.net/data/autopkgtest/unstable/amd64/p/phpmyadmin-sql-parser/27794800/log.gz

This was added in https://github.com/slimphp/Slim-Psr7/pull/76 Then moved as a normal dependency in https://github.com/slimphp/Slim-Psr7/pull/111 for https://github.com/slimphp/Slim-Psr7/issues/101

And got upgraded in https://github.com/slimphp/Slim-Psr7/pull/112

I see no reason this function would be now missing in PHP 7.4+

Description

When UploadedFile is created from stream then calling movingTo will throw an exception.

Script to reproduce the bug

require_once __DIR__ . '/vendor/autoload.php';

$file = new \Slim\Psr7\UploadedFile(
    (new \Slim\Psr7\Factory\StreamFactory())->createStream('Hello, World!')
);

$targetPath = tempnam(sys_get_temp_dir(), 'sample');
$file->moveTo($targetPath);

echo file_get_contents($targetPath);

Expected output:

Hello, World!

Actual output:

PHP Warning:  rename(): PHP wrapper does not support renaming in /home/rait/dev/github/Slim-Psr7/src/UploadedFile.php on line 172
PHP Stack trace:
PHP   1. {main}() /home/rait/dev/github/Slim-Psr7/demo.php:0
PHP   2. Slim\Psr7\UploadedFile->moveTo() /home/rait/dev/github/Slim-Psr7/demo.php:10
PHP   3. rename() /home/rait/dev/github/Slim-Psr7/src/UploadedFile.php:172
PHP Fatal error:  Uncaught RuntimeException: Error moving uploaded file  to /tmp/samplezHN38z in /home/rait/dev/github/Slim-Psr7/src/UploadedFile.php:173
Stack trace:
#0 /home/rait/dev/github/Slim-Psr7/demo.php(10): Slim\Psr7\UploadedFile->moveTo('/tmp/samplezHN3...')
#1 {main}
  thrown in /home/rait/dev/github/Slim-Psr7/src/UploadedFile.php on line 173

Motivation

I discovered this bug when I was creating a stub for a test.

Notes on implementation

I used stream_copy_to_stream for copying. I speculate that built-in stream function should be more efficient because it is implemented in C.

My fix also handles php://temp case where huge files might be the case.

Hello there, I'm using Slim 4.5.0. I'm PUTting a binary file to one of my routes but the Slim\Psr7\Stream instance I get from the Slim\Http\ServerRequest object won't tell me the content size. I'm NOT sending a multipart/form-data request. I'm just PUTting a file with curl -T "filename" "http://my-host/my-route"

Here's my PHP code. $request->getBody()->getSize() is null even though the stream is reported seekable and the Content-Length header was provided.

public function putMediaContent(ServerRequestInterface $request, ResponseInterface $response, array $args) : ResponseInterface {
    //body is a Slim\Psr7\Stream instance
    $body = $request->getBody();
    //size is null
    $size = $body->getSize();
    //isSeekable is true
    $isSeekable = $body->isSeekable();
    //contentLength has the correct uploaded file size
    $contentLength = $request->getHeaders()['Content-Length'][0];

    //...
}

This is a problem since I then have to pass this stream to an S3Client for cloud upload and it complains about the fact the size is unknown. Is this intended?

Thanks.

According to the documentation

The PSR-7 Request object’s URI is itself an object that provides the following methods to inspect the HTTP request’s URL parts:

getScheme()
getAuthority()
getUserInfo()
getHost()
getPort()
getPath()
getBasePath()
getQuery() (returns the full query string, e.g. a=1&b=2)
getFragment()
getBaseUrl()
You can get the query parameters as an associative array on the Request object using getQueryParams().

Base Path
If your Slim application's front-controller lives in a physical subdirectory beneath your document root directory, you can fetch the HTTP request's physical base path (relative to the document root) with the Uri object's getBasePath() method. This will be an empty string if the Slim application is installed in the document root's top-most directory.

Slim v3 implemented the basePath processing as per https://github.com/slimphp/Slim/blob/3.x/Slim/Http/Uri.php#L204

Currently we do not parse any incoming data in the Request object. All that functionality has been moved to the Slim-Http decorators repository.

We should by default at least support the incoming form data in the $_POST object and JSON.