1. I'm not sure it that is covered by tests at 100%, because the $file->getPath() always resulted in Foo.php without relative path. I have added a test however, that will exclude one sniff based for a Foo.php file. This way if that breaks at some point, then we'll have failing test.
2. I've used shell_exec to recursively remove a directory and because of it won't work on Windows.

Closes #201

It would be good to have more details about why an inspection get canceled.

Thus, I think the detection of commit hash changes is flawed for PR inspections. On my work project, half of the recent PR inspections got canceled, including some inspections with no concurrent change on any branch of the repository.

The current code coverage implementation requires running the testsuite on Scrutinizer. this has several drawbacks:

• it duplicates work already done on Travis
• it requires installing vendors on scrutinizer, making things slower (other tools don't need it)
• it is difficult when your app needs additional PHP extensions (sundown in my case) or some other services (MySQL, MongoDB, RabbitMQ, Redis...) and your testsuite contains functional tests

It would be great to be able to collect the code coverage while running tests on CI services (as done by coveralls.io btw)

When using Scrutinizer, the build status icon (the one that states one of: passed, failed, error) links to ScrutinizerCI rather than to TravisCI. It's nice to have a link to ScrutinizerCI, though for my team the choice goes to TravisCI if we need to pick one. That is where we want to go when a build fails after all.

Hi, currently I have an issue where scrutinizer auto cancels inspections with this message(and similar):

The expected parents 25286bf21381e6d24f34b3ea94e70341a997ee0a, bcf4868bdb629e7066c4dbe3ff6a2b40c92beec6 did not match the actual parents 25286bf21381e6d24f34b3ea94e70341a997ee0a, 825f58c18d9e8e96edb2b5011ab075e50b94bcaf of the merge commit. The remote refspec has changed since the inspection was scheduled.Parsing custom inspection configuration

First I thought there are some commits messages which can cancel inspection or PR's where we do some commits amends/rebase. But no, even the most standard commits are cancelled. Can send some urls to inspections where it happens. It never happened before, started few days ago in random repositories/commits. It happens for the last commits in PR so basically cancels whole PR inspection. Is it our fault or something with scrutinizer/github?

Hey!

I just start using caret constraint in composer for one of my project. It seems Scrutinizer is not able to parse caret constraint according to https://scrutinizer-ci.com/g/egeloen/ivory-http-adapter/inspections/5438bf1e-cd62-4d18-85ad-3b2b51aac172 whereas the build is green: https://travis-ci.org/egeloen/ivory-http-adapter/builds/44506481

Can you please update the current composer version used?

Just found out about "Slack" which is an incredible team coordination. They have integrations for everything, except Scrutinizer.

Are there any plans on this front? Travis has it built in with "notifications" configuration. Perhaps something like this is in order?

If not I can write a composer package to do that with with the "custom commands", however there is no way to securely use a token and put it in a public repo.

Ideally:

before_commands:
    - composer require "somepackage/package:0.1"
    - composer install

tools:
    custom_commands:
        -
            scope: project
            command: vendor/bin/slack --token=%mytoken%

something like this should work, I just have to figure out to make %mytoken% secret.

I tried creating a new issue filter in my private project by using the dedicated action in the issue view. However, after running the spinner for a long time, the Ajax request gets a 504 Gateway timeout response and an alert tells me that the filter cannot be created

we have set:

    line_length:
        max_length: '120'

but anyway get a message about a line length limit of 80 chars. so it seems the setting is not used correctly

see Issue (Id: Generic.Files.LineLength.TooLong)

The stats about methods are taking the code duplication into account: see this example. However, there is no way to identify where the duplicated code is.

Note that we could have such info by enabling php_cpd as it would create issues for the duplicated code. But it seems weird when the existing analyzer already have this info. Btw, is PHP_CPD used to provide this metric if PhpAnalyzer is not enabled ?

The travis status is set as pending in the inspection when the Travis build is started, but it is not updated as failed after the Travis failure. It is kept as pending. And this means that the status of the PR on github is also kept as pending.

I encountered an issue saying " SQLSTATE[HY000] [1049] Unknown database 'scrutinizer'" even though I didn't make a database name scrutinizer. I've just encountered this 7 days ago until now, before its working fine and doesn't have any problems.

I put in my php code declare(strict_types=1);, and scrutinizer alerts me to patch that into declare(strict_types = 1); but only in this case, I want to still having the spaces around the operator enabled.

Thanks

I do not need run tests in scrutinizer. But i didnt find this option (disable tests) in docs: https://scrutinizer-ci.com/docs/configuration/build

How fix this trouble?

Hi, I've got an issue with ocular and scrutinizer-ci. Following this documentation https://scrutinizer-ci.com/docs/tools/external-code-coverage/#php I tried to upload a simple code coverage into a private scrutinizer repository, I follow all the documentation steps :

1. I Updated the scrutinizer configuration (from scrutinizer-ci.com)

tools:
    external_code_coverage: true
filter:
    paths:
        - 'src/*'
    excluded_paths:
        - "*/config/*"
        - "*/Tests/*"
        - 'src/AuditBundle/*'
        - 'src/*/Behat/*'
        - 'app/DoctrineMigrations/*'
        - 'app/LegacyMigrations/*'
checks:
    php:
        duplication: false
        avoid_closing_tag: false
        avoid_conflicting_incrementers: false
        avoid_entity_manager_injection: false
        avoid_useless_overridden_methods: true
        closure_use_modifiable: false
        foreach_usable_as_reference: false
        no_commented_out_code: false
        no_empty_statements: false
        no_trait_type_hints: false
        single_namespace_per_use: false
        unused_parameters: false
        overriding_parameter: false

coding_style:
    php:
        spaces:
            around_operators:
                concatenation: false
            other:
                after_type_cast: false

2. I created the access token in order to execute the upload. (with full access)

3. I execute my tests : vendor/bin/phpunit --coverage-clover=coverage.clover Which gives me a coverage.clover file at the root directory of my projet

<?xml version="1.0" encoding="UTF-8"?>
<coverage generated="1488352865">
  <project timestamp="1488352865">
    <package name="TestPolaris">
      <file name="/home/me/www/test/src/Math.php">
        <class name="Math" namespace="TestPolaris">
          <metrics complexity="1" methods="1" coveredmethods="1" conditionals="0" coveredconditionals="0" statements="1" coveredstatements="1" elements="2" coveredelements="2"/>
        </class>
        <line num="7" type="method" name="double" visibility="public" complexity="1" crap="1" count="1"/>
        <line num="8" type="stmt" count="1"/>
        <metrics loc="10" ncloc="10" classes="1" methods="1" coveredmethods="1" conditionals="0" coveredconditionals="0" statements="1" coveredstatements="1" elements="2" coveredelements="2"/>
      </file>
    </package>
    <metrics files="1" loc="10" ncloc="10" classes="1" methods="1" coveredmethods="1" conditionals="0" coveredconditionals="0" statements="1" coveredstatements="1" elements="2" coveredelements="2"/>
  </project>
</coverage>

4. execute thewget https://scrutinizer-ci.com/ocular.phar

And finaly, 5) Execute the following command with the created access-token :

php ocular.phar code-coverage:upload --access-token="ef247198b80ddb9358d8cf8e0ea1MYTOKEN789e0db0c6978e3777777777" --format=php-clover coverage.clover

The command result is :

#!/usr/bin/env php
Uploading code coverage for repository "b/snieditions/test" and revision "867595d41dfc747af619ec0085213d4c86b77dd8"... Done

(I executed all these command manually in my terminal and at the root directory of my project) The command is telling me the job is done without any erros, but I did not manage to find my coverage in the scrutinizer interface. I don't think there is a big problem, I probably just miss a little thing but I don't know what. or maybe I don't look at place.

Thank you for your help,

I have a function with @return array|false|string, however, I'm getting issue:

Consider making the return type a bit more specific; maybe use false|string|array.

Which is not useful, since I already have exactly the same types as suggested, just in alphabetical order.