When i have a setDescription in my configure function it is not moved to static property for https://github.com/rectorphp/rector-symfony/blob/main/docs/rector_rules_overview.md#makecommandlazyrector and not moved when i enable https://github.com/rectorphp/rector-symfony/blob/main/docs/rector_rules_overview.md#commandpropertytoattributerector

Feature Request

I'm actually working on a legacy application with Symfony 3.4 and everything is structured in not necessary bundles. Actually the ~500 routes of the application are configured with YAML in the different bundles. My target is to migrate the route configuration to annotations or attributes. For the beginning I prefer annotations because there are already Rector rules which converts routes between annotations and attributes and legacy applications may not use PHP 8^^

I've already seen that somebody asked for this feature but no one has implemented it or not?

My first step was to get the resolved routes from Symfony because of the bundle structure a route configuration in YAML for a controller/action looks like FooBundle:Bar:baz and will be resolved by the router to \FooBar\FooBundle\Controller\Bar::bazAction which makes me easily to get the correct controller and especially the action because inside the Controller there are often more than one action implemented. For testing I implemented a Symfony command which iterates through the existing routes from the Symfony router and every information of route like path, name, default, ... are available. Very easy to get the important information.

Now the PHP files must be edited which will be easy with Rector but I don't know if it possible to iterate over the configured routes instead of iterating over directories/files?

If it's not possible maybe it's possible to extend the Symfony command which I used for testing that it can use Rector to edit the PHP files but the isn't my prefered solution because it wouldn't be a contribution to the Rector project but I publish it on GitHub.

WDYT? I'm very open for any input :)

Diff

-foo_baz:
-    path: /foo/{baz}
-    defaults: { _controller: FooBundle:Bar:baz, _format: json }
-    methods: [ GET, POST ]

+/**
+ * @Route(name="foo_baz", path="/foo/{baz}", methods={"GET","POST"}, defaults={_format="json"})
+ */
public function bazAction(string $baz)

It's nice that that's lots of little Rectors for doing simple things, but it seems to me the most laborious and complex task of upgrading an old Symfony project is upgrading to the new Symfony 3.3 configuration. Specifically, this means replacing service "machine names" (e.g. my.foo) with FQCN names (e.g. My\Foo::class).

Without this, SymfonySetList::SYMFONY_CONSTRUCTOR_INJECTION cannot do its job and isn't very helpful, because it only promotes services called via get() that specify FQCN class names already. In older projects, this means little or no services are fixed because machine names for services were the norm back then. Nevertheless, it should be possible to read the service configuration and map those names back to the actual class names to both perform the constructor injection and rename the service. However, I cannot find any Rector to do this.

Add failing test for #250

I think the fix might be in ValueResolver from PhpParser as we use isValue to check if the constant is equal to int. But maybe we should also resolve the constant values?

Hi there,

that might be a dumb question, but I'm still on a learning curve from being an engineer only to also developer, but here is the situation. We've written a bundle with some clients, services and so on, which we are using on almost all projects internally.

I've already noticed, that the code quality could be a lot better, but I would like to check it via rector check as well, but obviously, there is no container loaded, so there isn't any container XML available.

I've already tried to include the bundle specifically in one of the projects by adding it to the $rectorConfig->paths, but it seems to ignore that directory (analyzed file count doesn't change).

Any hint would be appreciated.

Thanks !

Regards Oliver

Hi

According to https://github.com/symfony/symfony/blob/6.0/UPGRADE-6.0.md, getDoctrine() is being deprecated I have a lot of code $em = $this->getDoctrine()->getManager(); in my controllers, I would like to know if there is, or how to add, a rule to swap from this code to EntityManagerInterface $entityManager constructor injection or controller action injection

thank you

Hi,

Now https://github.com/rectorphp/rector-symfony/issues/255 is implemented (cc @johanadivare), there is an issue. I would say it's the rule https://github.com/rectorphp/rector-symfony/blob/main/docs/rector_rules_overview.md#consoleexecutereturnintrector

When running, rector with the SymfonyLevelSetList::UP_TO_SYMFONY_61 I get

return 0;

changed to

 return (int) Command::SUCCESS;

If I try to change to

 return Command::SUCCESS;

Running rector give me again

 return (int) Command::SUCCESS;

I saw you just did a PR https://github.com/rectorphp/rector-symfony/pull/290 @TomasVotruba, dont know if it was for this.

It seems that, after Rector finishes its first run after upgrading from 0.11 -> 0.12, almost every file in my project is attributed to an error similar to the following:

[ERROR] Could not process "src/Kernel.php" file, due to: "Method getExtendedTypes() was not found in reflection of class Symfony\Component\Form\AbstractTypeExtension.". On line: 328

Of course, the source file (Kernel.php) is different in each case, but otherwise the error is the same for every single file. Many of these files do not even appear to be tangentially related to the Form component in any way, so I have no idea what is going on.

This occurs on Symfony 4.4.33.

When i run rector, i have the following error:

[ERROR] Could not process "src/SomeMyNamespace/SomeMyClass.php" file by
         "Rector\Symfony2\Rector\MethodCall\AddFlashRector", due to:
         "Call to a member function getClassReflection() on null".

Bug Report

CommandPropertyToAttributeRector is not setting aliases and hidden in AsCommand attribute

| Subject | Details | | :------------- | :--------------------| | Rector version | last dev-main | | Installed as | composer dependency |

Minimal PHP Code Causing Issue

See https://getrector.org/demo/69d11564-5a50-458b-b185-de0c343b416b

<?php

class SunshineCommand extends \Symfony\Component\Console\Command\Command
{
    /** @var string|null */
    public static $defaultName = 'sunshine';

    /** @var string|null */
    public static $defaultDescription = 'Let the sun shine!';
    

    /**
     * {@inheritdoc}
     */
    protected function configure(): void
    {
        $this
            ->setAliases(['sun', 'shine'])
        ;
    }
}

Responsible rules

• CommandPropertyToAttributeRector

Expected Behavior

<?php

#[\Symfony\Component\Console\Attribute\AsCommand('sunshine', 'Let the sun shine!', ['sun', 'shine'], false)
class SunshineCommand extends \Symfony\Component\Console\Command\Command
{
    /**
     * {@inheritdoc}
     */
    protected function configure(): void
    {
    }
}

Bug Report

| Subject | Details | | :------------- | :---------------------------------------------------------------| | Rector version | 0.14.0 |

Hi,

I'm using SensioLab bundle (extra) for our route in controller. I'm using the annotation @Security for more flexibility. I'm using php function constant as parameter for is_granted. With Attribute, it seems we must use \\\ instead of \\ for the fqn of the class + constant Note: It's a bit strange, not sure it's on purpose or a bug but it's working with 3 instead of 2. So Rector should update this argument too.

Framework/ORM

Symfony 6.1 Doctrine

Php

php 8.1.9 CentOs stream 8

My file rector.php

return static function (RectorConfig $rectorConfig): void {

    $rectorConfig->paths([
                             __DIR__ . '/src/Controller/ResourcesBrandController.php'
                         ]);

    // Custom Annotation
    $rectorConfig->ruleWithConfiguration(
        AnnotationToAttributeRector::class, [
                                              new AnnotationToAttribute('App\\Service\\PlatformUserActivity\\Mapping\\Annotation\\UserActivityLoggable'),
                                              new AnnotationToAttribute('App\\Service\\PlatformUserActivity\\Mapping\\Annotation\\Versioned'),
                                          ]
    );

    // https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#inlineconstructordefaulttopropertyrector
    $rectorConfig->rule(InlineConstructorDefaultToPropertyRector::class);

    // Add back new line after statement but keep for Class constant and Trait
    $rectorConfig->rule(NewlineAfterStatementCustomRector::class);

    $rectorConfig->sets(
        [
            DoctrineSetList::ANNOTATIONS_TO_ATTRIBUTES,
            DoctrineSetList::GEDMO_ANNOTATIONS_TO_ATTRIBUTES,
            SymfonySetList::ANNOTATIONS_TO_ATTRIBUTES,
            SymfonySetList::SYMFONY_CODE_QUALITY,
            SensiolabsSetList::FRAMEWORK_EXTRA_61,
            LevelSetList::UP_TO_PHP_80
        ]
    );

};

Original code with annotation

/**
 * Class ResourcesBrandController
 *
 * @Route("/%route-backend_prefix%/resources/brand")
 * @Security("is_granted('ROLE_GA_BRAND_USER') and is_granted(constant('\\App\\Security\\Voter\\BrandVoter::ACCESS'))")
 */
class ResourcesBrandControllerextends AbstractController
{

Expected Behaviour

/**
 * Class ResourcesBrandController
 */
#[Route(path: '/%route-backend_prefix%/resources/brand')]
#[Security("is_granted('ROLE_GA_BRAND_USER') and is_granted(constant('\\\App\\\Security\\\Voter\\\BrandVoter::ACCESS'))")]
class ResourcesBrandController extends AbstractController
{

What rector do

/**
 * Class ResourcesBrandController
 */
#[Route(path: '/%route-backend_prefix%/resources/brand')]
#[Security("is_granted('ROLE_GA_BRAND_USER') and is_granted(constant('\\App\\Security\\Voter\\BrandVoter::ACCESS'))")]
class ResourcesBrandController extends AbstractController
{

Like that, the ExpressionLanguage try to load a class called AppSecurityVoterBrandVoter instead of \App\Security\Voter\BrandVoter

When using TypedPropertyFromStrictSetUpRector, properties in setUp() that are set with static::getContainer()->get('my_service') are refactored wit ?object instead of the inferred type of the service

These interfaces from symfony/messenger are deprecated in Symfony 6.2 in favor of the AsMessageHandler attribute.

See https://github.com/symfony/symfony/pull/47068

Minimal YAML Code Causing Issue

test_route:
  path: /test
  methods: ["GET"]
  controller: App\Controller\TestRouteController

Minimal PHP Code Causing Issue

<?php

declare(strict_types=1);

namespace App\Controller;

use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;

class TestRouteController extends AbstractController
{
    public function __invoke(): void {
    }
}

Responsible Rule

• AddRouteAnnotationRector

Expected Behaviour

<?php

declare(strict_types=1);

namespace App\Controller;

use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\Routing\Annotation\Route;

class TestRouteController extends AbstractController
{
+   /**
+   * @Route(path="/test", name="test_route", methods={"GET"})
+   */
    public function __invoke(): void {
    }
}

See https://github.com/rectorphp/rector-symfony/issues/264

This is my first time working with Rector and the AST so please add feedback 🙂

Right now I'm confused why the use is not being removed (I thought RenamedClassesDataCollector would take care of that) and why the MapEntity is placed on a new line instead of prepended to the parameter.

To do:

• [x] ~Set MapEntity on the same line as the class method parameter~ Rector convention
• [x] Remove use of ParamConverter
• [x] Add fixture with multiple ParamConverters
• [ ] Add fixture(s) that should be skipped
• [x] Add fixture with other options (id, exclude, strip_null, entity_manager and evict_cache)
• [ ] Fix CI

Discussion:

1. Should this also replace Entity attributes since that is a shortcut for using expr?

Make sure to write a custom rule for this as return type has changed from bool to array more information can be found on the symfony pull request

Some more info https://github.com/rectorphp/rector-symfony/pull/279#discussion_r1029400492 & https://github.com/rectorphp/rector-symfony/pull/287

Make sure to write a custom rule for this as return type has changed more information can be found on the symfony pull request

Some more info https://github.com/rectorphp/rector-symfony/pull/283