Add fixture for https://getrector.org/demo/1ec84192-9d46-65fc-947d-9f7ed7e29daf as discussed in https://github.com/rectorphp/rector/issues/6976#issuecomment-1027831779.

\Rector\PHPUnit\PhpDoc\PhpDocValueToNodeMapper::mapGenericTagValueNode is used for both the expected exception and the expected exception message when refactoring php doc tags into exception methods, which opportunistically tries to use class constants.

If there happens to be :: in the exception message, then the exception message isn't treated as a string. Would it be possible to handle exception messages (and maybe regexps) as strings always? Otherwise invalid class constants can be written and generate invalid PHP.

Rector 130b634b5e348554c3349ed3b3f52fa3d08bfb6e PHPUnit 8.5

PHP Fatal error:  Declaration of Rector\Testing\PHPUnit\PlatformAgnosticAssertions::assertStringEqualsFile($expectedFile, $actualString, $message = ''): void must be compatible with PHPUnit\Framework\Assert::assertStringEqualsFile(string $expectedFile, string $actualString, string $message = '', bool $canonicalize = false, bool $ignoreCase = false): void in /var/www/html/vendor/rector/rector/packages/Testing/PHPUnit/AbstractTestCase.php on line 41

We have a big codebase in @sulu and lots of our testcases are not really analyzeable by phpstan as there are lot of false typehints for mocks (we have a very very big baseline). We are using prophecy for mocking. And there are different false typehints in our codebase:

Variant A (class but didnt define mock):

class MyClassTest extends TestCase {
    /**
     * @var MyClass
     */
    private $my;

    public function setUp(): void
    {
         $this->my = $this->prophesize(MyClass::class);
    }
}

Variant B (mock but didnt define class):

class MyClassTest extends TestCase {
    /**
     * @var ObjectProphecy
     */
    private $my;

    public function setUp(): void
    {
         $this->my = $this->prophesize(MyClass::class);
    }
}

Variant C (mock or class (is still false but works sometimes)):

class MyClassTest extends TestCase {
    /**
     * @var ObjectProphecy|MyClass
     */
    private $my;

    public function setUp(): void
    {
         $this->my = $this->prophesize(MyClass::class);
    }
}

Variant D (nothing defined):

class MyClassTest extends TestCase {
    private $my;

    public function setUp(): void
    {
         $this->my = $this->prophesize(MyClass::class);
    }
}

Expected would be ObjectProphecy Generic with the class:

class MyClassTest extends TestCase {
    /**
     * @var ObjectProphecy<MyClass>
     */
    private $my;

    public function setUp(): void
    {
         $this->my = $this->prophesize(MyClass::class);
    }
}

So I asked myself if rector could be used to provide a rule to analyze all $this->prophesize calls and set the correct type for this classes. Think it would be a great rule which could be shipped with rector via a CodeQuality ruleset. Any hints are welcome how to achieve this :)

Given the following code:

$expected = ['date' => new DateTimeImmutable('2022-10-31 12:32:33')];
$date = new DateTimeImmutable('2022-10-31 12:32:33');
$actual = compact('date');

self::assertEquals($expected, $actual);

The new version of the rule will change the assertion to assertSame but this would lead to an error given this will check the two arrays contain exactly the same object.

I noticed a problem with how RemoveDataProviderTestPrefixRector that I think is related to how I'm using inheritance in tests for a project of mine.

I have a base class for tests with a test method that uses an illegally named data provider:

 /**
   * blah blah blah
   *
   * @dataProvider testExceptionsProvider
   */
  public function testExceptions($filename, $message) {

The rector rule correctly updates the annotation to read:

  /**
   * blah blah blah
   *
   * @dataProvider exceptionsProvider
   */
  public function testExceptions($filename, $message) {

However, the annotation in the base class is the only place that the data provider name is changed.

The rector rule seems to be getting "confused" because of how I'm relying on inheritance in these test classes. Specifically:

1. testExceptions() is only declared in the base class.
2. testExceptionsProvider() is not declared in the base test class. It is declared in each of the test classes that extend the base class.

For the record, I am seeing this on a Drupal project that I maintain: https://www.drupal.org/project/crossword/issues/3286830

Thanks!

PR for https://github.com/rectorphp/rector-phpunit/issues/51

I have tested this locally by applying a patch to the rector's vendor directory, and then in rector.php

    $services->set(
        \Rector\PHPUnit\Naming\TestClassNameResolverInterface::class,
        \Utils\Rector\Rector\PHPUnit\Naming\CustomTestClassNameResolver::class
    );

Not sure how that could happen.

Concrete code:

$columns = array_map(function ($row) {
     return $row['column_name'];
}, $connection->fetchAll(sprintf('SHOW COLUMNS IN %s', $connection->quoteIdentifier('updatedDisplayName'))));

$this->assertContains('add_test_column', $columns);

// fetchAll(): array - it's a custom ODBC driver implementation. My only idea was that somehow it thought that it could be false as well 

PHP Fatal error:  Uncaught Error: Class "RectorPrefix20210513\Nette\Loaders\RobotLoader" not found in /home/runner/work/coding-standard/coding-standard/vendor/rector/rector/vendor/rector/rector-phpunit/src/RobotLoader/RobotLoaderFactory.php:14

PHPUnit will deprecate using non-static methods as data providers: https://github.com/sebastianbergmann/phpunit/commit/9caafe2d49b33a21f87db248a8ad6ca7c7bdac09

It would be great to have a rector that automatically turns data provider methods (i.e. methods referenced in @dataProvider annotations or the equivalent attribute) into static methods (the extra safety would do that only if they are not called or overridden somewhere else)

PHPUnit will support attributes in version 10.
It would be cool to have day 1 support. ref issue: https://github.com/rectorphp/rector-phpunit/issues/69

This is work in progress because currently AnnotationToAttribute:

1. do not support syntax like: @dataProvider data or @group api (those are probably most common)
2. are not aware if the annotation is attached to method or class

Probably some new class like PHPUnitAnnotationToAttribute is needed. @TomasVotruba Any feedback is welcome.

Since PHPUnit 10, it is not allowed to name abstract test classes with *Test suffix, for example: abstract class MyBaseTest should be renamed to abstract class MyBaseTestCase, etc. Many existing projects use this naming convention and need refactoring.

Please note that base *Test and target *TestCase suffixes should be customizable (users may choose different suffixes in phpunit.xml using <directory suffix="Test.php">).

For reference: https://github.com/sebastianbergmann/phpunit/issues/4979

There exists a rector rule called AddVoidReturnTypeWhereNoReturnRector. It would be nice if we could add to rector-phpunit to the PHPUNIT_CODE_QUALITY a rule to add this to all classes extending from PHPUnits TestCase class or any other class extending from PHPUnit TestClass. The AddVoidReturnTypeWhereNoReturnRector is currently final.

What do you think the best way is to implement this. Currently we can not extend from AddVoidReturnTypeWhereNoReturnRector to achieve this simple here. Another option could be that we extend the AddVoidReturnTypeWhereNoReturnRector Rule in rector itself to filter by a class / interface and apply the rule only for that kind of classes, not sure if that kind of things make sense as a "General" Rector feature. That all rules could be limited to specific classes extending or implementing from a specific interface?

There is a rule provided in phpunit90 rule set that converts TestListener usages to TestHook usages. This was done because phpunit deprecated TestListener and provided somewhat similar functionality under their TestHook system. This has a couple gotchas where I think maybe removing this from the rule set may be a good idea?

First is the TestListener service provides wildly different functionality to the TestHook system, For example TestListener provides the actual test object whereas the TestHook only provides a string representation. Unfortunately this means that there is a large part of functionality available that a simple method signature change can't ever address.

I think the more important issue though is that TestHook is not a system they recommend to use nor is it actually staying long term, a new event system is under development for phpunit 10. You can see some of the discussion around that here https://github.com/sebastianbergmann/phpunit/issues/3390.

The main reason I suggest this change is that its a potentially breaking change rule since the interface isn't at all the same but its also not even a system that will be in use going forward. I can make a PR to do this but wanted to discuss first what your thoughts were on this?

Just for reference the rule I"m talking about. https://github.com/rectorphp/rector-phpunit/blob/main/config/sets/phpunit90.php#L13

1) tests/system/Email/EmailTest.php:138

    ---------- begin diff ----------
@@ @@

     public function testDestructDoesNotThrowException()
     {
-        $email = $this->getMockBuilder(Email::class)
-            ->disableOriginalConstructor()
-            ->onlyMethods(['sendCommand'])
-            ->getMock();
+        $email = $this->createMock(Email::class);
         $email->method('sendCommand')
             ->willThrowException(new ErrorException('SMTP Error.'));
    ----------- end diff -----------

Applied rules:
 * GetMockBuilderGetMockToCreateMockRector (https://github.com/lmc-eu/steward/pull/187/files#diff-c7e8c65e59b8b4ff8b54325814d4ba55L80)

But when I run the test, I got the error:

$ vendor/bin/phpunit tests/system/Email/EmailTest.php
PHPUnit 9.5.21 #StandWithUkraine

Runtime:       PHP 8.0.20
Configuration: .../CodeIgniter4/phpunit.xml

........E                                                           9 / 9 (100%)E                                                           9 / 9 (100%)

Time: 00:00.358, Memory: 14.00 MB

There was 1 error:

1) CodeIgniter\Email\EmailTest::testDestructDoesNotThrowException
PHPUnit\Framework\MockObject\MethodNameNotConfiguredException: Method name is not configured

ERRORS!
Tests: 9, Assertions: 20, Errors: 1.