Continue of https://github.com/rectorphp/rector-src/pull/2523, given the following code:

trait ServiceLocatorTrait
{
    private array $factories;
    private array $loading = [];
    private array $providedTypes;

    public function get(string $id): mixed
    {
        if (!isset($this->factories[$id])) {
            throw $this->createNotFoundException($id);
        }

        $this->loading[$id] = $id;
        try {
            return $this->factories[$id]($this);
        } finally {
            unset($this->loading[$id]);
        }
    }
}

cause error:

php ../e2eTestRunner.php
 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%[ERROR] Could not process "src/ServiceLocatorTrait.php" file, due to:
         "System error: "Scope not available on "PhpParser\Node\Expr\FuncCall" node with parent node of
         "PhpParser\Node\Stmt\Return_", but is required by a refactorWithScope() method of
         "Rector\DowngradePhp81\Rector\FuncCall\DowngradeArrayIsListRector" rule. Fix scope refresh on changed nodes
         first"
         Run Rector with "--debug" option and post the report here: https://github.com/rectorphp/rector/issues/new". On
         line: 43%    

As discussed in https://github.com/rectorphp/rector-src/pull/115#discussion_r640952613 this PR introduced a way which allows to turn assertSame assertions to ignore PHP_EOL differences.

Since I don't like overriding the very fundatmental behaviour across the entire code-base I figured using a simple Trait could be used in Testclasses as an opt-in to a newline normalized assertSame (later maybe more assertion methods).

Adding a trait is very easy and does not require changes in the inheritance hierarchy of the classes which already exist. existing tests currently extend from PHPUnit\Framework\TestCase, some from Rector\Testing\PHPUnit\AbstractTestCase, and some from Rector\Testing\PHPUnit\AbstractRectorTestCase

closes https://github.com/rectorphp/rector-src/pull/115 https://github.com/rectorphp/rector-src/pull/117 https://github.com/rectorphp/rector-src/pull/99

Based on PR https://github.com/rectorphp/rector-nette/pull/26 and https://github.com/rectorphp/rector-nette/pull/23 I've created this generic way how to test Rectors which create / update also another files.

Usage:

Rector:

Add file with content:

$addedFileWithContent = new AddedFileWithContent($templateFilePath, $content);
$this->removedAndAddedFilesCollector->addAddedFile($addedFileWithContent);

Test fixtures

Fixtures contains more parts separated by ----- like in previous tests:

1) original content
-----
2) expected content (keep empty if no change should happen)
-----
3) path to another changed file (relative to file processed)
-----
4) original content of another file (keep empty if file doesn't exist yet)
-----
5) expected content of another file

3-5 can be multiplied in case there are more files created / updated

Fixture example

<?php

namespace Rector\Nette\Tests\Rector\Class_\LatteVarTypesBasedOnPresenterTemplateParametersRector\Fixture;

use Nette\Application\UI\Presenter;

class SomePresenter extends Presenter
{
    public function renderDefault(): void
    {
        $this->template->title = 'My title';
        $this->template->count = 123;
    }
}

?>
-----
-----
templates/Some/default.latte
-----
<h1>{$title}</h1>
<span class="count">{$count}</span>
-----
{varType string $title}
{varType int $count}

<h1>{$title}</h1>
<span class="count">{$count}</span>

RectorTest

In RectorTest just use

$this->doTestFileInfoWithAdditionalChanges($fileInfo);

instead of

$this->doTestFileInfo($fileInfo);

This rector rule accounts for the proposed RFC to deprecate implicit dynamic properties in PHP 8.2. Per discussion on twitter this rule would add the new #[AllowDynamicProperties] attribute to every class - unless it already has this attribute applied.

I faced with performance issue on my project. When I run rector process on big number of files it takes a lot of time. I profiled this command and found that NodeScopeResolver is decorated on each node processing. As result there is a huge staketrace:

I moved decoration to constructor to do it once and it boost performance a lot.

First draft that adds return type only by first parent/interface found with that method. In future I will try to change it to detect correct intersection type that will satisfy all parents/interfaces.

It is heavily based on AddReturnTypeDeclaration and AddParamBasedOnParentClassMethodRector.

There were some duplicated code with existing rule so I moved it to service but not sure if it is correct place. Structure of services used in rules is quite confusing to me - is there any design guide for that?

I think this roule could also be added to some existing sets but not sure to which. It is quite universal rule that detects issues that would cause Fatal error.

Tests included and after PR #2660 by @samsonasik it works perfectly with interfaces too.

@TomasVotruba Let me know if you want something solved differently.

The following code should be skipped:

final class SkipUsingCoalesceAssignOperator
{
    private SomeService $someService;

    private array $types = [];

    public function __construct(SomeService $someService)
    {
        $this->someService = $someService;
    }

    public function get(string $key)
    {
        return $this->types[$key] ??= $this->someService->resolve();
    }
}

@TomasVotruba it seems the error is only happen on Github action on php 7.2. This rollback the tweak and remove the e2e/define-constant, The e2e/define-constant was exists to verify RichParser which it working ok now, so I think it is safe to be removed.

as can be seen in https://github.com/rectorphp/rector-src/pull/461#issuecomment-885617373 the FileCacheStorage is a major bottleneck while running tests on windows - I guess the same is true on other OSes.

This PR removes unnecessary temp-file handling, because smartFileSystem->dumpFile is already a atomic operation which does magic temp-path file handling behind the scenes. therefore we don't need to do the same things on the rector side.

With consecutive last passed Rector rule correctly handled at PR:

• https://github.com/rectorphp/rector-src/pull/3078

The RectifiedNode value object that previously used to save last previously run Rector rule no longer needed, so it can be removed https://github.com/rectorphp/rector-src/pull/3079/files#diff-5c5469b5b3ba8256b58b9d9bf66fe5873b03597965174036968f5b0d1513a565

~~It require verify phpstan_cache_printer attribute exists to decorate attribute CREATED_BY_RULE when refactor() call returns null.~~ It require connect refactored Node with existing Nodes for previous and next node.

By this, we finally get rid of unnecessary save Node and Rector rule into object as it already in CREATED_BY_RULE :tada: 🎉 🎉

@ondrejmirtes @TomasVotruba I try to set compatible for upcoming PHPStan 1.6.x with bleeding edge feature. I tried to register NodeConnectingVisitor to config/phpstan/static-reflection.neon and it cause error Multiple services definition:

Caused by
_PHPStan_ccec86fc8\Nette\DI\ServiceCreationException: Multiple services of type PhpParser\NodeVisitor\NodeConnectingVisitor found: 04, 0258

so I add to existing Service->set() definition in the config/services.php with define its tag there:

    $services->set(NodeConnectingVisitor::class)
        ->tag('phpstan.parser.richParserNodeVisitor');

ref https://github.com/rectorphp/rector/issues/7088

Given the following config in tests:

use Rector\Config\RectorConfig;
use Rector\Renaming\Rector\Name\RenameClassRector;
use Rector\Tests\Renaming\Rector\Name\RenameClassRector\Source\NewClass;
use Rector\Tests\Renaming\Rector\Name\RenameClassRector\Source\OldClass;

return static function (RectorConfig $rectorConfig): void {
    $rectorConfig
        ->ruleWithConfiguration(RenameClassRector::class, [
            OldClass::class => NewClass::class,
        ]);

    // skip the path after defined
    $rectorConfig->skip([
        RenameClassRector::class => [sys_get_temp_dir() . '/rector/tests_fixture_'],
    ]);
};

It not properly skipped, as there are 2 services:

• RenameClassRector
• ClassRenamingPostRector

The ClassRenamingPostRector apply the change already before it actually skipped because that read the configs:

https://github.com/rectorphp/rector-src/blob/3c168f03d38bb967a5e65e453f82adf120ef4eba/packages/PostRector/Rector/ClassRenamingPostRector.php#L27-L35

This PR try to fix it with add new interface: PostRectorDependencyInterface to define the dependencies of the PostRector when needed.

Fixes https://github.com/rectorphp/rector/issues/7417

I created a new rector rule to update \FilesystemIterator , this rule is supposed to be used when migrating code from php 8.1 to 8.2.

Before PHP 8.2, \FilesystemIterator::SKIP_DOTS was always set and couldn't be removed, this has been fixed in PHP 8.2 and now you have to add this constant manually if you want to maintain the same behavior. This is also explained in documentation https://www.php.net/manual/en/filesystemiterator.construct.php.

You can see an example here https://3v4l.org/HrmZ2.

Note that this rule is important only if you use the second parameter ($params) from FilesystemIterator, the reason is that \FilesystemIterator::SKIP_DOTS is part of $paramsdefault value.

// Nothing to do since \FilesystemIterator::SKIP_DOTS is part of default value.  
new \FilesystemIterator(__DIR__);

// Must add \FilesystemIterator::SKIP_DOTS to maintain same behavior before PHP 8.2
new \FilesystemIterator(__DIR__, \FilesystemIterator::KEY_AS_FILENAME);

I don't have experience creating Rector rules, so I'm open to any comment/suggestion :)

This rector allows users to remove calls to the parent class, for example when a parent method is removed.

class SomeClass extends Other
{
   public function __construct() {
-     parent::__construct();
      /* ... */
   }

   public function other() {
-     parent::some();
      /* ... */
   }
}

• [ ] add tests

Failing Test for SimplifyForeachToCoalescingRector

Based on https://getrector.org/demo/f9798778-4ed8-46c7-8d25-c4aa36358e82

See https://github.com/rectorphp/rector/issues/7593

Previously, NormalizeNamespaceByPSR4ComposerAutoloadRector did not update references to other normalized classes properly. This change fixes that by recording the renames using RenamedClassesDataCollector.

Supersedes https://github.com/rectorphp/rector-src/pull/2482