I check all the rules and upgrade for the laravel 7 to 8 and 8 to 9. I got the rules can we make a set for this laravel upgrade? if you agree then I will do that.

This PR adds a new rule RedirectBackToBackHelperRector to refactor the code around redirect back.

Most of the Laravel developers redirect to the previous location with the code like this:

return redirect()->back()->with('...');

But there is a Laravel helper called back that can be called directly and the redirect() call is not needed. The above line can be rewritten as:

return back()->with('...');

This is my first PR with Rector. Please feel free to share your honest feedback. I am new to AST and related stuff. The Rector book helped me a lot in learning it. Thanks for making this tool.

This PR adds a new rule RemoveDumpDataDeadCodeRector to remove the unnecessary dump data code.

We are Humans And Human makes mistake sometimes we miss removing dump data code like dd or dump function calls.

That's why I added this new rector class to remove code that the developer forgot to remove.

To avoid error like:

                                                                                                                        
 [ERROR] Expected an instance of this class or to this class among his parents                                          
         Rector\Core\Contract\Rector\RectorInterface. Got: string in                                                    
         /Users/samsonasik/www/rector-symfony/config/config.php (which is being imported from                           
         "/Users/samsonasik/www/rector-symfony/rector.php").      

This PR adds a new rector called AddGenericReturnTypeToRelationsRector Which adds generic return type docblocks to Laravel relations in models.

Laravel relations are not generic. But Larastan (PHPStan extension for Laravel) makes them generic to be able to do more accurate analysis on relations. So this rector is not really useful for normal Laravel users, but only for Larastan users. I hope you'll still accept it though.

I tried to implement it in a way that it will add @return doc tag if

• the method has a relation return type (There are other rectors to add missing return types)
• the method doesn't have any comments at all
• the method has comments but no existing @return
• the method only has 1 statement in body and it's return keyword. (this is how almost all Laravel relations are implemented)

From my local testing the only error I'm getting is about cognitive complexity. I don't know how I can reduce it more. Any tips for that would be great!

Definition

Before: https://laravel.com/docs/7.x/database-testing#writing-factories After: https://laravel.com/docs/8.x/database-testing#defining-model-factories

Usage

Before: https://laravel.com/docs/7.x/database-testing#using-factories After: https://laravel.com/docs/8.x/database-testing#creating-models-using-factories

Tasks

• [x] Convert factory definition to class.
• [x] Use the static factory method instead of global factory function.
• [x] Applying states by specify the name of each state to simply call the state methods

Missing jobs:

• Remove classmap block from the autoload section and add the new namespaced class directory mappings in the composer.json file.
• Add the Database\Factories namespace to those classes.

I think the NormalizeNamespaceByPSR4ComposerAutoloadRector can handle these missing jobs well, so these jobs have not been processed for the time being.

This currently doesn't work for named routes. I searched through possible configuration options but couldn't find anything.

Is it possible to do this currently?

If a migration class is abstract it is meant to be used by other migrations and can not be used as a migration on it's own. I'm willing to provide a PR, but I'm not sure how to check if a class is abstract.

Dear Team,

I installed rector and rector-laravel reffering this site. And these commands are I executed;

vagrant@homestead:~/code/laravel-project$ php -v
PHP 8.0.25 (cli) (built: Oct 28 2022 18:02:51) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.25, Copyright (c) Zend Technologies
    with Zend OPcache v8.0.25, Copyright (c), by Zend Technologies

vagrant@homestead:~/code$ cd laravel-project/
vagrant@homestead:~/code/laravel-project$ mkdir --parents tools/rector
vagrant@homestead:~/code/laravel-project$ composer req --working-dir=tools/rector rector/rector
・・・
vagrant@homestead:~/code/laravel-project$ tools/rector/vendor/bin/rector --version
Rector 0.14.8
vagrant@homestead:~/code/laravel-project$ tools/rector/vendor/bin/rector init

Then, edit laravel-project/rector.php :

declare(strict_types=1);

use Rector\CodeQuality\Rector\Class_\InlineConstructorDefaultToPropertyRector;
use Rector\Config\RectorConfig;
use Rector\Set\ValueObject\LevelSetList;

return static function (RectorConfig $rectorConfig): void {
    $rectorConfig->paths([
        __DIR__ . '/Flow',
        __DIR__ . '/app',
        __DIR__ . '/bootstrap',
        __DIR__ . '/config',
        __DIR__ . '/database',
        __DIR__ . '/public',
        __DIR__ . '/resources',
        __DIR__ . '/routes',
        __DIR__ . '/storage',
        __DIR__ . '/tests',
        __DIR__ . '/tools',
    ]);

    // register a single rule
    $rectorConfig->rule(InlineConstructorDefaultToPropertyRector::class);

    // define sets of rules
        $rectorConfig->sets([
            LevelSetList::UP_TO_PHP_80
        ]);
};

Execute rector.php tools/rector/vendor/bin/rector process --dry-run →run successfully

Install rector-laravel composer req --working-dir=tools/rector driftingly/rector-laravel Edit laravel-project/rector.php again

declare(strict_types=1);

use Rector\CodeQuality\Rector\Class_\InlineConstructorDefaultToPropertyRector;
use Rector\Config\RectorConfig;
use Rector\Set\ValueObject\LevelSetList;
use RectorLaravel\Set\LaravelSetList;

return static function (RectorConfig $rectorConfig): void {
    $rectorConfig->paths([
        __DIR__ . '/Flow',
        __DIR__ . '/app',
        __DIR__ . '/bootstrap',
        __DIR__ . '/config',
        __DIR__ . '/database',
        __DIR__ . '/public',
        __DIR__ . '/resources',
        __DIR__ . '/routes',
        __DIR__ . '/storage',
        __DIR__ . '/tests',
        __DIR__ . '/tools',
    ]);

    // register a single rule
    $rectorConfig->rule(InlineConstructorDefaultToPropertyRector::class);

    // define sets of rules
        $rectorConfig->sets([
            UP_TO_LARAVEL_70
        ]);
};

Execute;

vagrant@homestead:~/code/laravel-project$ tools/rector/vendor/bin/rector process --dry-run
[ERROR] Class "Rector\Larave\Set\LaravelSetList" not found

Why this error occured?

Thanks, Kate.

Hi there,

After joining a meet-up on Rector (PHP-WVL) I was very curious about the package. I'm now using it to upgrade a L7 to L8 and noticed that there's probably a rule missing, although I'm not sure as it could be that I'm not familiar enough with rector.

The high impact change is that Seeder classes need namespacing from L8 forward. Is it possible that this rules needs to be added still, if so how can I help?

Replaces usage of optional() with the nullsafe operator.

Ref: rfc, https://github.com/laravel/laravel/pull/5670, https://github.com/laravel/framework/pull/38868

-optional($user)->getKey();
-optional($user)->id;
+$user?->getKey();
+$user?->id;

Only supported if the existing PHPDoc return type is the same as the native return type. This way we ensure that we don't change types.

Not updating of another type was already covered with a test. I added a test for the case when we can update the PHPDoc with only the generics.

Hey,

Using:

• Rector 0.15.0
• Rector-Laravel 0.14.1

I use the set

• LaravelLevelSetList::UP_TO_LARAVEL_90,

When running rector, I get the following error:

• [ERROR] Use specific rules to infer params instead. This rule was split info many small ones.

Seems to refer to the following file in rector-laravel:

• https://github.com/driftingly/rector-laravel/blob/main/config/sets/laravel60.php#L26
• This one might also break: https://github.com/driftingly/rector-laravel/blob/main/config/sets/laravel70.php#L21-L47

I did some small digging, looks like 0.15.0 of rector now throws an error.

• https://github.com/rectorphp/rector/blob/0.15.0/rules/TypeDeclaration/Rector/FunctionLike/ParamTypeDeclarationRector.php#L65

Current solution is to use older version of rector, but thought I'd report this.

Helloo 😃

Not sure if this Rule is essential, or even doable, but this is my first attempt at moving old accessors and mutators to the new syntax introduced in Laravel 9. I've got it working fine with Accessors, tested them in real-life projects, and got good results. Mutators are a bit more challenging to migrate, and there's some added complexity since we need to put them into the same method now. The test case 'migrate-mutators.php.inc' is currently failing in a weird way, and the code still needs a lot of refactoring.

Any thoughts, advice, or help is greatly appreciated. Thank you.

Just wondering why this dependency requires a greater version of PHP (>=8.1) than Rector (^7.2|^8.0) does? It makes it more problematic to use on older versions of PHP. Thanks