Reproducer the MakeEntitySetterNullabilityInSyncWithPropertyRector currently is implemented uncorrectly. By default a ManyToOne is nullable="true" see https://github.com/doctrine/orm/blob/5283e1441cc020d526d4842c6bfa21c1a500886d/lib/Doctrine/ORM/Mapping/JoinColumn.php#L28 and so currently this rules accidently removes ? from a setter where it should not do it.

PS: This error does not happening when using Attributes but maybe not a equal rule for attributes does exist?

EDIT @TomasVotruba : Fixes https://github.com/rectorphp/rector/issues/7353, closes https://github.com/rectorphp/rector-doctrine/pull/123

Fixes https://github.com/rectorphp/rector-doctrine/issues/4 .

~~This is for starter. It may need more examples for usage, eg: join table, etc.~~ implemented 🎉

Given the following code:

/**
 * @ORM\Entity()
 */
class PointedToConstantValue
{
    public const ONE = 1;

    /**
     * @ORM\Column(type="integer")
     */
    private $stav = self::ONE;

    /**
     * @ORM\Column(type="integer")
     */
    private $stav2 = SOME_CONSTANT_VALUE;
}

It currently make crash:

There was 1 error:

1) Rector\Doctrine\Tests\Rector\Property\CorrectDefaultTypesOnEntityPropertyRector\CorrectDefaultTypesOnEntityPropertyRectorTest::test with data set #0 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
Rector\Core\Exception\NotImplementedYetException: 

This PR fix it. Fixes https://github.com/rectorphp/rector/issues/7227

I'm trying out the new ORM 2.9 upgrade set to convert Annotations to Attributes and I found a problem.

Given I have the following entity:

/** 
 * @ORM\Table(
 *     name="table",
 *     options={"charset": "utf8mb4", "collate": "utf8mb4_bin"},
 *     uniqueConstraints={
 *         @ORM\UniqueConstraint(name="unique_review", columns={"type", "relationship_id", "user_id"})
 *     },
 *     indexes={
 *         @ORM\Index(name="index_name", columns={"user_id", "type", "relationship_id", "created_at", "is_deleted"}),
 *     },
 * )
 */
class SomeEntity

Rector changes this to:

#[Table(name: 'table', options: ['charset' => 'utf8mb4', 'collate' => 'utf8mb4_bin'], uniqueConstraints: ['(name="unique_review", columns={"type", "relationship_id", "user_id"})'], indexes: ['(name="index_name", columns={"user_id", "type", "relationship_id", "created_at", "is_deleted"})'], ')')]
class SomeEntity

As you can see, it completely trips on the nested annotations. And just dumps them in as strings.

Turns out that nested attributes are not supported.

The solution would be, to move the nested annotations to attributes on a new line, like this:

#[Table(name: 'table', options: ['charset' => 'utf8mb4', 'collate' => 'utf8mb4_bin'])]
#[UniqueConstraint(name: 'unique_review', columns=['type', 'relationship_id', 'user_id']]
#[Index(name: 'index_name', columns=['user_id', 'type', 'relationship_id', 'created_at', 'is_deleted'])]
class SomeEntity

To mitigate this bug, I tried to first manually convert the nested Annotations to Class Annotations. But Doctrine doesn't allow that:

/** 
 * @ORM\Table(name="table", options={"charset": "utf8mb4", "collate": "utf8mb4_bin"})
 * @ORM\UniqueConstraint(name="unique_review", columns={"type", "relationship_id", "user_id"})
 * @ORM\Index(name="index_name", columns={"user_id", "type", "relationship_id", "created_at", "is_deleted"})
 */
class SomeEntity

[Semantical Error] Annotation @ORM\UniqueConstraint is not allowed to be declared on class SomeEntity. 
You may only use this annotation on these code elements: ANNOTATION.

That also means that these examples are impossible/invalid: https://github.com/rectorphp/rector-doctrine/blob/main/tests/Set/DoctrineORM29Set/Fixture/unique_constraint.php.inc https://github.com/rectorphp/rector-doctrine/blob/main/tests/Set/DoctrineORM29Set/Fixture/index.php.inc

Looks like there's a bug on the ManyToOne relation with the JoinColumns annotation which ends out with the following error.

[Syntax Error] Expected PlainValue, got '(' at position 166 in property App\Entity\Product::$inventoryPosition.

The documentation says the @JoinColumns needs an array of JoinColumn:

An array of @JoinColumn annotations for a @ManyToOne or @OneToOne relation with an entity that has multiple identifiers.

Take a look the code below removing the @ORM\JoinColumn annotation.

     /**
      * @var InventoryPosition
      *
      * @ORM\ManyToOne(targetEntity="App\Entity\InventoryPosition", inversedBy="products", cascade={"persist"})
-     * @ORM\JoinColumns({
-     *   @ORM\JoinColumn(name="inventory_position_id", referencedColumnName="id")
-     * })
+     * @ORM\JoinColumns({(name="inventory_position_id")})
      */
-    private $inventoryPosition;
+    private ?\App\Entity\InventoryPosition $inventoryPosition = null;

I'm using the DoctrineSetList::DOCTRINE_CODE_QUALITY setlist

See https://github.com/rectorphp/rector-doctrine/issues/16

@UniqueConstraint and @Index cannot be used on a class but must be used inside an annotation.

For attributes, that's the opposite, they must be declared on the class instead.

See docs https://www.doctrine-project.org/projects/doctrine-orm/en/2.9/reference/attributes-reference.html#attrref_joincolumn

Fixes https://github.com/rectorphp/rector-doctrine/pull/76

• Dont Touch Unrelated Code by TypedPropertyFromToManyRelationTypeRector unit test
• Fix empty typed property in TypedPropertyFromToManyRelationTypeRector

In the past doctrine recommended using class strings with omitted leading backslash. Hence, we have to check again for that class with added backslash. See https://www.doctrine-project.org/projects/doctrine-orm/en/latest/reference/annotations-reference.html#entity for an example.

I think when configured a while back ago, class-strings without leading backslash is very common.

This rule is removing JoinColumn annotation

-     * @ORM\JoinTable(name="vouchers_subscriptions",
-     *     joinColumns={@ORM\JoinColumn(name="voucher_id", referencedColumnName="id")},
-     *     inverseJoinColumns={@ORM\JoinColumn(name="subscription_id", referencedColumnName="id")}
-     *     )
+     * @ORM\JoinTable(name="vouchers_subscriptions", joinColumns={(name="voucher_id")}, inverseJoinColumns={(name="subscription_id", referencedColumnName="id")})

But in the doc it needs of JoinColumn

https://www.doctrine-project.org/projects/doctrine-orm/en/2.9/reference/association-mapping.html#many-to-many-unidirectional

PHP 8.1 introduced a way to handle nested attributes, something missing from the 8.0 implementation and needed for some Doctrine annotations.

Doctrine has the annotation, @ORM\JoinColumns, used like so:

@ORM\JoinColumns({
    @ORM\JoinColumn(name="thing_id", referencedColumnName="id", nullable=false)
})

Currently, the DoctrineAnnotationClassToAttributeRector skips over this annotation, presumably due to PHP 8.0's lack of nested attribute support. Is there an update on supporting this or a plan in place?

When running rector with the doctrine exension:

    $containerConfigurator->import(DoctrineSetList::DOCTRINE_CODE_QUALITY);

1) src/Cashback/Domain/Model/CashbackClaim.php:57

    ---------- begin diff ----------
@@ @@
     /**
      * @ORM\Column(type="datetime", nullable=true)
      */
-    private ?DateTimeInterface $orderDetailsOrderDate = null;
+    private ?DateTimeInterface $orderDetailsOrderDate;

     /**
      * @ORM\Column(length="256")
@@ @@

@@ @@
     {
         $uuid = Uuid::uuid4();
         $this->entityId = $uuid->toString();
+        $this->orderDetailsOrderDate = new \DateTime(null);
     }

The result is unexpected as it did add:

$this->orderDetailsOrderDate = new \DateTime(null);

Which should just stay as:

private ?DateTimeInterface $orderDetailsOrderDate = null;

Lets add a rule to replace event strings with the corresponding class constants (Just like the Criteria constants)

<?php

declare(strict_types=1);

namespace App\Subscriber\Doctrine;

use Doctrine\Common\EventSubscriber;
use Doctrine\ORM\Event\LifecycleEventArgs;
use Doctrine\ORM\Event\PreUpdateEventArgs;
+use Doctrine\ORM\Events;

class DoctrineSubscriber implements EventSubscriber
{

    public function getSubscribedEvents(): array
    {
        return [   
-            'prePersist',
-            'preUpdate',
+            Events::prePersist,
+            Events::preUpdate,
        ];
    }

    public function prePersist(LifecycleEventArgs $args) {
        //...
    }
    public function preUpdate(PreUpdateEventArgs $eventArgs) {
        //...
    }
}

I'll see if I can implement this in the future

Similar to https://github.com/rectorphp/rector-phpunit/pull/114, https://github.com/rectorphp/rector-phpunit/pull/114 / https://github.com/rectorphp/rector-phpunit/pull/115

I would like to set the PHPDocInfo @var based on doctrine metadata. Via phpstan-doctrine phpstan already knows the correct type from the Doctrine Metadata () which should be set to the property and getter of that property.

I'm not yet sure how I can access the expected PHPStan type. Any hints how to achieve this would be welcome.