Considering #17 I think it would be interesting to allow the Image class to offer any color-related functionality. For now we just have the implicit extract method which prevents consistency, it certainly means there will be some BC.

Any idea of how to do that properly?

Hello and congratulations for this nice piece of code !

I am trying to work with some .png files and this one particularly fails and returns me #000000 as the most vibrant color.

I guess it fetches it from the alpha channel.

Could you have a more in-depth look please ? Here is the image

Hi,

Got an infinite loop on ligne 129 of Image.php for some images. Image size is 50*50.

As you can see on my PR, this https://github.com/thephpleague/color-extractor/pull/25 fix the thing.

Any idea ?

Thx

I have found an issue when I try and extract colours from corrupted images, the extract method seems to get stuck in a loop and eventually times out.

I have attached a faulty image, hopefully it will survive intact.

Issue: In laravel 5 when the ServiceProvider is loaded it throws BadMethodCallException for use of undefined method [package].

Fix: Commenting out the boot() section of the ServiceProvider works fine.

Fix #37

Add creation method for Imagick and call it from fromFilename if the extension is loaded because it seems faster.

Since ext-gd is no longer mandatory I moved it with ext-imagick in composer.json suggest section.

I'm thinking this PR could introduce the 1.0.0 release. What do you think @GrahamCampbell @philsturgeon @toin0u?

I had issues trying to use this library initially, because I didn't realize it was using GD manipulations under the hood, and by default my (and possibly most) php installations don't include GD support out of the box.

I found the documentation and comments at http://php.net/manual/en/image.installation.php helpful in order to install php5-gd on my debian-based distro in order to use this library.

Without GD support, errors occur such as:

Call to undefined function League\ColorExtractor\imagecreatefrompng() in [...]/vendor/league/color-extractor/src/League/ColorExtractor/Client.php on line 14

In order to help others, I submit this README.md update comment referencing the php.net documentation.

Hey guys,

I am doing some tutorials on composer and one of the lessons uses the color-extractor package. All seems to install ok. But I keep getting an error when I try to stream in an image.

This code block seems to cause an issue (line 54-55 - vendor/league/color-extractor/src/League/ColorExtractor/Palette.php): $image = imagecreatefromstring(file_get_contents($filename)); $palette = self::fromGD($image, $backgroundColor);

As does this one (line 71 same file): if (!is_resource($image) || get_resource_type($image) != 'gd')

The condition gets met and we see the following error.

Fatal error: Uncaught InvalidArgumentException: Image must be a gd resource in /Users/ufmurphy/Sites/vendor/league/color-extractor/src/League/ColorExtractor/Palette.php:72 Stack trace: #0 /Users/ufmurphy/Sites/vendor/league/color-extractor/src/League/ColorExtractor/Palette.php(55): League\ColorExtractor\Palette::fromGD(Object(GdImage), NULL) #1 /Users/ufmurphy/Sites/index.php(19): League\ColorExtractor\Palette::fromFilename('images/bricks.j...') #2 {main} thrown in /Users/ufmurphy/Sites/vendor/league/color-extractor/src/League/ColorExtractor/Palette.php on line 72

Doing some sleuthing, it looks like a change in how GD images are handled in PHP8. https://php.watch/versions/8.0/gdimage

Is there a more recent version than 0.3.2?

Thanks, Jim

php memory limit is 1024 MB, the below exception occurs while processing a 12 MB jpeg. I can of course increase the memory limit, but wondered if this level of memory usage is expected?

PHP Fatal error:  Allowed memory size of 1073741824 bytes exhausted (tried to allocate 20480 bytes) in /var/www/auto/vendor/league/color-extractor/src/League/ColorExtractor/ColorExtractor.php on line 226
PHP Fatal error:  Allowed memory size of 1073741824 bytes exhausted (tried to allocate 20480 bytes) in /var/www/auto/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php on line 122

Here's my color extraction code:

$primaryPalette = Palette::fromFilename($sFullPath);
$extractor = new ColorExtractor($primaryPalette);
$primaryPalette = null;

$aExtractedColours = $extractor->extract(5);
$extractor = null;

Hi, I'm getting an "Image must be a gd resource"

PHP has moved to make GD an object instead of a resource, because GD is now an object, it will never be a resource and this causes an error

I love the interface of this package. However, the palette that it generates contains the color value of every pixel it seems, even if the colors are nearly indistinguishable. I would love to be able to find the 5 most used colors that are actually in different color spectrums instead of 5 colors that are practically the same color.

I have been using this package to find a good color palette https://github.com/ksubileau/color-thief-php but its interface is not quite as nice as this one.

Hi, I just started to use color-extractor in one or our customer's project.

We wrote a unit test to check our code and it appears the Palette.getMostUsedColors() function is not returning de same results depending on the OS and/or PHP version in use (perhaps this could also be dependent on the GD version which is installed on the machine).

For exemple on a Unix machine we get this array (the limit parameter is equal to 12 and the index of this array has been converted to hexadecimal).

[
    '#000000' => 93285,
    '#010000' => 7871,
    '#020001' => 6022,
    '#010101' => 3413,
    '#040000' => 3321,
    '#000002' => 2070,
    '#050100' => 2036,
    '#030000' => 1945,
    '#000100' => 1789,
    '#060000' => 1668,
    '#020100' => 1604,
    '#634D40' => 1263,
]

On a Windows machine and with the same image we get the following values.

[
    '#000000' => 93135,
    '#010000' => 7710,
    '#020001' => 6001,
    '#010101' => 3377,
    '#040000' => 3227,
    '#000002' => 2056,
    '#050100' => 2052,
    '#000100' => 1842,
    '#030000' => 1747,
    '#020100' => 1580,
    '#060000' => 1557,
    '#634D40' => 1264,
]

We only encounter this problem with one testing JPEG file (I can provide you the file if needed).

We also have similar unit test with GIF and PNG files, with those formats we do not encounter any problem.

So do you know what could cause differences in our case ?

• Could it be caused by the GD version installed on the machine ? Also perhaps their are difference between the Windows and Unix GD libraries ?
• Could it be caused by the PHP version in use ?
• Or are they potential rounded values in the source code which could be different between platforms ?

If it can help here are much more details about each testing envirronment

• Windows 10 Pro 64bits, PHP 7.0.8
• Centos 7 64bits, PHP 7.0.8

If the problem is linked to GD perhaps doing the same test with https://github.com/thephpleague/color-extractor/issues/37 could be interesting.

In any case I the problem cannot be solved IMO it should be described and explained in the README.

Thanks

Hello

Here is a proposition for Imagick integration in Palette.

    /**
     * @param \Imagick $image
     *
     * @return Palette
     *
     * @throws \InvalidArgumentException
     */
    public static function fromImagick(\Imagick $image)
    {
        if (!is_object($image) || $image instanceof \Imagick === FALSE) {
            throw new \InvalidArgumentException('Image must be an Imagick instance');
        }

        $palette = new self();
        $palette->colors = [];

        $iterator = $image->getPixelIterator();

        foreach($iterator as $row) {

            foreach($row as $pixel) {

                $colorInfo = $pixel->getColor();
                $color = ($colorInfo['r'] * 65536) + ($colorInfo['g'] * 256) + ($colorInfo['b']);

                isset($palette->colors[$color]) ?
                    $palette->colors[$color] += 1 :
                    $palette->colors[$color] = 1;

            }

        }

        arsort($palette->colors);

        return $palette;
    }