This pull request enables applying the canvas filter on (layers of) an animated GIF.

To achieve this, the following has been addressed:

• Image delays are accessible and can be modified
  public function ImageInterface#setDelay($delay) public function ImageInterface#getDelay()
  • The canvas filter is now able to copy the delay into the new ImageInterface.
• As filters return a modified ImageInterface,
  • layers should be replacable,
    public function LayersInterface#replace($offset, ImageInterface $image)
  • which is only possible if the image's resource is available (for internal use only).
    public function ImageInterface#getResource()
  • Also, GD now saves the first (and only) layer, as it may have been replaced.
• When working with GD layers, the GD resource is destroyed when a layer is garbage-collected (ImageInterface#__destruct()). To counteract this, I've wrapped the GD resource in a the Imagine\Gd\Gd class so it can be reused.

When trying to create a thumbnail of a large image (3000x3000) the memory usage of my script exceeds 128MB.

The issue seems to be because a copy of the original image is created before resizing occurs.

I've managed to work around this by copying the thumbnail sizing logic into my own code and calling "resize" rather than "thumbnail" as it doesn't create a copy. I do not need the original image so this works for me.

It would be useful to be able to resize an image based on thumbnail modes. Is this something that you would be interested in including? I didn't want to do the work and create a pull request before checking.

Thanks

• Animated GIFs may contain inconsistently sized frames. Coalescing this frames makes sure all frames are of the same size.
• Previously only one frame of an animated GIF was written. To allow for animated GIFs, let Imagick write multiple, adjoined images.

Tests included.

NB - Contains commit from #176.

Hi,

We are using this library for our project and we came across an issue that blocks us from extending the functionality and in particular the fact that quite a few classes defined as final.

What is the actual reason for these classes to be final?

There is a huge amount of good PRs and an even bigger amount of issues that don't get any attention.

Why? Is the project dead?

I really consider switching to https://github.com/Intervention/image because of the lack of support for this lib. :(

Hi!

Issue description

Our CI tests started failing yesterday with errors similar to Failed to load resource: the server responded with a status of 502 (Bad Gateway). The logs look like this:

web_1       | 2022-03-16T10:20:53.320977547Z 172.19.0.4 - - [16/Mar/2022:10:20:53 +0000] "POST /api/ezp/v2/user/sessions HTTP/1.1" 201 584 "-" "Symfony HttpClient/Curl" "-"
web_1       | 2022-03-16T10:20:53.504025837Z 172.19.0.4 - - [16/Mar/2022:10:20:53 +0000] "GET /api/ezp/v2/content/objects/52/versions/1 HTTP/1.1" 200 5112 "-" "Symfony HttpClient/Curl" "-"
web_1       | 2022-03-16T10:20:53.683592022Z 2022/03/16 10:20:53 [error] 9#9: *4 recv() failed (104: Connection reset by peer) while reading response header from upstream, client: 172.19.0.4, server: localhost, request: "GET /api/ezp/v2/content/binary/images/52-183-1/variations/medium HTTP/1.1", upstream: "fastcgi://172.19.0.4:9000", host: "web"
app_1       | 2022-03-16T10:20:53.688494227Z [16-Mar-2022 10:20:53] WARNING: [pool www] child 208 exited on signal 11 (SIGSEGV - core dumped) after 79.766833 seconds from start

It started happening right after 1.3.0/1.3.1 has been released and it disappears when a Composer conflict with imagine/imagine:^1.3.0 is added (see: https://github.com/ezsystems/ezplatform-rest/pull/92 for a failing and passing CI build).

What version of Imagine are you using?

1.3.1

What's the PHP version you are using?

7.3

What's the imaging library you are using [gd/imagick/gmagick/any]?

gd

What's the imaging library configuration

root@1021939f0ff2:/var/www# php --ri gd

gd

GD Support => enabled
GD Version => bundled (2.1.0 compatible)
FreeType Support => enabled
FreeType Linkage => with freetype
FreeType Version => 2.6.3
GIF Read Support => enabled
GIF Create Support => enabled
JPEG Support => enabled
libJPEG Version => 6b
PNG Support => enabled
libPNG Version => 1.6.28
WBMP Support => enabled
XPM Support => enabled
libXpm Version => 30411
XBM Support => enabled
JIS-mapped Japanese Font Support => enabled

Directive => Local Value => Master Value
gd.jpeg_ignore_warning => 1 => 1

Minimal PHP code to reproduce the error:

I don't have a reproducer yet, I am still gathering more data about this issue - I was not able to reproduce it locally, even when using the same PHP Docker image that we use on CI. I will try to extract the core dump and analyse what's happening there. I wish I had more data, but given that 1.3.x is a fresh release I think it's important to let you know that the behaviour has changed between the 1.2.x and 1.3.x releases.

I will update this issue as soon as I have more information.

These lines are needed to support webp with the imagick adapter.

I don't intend to write webp support for the other adapters, but this may be a start for someone else.

Also requested in #271

Issue description

No Exif data returned when using (new ExifMetadataReader())->readFile($path) while exif_read_data($path, null, true, false) works fine.

What version of Imagine are you using?

1.2.2

What's the PHP version you are using?

7.3.11

What's the imaging library you are using [gd/imagick/gmagick/any]?

any

What's the imaging library configuration

--

Minimal PHP code to reproduce the error:

(new ExifMetadataReader())->readFile($path)

When an image is uploaded directly from an iPad or iPhone without going through a computer first, the image is not properly rotated. Usually the computer will apply transformations automatically upon import, but with a direct upload the image library will need to detect these tags and rotate the image automatically.

(sample code - http://php.net/manual/en/function.exif-read-data.php#110894)

Any thoughts?

Hello Bulat,

this PR proposes a support for layers. It is quite useful when you want to extract all images of an animated gif, or all layers of a photoshop file.

I've choosen to implement the \Countable interface to count the number of frame/layer an image contains.

GD does not support layers.

Please give me feedback about the public API (Iv'e choosen layer over frame, what do you think about it ?). As soon as you validate it, I will add documentation so the PR will be mergeable :)

Romain

This pull request implements a canvas filter that enables you to define a new canvas size, and place the current image somewhere in the new image.

Example usage:

$imagine = new Imagine\Imagick\Imagine();
$image = $imagine->open('/path/to/image.png');

// Apply canvas
$image->canvas(
    // New canvas size
    new Imagine\Image\Box(200, 200),

    // Where to place the existing image (defaults to 0, 0)
    new Imagine\Image\Point(20, 20),

    // Optional background image for the regions that go outside of the existing image
    new Imagine\Image\Color('000')
);

Issue description

The Imagine Point class constrains point values to be positive (vis

   /**
     * Constructs a point of coordinates.
     *
     * @param int $x
     * @param int $y
     *
     * @throws \Imagine\Exception\InvalidArgumentException
     */
    public function __construct($x, $y)
    {
        if ($x < 0 || $y < 0) {
            throw new InvalidArgumentException(sprintf('A coordinate cannot be positioned outside of a bounding box (x: %s, y: %s given)', $x, $y));
        }

        $this->x = $x;
        $this->y = $y;
    }

Why is this? Is there a work-around for positioning drawn or pasted image objects so that they are partially placed outside of an image area?

If you disable the constraint, it appears that Imagine continues to work OK with negative values.

What version of Imagine are you using?

1.3.2

What's the PHP version you are using?

8.0.25

What's the imaging library you are using [gd/imagick/gmagick/any]?

GD2

What's the imaging library configuration

GD Version: "2.3.3" FreeType Support: true FreeType Linkage: "with freetype" GIF Read Support: true GIF Create Support: true JPEG Support: true PNG Support: true WBMP Support: true XPM Support: true XBM Support: true WebP Support: true BMP Support: true TGA Read Support: true JIS-mapped Japanese Font Support: false

Minimal PHP code to reproduce the error:

n/a

Issue description

This method calls this code three times (line 154, 165, 172)

        if (function_exists('imageantialias')) {
            imageantialias($this->resource, true);
        }

At least two of these calls appear to be unnecessary.

Before doing a PR to remove I thought it prudent to check whether there is a good reason for the apparently redundant calls...

What version of Imagine are you using?

1.3.2

What's the PHP version you are using?

8.0.25

What's the imaging library you are using [gd/imagick/gmagick/any]?

GD2

What's the imaging library configuration

GD Version: "2.3.3" FreeType Support: true FreeType Linkage: "with freetype" GIF Read Support: true GIF Create Support: true JPEG Support: true PNG Support: true WBMP Support: true XPM Support: true XBM Support: true WebP Support: true BMP Support: true TGA Read Support: true JIS-mapped Japanese Font Support: false

Minimal PHP code to reproduce the error:

n/a

Issue description

The getGdResource() method extracts the GDResource component from a GD type Image object.

However there does not appear to be any clean way to generate or update the Image object from a GDResource type entity.

This is unfortunate.

If (for example) if you need to apply a process to an image for which no Image methods exist (e.g. apply an arbitrary laplacian type filter) then the only option (in GD universe) is to export the image resource, apply the process using GD primitives and then ... you are stuck. The Imagine read() method apparently only reads GD resources from disk, so it would appear to proceed with processing you need to write the partially processed image to disk and read it back again (or if that doesn't work, write out partially processed image in an image file format and create a new Image instance by reading that back again).

A better solution would be for there to be a way to simply load a GD resource back into the Image object. ...

What version of Imagine are you using?

1.3.2

What's the PHP version you are using?

8.0.25

What's the imaging library you are using [gd/imagick/gmagick/any]?

GD2

What's the imaging library configuration

GD Version: "2.3.3" FreeType Support: true FreeType Linkage: "with freetype" GIF Read Support: true GIF Create Support: true JPEG Support: true PNG Support: true WBMP Support: true XPM Support: true XBM Support: true WebP Support: true BMP Support: true TGA Read Support: true JIS-mapped Japanese Font Support: false

Minimal PHP code to reproduce the error:

$imagine_object = new Imagine\Gd\Imagine(); // Creates new Imagine GD object
$image_object = $imagine_object->load($image); // Creates a new Image GD object
$gd_resource = $image_object->getGdResource();
... do stuff ...
$modified_image_object = $imagine_object->read($gd_resource); // Fails... :(

Issue description

Unable to open remote jpg image, while the remote image does exists. No problem with png images, just jpg images.

What version of Imagine are you using?

1.3.2

What's the PHP version you are using?

7.4.29

What's the imaging library you are using [gd/imagick/gmagick/any]?

GD

What's the imaging library configuration

GD Support => enabled GD headers Version => 2.3.3 GD library Version => 2.3.3 FreeType Support => enabled FreeType Linkage => with freetype GIF Read Support => enabled GIF Create Support => enabled JPEG Support => enabled PNG Support => enabled WBMP Support => enabled XPM Support => enabled XBM Support => enabled WebP Support => enabled BMP Support => enabled TGA Read Support => enabled

Directive => Local Value => Master Value gd.jpeg_ignore_warning => 1 => 1

Minimal PHP code to reproduce the error:

$imagine = new \Imagine\Gd\Imagine();
$image = 'https://illuxi-v3.s3.amazonaws.com/virtual_event/boot/ASSTSAS-759-FR.jpg';
$image = $imagine->open($image);

Issue description

I'm getting the following error:

Uncaught Imagine\Exception\RuntimeException: error:1409442E:SSL routines:ssl3_read_bytes:tlsv1 alert protocol version in /var/www/homesbymarco.com/vendor/imagine/imagine/src/File/Loader.php:237

I get the error on my server running Ubuntu 18.04 with curl 7.58, but I do not get the error on my other server running Ubuntu 20.04 with curl 7.68.

What version of Imagine are you using?

1.3.2

What's the PHP version you are using?

PHP 7.2.34-28+ubuntu18.04.1+deb.sury.org+1 (cli) (built: Nov 19 2021 06:36:36) ( NTS ) Copyright (c) 1997-2018 The PHP Group Zend Engine v3.2.0, Copyright (c) 1998-2018 Zend Technologies with Zend OPcache v7.2.34-28+ubuntu18.04.1+deb.sury.org+1, Copyright (c) 1999-2018, by Zend Technologies

What's the imaging library you are using [gd/imagick/gmagick/any]?

gd

What's the imaging library configuration

php --ri gd

gd

GD Support => enabled GD headers Version => 2.3.0 GD library Version => 2.3.0 FreeType Support => enabled FreeType Linkage => with freetype FreeType Version => 2.8.1 GIF Read Support => enabled GIF Create Support => enabled JPEG Support => enabled libJPEG Version => 8 PNG Support => enabled libPNG Version => 1.6.34 WBMP Support => enabled XPM Support => enabled libXpm Version => 30411 XBM Support => enabled WebP Support => enabled

Directive => Local Value => Master Value gd.jpeg_ignore_warning => 1 => 1

Minimal PHP code to reproduce the error:

$url = 'https://cdn.onebauer.media/one/empire-images/features/5665a94d329ff0ca7c62aca1/STA039DV.jpg?format=jpg&quality=80&width=850&ratio=1-1&resize=aspectfit';

$imagine = new Imagine\Gd\Imagine();
$photo = $imagine->open(new Imagine\File\Loader($url));