Hello. Based on this statement:

imagejpeg( $image, $newlocation, $this->opts['quality'] );

an image is always converted as a JPG image. Why it can't be saved as its previous format?

Hi,

Yesterday I used ImageCache class to cache some images on my website. I noticed, that when $_SERVER['DOCUMENT_ROOT'] = '/', then solution presented currently in ImageCache.php is going to replace all occurences of slash, which results in incorrect source string.

For example, if resulting string should be: /path/to/img , then after using makesource function, we've got: pathtoimg.

I've done some workaround for it, which works for me:

private function makesource( $dir ) {
        $cururl = strtolower( reset( explode( '/', $_SERVER['SERVER_PROTOCOL'] ) ) ) . '://' . $_SERVER['SERVER_NAME'];
        $base = $_SERVER['DOCUMENT_ROOT'];

        if($base == '/')
        {
            $localpath = substr($dir, 1);
        }else{
            $localpath = str_replace( $base, '', $dir );
        }

        return $cururl . $localpath;
}

Best regards, Mike

Hi,

I noticed that some times the size of the image actually increases. For ex an image 170 KB increase to 204 KB.

This happens rarely but it would be good if there was an inbuilt way to check if any image compression took place.

The documentation of PHP does not allow strtotime() empty.

Error: strtotime() expects at least 1 parameter, 0 given

File: /src/ImageCache/ImageCache.php Line: 197.

Fix: Add 'now' in strtotime(), or switch to time()

The docs located at:

http://nielse63.github.io/php-image-cache/

Do not match the functionality at all. For example:

$image = new ImageCache(
    $filebase = '', $dir = null, $create_dir = true, $opts = array()
);
/**
 * @param $filebase (string) - The base URL that will be included in the final output for the image source; primarily used if you want the image source to be an absolute URL; defaults to relative.
 * @param $dir (string/null) - The base directory that houses the image being compressed; defaults to the location of ImageCache.php.
 * @param $create_dir (bool) - Whether or not to create a new directory for the compressed images; defaults to "true"
 * @param $opts (array) - An array of available options that the user can include to the overwrite default settings.  Mostly just for forward-compatibility at the moment.
 */

In the code the constructor actually accepts 3 parameters, 2 of which will be deprecated soon!

Very confusing.

Error behaviour is also completely undocumented.

I think your script is not user friendly... just to configure your script we need more time... and there are soo many functions missing.... i really wanted to use your script.. but i keep getting errror message ...and these error error message can be answered only by you.. " Call to undefined function ImageCache\curl_init() in C:\wamp\www\icon\src\ImageCache\ImageCache.php " dont know why have you desghned this?? there is no documentation also.. serioously i wasted my time.. even stack experts could not find solutions for your script bugs...if you really want to make this as popular script.. please write a good documentation, each and every line on how to work on your script... forget about script updation, first let the basic things work...Sorry but that's what i found....

Because when the image has a longer height than width, the image is created with a blank space until the height ends.

Original Image

Image after cache();

private function is404($source) { $ch = curl_init(); curl_setopt($ch, CURLOPT_URL, $main_url); curl_setopt($ch, CURLOPT_NOBODY, true); curl_exec($ch); if (curl_getinfo($ch, CURLINFO_HTTP_CODE) == '404') return $this->show404(); return false; }

A PHP Error was encountered

Severity: Notice

Message: Undefined variable: main_url

Filename: ImageCache/ImageCache.php

Line Number: 232

Hello, I download the latest version, then transfer to my server but when I run the demo I have two PHP error ?

Warning: Unexpected character in input: '' (ASCII = 92) state = 1 in / fximg/new/demo/index.php on line 16

Parse error: syntax error, unexpected T_STRING in / fximg/new/demo/index.php on line 16

What it comes from my version of PHP ? ... or something else!

help me please ;)

• Fixed indentation and other coding style details to match the PSR-2 standard (see https://github.com/php-fig/fig-standards/blob/master/accepted/fr/PSR-2-coding-style-guide.md)
• Added a namespace (also required by PSR-2) and modified documentation, composer.json and test script accordingly
• Changed the required version of PHP to 5.3.0 and fixed a couple minor issues (lack of a datetime zone definition in the test script, function return value passed directly as reference...) to avoid notices and warnings appearing on PHP 5.3 and above
• Suggestion : autodetect the current path in the test script ? I had to change it when testing my changes, as I guess http://test is some local domain configured on your own working station

I added a way to change the desired quality of the cached image because it could be useful caching images on a lower quality. And also a way to generate new cached versions from the same image. It is usefull to use the same filename for many cropped versions of a image (and to reset browser cache, if necessary).

ps.: Sorry about the changes on the indentation. I edited it on netbeans and I have a problem with the Ctrl + Shift + F (I use it all the time...)

Hey,

I am experiencing an issue. I can successfully shrink and cache the image but I am getting a blank page.

How can I fix this?

Update: Apparently this is caused by an error made by ImageCache.php: "Final image URL is broken". I used this guide to solve it

../images must writable! is being displayed on the php page

This is the line of code which I believe is giving the problem

$cached_src_one = $imagecache->cache( '../images/background.jpg' );

I am running the php page from where the images folder is found.

I am trying your class with JPG file getting lot of errors

first was "The file you supplied isn't a valid image."

Then I commented the if condition just to check, then got "The image you supply must have a .gif, .jpg/.jpeg, or .png extension." Then I checked "$file_mime_as_ext" and it dump "octet-stream" for jpg file. I know it's some kind of mime problem. Any idea how to fix it?

Thanks in advance

Web server: NGINX PHP Version: 5.5.9-1ubuntu4.14

I am getting this error Final image URL is broken. The page looks like this There should be 100 images displayed but it dies at the third.

It is returning this url There should be a / between the mediapage.zips.me and core, however it is a local image so I don't see why it should even need the host name.

How I am doing this is,

On the top of each page I am calling another page which contains the setup of the class

<?php
    //Calls the php-image things
    include 'test.php';

?>

Inside test.php

<?php 
    require_once 'core/classes/ImageCache.php';
    $imagecache = new ImageCache();
?>

Image page

<?php 
    //Directory NON-CACHED images are stored in
    $dir    =   "i/";

    //Array of files in the Directory
    $files1 =   scandir($dir);
    //Used to limit results (100's of images)
    $count = 0;
    foreach ($files1 as $key) {
        //If the file name is longer than 3 chars and the count is less 
        //than the amount of images I want displayed.
        if (strlen($key) > 3 && $count <= 100){
            $count++;
            //dir2 is the directory/nameofFile.extension
            //Eg: i/testImage.png
            $dir2   =   $dir.''.$key;
            $info = new SplFileInfo($key);
            //Image Cache variable
            $cached_src = $imagecache->cache($dir2);
?>
    <tr>
        <td>
            <!-- Link for light box for full resolution image -->
            <a href="<?php echo $dir2;?>" data-popup="lightbox">
                <!-- src of cached image is outputted and the alt is the name of the uncached image. -->
                <img src="<?php echo $cached_src;?>" alt="<?php echo $key;?>" class="img-rounded img-preview">
            </a>
        </td>
        <!-- More table stuff... -->
    </tr>

<?php
        } //End If
    } //End for
?>

Warning: imagejpeg(C:\xampp\htdocs\php-image-cache-master\demo/images/cached/ccc2078020a3fec0056ed59b53a7bf2d.jpeg): failed to open stream: No such file or directory in C:\xampp\htdocs\php-image-cache-master\src\ImageCache\ImageCache.php on line 230 Could not copy image resource.

"It showing error like this how should i give input(Url) please suggest me"