Hey,

I changed the following things:

• Check if migrations ran in service provider before querying the database. If the package is added by a deploy service, it fails because it tries to fetch webhooks before the migrations are run.
• Remove dynamic migration dates. This is because I needed to change the migration in an other package in stead of the underlying Laravel project. It's impossible to override a migration in an other package if "vendor:publish" is run by a deploy service and the migration name is unknown. (the files are copied after all the service providers have been triggered, so the check if the migration already exists doesn't work in this case)
• made tenant_id unsigned This is done so I can set a foreign key to another table.
• add missing : to eloquent events in README The webhooks weren't triggering because I missed a : in the event name.

Hope I provided enough info and you accept this pull request! :)

This is a fairly large PR, and it does a few things aside from what the title says:

• [x] Allow users to enable logging of webhooks (defaults to active with a 50 logs/hook limit)
• [x] Make code more testable by clearer separation
• [x] Separate the execution of the event handler out into a separate job
• [x] New migration system to allow creating multiple migrations, this will make upgrading easier as it just requires publishing the latest files

Upgrade notes

This introduces a logger as part of the Job. This means that users need to run the latest migration, by first publishing the latest migration files and calling php artisan migrate.

• No need for a custom service provider, you now declare your listeners in the config file!
• Request data is now not automatically JSON encoded, this is instead done by the transformer in config. By default, the function is a simple JSON encode.

Final comments

The package is still lacking some structure. However, I did not want to restructure the entire application in this pull request. In the future, a goal should be to get rid of getters and setters only used for testing purposes, and instead resolved out of the IoC container, for a start. Abstracting out Guzzle might also be useful for testing purposes, and same goes for the logging module.

We're using this with Zapier, but we'd like to remove the webhooks/subscriptions/zaps that are returning 401 (removed).

Could we add some code to TriggerWebhooksJob.php around line 72 to the tune of this:

                }, function ($request, $options, Promise $response) use ($log, $webhook) {
                $response->then(function (ResponseInterface $response) use ($log, $webhook) {
                    $log->status = $response->getStatusCode();
                    $log->response = $response->getBody()->getContents();
                    $log->response_format = $log->payload_format = isset($response->getHeader('Content-Type')[0]) ? $response->getHeader('Content-Type')[0] : null;

                    $log->save();

                    // Retry this job if the webhook response didn't give us a HTTP 200 OK
                    if ($response->getStatusCode() != 200) {
                        $this->release(30);
                    }

                    // Delete the webhook if the reponse is returning HTTP 410 REMOVED
                    if ($response->getStatusCode() == 410) {
                        $webhook->delete();
                    }
                });

In order to analyze possible webhook errors or to just display the results of the last X webhooks, we need a "webhook_logs" table, that will store that information. It should be configurable how many log entries get stored per webhook.

Issue description

I have been trying to get captainhook to work for a model and was not able to do so. I'm not sure where I'm doing a mistake but I assume Laravel is not firing eloquent.saved or any other events. I followed all the exact instructions mentioned in readme.

Here are my project files that might help resolve the issue:

Any help is greatly appreciated.

php artisan hook:list

+----+-----------+------------------------+----------------------------+
| id | tenant_id | url                    | event                      |
+----+-----------+------------------------+----------------------------+
| 7  |           | http://localhost:10000 | eloquent.saved \App\Vessel |
+----+-----------+------------------------+----------------------------+

composer.json

{
  "name": "laravel/laravel",
  "description": "The Laravel Framework.",
  "keywords": [
    "framework",
    "laravel"
  ],
  "license": "MIT",
  "type": "project",
  "require": {
    "laravel/framework": "5.2.39",
    "league/flysystem-aws-s3-v3": "~1.0",
    "venturecraft/revisionable": "1.*",
    "maknz/slack": "^1.7",
    "phpmailer/phpmailer": "^5.2",
    "snowfire/beautymail": "dev-master",
    "mpociot/captainhook": "~2.0",
    "doctrine/dbal": "^2.5",
    "predis/predis": "^1.1",
    "torann/currency": "^0.3.0",
    "yajra/laravel-datatables-oracle": "~6.0"
  },
  "require-dev": {
    "fzaninotto/faker": "~1.4",
    "mockery/mockery": "0.9.*",
    "phpunit/phpunit": "~4.0",
    "symfony/css-selector": "2.8.*|3.0.*",
    "symfony/dom-crawler": "2.8.*|3.0.*"
  },
  "autoload": {
    "classmap": [
      "database",
      "app/Libraries/ImageUploaderPHP"
    ],
    "psr-4": {
      "App\\": "app/"
    },
    "files": [
      "app/Support/helpers.php"
    ]
  },
  "autoload-dev": {
    "classmap": [
      "tests/TestCase.php"
    ]
  },
  "scripts": {
    "post-root-package-install": [
      "php -r \"file_exists('.env') || copy('.env.example', '.env');\""
    ],
    "post-create-project-cmd": [
      "php artisan key:generate"
    ],
    "post-install-cmd": [
      "Illuminate\\Foundation\\ComposerScripts::postInstall",
      "php artisan optimize"
    ],
    "post-update-cmd": [
      "Illuminate\\Foundation\\ComposerScripts::postUpdate",
      "php artisan optimize"
    ]
  },
  "config": {
    "preferred-install": "dist",
    "process-timeout": 0
  }
}

.env

APP_ENV=local
APP_DEBUG=true
APP_KEY=1yoaL71DDzGvey0BwVy25hySFMdBaEoA

DB_HOST=127.0.0.1
DB_DATABASE=myfyba
DB_USERNAME=root
DB_PASSWORD=

CACHE_DRIVER=redis
SESSION_DRIVER=redis
QUEUE_DRIVER=redis
REDIS_HOST=localhost

....

config/captain_hook.php

<?php

/**
 * This file is part of CaptainHook arrrrr.
 *
 * @license MIT
 */

return [

    /*
    |--------------------------------------------------------------------------
    | Event listeners
    |--------------------------------------------------------------------------
    |
    | This array allows you to define all events that Captain Hook should
    | listen for in the application. By default, the Captain will just
    | respond to eloquent events, but you may edit this as you like.
    */
    'listeners' => ['eloquent.*'],

    /*
    |--------------------------------------------------------------------------
    | Webhook filter closure
    |--------------------------------------------------------------------------
    |
    | If your webhooks are scoped to a tenant_id, you can modify
    | this filter function to return only the webhooks for your
    | tenant. This function is applied as a collection filter.
    | The tenant_id field can be used for verification.
    |
    */
    'filter' => function ($webhook) {
        return true;
    },

    /*
    |--------------------------------------------------------------------------
    | Webhook data transformer
    |--------------------------------------------------------------------------
    |
    | The data transformer is a simple function that allows you to take the
    | subject data of an event and convert it to a format that will then
    | be posted to the webhooks. By default, all data is json encoded.
    | The second argument is the Webhook that was triggered in case
    | you want to transform the data in different ways per hook.
    |
    | You can also use the 'Foo\Class@transform' notation if you want.
    |
    */
    'transformer' => function ($eventData, $webhook) {
        return json_encode($eventData);
    },

    /*
    |--------------------------------------------------------------------------
    | Webhook response callback
    |--------------------------------------------------------------------------
    |
    | The response callback can be used if you want to trigger
    | certain actions depending on the webhook response.
    | This is unused by default.
    |
    | You can also use the 'Foo\Class@handle' notation if you want.
    |
    */
    'response_callback' => function ($webhook, $response) {
        // Handle custom response status codes, ...
    },

    /*
    |--------------------------------------------------------------------------
    | Logging configuration
    |--------------------------------------------------------------------------
    |
    | Captain Hook ships with built-in logging to allow you to store data
    | about the requests that you have made in a certain time interval.
    */
    'log' => [
        'active' => true,
        'storage_quantity' => 50,
    ],
];

In looking at the source for guzzlehttp/guzzle 5.3 (https://github.com/guzzle/guzzle/tree/5.3/src), there is no Middleware class, so it's no surprise that I'm getting a "Class does not exist" exception.

This can be resolved by either dropping support for 5.3 in your composer.json file, or refactoring your usage of the Middleware class to be compliant with 5.3 and 6.

I added a webhook by running this -

php artisan hook:add http://localhost:9999 'eloquent.updated \App\Models\User'

but when I update my user model I don't get any request in http://localhost:9999

Am I doing it right? Any help will be appreciated.

Thanks

The new 'tenant_spark_model' option in the config allows you to assign the tenant_id to the Spark Team instead of the User like is happening by default.

With this new config option you can choose to add extra routes that will allow services like Zapier to create,update and delete Webhooks like explained in this website http://resthooks.org/ .

• Sort import in composer.json : this allows to get less noise in commits when adding/updating/deleting an entry
• Add support for phpunit 5
• Use new || syntax
• Stay consistant and use tilde (~) syntax for Mockery

If we allow users to define custom events in a config file, there will be no need to go through the hassle of extend the SP, which I reckon could be quite handy.

So far looks like request post to webhook receiver is anonymous. Can this be a configuration of adding more header options?

For example: create a captain_hook.request_header callable (like $transformer), then we can use the $webhook object and original $header option, such as

// @file config/config.php
'request_header' => function ($webhook, $header = []) {
    return [
        'X-Hub-Signature' => 'sha1=xxxxxxxxxxxxxxxxxxxxx',
    ]
}

After I try to run "php artisan config:cache" I get an error that prevents Laravel from running completely (ReflectionException). After some debugging I found that the problem was in this part of the config file of CaptainHook

    'filter'             => function($webhook) {
        return $webhook->tenant_id == Auth::user()->currentTeam->id;
    },

The problem is that Laravel can't cache Closures, so it's throwing an error.

It would be really nice if we could pass to the filter params also a string with the Class and method to be run ("\App\SomeClass@someMethod"), just like you do for the "transformer" and the "response_callback" field.

Do you think it would be possible to make?

and thanks a lot for the amazing libraries you've built!!!

Our take on Laravel 5.4 compatibility.

By using a wildcard in the event name Laravel will give us the event name in the event listener so we don’t have to retrieve the name from elsewhere.

I'm integrating this module into a Laravel 5.1 application and I found some incompatibilities.

To get it working, I had to make a change to the migration scripts and revert PR #37 (Removed deprecated Selfhandling contract).

Is there any plan to continue support for Laravel 5.1 such as a maintenance branch or is there some specific version of this package I should use instead?

I'm fairly new to Laravel so I might be missing something. Also, great work on the package!