Two Factor Authentication for Magento 2

Related tags

Miscellaneous m2-MSP_TwoFactorAuth
Overview
Comments
  • Endless loop with DUO

    Endless loop with DUO

    I was trying to setup DUO but after enabling I get to the screen with Push/Call/Enter Code and then i approve the push or enter the code and clicking continue takes me back to the Push/Call/Enter Code page.

    Trying to access /admin panel redirects me there again - so i get locked until using the command line to disable 2fa.

    opened by piotrekkaminski 7
  • Call to non-existing methods

    Call to non-existing methods

    Steps to reproduce:

    1. ... -> Security Suite -> Two Factor Authentication -> Enable = yes.
    2. Save Configuration
    3. Flush cache
    4. Admin user -> 2FA -> Enable = yes.
    5. Save user
    6. Now you will be asked for scanning the QR Code, but the image is broken: image
    7. Follow link of the image: error

    Because of the requirement in composer.json "endroid/qrcode": "^1.7" it installed version 1.9.3 in which those methods don't exist anymore. Also saw that on their github 1.7 tags don't exists.

    So I can think of 2 possible solutions:

    1. Fix composer.json to include the correct package version endriod/qrcode
    2. Update the code to use their new package version (also update composer.json to reflect that version number).

    Hopefully you can provide an solution asap :smile:

    Don't think this is really relevant for the issue but: Tested on latest Magento 2 CE & EE 2.1.6 Installed version of endroid/qrcode = 1.9.3 Installed version of msp/twofactorauth = 0.1.4

    opened by GeoffreyDijkstra 6
  • isn't enabling/disabling 2FA from the admin a security issue?

    isn't enabling/disabling 2FA from the admin a security issue?

    I think ability to disable/enable 2FA from admin is a possible security risk. We already had hackers entering admin and changing symlinks config to use RCE. In this case, if there is CSRF vulnerability in Magento, admin can be tricked to click on link that would disable 2FA.

    I think all enable/disable/provider list should be in command line or XML file, not exposed via admin.

    question 
    opened by piotrekkaminski 4
  • Module cause 500 on swagger

    Module cause 500 on swagger

    Preconditions

    1. Magento 2.1.10
    2. MSP_SecuritySuite 2.0.1

    Steps to reproduce

    1. Try to run swagger

    Expected result

    1. See swagger

    Actual result

    1. Error 500

    500 : {"message":"Invalid parameter type "\MSP\TwoFactorAuth\Model\ProviderInterface[]".","trace":"#0 /app/magento/vendor/magento/framework/Reflection/TypeProcessor.php(160): Magento\Framework\Reflection\TypeProcessor->translateTypeName('\\MSP\\TwoFactorA...')\n#1 /app/magento/vendor/magento/module-webapi/Model/Config/ClassReflector.php(103): Magento\Framework\Reflection\TypeProcessor->register('\\MSP\\TwoFactorA...')\n#2 /app/magento/vendor/magento/module-webapi/Model/Config/ClassReflector.php(72): Magento\Webapi\Model\Config\ClassReflector->extractMethodData(Object(Zend\Code\Reflection\MethodReflection))\n#3 /app/magento/vendor/magento/module-webapi/Model/ServiceMetadata.php(119): Magento\Webapi\Model\Config\ClassReflector->reflectClassMethods('\\MSP\\TwoFactorA...', Array)\n#4 /app/magento/vendor/magento/module-webapi/Model/ServiceMetadata.php(148): Magento\Webapi\Model\ServiceMetadata->initServicesMetadata()\n#5 /app/magento/vendor/magento/module-webapi/Model/Rest/Swagger/Generator.php(913): Magento\Webapi\Model\ServiceMetadata->getServicesConfig()\n#6 /app/magento/vendor/magento/module-webapi/Controller/Rest.php(278): Magento\Webapi\Model\Rest\Swagger\Generator->getListOfServices()\n#7 /app/magento/vendor/magento/module-webapi/Controller/Rest.php(214): Magento\Webapi\Controller\Rest->processSchemaRequest()\n#8 /app/magento/var/generation/Magento/Webapi/Controller/Rest/Interceptor.php(37): Magento\Webapi\Controller\Rest->dispatch(Object(Magento\Framework\App\Request\Http))\n#9 /app/magento/vendor/magento/framework/App/Http.php(135): Magento\Webapi\Controller\Rest\Interceptor->dispatch(Object(Magento\Framework\App\Request\Http))\n#10 /app/magento/vendor/magento/framework/Interception/Interceptor.php(74): Magento\Framework\App\Http->launch()\n#11 /app/magento/vendor/magento/framework/Interception/Chain/Chain.php(70): Magento\Framework\App\Http\Interceptor->___callParent('launch', Array)\n#12 /app/magento/vendor/magento/framework/Interception/Chain/Chain.php(63): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Framewo...', 'launch', Object(Magento\Framework\App\Http\Interceptor), Array, 'mSPShieldAppInt...')\n#13 /app/magento/vendor/msp/shield/Plugin/AppInterfacePlugin.php(111): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain\{closure}()\n#14 /app/magento/vendor/magento/framework/Interception/Chain/Chain.php(67): MSP\Shield\Plugin\AppInterfacePlugin->aroundLaunch(Object(Magento\Framework\App\Http\Interceptor), Object(Closure))\n#15 /app/magento/vendor/magento/framework/Interception/Chain/Chain.php(63): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Framewo...', 'launch', Object(Magento\Framework\App\Http\Interceptor), Array, 'mSPAdminRestric...')\n#16 /app/magento/vendor/msp/adminrestriction/Plugin/AppInterfacePlugin.php(134): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain\{closure}()\n#17 /app/magento/vendor/magento/framework/Interception/Chain/Chain.php(67): MSP\AdminRestriction\Plugin\AppInterfacePlugin->aroundLaunch(Object(Magento\Framework\App\Http\Interceptor), Object(Closure))\n#18 /app/magento/vendor/magento/framework/Interception/Interceptor.php(138): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\\Framewo...', 'launch', Object(Magento\Framework\App\Http\Interceptor), Array, 'mSPAntiVirusApp...')\n#19 /app/magento/vendor/msp/antivirus/Plugin/AppInterfacePlugin.php(104): Magento\Framework\App\Http\Interceptor->Magento\Framework\Interception\{closure}()\n#20 /app/magento/vendor/magento/framework/Interception/Interceptor.php(142): MSP\AntiVirus\Plugin\AppInterfacePlugin->aroundLaunch(Object(Magento\Framework\App\Http\Interceptor), Object(Closure))\n#21 /app/magento/var/generation/Magento/Framework/App/Http/Interceptor.php(26): Magento\Framework\App\Http\Interceptor->___callPlugins('launch', Array, Array)\n#22 /app/magento/vendor/magento/framework/App/Bootstrap.php(258): Magento\Framework\App\Http\Interceptor->launch()\n#23 /app/magento/pub/index.php(37): Magento\Framework\App\Bootstrap->run(Object(Magento\Framework\App\Http\Interceptor))\n#24 {main}"} http://magento.dev/rest/default/schema?services=all

    bug 
    opened by maqlec 4
  • Compilation error on Magento 2.2

    Compilation error on Magento 2.2

    Preconditions

    1. Magento 2.2
    2. Latest version of this module

    Steps to reproduce

    1. php bin/magento setup:di:compile in production mode

    Expected result

    1. It should compile

    Actual result

    1. This;
    Interception cache generation... 6/7 [========================>---]  85% 43 secs 248.0 MiBErrors during compilation:
	MSP\TwoFactorAuth\Ui\Component\Form\User\DataProvider
		Incompatible argument type: Required type: string. Actual type: \MSP\TwoFactorAuth\Ui\Component\Form\User\name; File: 
/builds/clientname/clientname/vendor/msp/twofactorauth/Ui/Component/Form/User/DataProvider.php
    bug 
    opened by peterjaap 4
  • Question / Feature Request: Force 2FA

    Question / Feature Request: Force 2FA

    Is it possible to add an way that 2FA is forced? Because now you manually have to enable it for every user and if you don't enable it for one he/she can still log in without 2FA.

    opened by GeoffreyDijkstra 4
  • Error during compilation on 2.1.8

    Error during compilation on 2.1.8

    MSP\TwoFactorAuth\Controller\Adminhtml\Authy\Authpost Incorrect dependency in class MSP\TwoFactorAuth\Controller\Adminhtml\Authy\Authpost in /var/www/html/vendor/msp/twofactorauth/Controller/Adminhtml/Authy/Authpost.php \Magento\Framework\Event\ManagerInterface already exists in context object

    This error comes for every controller. It seems to have been fixed in PR #5 but the code is not in the latest release.

    Kind regards, Giancarlo.

    opened by gperis 3
  • u2f not working

    u2f not working

    1. I was trying with Yubikey and it does not register the device (it worked well with https://demo.yubico.com/).
    2. It also locked me out of admin - bin/magento msp:security:tfa:disable doesn't disable redirect to yubikey registration.
    3. Additionally, there is no way to log in as a different admin when you are stuck on registration page
    opened by piotrekkaminski 3
  • Breaks in 2.1.7

    Breaks in 2.1.7

    The image doesn't show;

    image

    When rightclicking the image and visiting the URL (http://elgentos.clientname.magento2.dev/admin_dfi38d/msp_twofactorauth/activate/qrcode/key/695c4ae02ae6c687e98af33c3853921971a86f6640360b0316786b23f521d880/) I get:

    ( ! ) Fatal error: Uncaught TypeError: Argument 1 passed to Endroid\QrCode\Writer\PngWriter::writeString() must implement interface Endroid\QrCode\QrCodeInterface, none given, called in /data/elgentos/clientname/vendor/msp/twofactorauth/Model/Tfa.php on line 211 and defined in /data/elgentos/clientname/vendor/endroid/qrcode/src/Writer/PngWriter.php on line 27
( ! ) TypeError: Argument 1 passed to Endroid\QrCode\Writer\PngWriter::writeString() must implement interface Endroid\QrCode\QrCodeInterface, none given, called in /data/elgentos/clientname/vendor/msp/twofactorauth/Model/Tfa.php on line 211 in /data/elgentos/clientname/vendor/endroid/qrcode/src/Writer/PngWriter.php on line 27

Call Stack
#	Time	Memory	Function	Location
1	0.0002	400984	{main}( )	.../index.php:0
2	0.1174	7500800	Magento\Framework\App\Bootstrap->run( )	.../index.php:37
3	0.1180	7548280	Magento\Framework\App\Http\Interceptor->launch( )	.../Bootstrap.php:258
4	0.1196	7856544	Magento\Framework\App\Http\Interceptor->___callPlugins( )	.../Interceptor.php:26
5	0.1472	9315152	MSP\AdminRestriction\Plugin\AppInterfacePlugin->aroundLaunch( )	.../Interceptor.php:142
6	0.1476	9317408	Magento\Framework\App\Http\Interceptor->Magento\Framework\Interception\{closure}( )	.../AppInterfacePlugin.php:105
7	0.1476	9317464	Magento\Framework\Interception\Chain\Chain->invokeNext( )	.../Interceptor.php:138
8	0.1476	9317496	Magento\Framework\App\Http\Interceptor->___callParent( )	.../Chain.php:70
9	0.1476	9317496	Magento\Framework\App\Http->launch( )	.../Interceptor.php:74
10	0.2192	13596152	Magento\Framework\App\FrontController\Interceptor->dispatch( )	.../Http.php:135
11	0.2212	13558320	Magento\Framework\App\FrontController\Interceptor->___callPlugins( )	.../Interceptor.php:26
12	0.2367	14579752	Magento\Framework\Module\Plugin\DbStatusValidator->aroundDispatch( )	.../Interceptor.php:142
13	0.2368	14579800	Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}( )	.../DbStatusValidator.php:69
14	0.2369	14580176	Magento\Framework\Interception\Chain\Chain->invokeNext( )	.../Interceptor.php:138
15	0.2371	14581440	Magento\Framework\App\FrontController\Interceptor->___callParent( )	.../Chain.php:70
16	0.2371	14581440	Magento\Framework\App\FrontController->dispatch( )	.../Interceptor.php:74
17	0.3726	22371512	MSP\TwoFactorAuth\Controller\Adminhtml\Activate\Qrcode\Interceptor->dispatch( )	.../FrontController.php:55
18	0.3746	22456256	MSP\TwoFactorAuth\Controller\Adminhtml\Activate\Qrcode\Interceptor->___callPlugins( )	.../Interceptor.php:39
19	0.5621	27568648	Magento\Backend\App\Action\Plugin\MassactionKey->aroundDispatch( )	.../Interceptor.php:142
20	0.5621	27568648	MSP\TwoFactorAuth\Controller\Adminhtml\Activate\Qrcode\Interceptor->Magento\Framework\Interception\{closure}( )	.../MassactionKey.php:33
21	0.5621	27569024	Magento\Framework\Interception\Chain\Chain->invokeNext( )	.../Interceptor.php:138
22	0.5688	27811320	Magento\Backend\App\Action\Plugin\Authentication->aroundDispatch( )	.../Chain.php:67
23	0.5912	27966944	Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain\{closure}( )	.../Authentication.php:143
24	0.5913	27967320	Magento\Framework\Interception\Chain\Chain->invokeNext( )	.../Chain.php:63
25	0.5913	27967360	MSP\TwoFactorAuth\Controller\Adminhtml\Activate\Qrcode\Interceptor->___callParent( )	.../Chain.php:70
26	0.5913	27967360	Magento\Backend\App\AbstractAction->dispatch( )	.../Interceptor.php:74
27	0.5953	27969656	Magento\Framework\App\Action\Action->dispatch( )	.../AbstractAction.php:226
28	0.6069	28185792	MSP\TwoFactorAuth\Controller\Adminhtml\Activate\Qrcode\Interceptor->execute( )	.../Action.php:102
29	0.6069	28185792	MSP\TwoFactorAuth\Controller\Adminhtml\Activate\Qrcode->execute( )	.../Interceptor.php:24
30	0.6069	28185792	MSP\TwoFactorAuth\Model\Tfa->getQrCodeAsPng( )	.../Qrcode.php:53
31	0.6175	28840656	Endroid\QrCode\Writer\PngWriter->writeString( )	.../Tfa.php:211
    opened by peterjaap 3
  • Some authenticator apps say invalid URL

    Some authenticator apps say invalid URL

    Sometimes the QR code generated will not validate. 1Password One Time Password does read the QR code but will generate an invalid code every time. Google Authenticator will give an invalid url warning;

    image

    We tracked it down to the secret being a base32 hash and thus containing three = at the end of the string. The created otpauth:// will then be invalid for some authenticator apps in some situations.

    The fix is to strip out the special characters, thereby generating a valid oauth url everytime.

    opened by peterjaap 2
  • Errors during compilation in 2.1.7

    Errors during compilation in 2.1.7 

    Errors during compilation:
	MSP\TwoFactorAuth\Controller\Adminhtml\Auth\Post
		Incorrect dependency in class MSP\TwoFactorAuth\Controller\Adminhtml\Auth\Post in /data/elgentos/mikx/vendor/msp/twofactorauth/Controller/Adminhtml/Auth/Post.php
\Magento\Framework\Event\ManagerInterface already exists in context object
Total Errors Count: 1
    opened by peterjaap 2
  • Getting Lot of Warning Message when run Magento Extension Quality Program Coding Standard

    Getting Lot of Warning Message when run Magento Extension Quality Program Coding Standard

    Preconditions

    1. Run Magento Extension Quality Program Coding Standard on extension and getting lot of error Message as belows

    Use of protected class members is discouraged

    As per as magento extension Quality program this warnings should be fix.

    Steps to reproduce

    1. Clone Magento Extension Quality Program Coding Standard using composer.
    2. After clone goto directory magento-coding-standard where i have clone the the package
    3. clone m2-MSP_TwoFactorAuth using composer require msp/twofactorauth
    4. Now Extension Quality Program Coding standard program using php vendor/bin/phpcs /var/www/html/vendor/msp/twofactorauth --standard=MEQP2 and that command show lot of warning message :

    Use of protected class members is discouraged

    Expected result

    1. Logs:
    vagrant@dev:/var/www/html/magento-coding-standard$ php vendor/bin/phpcs /var/www/html/vendor/msp/twofactorauth --standard=MEQP2

FILE: /var/www/html/vendor/msp/twofactorauth/Setup/InstallSchema.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 35 | WARNING | The method parameter $context is never used
----------------------------------------------------------------------


FILE: /var/www/html/vendor/msp/twofactorauth/Setup/InstallData.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 40 | WARNING | The method parameter $context is never used
----------------------------------------------------------------------


FILE: ...dor/msp/twofactorauth/Model/ResourceModel/Country/Collection.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 35 | WARNING | Use of protected class members is discouraged.
 35 | WARNING | Property name "$_idFieldName" should not be prefixed
    |         | with an underscore to indicate visibility
 37 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: ...ww/html/vendor/msp/twofactorauth/Model/ResourceModel/Country.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 34 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: ...dor/msp/twofactorauth/Model/ResourceModel/Trusted/Collection.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 35 | WARNING | Use of protected class members is discouraged.
 35 | WARNING | Property name "$_idFieldName" should not be prefixed
    |         | with an underscore to indicate visibility
 37 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: ...html/vendor/msp/twofactorauth/Model/ResourceModel/UserConfig.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 56 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: ...ww/html/vendor/msp/twofactorauth/Model/ResourceModel/Trusted.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 34 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: .../msp/twofactorauth/Model/ResourceModel/UserConfig/Collection.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 35 | WARNING | Use of protected class members is discouraged.
 35 | WARNING | Property name "$_idFieldName" should not be prefixed
    |         | with an underscore to indicate visibility
 37 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: /var/www/html/vendor/msp/twofactorauth/Model/Country.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 64 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: /var/www/html/vendor/msp/twofactorauth/Model/UserConfig.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 64 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: /var/www/html/vendor/msp/twofactorauth/Model/Trusted.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 64 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: ...endor/msp/twofactorauth/Observer/BackendAuthUserLoginSuccess.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 53 | WARNING | The method parameter $observer is never used
----------------------------------------------------------------------


FILE: ...vendor/msp/twofactorauth/Ui/Component/Form/User/DataProvider.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 70 | WARNING | Only dependency assignment operations are allowed in
    |         | constructor. No other operations are allowed.
----------------------------------------------------------------------


FILE: ...l/vendor/msp/twofactorauth/Controller/Adminhtml/Duo/Authpost.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 149 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: .../html/vendor/msp/twofactorauth/Controller/Adminhtml/Duo/Auth.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 93 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: .../vendor/msp/twofactorauth/Controller/Adminhtml/U2f/Configure.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 80 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: ...l/vendor/msp/twofactorauth/Controller/Adminhtml/U2f/Authpost.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 149 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: ...dor/msp/twofactorauth/Controller/Adminhtml/U2f/Configurepost.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 139 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: .../html/vendor/msp/twofactorauth/Controller/Adminhtml/U2f/Auth.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 90 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: ...l/vendor/msp/twofactorauth/Controller/Adminhtml/Authy/Verify.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 125 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: ...vendor/msp/twofactorauth/Controller/Adminhtml/Authy/Onetouch.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 108 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: .../msp/twofactorauth/Controller/Adminhtml/Authy/Verifyonetouch.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 159 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: ...endor/msp/twofactorauth/Controller/Adminhtml/Authy/Configure.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 89 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: ...vendor/msp/twofactorauth/Controller/Adminhtml/Authy/Authpost.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 156 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: ...ml/vendor/msp/twofactorauth/Controller/Adminhtml/Authy/Token.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 109 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: ...r/msp/twofactorauth/Controller/Adminhtml/Authy/Configurepost.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 152 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: ...twofactorauth/Controller/Adminhtml/Authy/Configureverifypost.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 157 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: ...tml/vendor/msp/twofactorauth/Controller/Adminhtml/Authy/Auth.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 100 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: ...ndor/msp/twofactorauth/Controller/Adminhtml/Google/Configure.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 81 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: ...endor/msp/twofactorauth/Controller/Adminhtml/Google/Authpost.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 157 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: .../msp/twofactorauth/Controller/Adminhtml/Google/Configurepost.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 144 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: ...html/vendor/msp/twofactorauth/Controller/Adminhtml/Google/Qr.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 102 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: ...ml/vendor/msp/twofactorauth/Controller/Adminhtml/Google/Auth.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 90 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: ...html/vendor/msp/twofactorauth/Controller/Adminhtml/Tfa/Reset.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 91 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: ...tml/vendor/msp/twofactorauth/Controller/Adminhtml/Tfa/Revoke.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 62 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: /var/www/html/vendor/msp/twofactorauth/Block/ChangeProvider.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 49 | WARNING | Only dependency assignment operations are allowed in
    |         | constructor. No other operations are allowed.
----------------------------------------------------------------------


FILE: ...ugin/Observer/Backend/ForceAdminPasswordChangeObserverPlugin.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 54 | WARNING | The method parameter $subject is never used
----------------------------------------------------------------------


FILE: /var/www/html/vendor/msp/twofactorauth/Command/TfaReset.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 68 | WARNING | Use of protected class members is discouraged.
 83 | WARNING | Use of protected class members is discouraged.
----------------------------------------------------------------------


FILE: /var/www/html/vendor/msp/twofactorauth/Command/TfaProviders.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 47 | WARNING | Use of protected class members is discouraged.
 58 | WARNING | Use of protected class members is discouraged.
 58 | WARNING | The method parameter $input is never used
----------------------------------------------------------------------


FILE: /var/www/html/vendor/msp/twofactorauth/Command/TfaDisable.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 51 | WARNING | Use of protected class members is discouraged.
 62 | WARNING | Use of protected class members is discouraged.
 62 | WARNING | The method parameter $input is never used
 62 | WARNING | The method parameter $output is never used
----------------------------------------------------------------------


FILE: ...factorauth/view/adminhtml/web/js/form/element/reset_providers.js
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 42 | WARNING | [x] Opening brace must be the last content on the
    |         |     line
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...w/html/vendor/msp/twofactorauth/view/adminhtml/web/js/duo/api.js
----------------------------------------------------------------------
FOUND 0 ERRORS AND 45 WARNINGS AFFECTING 45 LINES
----------------------------------------------------------------------
  51 | WARNING | [x] Opening brace should be on a new line
  53 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 12 spaces but found 10
  54 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 12 spaces but found 10
  58 | WARNING | [x] Opening brace should be on a new line
  63 | WARNING | [x] Opening brace should be on a new line
  73 | WARNING | [x] Opening brace should be on a new line
  81 | WARNING | [x] Opening brace should be on a new line
  89 | WARNING | [x] Opening brace should be on a new line
  93 | WARNING | [x] Opening brace should be on a new line
  97 | WARNING | [x] Opening brace should be on a new line
 101 | WARNING | [x] Opening brace should be on a new line
 111 | WARNING | [x] Opening brace should be on a new line
 125 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 16 spaces but found 14
 126 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 16 spaces but found 14
 127 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 16 spaces but found 14
 149 | WARNING | [x] Opening brace should be on a new line
 154 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 16 spaces but found 14
 155 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 16 spaces but found 14
 156 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 16 spaces but found 14
 157 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 16 spaces but found 14
 158 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 16 spaces but found 14
 179 | WARNING | [x] Opening brace should be on a new line
 181 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 12 spaces but found 10
 182 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 12 spaces but found 10
 183 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 12 spaces but found 10
 187 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 12 spaces but found 10
 203 | WARNING | [x] Expected 5 space(s) before asterisk; 7 found
 204 | WARNING | [x] Expected 5 space(s) before asterisk; 7 found
 205 | WARNING | [x] Expected 5 space(s) before asterisk; 7 found
 206 | WARNING | [x] Expected 5 space(s) before asterisk; 7 found
 207 | WARNING | [x] Expected 5 space(s) before asterisk; 7 found
 208 | WARNING | [x] Expected 5 space(s) before asterisk; 7 found
 232 | WARNING | [x] Opening brace should be on a new line
 291 | WARNING | [x] Opening brace should be on a new line
 316 | WARNING | [x] Opening brace should be on a new line
 344 | WARNING | [x] Opening brace should be on a new line
 350 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 20 spaces but found 18
 351 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 20 spaces but found 18
 352 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 20 spaces but found 18
 353 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 20 spaces but found 18
 363 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 20 spaces but found 18
 364 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 20 spaces but found 18
 365 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 20 spaces but found 18
 366 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 20 spaces but found 18
 397 | WARNING | [x] Opening brace should be on a new line
----------------------------------------------------------------------
PHPCBF CAN FIX THE 45 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...tml/vendor/msp/twofactorauth/view/adminhtml/web/js/u2fkey/api.js
----------------------------------------------------------------------
FOUND 0 ERRORS AND 29 WARNINGS AFFECTING 13 LINES
----------------------------------------------------------------------
 180 | WARNING | [x] Opening parenthesis of a multi-line function
     |         |     call must be the last content on the line
 183 | WARNING | [x] Closing parenthesis of a multi-line function
     |         |     call must be on a line by itself
 313 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 12 spaces but found 16
 313 | WARNING | [x] Only one argument is allowed per line in a
     |         |     multi-line function call
 313 | WARNING | [x] Only one argument is allowed per line in a
     |         |     multi-line function call
 313 | WARNING | [x] Closing parenthesis of a multi-line function
     |         |     call must be on a line by itself
 421 | WARNING | [ ] Comment refers to a FIXME task "stash away
     |         |     requestId, as the authenticator app does"
 421 | WARNING | [ ] Comment refers to a TODO task "fixme): stash
     |         |     away requestId, as the authenticator app does"
 425 | WARNING | [ ] Comment refers to a FIXME task "stash away the
     |         |     signRequests, to deal with the legacy"
 425 | WARNING | [ ] Comment refers to a TODO task "fixme): stash
     |         |     away the signRequests, to deal with the legacy"
 441 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 12 spaces but found 16
 441 | WARNING | [x] Closing parenthesis of a multi-line function
     |         |     call must be on a line by itself
 528 | WARNING | [ ] Comment refers to a FIXME task "stash away
     |         |     requestId, this is is not necessary for"
 528 | WARNING | [ ] Comment refers to a TODO task "fixme): stash
     |         |     away requestId, this is is not necessary for"
 621 | WARNING | [x] Opening parenthesis of a multi-line function
     |         |     call must be the last content on the line
 622 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 16 spaces but found 20
 622 | WARNING | [x] Closing parenthesis of a multi-line function
     |         |     call must be on a line by itself
 625 | WARNING | [x] Inline control structures are not allowed
 625 | WARNING | [x] Expected 0 spaces before semicolon; newline
     |         |     found
 680 | WARNING | [x] The first parameter of a multi-line function
     |         |     declaration must be on the line after the
     |         |     opening bracket
 680 | WARNING | [x] Multi-line function declarations must define one
     |         |     parameter per line
 681 | WARNING | [x] Multi-line function declaration not indented
     |         |     correctly; expected 4 spaces but found 24
 681 | WARNING | [x] Multi-line function declarations must define one
     |         |     parameter per line
 681 | WARNING | [x] The closing parenthesis of a multi-line function
     |         |     declaration must be on a new line
 689 | WARNING | [x] Multi-line function call not indented correctly;
     |         |     expected 8 spaces but found 12
 689 | WARNING | [x] Only one argument is allowed per line in a
     |         |     multi-line function call
 689 | WARNING | [x] Only one argument is allowed per line in a
     |         |     multi-line function call
 689 | WARNING | [x] Only one argument is allowed per line in a
     |         |     multi-line function call
 689 | WARNING | [x] Closing parenthesis of a multi-line function
     |         |     call must be on a line by itself
----------------------------------------------------------------------
PHPCBF CAN FIX THE 23 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...ndor/msp/twofactorauth/view/adminhtml/web/js/u2fkey/configure.js
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 96 | WARNING | [x] Only one argument is allowed per line in a
    |         |     multi-line function call
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...ml/vendor/msp/twofactorauth/view/adminhtml/web/js/u2fkey/auth.js
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 96 | WARNING | [x] Only one argument is allowed per line in a
    |         |     multi-line function call
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 8.66 secs; Memory: 22Mb

    Actual result

    1. As per as magento extension Quality program this warnings should be fix.Mostly Use of protected class members is discouraged waring. So, what is solution on this case.
    opened by devamitbera 0
Releases(2.1.10)
Owner
MageSpecialist
MageSpecialist
GitHub
Magento 2 Italian Language Pack is special gift for Magento 2 Community Edition. The data of the translation is supplied by Magento 2 Translation Project of Crowdin site, on which you will contribute into the project and download the zip file to install on your own store. This knowledge base will include full of the clear guides that supports you to convert the default language (English) into Italian language on your entire store.

Magento 2 Italian Language Pack Magento 2 Italian Language Pack is a special gift for Magento 2 Community Edition. The data of the translation is supp

Mageplaza 13 Nov 11, 2022
A tool that allows to quickly export data from Magento 1 and Magento 2 store and import it back into Magento 2

Simple Import / Export tool A tool that allows to quickly export data from Magento 1 and Magento 2 store and import it back into Magento 2. Table data

EcomDev B.V. 51 Dec 5, 2022
Simple PHP package for add two numbers

Sum Simple PHP package for add two numbers Installation To get the latest version of Sum, simply require the project using Composer: composer require

Nazar 13 Nov 20, 2022
Compares two directories and removes the duplicate files from the second directory.

How does the HRZ Duplicate Refiner work? 1- Compares two directories : patternDir: the directory used as the pattern & does not change. victimDir: A d

Hamidreza Zolfaghar 2 May 6, 2022
A comprehensive library for generating differences between two strings in multiple formats (unified, side by side HTML etc). Based on the difflib implementation in Python

PHP Diff Class Introduction A comprehensive library for generating differences between two hashable objects (strings or arrays). Generated differences

Chris Boulton 708 Dec 25, 2022
A tool that can be used to verify BC breaks between two versions of a PHP library.

Roave Backward Compatibility Check A tool that can be used to verify BC breaks between two versions of a PHP library. Pre-requisites/assumptions Your

Roave, LLC 530 Dec 27, 2022
This Magento 2 extension integrates EasyTranslate into Magento 2.

EasyTranslate Magento 2 Connector This Magento 2 extension integrates EasyTranslate into Magento 2. Mind that you need to have an account with EasyTra

Easytranslate ApS 0 Oct 7, 2022
Magento-Functions - A Resource of Magento Functions

Magento-Functions A Resource of Magento Functions Table of Contents Category Product User Cart Checkout General Account [Working w/ URL's] (#urls) Cat

Bryan Littlefield 28 Apr 19, 2021
Magento - Magento Community Editions

Magento Community Edition /// THIS REPOSITORY IS DEPREACTED /// 1.9.4.1 will be the last version update. Please switch over to OpenMage! Either to the

FireGento e. V. 107 Oct 17, 2022
Magento-Vagrant-Puppet-Nginx - Installs magento and a nginx server

Magento-Vagrant-Puppet-Nginx Installs Magento MySQL PHP PHP-FPM Nginx n98-magerun Setup git submodule init git submodule update vagrant up Modify pupp

Christian Münch 61 Aug 10, 2022
Docker-magento - Docker image for Magento 1.6 to 1.9

Docker image for Magento 1.x This repo creates a Docker image for Magento 1.x. Please note The primary goal of this repo is to create Docker images fo

Fu Cheng 144 Nov 18, 2022
Magento-composer-installer - Composer installer for Magento modules

!!! support the maintainer of this project via Patreon: https://www.patreon.com/Flyingmana Magento Composer Installer The purpose of this project is t

null 213 Sep 24, 2022
Chef-magento - Installs and Configures a Magento project

Description Requirements Chef 0.10.0 or higher required (for Chef environment use). Platform Debian, Ubuntu CentOS, Red Hat, Fedora Your basebox must

Inviqa 3 Jun 30, 2020
Cookbook-magento - Collection of recipes to build app stack for the Magento deployments with Chef

Magento Cookbook Collection of recipes to build app stack for the Magento deployments with Chef Installation With Berkshelf echo "cookbook 'magento',

Yevhen Viktorov 37 Sep 26, 2020
Magento-bulk - Bulk Import/Export helper scripts and CLI utilities for Magento Commerce

Magento Bulk Bulk operations for Magento. Configuration Copy config.php.sample to config.php and edit it. Product Attribute Management List All Attrib

Bippo Indonesia 23 Dec 20, 2022
Phpcs-magento-rules - A set of PHPCS rules used by made.com when hacking Magento

Made.com PHPCS Magento Rules A set of PHPCS rules used by made.com when hacking Magento. Pre-Requisites PHPCS Installation Short Version Clone this re

Made.com Tech Team 26 Jun 3, 2020
This Magento extension provides a Real Full Page Caching for Magento powered by Varnish with support of Session-Based information caching (Cart, Customer Accounts, ...) via ESI includes

This Magento extension provides a Real Full Page Caching (FPC) for Magento powered by Varnish with support of Session-Based information caching (Cart, Customer Accounts, ...) via ESI includes

Hugues Alary 95 Feb 11, 2022
Automatically load the next page of products in Magento. Easy to install and configure, this module works 100% out of the box with vanilla Magento 1.9.x and earlier.

Automatically load the next page of products in Magento. Easy to install and configure, this module works 100% out of the box with vanilla Magento 1.9.x and earlier.

Strategery 123 Nov 20, 2021
Foundation 3 Framework for Magento 1.7. Foundation styles and libraries. Magento Responsive theme. Off-canvas Left-Right sidebar columns for mobile.

Magento Foundation 3 Framework Zurb Foundation 3 framework for Magento 1.7. Magento Foundation 3 Version 1.3.0. Demo page: http://magendation.internet

Nando Boronat 62 Apr 1, 2022