The "https://repo.magento.com/packages.json" file could not be downloaded: SSL: Connection reset by peer  
Failed to enable crypto                                                                                   
failed to open stream: operation failed

Getting this error after attempting to install. I never get prompted for any auth. I've tried setting up an auth.json file, according to the Composer docs, and added the public/secret keys that I set up with my Magento account, but get the same error as without having an auth.json.

Any tips?

We have checked the MEQP1 standard. But throw below mentioned errors,

PHP Fatal error: Trait 'MEQP\Utils\Helper' not found in /var/www/development/marketplace-eqp-master/MEQP1/Sniffs/Classes/ResourceModelSniff.php on line 21

My system details. OS - Ubuntu 16.04.3 PHP - 7.0.18

How to solve this issue.....!

Magento 2.1, version 1.0.2. I can't get it working in PHPStorm.

Using the path$PROJECT/vendor/magento/marketplace-eqp/MEQP1

phpcs: PHP Fatal error: Uncaught PHP_CodeSniffer_Exception: Referenced sniff "Generic.Arrays.DisallowShortArraySyntax" does not exist in /vendor/squizlabs/php_codesniffer/CodeSniffer.php:847 Stack trace:
#0 /vendor/squizlabs/php_codesniffer/CodeSniffer.php(587): PHP_CodeSniffer->_expandRulesetReference(Object(SimpleXMLElement), '/Users/paul/Sit...', 0)
#1 /vendor/squizlabs/php_codesniffer/CodeSniffer.php(435): PHP_CodeSniffer->processRuleset('/Users/paul/Sit...')

Using the path$PROJECT/vendor/magento/marketplace-eqp/MEQP2

phpcs: PHP Fatal error: Uncaught PHP_CodeSniffer_Exception: Referenced sniff "MEQP1.CodeAnalysis.EmptyBlock" does not exist in vendor/squizlabs/php_codesniffer/CodeSniffer.php:847 Stack trace:
#0 vendor/squizlabs/php_codesniffer/CodeSniffer.php(587): PHP_CodeSniffer->_expandRulesetReference(Object(SimpleXMLElement), '/Users/paul/Sit...', 0)
#1 vendor/squizlabs/php_codesniffer/CodeSniffer.php(435): PHP_CodeSniffer->processRuleset('/Users/paul/Sit...')

Instructions how to integrate with PHPStorm to run besides the default code sniffer.

Magento 2's default code sniffer is ran from here: $PROJECT/dev/tests/static/testsuite/Magento/Test/Php/_files/phpcs

Is this code sniffer meant to replace Magento's code sniffer or is it complementary? I understand they both offer a different purpose, but I see a lot of smart checks that are helpful during development.

We have executed the below command,

phpcs --standard=MEQP1 module/

But throw below errors:

PHP Fatal error: Interface 'PHP_CodeSniffer\Sniffs\Sniff' not found in /var/www/marketplace-eqp-master/MEQP1/Sniffs/Classes/Mysql4Sniff.php on line 15

How to resolve this issue.

Magento 2 have very much classes with protected class members that should be overridden in extension's child classes. Therefor there is no sense to show this message for inherited from Magento-namespace classes, because developers can't change his access-visibility.

Therefor it would be great to have some command line option to disable this warning for inherited from magento properties and functions.

I don't know if this coding standard was ever intended for it (the naming marketplace-eqp suggests it though), but with the current configuration it is not useful to preview the Magento Marketplace technical review.

The technical review mostly uses the Code Validation Guidelines with some undocumented additions. The current rulesets for MEQP1 and MEQP2 do not define the severity or change the rules/sniffs that would block the technical review from passing to the error type.

I guess developers using any kind of CI to automatically perform static code analysis would appreciate to have the possibility to let their builds fail, if they would not pass the Marketplace technical review.

The coding standard MEQP1 disallows short array syntax and the MEQP2 disallows long array syntax. While I perfectly understand this decision for the sake of consistency with the core code, it leads to a number of violations when using the shared libraries approach.

Shared libraries, that is delivering platform specific code to hook into one or the other major Magento version, accompanied by framework independent code (the library) that provides functionality for reuse in both, M1 and M2.

Fabian Schmengler / integer_net

To overcome the current situation where the library cannot comply to the rules of both major versions, I suggest enforcing short array syntax in MEQP2 and accepting both in MEQP1 (i.e. remove the rule in question).

After I run composer require magento/marketplace-eqp I get error:

[InvalidArgumentException]
  Could not find package magento/marketplace-eqp at any version for your mi
  nimum-stability (alpha). Check the package spelling or your minimum-stabi
  lity

Prerequisites

Marketplace EQP 1.0.5

Steps to reproduce

1. Create a plugin on a controller with the path to the plugin involving the substring Controller somewhere.
2. On the beforeExecute/afterExecute/aroundExecute function, see that you receive the following erroneous code sniff: The use of public non-interface method in ACTION is discouraged. Example: https://www.screencast.com/t/Dcw3DdM0R

Workaround

Create the plugin without using the word "Controller" in the file or folder structure.

Analysis

Seems to be due to PublicNonInterfaceMethodsSniff::foundInAction looking for the substring "Controller" in the file path to determine if a class is a controller.

Possible solution

Possibly also look for the phrase "public function execute(" or something similar to determine if a file is indeed a controller action? And/or check that the file's structure is specifically <module top level folder>/Controller, rather than looking for Controller anywhere?

Not sure if either of these solutions are possible or desired.

Hello, I found not logic rule. https://github.com/magento/marketplace-eqp/blob/develop/MEQP2/Sniffs/PHP/ProtectedClassMemberSniff.php Comment in line 13 says "Detects possible usage of 'private' scope modifiers.", and whole class detecting 'protected'. To fast fix: change return [T_PROTECTED]; to return [T_PRIVATE]; in line 32. And protected $warningCode = 'FoundProtected'; to protected $warningCode = 'FoundPrivate';

Same on Russian: Похоже что произошла ошибка, PHPCS с стилем MEQP2 говорит мне что protected переменные не желательны. А судя по комменту в коде детектора, должно искать private, а не protected.

Fixed file: ProtectedClassMemberSniff.php.txt

I've got an install script that creates a CMS page like this:

$page = $this->pageFactory->create();
$page->setIsActive(true);
$page->setTitle('Error');
$page->setPageLayout('1column');
$page->setContentHeading('Something went wrong');
$page->setContent('<p>It looks like something went wrong while handling your request. More details:</p>');
$page = $this->pageRepository->save($page);

This triggers the "Possible slow SQL method" sniff because the word "like" is in my query.

I'm getting the following error even when using Mage::getSingleton('core/date').

Even if I use it directly I also get the error.

The sniffer Sniffs/Stdlib/DateTimeSniff.php doesn't check if the date method in use belongs to core/date Singleton class.

Fatal error: Trait 'MEQP\Utils\Helper' not found in ~/.composer/vendor/magento-ecg/coding-standard/MEQP1/Sniffs/Classes/ResourceModelSniff.php on line 22.

Occurs when I run: phpcs --standard=MEQP1 /path-to-magento

The loop performance error MEQP1.Performance.Loop.ArraySize should not trigger when the variable that count() is being called on is declared inside that same loop. For example:

foreach ($productIds as $productId) {
    $images = getImages($productId);
    echo count($images) . "\n";
}

In this case, it isn't possible to call count() outside the loop, and therefore the warning is invalid.