Hello,

I've been playing with many concurrent clients calling a server so that it rebroadcasts the sent message to other clients. However, the sad news is that it appears I'm losing almost 20%-30% of those messages when I have 5 or more concurrent connections.

A simple test case is as follow:

server.php

$i = 0;
$j = 0;
$k = 0;

$websocket = new Hoa\Websocket\Server(
    new Hoa\Socket\Server('tcp://127.0.0.1:8889')
);
$websocket->on('open', function (Hoa\Core\Event\Bucket $bucket) use (&$i) {
    echo 'connection ' . ++$i . PHP_EOL;
});
$websocket->on('message', function (Hoa\Core\Event\Bucket $bucket) use (&$j) {
    echo 'message ' .++$j.PHP_EOL;
});
$websocket->on('close', function (Hoa\Core\Event\Bucket $bucket) use (&$k) {
    echo 'connection closed ' . ++$k . PHP_EOL;
});
$websocket->run();

client.php

$client   = new Hoa\Websocket\Client(
    new Hoa\Socket\Client('tcp://127.0.0.1:8889')
);
$client->setHost('test');
$client->connect();

$client->send('HELLO WORLD');

test command

ab -n 500 -c 5 -B 127.0.0.1 http://localhost/client.php

Here's what I see at the end of a run:

connection 500
message 372
connection closed 369

What I'd expect:

connection 500
message 500
connection closed 500

I haven't investigated yet as to what the issue is, but considering that all connection are properly made, something occurs between the time the connection is made and the time a message is supposed to be sent. It is also interesting to note that many connections aren't closed as well, which doesn't sound good.

Tested different concurrency levels:

| Concurrency | messages retransmitted/connections | messages delivered overall | | --- | --- | --- | | 1 | 500/500 | 100% | | 2 | 464/500 | 93% | | 3 | 433/500 | 87% | | 4 | 398/500 | 80% | | 5 | 362/500 | 72% | | 500 | 250/500 | 50% |

Edit 1: After some more testing and playing around, it seems very critical for the client code to call $client->close();. Doing so increases the rate of message delivered to almost 100% (but not 100%).

Suggested: Implement the __destruct method in Clients classes so that they may close their connection cleanly (if the user didn't call close() himself).

Furthermore, it appears that the connections that do not end up triggering a close event are actually triggering an error event. It has to do with the fact that we try to write to a socket that has been closed.

I'm trying to send big arrays filled with floats to Hoa\WebSocket\Server. I wrote a client for testing purposes : https://squadclient-html5-etiennewan-1.c9.io/test.html

There is no problem with little arrays (with a length of 1, 10 or an hundred items) When sending bigger arrays, the WebSocket connection closes unexpectedly without errors server-side and with this reason sent to the client : "Get rsv1: 0, rsv2: 1, rsv3: 0, they all must be equal to 0" with one or more rsv equal to 1.

Here is the PHP server code (as simple as codes in examples):

<?php
require_once 'vendor/autoload.php';

$server = new Hoa\Websocket\Server(
    new Hoa\Socket\Server('tcp://'.$argv[1].':'.$argv[2])
);

$server->on('message', function (Hoa\Core\Event\Bucket $bucket) {
    $data = $bucket->getData();

    $received = count(explode(",", $data['message']))-1;

    echo $received, PHP_EOL;

    $source = $bucket->getSource();

    $source->send($received);

    return;
});

$server ->on('open', function (){
    echo 'new client connection', PHP_EOL;

});

echo "Server is starting", PHP_EOL;
$server->run();

Note : the client and server are hosted on Cloud9 and will be running for debugging purposes. A live-debugging sessions is possible on the server workspace. Please tell me if you want to have access to it.

Addendum: The size of the array needed to reproduce the error can vary, but 800 seems to be the minimum sometimes. Here, I only work with normal arrays, but it seemed to happened more often with typed arrays (I was trying to send Float32Array (1024 items) when the error occured for the first time)

I have an application with a Hoa WebSocket Server. When I connect my laptop to internet through my Android phone (tethering), i can open a connection... but no more.

When I go to http://www.websocket.org/echo.html (with same network configuration), all is working.

Do you think it could be a little problem in Hoa\WebSocket ?

Hello !

Here the PR about the implementation of hoaproject/Socket#27 in the websocket project.

I tried to make it clean :

• Must use WebsocketSocket instead of just Socket to avoid Socket name reusing (due to Hoa\Socket\Socket flexion) ;
• Retrieve endPoint from the socket if it is not given to Websocket\Client constructor ;
• Add the factories to Websocket\Connection.

But I have a problem about factories loading... They are defined in the Websocket lib so if I construct a Socket\Client before using Websocket\Client the factories are not yet loaded...

Examples :

<?php
$connection = new Socket\Client('wss://0.0.0.0/a/path');
// Here the transport wrappers are not yet registered because classes are loaded
// only at first use
$client = new Websocket\Client($connection);
// They are defined here but too late, I already get a "wss transport does not exists" exception

<?php
// That way it works because PHP parser encounter the `Websocket\Client` token
// before the `Socket\Client`
$client = new Websocket\Client(
    new Socket\Client('wss://0.0.0.0/a/path')
);

For me there is 3 approachs to use here :

• Create an extension of Socket\Client and use it instead of the root class to enable and use the wrappers properly ;
• Change the register approach (I haven't idea here) ;
• Create a factory for the Websocket\Client which handle Socket\Client creation.

I think it's not really valid because sometimes the code will works, sometimes not because of instruction order...

I haven't added tests for the moment because we need to validate the approach before...

Hello,

I'm currently trying to implement slack bot stuff using PHP. I found that there is an awesome Real Time Messaging API which using websockets (https://api.slack.com/rtm).

I tried to implement a method which can follow the given steps :

• call : https://api.slack.com/methods/rtm.start
• extract the websocket URL (key url in the JSON)
• connect to the websocket
• broadcast message

I found that Hoaproject as an awesome WebSocket client/server but I can't find a way to do that...

A websocket URL given by Slack API (they have a lifetime of 30sec): wss://ms177.slack-msgs.com/websocket/GEjhTU7tHl3C90SwJuKaF71Orb8F9HZgdv-HIwf4HxIMygveAW9xc2X_bZb_LtDXLVAapy7nTJ7qh9Oz0zYnyrr7Gn2kD4635oihxNh3ZTM=.

Here the code I used to do that :

<?php
require_once __DIR__.'/vendor/autoload.php';

$rtmStart = "https://slack.com/api/rtm.start?token=".$argv[1];
$content = json_decode(file_get_contents($rtmStart));

$client = new Hoa\Websocket\Client( new Hoa\Socket\Client($url) );
$client->connect();

$client->send('{
     "type": "message",
     "channel": "XXX",
     "user": "XXX",
     "text": "Hello world",
     "ts": "'.microtime(true).'"
}');

$client->close();

Thanks :)

Previously the constructors must be called with an instance of Socket\Client or Socket\Server as the first parameter.

This PR allow the constructors to build the valid instance from a string.

Added: type check + doc update

hoaproject/Websocket 2.15.08.05

I have setup a small websocket server which only dispatches message to all other connected clients. I use client code available @ http://hoa-project.net/En/Awecode/Websocket.html to connect to the server with ab: ab -c 50 -n 500 http://localhost/client-push.php.

However, it appears that as soon as I do that, the websocket server crashes with the following error:

PHP Fatal error: Call to a member function send() on null in /site/vendor/hoa/websocket/Connection.php on line 508 PHP Stack trace: PHP 1. {main}() /site/API/X/Server.php:0 PHP 2. NAMESPACE\Server::run() /site/API/X/Server.php:11 PHP 3. Hoa\Socket\Connection\Handler->run() /site/src/Z/Y/X/Server.php:16 PHP 4. Hoa\Websocket\Connection->_run() /site/vendor/hoa/socket/Connection/Handler.php:186 PHP 5. Hoa\Core\Event\Listener->fire() /site/vendor/hoa/websocket/Connection.php:310 PHP 6. Hoa\Core\Consistency\Xcallable->__invoke() /site/vendor/hoa/core/Event.php:524 PHP 7. call_user_func_array:{/site/vendor/hoa/core/Consistency.php:762}() /site/vendor/hoa/core/Consistency.php:762 PHP 8. NAMESPACE\Server::NAMESPACE{closure}() /site/vendor/hoa/core/Consistency.php:762 PHP 9. Hoa\Socket\Connection\Handler->broadcast() /site/src/Z/Y/X/Server.php:14 PHP 10. call_user_func_array:{/site/vendor/hoa/socket/Connection/Handler.php:288}() /site/vendor/hoa/socket/Connection/Handler.php:288 PHP 11. Hoa\Socket\Connection\Handler->broadcastIf() /site/vendor/hoa/socket/Connection/Handler.php:288 PHP 12. call_user_func_array:{/site/vendor/hoa/socket/Connection/Handler.php:323}() /site/vendor/hoa/socket/Connection/Handler.php:323 PHP 13. Hoa\Websocket\Connection->send() /site/vendor/hoa/socket/Connection/Handler.php:323 PHP 14. Hoa\Socket\Connection\Handler->Hoa\Socket\Connection{closure}() /site/vendor/hoa/websocket/Connection.php:534 PHP 15. call_user_func_array:{/site/vendor/hoa/socket/Connection/Handler.php:257}() /site/vendor/hoa/socket/Connection/Handler.php:257 PHP 16. Hoa\Websocket\Connection->Hoa\Websocket{closure}() /site/vendor/hoa/socket/Connection/Handler.php:257

Note that if I run ab without concurrency, the server does not crash.

Thanks by the way for this awesome library :)

Will fix #41.

1. People are likely to use ws:// or wss:// directly. They don't understand that we must use a tcp:// URL. I can't blame them. HTTP Upgrade is just… confusing.
2. Moreover, there is a need for automatic encryption, because with wss://, we need to instanciate a Hoa\Socket\Client object with tcp://…:443 and then call enableEncryption. Most of the time with ENCRYPTION_TLS (maybe with SSLv2 or SSLv3 sometimes, how to know?).
3. In addition, we have to deal with URL endpoint (in the Websocket client).

So, yup, this is more like a factory. The same way we have Hoa\Socket\Socket to parse tcp:// and udp:// URL, maybe we can extend it to support ws:// and wss://. It could be great to have an enhanced Hoa\Socket\Socket object where we could be able to register new schemes (like ws:// or wss://) in order to automatically transform a string into a real Hoa\Socket\Socket valid object (with a real tcp:// or udp:// URL). So it requires a little bit of work on Hoa\Socket.

Here is the work I propose:

1. On Hoa\Socket\Socket:
   1. Introduce a “socket wrapper” interface that declares a factory to transform a URL into a valid Hoa\Socket\Socket object (or a child of),
   2. Introduce the registerWrapper and unregisterWrapper static methods that take a “socket wrapper” interface as an argument,
   3. Declare tcp:// and udp:// as socket wrappers.
2. On Hoa\Socket\Connection:
   1. In the setSocket method, we receive a URL; we then have to find and apply the appropriated stream wrapper to get a valid Hoa\Socket\Socket object (or a child of).
3. On Hoa\Websocket\Connection:
   1. We must create Hoa\Websocket\Socket (the “socket wrapper”) that extends Hoa\Socket\Socket,
   2. We must declare the “socket wrapper” ws:// and wss://.

When executing:

new Hoa\Websocket\Client(
    new Hoa\Socket\Client('ws://…')
)

What is going to happen? The ws:// and wss:// URLs are going to be transform into a Hoa\Websocket\Socket object because Hoa\Socket\Client is extending Hoa\Socket\Connection\Connection. This latter will call the setSocket method: It will look for a valid “socket wrapper”, execute it and a valid Hoa\Websocket\Socket will be created. It will be used by Hoa\Websocket\Client very smootly thanks to inheritance, but we will have more information on it, such as: Should it be encrypted? for instance (in the Hoa\Websocket\Client, we would just need to call $connection->getSocket()->isSecure() for instance). Finally, we will have to act accordingly.

Well, that's easier that what I thought!

Finally: We will have to update the documentation.

Hi,

When i try to Use the broadcast() function on a close event in the server, if a client disconnect himself, the first remaining connected client gets disconnected and he's the only one to receive the broadcast message . Others don't receive anything.

$websocket->on('close', function ( Hoa\Core\Event\Bucket $bucket )  {
    echo "connection closed\n";
    $bucket->getSource()->broadcast("A client disconnect himself from server"));
    return;
});

To understand, here's an example :

• Client 1 connect himself to server
• Client 2 connect himself to server
• Client 3 connect himself to server
• Client 1 disconnect himself from server
• Client 2 receive message "A client disconnect from server" , and immediatly get disconnected from server
• Client 3 doesn't get any message and is still connected

Firing the close event before closing allows for the user to grab the connection's unique ID. This is useful if the user is keeping track of connection based states across the lifecycle of a connection (e.g. session data).

Fire the event on a protocol error as well before closing.

Injecting data at the WebSocket/Node object

Hello, I try including this library at my project in Laravel. In this moment I can manage the running of server from Laravel using Artisan command, but I need vinculate one or some nodes for each client, when the client connect at the system.

Other things what I need is configure the listeners on one abstract class, but inside the server connection, while it is running. For example, I need create one class calling HoaWebSocket, and I can configure for example, this:

class HoaWebSocket extend [hoa way point class] {
    ...
    public function onOpen($node, $user) {
        //Assing one node at one user.
    }

    public function send($message, $user) {
        //Send one message at one node.
    }
    ...
}

This is a fictitious idea, is only for comment the flow with I need.

In this moment, I can send the system message at our user using this method

use Hoa\Websocket\Client as WsClient;
use Hoa\Socket\Client as SClient;
...
    public function getLogin()
    {
        $client = new WsClient(
            new SClient('tcp://127.0.0.1:8080')
        );
        $client->connect();
        $client->send('Login rendered');
        $client->close();

        return view('auth.login');
    }
...

And the idea final is it:

use HoaWebSocket;
...
    public function getLogin()
    {
        HoaWebSocket::send('Login rendered', User::findById(1));
        return view('auth.login');
    }
...

But, doing this action without Hoa\Websocket\Client and/or Hoa\Socket\Client.

Thanks

YnievesDotNet

Console: WebSocket connection to 'ws://127.0.0.1:8889/' failed, WebSocket is already in CLOSING or CLOSED state I'm using Google Chrome(90.0.4430.212) 64bits

Dependabot Preview will be shut down on August 3rd, 2021. In order to keep getting Dependabot updates, please merge this PR and migrate to GitHub-native Dependabot before then.

Dependabot has been fully integrated into GitHub, so you no longer have to install and manage a separate app. This pull request migrates your configuration from Dependabot.com to a config file, using the new syntax. When merged, we'll swap out dependabot-preview (me) for a new dependabot app, and you'll be all set!

With this change, you'll now use the Dependabot page in GitHub, rather than the Dependabot dashboard, to monitor your version updates, and you'll configure Dependabot through the new config file rather than a UI.

If you've got any questions or feedback for us, please let us know by creating an issue in the dependabot/dependabot-core repository.

Learn more about migrating to GitHub-native Dependabot

Please note that regular @dependabot commands do not work on this pull request.

Dependabot can't resolve your PHP dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Your requirements could not be resolved to an installable set of packages.
  Problem 1
    - Root composer.json requires hoa/socket dev-master -> satisfiable by hoa/socket[dev-master].
    - hoa/socket dev-master requires hoa/stream dev-master -> found hoa/stream[dev-master, 1.x-dev (alias of dev-master)] but it does not match your minimum-stability.
  Problem 2
    - Root composer.json requires hoa/http dev-master -> satisfiable by hoa/http[dev-master].
    - hoa/http dev-master requires hoa/stream dev-master -> found hoa/stream[dev-master, 1.x-dev (alias of dev-master)] but it does not match your minimum-stability.
  Problem 3
    - Root composer.json requires hoa/test dev-master -> satisfiable by hoa/test[dev-master].
    - hoa/test dev-master requires hoa/cli dev-master -> found hoa/cli[dev-master, 3.x-dev (alias of dev-master)] but it does not match your minimum-stability.

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

View the update logs.

Hello!

I'm working on a project that manages Quizzs. For this project, I need to send message to specific users that are stored in different rooms. One room is made of two users. Each time one user sends a message to the WebSocket server, the server needs to send a message to both users in the room.

The beginning of my code looks like that:

$rooms = [];

$server = new Hoa\Socket\Server('ws://127.0.0.1:8080');
$websocket = new Hoa\Websocket\Server($server);

$websocket->getConnection()->setNodeName(QuizzDuoNode::class);

$websocket->on('open', function (Hoa\Event\Bucket $bucket) {
    echo 'new connection', "\n";
    
    return;
});

And If I simplify my code, it looks something like this:

$websocket->on('message', function (Hoa\Event\Bucket $bucket) {
    global $rooms;
    global $server;

    $data = $bucket->getData();
    $msgInfo = json_decode($data['message'], true);
    $node = $bucket->getSource()->getConnection()->getCurrentNode();
    $node->setId($msgInfo['id']);

    $nodes = $server->getNodes();

    foreach ($rooms as $room) {
        foreach($nodes as $userNode) {
            if ($userNode->getId() === $room["user1"]) {
                $userNode->send(... speficic message for user1...);
            } else if ($userNode->getId() === $room["user2"]) {
                $userNode->send(... specific message for user2...);
            }
        }
    }
    

    return;
});

But If I try to use the send() method with a customized node, I get an error message saying that this method doesn't exist in QuizzDuoNode, which is true. The send method is not inherited from the Hoa\Websocket\Node, and I cannot find anything related to this in the documentation.

My problem

I cannot find anything in the documentation that would allow me to send a message to a specific user and I don't know how to do that.

PHP Fatal error: Uncaught Hoa\Socket\Server::select(): (3) Operation timed out (nothing to accept). in /usr/local/nginx/html/websocket/vendor/hoa/socket/Server.php at line 337. thrown in /usr/local/nginx/html/websocket/vendor/hoa/socket/Server.php on line 337

Error: fwrite(): SSL operation failed with code 1. OpenSSL Error messages: error:140D00CF:SSL routines:SSL_write:protocol is shutdown

Always. a simple refresh and the server crash.