Why does PelEntryWindowsString support only Latin-1 character set? Windows surely supports other ASCII character sets in file properties dialog (particularly, russian: Windows-1251).

A long time standing bug https://sourceforge.net/p/pel/mailman/message/26706741/

This case seems due to wrong data setup in the test image: the INTEROPERABILITY IFD has inside it a pointer to another INTEROPERABILITY IFD. But this is incorrect - we expect only one INTEROPERABILITY IFD in an image file. This leads to an infinite loop.

This PR addresses this by passing the parent IFD type to the load method, so that it can check it's not duplicating IFDs of the same type.

I was thinking for a while about this, then also found this in the TODO:

• Restructure information about tags. Currently information about the tags are stored in several places around the code, making updates difficult. All information about a tag should be stored at one place, maybe by having a class per tag (how well does PHP handle 142 small classes?).

  The information in question is:

  • hex code,
  • title,
  • name,
  • description
  • format,
  • components,
  • valid IFD types,
  • how to load data,
  • how to display (the getText() method)

ua-parser/uap-php manages something like this - it has a big list of regex patterns that are stored in a YAML file; to reduce I/O and processing, the YAML file is compiled into a PHP equivalent and then included in code as needed.

This would mean a BC change, so I this is a for a new major version of PEL.

Just wanted to test the waters if any feedback. Next steps if there is interest could be to start defining a YAML model to store the info needed.

This PR is my first attempt of parsing canon's maker notes. The results look good so far. Beside FocalLength, which is overwritten by the maker notes and has an other format. Only first level elements are taken into account. E.g. tag 0x0001 (Exif.Canon.CameraSettings) is not parsed yet.

Would be great if anyone else could test and have a look at my code if it is ok :) As soon as this one gets (hopefully) merged, I'd have a look at nikon's maker notes.

Added new reverse lookup methods: getExifTagByName() and getGpsTagByName(). There is no way to tell what type of tag was returned by the getTagByName, making it unusable. I suggest deprecating getTagByName() as soon as possible, will delete it from branch if you confirm this. Fixed inconsistent PHPDOC parameter types for PelTag enumerations, which were erroneously referring to PelTag type. Every method that use tag wants int as an argument, not a PelTag instance. Also, PelEntry and PelEntryException use int as their $tag property, not PelEntry instance.

Needed a reverse lookup of the tag short name to the tag value, so had to rework how it is handled. Stored tags into arrays, tag as a key, value as a string.

I am not using PEL in any of my own projects, and haven't been for a while. Therefore, the project needs a new maintainer, which actually maintains the code. Are you up for it?

PelFormat::getSize can also return non-numeric values (string, in case of an error). We should handle those cases correctly.

In my case, this is the warning I see (only the relevant backtrace is shown here).

Warning: A non-numeric value encountered in lsolesen\pel\PelIfd->loadSingleValue() (line 447 of /var/www/.../vendor/lsolesen/pel/src/PelIfd.php) #0 /var/www/.../web/core/includes/bootstrap.inc(600): _drupal_error_handler_real(2, 'A non-numeric v...', '/var/www/...', 447, Array)
#1 /var/www/.../vendor/lsolesen/pel/src/PelIfd.php(447): _drupal_error_handler(2, 'A non-numeric v...', '/var/www/...', 447, Array)
#2 /var/www/.../vendor/lsolesen/pel/src/PelCanonMakerNotes.php(215): lsolesen\pel\PelIfd->loadSingleValue(Object(lsolesen\pel\PelDataWindow), 4908, 71, 19200)
#3 /var/www/.../vendor/lsolesen/pel/src/PelIfd.php(406): lsolesen\pel\PelCanonMakerNotes->load()
#4 /var/www/.../vendor/lsolesen/pel/src/PelTiff.php(159): lsolesen\pel\PelIfd->load(Object(lsolesen\pel\PelDataWindow), 10)
#5 /var/www/.../vendor/lsolesen/pel/src/PelExif.php(108): lsolesen\pel\PelTiff->load(Object(lsolesen\pel\PelDataWindow))
#6 /var/www/.../vendor/lsolesen/pel/src/PelJpeg.php(216): lsolesen\pel\PelExif->load(Object(lsolesen\pel\PelDataWindow))
#7 /var/www/.../vendor/lsolesen/pel/src/PelJpeg.php(286): lsolesen\pel\PelJpeg->load(Object(lsolesen\pel\PelDataWindow))
#8 /var/www/.../vendor/lsolesen/pel/src/PelJpeg.php(123): lsolesen\pel\PelJpeg->loadFile('public://photos...')

Since PHP 5.4, the array syntax changed from array() to [].

This PR is changing the old syntax to the new syntax. Used the script @ https://github.com/thomasbachem/php-short-array-syntax-converter.

The pel/pel package on Packagist refers to another project, and the badge on the readme is wrong. So it looks like in composer you still need to require lsolesel/pel.

Also, the badge linking to Scrutinizer leads to a 404 page.

Bug created from sourceforge

require_once('PelJpeg.php'); 
$jpeg = new PelJpeg($tmpfile); 
$exif = $jpeg->getExif(); 
if ( $exif != null ) { 
    $jpeg1 = new PelJpeg($bigfile); 
    $jpeg1->setExif( $exif); 
    file_put_contents($bigfile, $jpeg1->getBytes()); 
}

A test case has been created

Since 0.9.12, there have been several commits, with fixes and PHP 8.2 compatibility changes.

@weberhofer can we have a new release?

Right now testing on PHP 8.2 with 0.9.12 fails with Creation of dynamic property lsolesen\pel\PelCanonMakerNotes::$size is deprecated, which was fixed in bb3e02327f93c15ccf09ad4f9898214c5bf58a28

Another issue that surfaced from drupal file_mdm module (https://www.drupal.org/project/file_mdm/issues/3229460).

Error is caused by: https://cp8.wirtschaftsverlag.at/sites/contentpool/files/public/2020-05/196981_geberit_ausstellung.jpg

Slightly offtopic: I'm also wondering since we're seeing a few of pel issues - does anyone know a way of how to fix image exif metadata on filesystem directly? other error: Message: Unknown format: 0x300

Hi, are there plans to add webp image type support ? It doesn't look too complicated if you consider this answer on StackOverflow : https://stackoverflow.com/a/70230480/10294357 Thank you for the good work so far, I've been using PEL for years ;)

I cannot for the life of me find a way to extract the document name:

<?php
use lsolesen\pel\PelJpeg;
use lsolesen\pel\PelTag;

$jpeg=new PelJpeg('samplepic-doctitle.jpg');
$exif=$jpeg->getExif();
$tiff=$exif->getTiff();
$ifd=$tiff->getIfd();
print_r($ifd->getEntry( PelTag::DOCUMENT_NAME));

I see the name, though, if I check with GNOME's file manager or other apps:

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to increase the usage of combined operators accordingly.

diff --git a/src/PelEntrySShort.php b/src/PelEntrySShort.php
index 94f0f3d..b65fa44 100644
--- a/src/PelEntrySShort.php
+++ b/src/PelEntrySShort.php
@@ -793,7 +793,7 @@ class PelEntrySShort extends PelEntryNumber
             $val = $this->value[0];
             if ($this->ifd_type === PelIfd::CANON_CAMERA_SETTINGS && $this->tag === PelTag::CANON_CS_LENS_TYPE) {
                 // special handling: lens types must be multtiplied by 100 because digits canÄt be used in arrays
-                $val = $val * 100;
+                $val *= 100;
             }
             if (array_key_exists($val, self::TRANSLATIONS[$this->ifd_type][$this->tag])) {
                 return Pel::tra(self::TRANSLATIONS[$this->ifd_type][$this->tag][$val]);
diff --git a/src/PelEntryTime.php b/src/PelEntryTime.php
index 5275d68..ae3116e 100644
--- a/src/PelEntryTime.php
+++ b/src/PelEntryTime.php
@@ -270,9 +270,9 @@ class PelEntryTime extends PelEntryAscii
 
         $l = $jd + 68569;
         $n = floor((4 * $l) / 146097);
-        $l = $l - floor((146097 * $n + 3) / 4);
+        $l -= floor((146097 * $n + 3) / 4);
         $i = floor((4000 * ($l + 1)) / 1461001);
-        $l = $l - floor((1461 * $i) / 4) + 31;
+        $l -= floor((1461 * $i) / 4) - 31;
         $j = floor((80 * $l) / 2447);
         $d = $l - floor((2447 * $j) / 80);
         $l = floor($j / 11);