Dear developer,

Can you please make sure packagist is also getting updated with the latest versions? I now need to add this repository to my composer.json in order to install the Magento 2.3 compatible version.

Preconditions

1. Mutli-website instance of Magento 2
2. Install Avs_ScopeHint2 module

Steps to reproduce

1. Create a textarea configuration field
2. Set a JavaScript script inside the configuration in a website or store view
3. Save the configuration
4. Inspect source code of the configuration page

Expected result

1. The script tag is not interpreted in the page

Actual result

1. The script tag is interpreted when the page is loaded because of the tooltip

Configuration field:

DOM:

As you can see, the script tag set in the textarea field is interpreted in the DOM.

Thank you for your help.

Check for array, and implode if so

Alternative would be to write code for the tier price attribute and retrieve 1 of the array values and show that

Possible fix for #13 13

Hi,

I do not know what the root cause is of this issue, but whenever I click on the "schedule new update" button, I am facing the message: "A technical problem with the server created an error. Try again to continue what you were doing. If the problem persists, try again later.".

This is the stacktrace I have found in my log file:

Fatal error: Uncaught Error: Call to a member function getId() on null in /app/vendor/avstudnitz/scopehint2/Plugin/ProductEavDataProviderPlugin.php:61 Stack trace: #0 /app/vendor/magento/framework/Interception/Interceptor.php(146): AvS\ScopeHint\Plugin\ProductEavDataProviderPlugin->afterSetupAttributeMeta(Object(Magento\CatalogStaging\Ui\DataProvider\Product\Form\Modifier\Eav\Interceptor), Array, Object(Magento\Catalog\Model\ResourceModel\Eav\Attribute\Interceptor), 'product-details', 0) #1 /app/vendor/magento/framework/Interception/Interceptor.php(153): Magento\CatalogStaging\Ui\DataProvider\Product\Form\Modifier\Eav\Interceptor->Magento\Framework\Interception{closure}(Object(Magento\Catalog\Model\ResourceModel\Eav\Attribute\Interceptor), 'product-details', 0) #2 /app/generated/code/Magento/CatalogStaging/Ui/DataProvider/Product/Form/Modifier/Eav/Interceptor.php(78): Magento\CatalogStaging\Ui\DataProvider\Product\Form\Modifier\Eav\Interceptor->___callPlugins('setupAttributeM...', Array, Array) #3 /app/vendor/magento/mod in /app/vendor/avstudnitz/scopehint2/Plugin/ProductEavDataProviderPlugin.php on line 61.

The issue is solved if I change this code:

if ($product->getId() === null) {
    return $result;
}

to:

if ($product === null || $product->getId() === null) {
    return $result;
}

I don't have a clue why the registry sometimes returns a null value for "current_product".

Can you help me out?

…esent it as json data. This fixes crashing the product edit page when using different tier prices over multiple websites for example.

This fixes https://github.com/avstudnitz/AvS_ScopeHint2/issues/13 and is a replacement for another proposed PR: https://github.com/avstudnitz/AvS_ScopeHint2/pull/15

Steps to reproduce the original reported problem:

• Setup a vanilla Magento installation (tested both on 2.1.16 and 2.3.2)
• Install avstudnitz/scopehint2 v1.1.1
• In the configuration, go to Catalog > Catalog > Price
• Change 'Catalog Price Scope' to 'Website'
• Go to Stores > All Stores and make sure you have a least 2 websites, stores & store views
• Create a new product, assign it to all the websites and setup tier prices (under 'Advanced Pricing')
• Switch to the other storeview scope associated with the second website
• Setup different tier prices on that scope
• See the page crashing without this fix

The reason why it crashes, is because the tier prices are returned as an array instead of the expected string. We've seen a similar problem with a third party module, which also returns an array, but a multi dimensional one. The original attempt to fix this tried to implode the value if it was an array, but that won't work on a multi dimensional array.

This PR attempt to fix all of these possible scenario's.

I've chosen a slightly different approach here, because I think there might be more than only array types not being able to get casted to a string. Here I'm trying to cast the value to a string in a try-catch statement, if this fails, the \Throwable will get catched and the error won't appear on the frontend. If this happens, I'm trying to json_encode the value, to get a string representation of the value. If that still fails, we silently ignore the problem and won't output anything.

In the case of the tier prices problem, there is another bug in that the tooltip doesn't show up for some reason. I haven't looked why that that happens yet, but that should be considered a different bug. This PR is trying make the product edit page more stable, I prefer to have it not crashing over showing the correct tooltip. Fixing the tooltip can be done at a later stage in my opinion.

If there are remarks, let me know! 🙂

Dear Herr Studnitz,

While developing a web store using your handy plugin I discovered a game-breaking bug.

Bug The bug in question would throw an exception when I wanted to add a new product to the catalog. Upon closer inspection I discovered that your plugin always assumes that a product is found before it runs a certain foreach() loop. But if I were to make a new product then no product is found and an exception is thrown.

Solution As a solution I've implemented a tiny if() statement that checks whether or not the $product variable has an id. If it doesn't then the $result is returned. This means that the foreach() loop needing product information is not run and the exception is not thrown. Of course, when an id has been found then it resumes operation like you intended.

This small solution works on my store as expected. I hope that you will find my solution useful. If you have any questions, feedback or other remarks please feel free to contact me.

Kind regards, Daniël Riezebos

Support products for scope hints. Work in progress based on work by @peterjaap but with better performance.

• EAV tooltip doesn't support html, this needs to be fixed.
• When switching to a store view it compares those values against all other stores.

I think this issue arised because of the latest update?

[2022-11-02T10:16:51.485009+00:00] main.CRITICAL: Exception: Notice: Array to string conversion in /public_html/vendor/avstudnitz/scopehint2/Plugin/ConfigFieldPlugin.php on line 138 in /public_html/vendor/magento/framework/App/ErrorHandler.php:62 Stack trace: #0 /public_html/vendor/avstudnitz/scopehint2/Plugin/ConfigFieldPlugin.php(138): Magento\Framework\App\ErrorHandler->handler() #1 /public_html/vendor/avstudnitz/scopehint2/Plugin/ConfigFieldPlugin.php(67): AvS\ScopeHint\Plugin\ConfigFieldPlugin->getScopeHint() #2 /public_html/vendor/magento/framework/Interception/Interceptor.php(146): AvS\ScopeHint\Plugin\ConfigFieldPlugin->afterGetTooltip() #3 /public_html/vendor/magento/framework/Interception/Interceptor.php(153): Magento\Config\Model\Config\Structure\Element\Field\Interceptor->Magento\Framework\Interception{closure}() #4 /public_html/generated/code/Magento/Config/Model/Config/Structure/Element/Field/Interceptor.php(32): Magento\Config\Model\Config\Structure\Element\Field\Interceptor->___callPlugins() #5 /public_html/vendor/magento/module-config/Block/System/Config/Form.php(369): Magento\Config\Model\Config\Structure\Element\Field\Interceptor->getTooltip() #6 /public_html/vendor/magento/module-config/Block/System/Config/Form.php(316): Magento\Config\Block\System\Config\Form->_initElement() #7 /public_html/vendor/magento/module-config/Block/System/Config/Form.php(256): Magento\Config\Block\System\Config\Form->initFields() #8 /public_html/vendor/magento/module-config/Block/System/Config/Form.php(202): Magento\Config\Block\System\Config\Form->_initGroup() #9 /public_html/vendor/magento/module-config/Block/System/Config/Form.php(542): Magento\Config\Block\System\Config\Form->initForm() #10 /public_html/vendor/magento/framework/View/Element/AbstractBlock.php(1094): Magento\Config\Block\System\Config\Form->_beforeToHtml() #11 /public_html/vendor/magento/framework/View/Element/AbstractBlock.php(1099): Magento\Framework\View\Element\AbstractBlock->Magento\Framework\View\Element{closure}() #12 /public_html/vendor/magento/framework/View/Element/AbstractBlock.php(660): Magento\Framework\View\Element\AbstractBlock->_loadCache() #13 /public_html/vendor/magento/framework/View/Layout.php(578): Magento\Framework\View\Element\AbstractBlock->toHtml() #14 /public_html/vendor/magento/framework/View/Layout.php(555): Magento\Framework\View\Layout->_renderBlock() #15 /public_html/generated/code/Magento/Framework/View/Layout/Interceptor.php(149): Magento\Framework\View\Layout->renderNonCachedElement() #16 /public_html/vendor/magento/framework/View/Layout.php(510): Magento\Framework\View\Layout\Interceptor->renderNonCachedElement() #17 /public_html/generated/code/Magento/Framework/View/Layout/Interceptor.php(140): Magento\Framework\View\Layout->renderElement() #18 /public_html/vendor/magento/framework/View/Element/AbstractBlock.php(507): Magento\Framework\View\Layout\Interceptor->renderElement() #19 /public_html/var/view_preprocessed/pub/static/vendor/magento/module-config/view/adminhtml/templates/system/config/edit.phtml(1): Magento\Framework\View\Element\AbstractBlock->getChildHtml() #20 /public_html/vendor/magento/framework/View/TemplateEngine/Php.php(71): include('/pu...') #21 /public_html/vendor/magento/framework/Interception/Interceptor.php(58): Magento\Framework\View\TemplateEngine\Php->render() #22 /public_html/vendor/magento/framework/Interception/Interceptor.php(138): Magento\Framework\View\TemplateEngine\Php\Interceptor->___callParent() #23 /public_html/vendor/magento/framework/Interception/Interceptor.php(153): Magento\Framework\View\TemplateEngine\Php\Interceptor->Magento\Framework\Interception{closure}() #24 /public_html/generated/code/Magento/Framework/View/TemplateEngine/Php/Interceptor.php(23): Magento\Framework\View\TemplateEngine\Php\Interceptor->___callPlugins() #25 /public_html/vendor/magento/framework/View/Element/Template.php(263): Magento\Framework\View\TemplateEngine\Php\Interceptor->render() #26 /public_html/vendor/magento/framework/View/Element/Template.php(293): Magento\Framework\View\Element\Template->fetchView() #27 /public_html/vendor/magento/module-backend/Block/Template.php(141): Magento\Framework\View\Element\Template->_toHtml() #28 /public_html/vendor/magento/framework/View/Element/AbstractBlock.php(1095): Magento\Backend\Block\Template->_toHtml() #29 /public_html/vendor/magento/framework/View/Element/AbstractBlock.php(1099): Magento\Framework\View\Element\AbstractBlock->Magento\Framework\View\Element{closure}() #30 /public_html/vendor/magento/framework/View/Element/AbstractBlock.php(660): Magento\Framework\View\Element\AbstractBlock->_loadCache() #31 /public_html/vendor/magento/framework/View/Layout.php(578): Magento\Framework\View\Element\AbstractBlock->toHtml() #32 /public_html/vendor/magento/framework/View/Layout.php(555): Magento\Framework\View\Layout->_renderBlock() #33 /public_html/generated/code/Magento/Framework/View/Layout/Interceptor.php(149): Magento\Framework\View\Layout->renderNonCachedElement() #34 /public_html/vendor/magento/framework/View/Layout.php(510): Magento\Framework\View\Layout\Interceptor->renderNonCachedElement() #35 /public_html/generated/code/Magento/Framework/View/Layout/Interceptor.php(140): Magento\Framework\View\Layout->renderElement() #36 /public_html/vendor/magento/framework/View/Layout.php(606): Magento\Framework\View\Layout\Interceptor->renderElement() #37 /public_html/vendor/magento/framework/View/Layout.php(557): Magento\Framework\View\Layout->_renderContainer() #38 /public_html/generated/code/Magento/Framework/View/Layout/Interceptor.php(149): Magento\Framework\View\Layout->renderNonCachedElement() #39 /public_html/vendor/magento/framework/View/Layout.php(510): Magento\Framework\View\Layout\Interceptor->renderNonCachedElement() #40 /public_html/generated/code/Magento/Framework/View/Layout/Interceptor.php(140): Magento\Framework\View\Layout->renderElement() #41 /public_html/vendor/magento/framework/View/Layout.php(606): Magento\Framework\View\Layout\Interceptor->renderElement() #42 /public_html/vendor/magento/framework/View/Layout.php(557): Magento\Framework\View\Layout->_renderContainer() #43 /public_html/generated/code/Magento/Framework/View/Layout/Interceptor.php(149): Magento\Framework\View\Layout->renderNonCachedElement() #44 /public_html/vendor/magento/framework/View/Layout.php(510): Magento\Framework\View\Layout\Interceptor->renderNonCachedElement() #45 /public_html/generated/code/Magento/Framework/View/Layout/Interceptor.php(140): Magento\Framework\View\Layout->renderElement() #46 /public_html/vendor/magento/framework/View/Layout.php(606): Magento\Framework\View\Layout\Interceptor->renderElement() #47 /public_html/vendor/magento/framework/View/Layout.php(557): Magento\Framework\View\Layout->_renderContainer() #48 /public_html/generated/code/Magento/Framework/View/Layout/Interceptor.php(149): Magento\Framework\View\Layout->renderNonCachedElement() #49 /public_html/vendor/magento/framework/View/Layout.php(510): Magento\Framework\View\Layout\Interceptor->renderNonCachedElement() #50 /public_html/generated/code/Magento/Framework/View/Layout/Interceptor.php(140): Magento\Framework\View\Layout->renderElement() #51 /public_html/vendor/magento/framework/View/Layout.php(606): Magento\Framework\View\Layout\Interceptor->renderElement() #52 /public_html/vendor/magento/framework/View/Layout.php(557): Magento\Framework\View\Layout->_renderContainer() #53 /public_html/generated/code/Magento/Framework/View/Layout/Interceptor.php(149): Magento\Framework\View\Layout->renderNonCachedElement() #54 /public_html/vendor/magento/framework/View/Layout.php(510): Magento\Framework\View\Layout\Interceptor->renderNonCachedElement() #55 /public_html/generated/code/Magento/Framework/View/Layout/Interceptor.php(140): Magento\Framework\View\Layout->renderElement() #56 /public_html/vendor/magento/framework/View/Layout.php(606): Magento\Framework\View\Layout\Interceptor->renderElement() #57 /public_html/vendor/magento/framework/View/Layout.php(557): Magento\Framework\View\Layout->_renderContainer() #58 /public_html/generated/code/Magento/Framework/View/Layout/Interceptor.php(149): Magento\Framework\View\Layout->renderNonCachedElement() #59 /public_html/vendor/magento/framework/View/Layout.php(510): Magento\Framework\View\Layout\Interceptor->renderNonCachedElement() #60 /public_html/generated/code/Magento/Framework/View/Layout/Interceptor.php(140): Magento\Framework\View\Layout->renderElement() #61 /public_html/vendor/magento/framework/View/Layout.php(606): Magento\Framework\View\Layout\Interceptor->renderElement() #62 /public_html/vendor/magento/framework/View/Layout.php(557): Magento\Framework\View\Layout->_renderContainer() #63 /public_html/generated/code/Magento/Framework/View/Layout/Interceptor.php(149): Magento\Framework\View\Layout->renderNonCachedElement() #64 /public_html/vendor/magento/framework/View/Layout.php(510): Magento\Framework\View\Layout\Interceptor->renderNonCachedElement() #65 /public_html/generated/code/Magento/Framework/View/Layout/Interceptor.php(140): Magento\Framework\View\Layout->renderElement() #66 /public_html/vendor/magento/framework/View/Layout.php(606): Magento\Framework\View\Layout\Interceptor->renderElement() #67 /public_html/vendor/magento/framework/View/Layout.php(557): Magento\Framework\View\Layout->_renderContainer() #68 /public_html/generated/code/Magento/Framework/View/Layout/Interceptor.php(149): Magento\Framework\View\Layout->renderNonCachedElement() #69 /public_html/vendor/magento/framework/View/Layout.php(510): Magento\Framework\View\Layout\Interceptor->renderNonCachedElement() #70 /public_html/generated/code/Magento/Framework/View/Layout/Interceptor.php(140): Magento\Framework\View\Layout->renderElement() #71 /public_html/vendor/magento/framework/View/Layout.php(606): Magento\Framework\View\Layout\Interceptor->renderElement() #72 /public_html/vendor/magento/framework/View/Layout.php(557): Magento\Framework\View\Layout->_renderContainer() #73 /public_html/generated/code/Magento/Framework/View/Layout/Interceptor.php(149): Magento\Framework\View\Layout->renderNonCachedElement() #74 /public_html/vendor/magento/framework/View/Layout.php(510): Magento\Framework\View\Layout\Interceptor->renderNonCachedElement() #75 /public_html/generated/code/Magento/Framework/View/Layout/Interceptor.php(140): Magento\Framework\View\Layout->renderElement() #76 /public_html/vendor/magento/framework/View/Layout.php(975): Magento\Framework\View\Layout\Interceptor->renderElement() #77 /public_html/generated/code/Magento/Framework/View/Layout/Interceptor.php(347): Magento\Framework\View\Layout->getOutput() #78 /public_html/vendor/magento/framework/View/Result/Page.php(260): Magento\Framework\View\Layout\Interceptor->getOutput() #79 /public_html/vendor/magento/framework/View/Result/Layout.php(171): Magento\Framework\View\Result\Page->render() #80 /public_html/generated/code/Magento/Backend/Model/View/Result/Page/Interceptor.php(32): Magento\Framework\View\Result\Layout->renderResult() #81 /public_html/vendor/magento/framework/App/Http.php(120): Magento\Backend\Model\View\Result\Page\Interceptor->renderResult() #82 /public_html/generated/code/Magento/Framework/App/Http/Interceptor.php(23): Magento\Framework\App\Http->launch() #83 /public_html/vendor/magento/framework/App/Bootstrap.php(264): Magento\Framework\App\Http\Interceptor->launch() #84 /public_html/pub/index.php(30): Magento\Framework\App\Bootstrap->run() #85 {main} [] []

Changes in https://github.com/avstudnitz/AvS_ScopeHint2/pull/28 introduced a change where the current value and scope value are cast to string. This leads however to the following exception, when using an array-serialized/serialized config field in store configuration:

Exception #0 (Exception): Warning: Array to string conversion in /var/www/html/vendor/avstudnitz/scopehint2/Plugin/ConfigFieldPlugin.php on line 138

Since the array values can be structured in multiple ways, I propose to just skip the array values and not generate a scope hint label for such cases. These kind of arrays often contain multiple entries anyways, so displaying changes in a popover is tricky anyways.

Noticed the bug while trying to configure the DHL extension which uses a custom ArraySerialized class. But Magento has those kind of classes in the core as well.

\AvS\ScopeHint\Plugin\ConfigFieldPlugin::afterGetComment is currently assuming that $result is a string. Actually, it may be a string or a /Magento/Framework/Phrase. Can you update the codebase so that the method returns a Phrase if it receives a phrase? Currently this module is breaking our admin panel, since in \Magento\SharedCatalog\Block\Adminhtml\System\Config\WebsiteRestriction\IsActive::prepareComment the method getText() is called on the result of this method, throwing an error because it's converted from a Phrase to a string in the plugin.

M2 version production ready

Would this work on M2.1.3 and is it ready for production. Also found https://github.com/ericthehacker/magento2-configscopehints -- currently investigating solutions

thanks for the update!

Hi,

Here's a feature I really wanted from this module. I adapted the \AvS\ScopeHint\Plugin\ProductEavDataProviderPlugin for the category edit form. I tried to stay close to the module coding style.

Check it out and tell me what you think.

Cheers

As posted on Magento Slack:

Just found out that in the admin products overview when set to 'All Store Views', you can't see if a value is overruled for a specific store view. This makes it hard to find out why, for instance, the status stays 'enabled' when I'm disabling the product using the mass action.

Is there a method to mark a value should it be overruled. Or might it be possible to show overruled values in the 'All Store Views'. Example:

And was pointed to this plugin in which support is already being added for the product detail edit, https://github.com/avstudnitz/AvS_ScopeHint2/issues/4 .

Could the support be extended to the product overview?