Hello,

getting the following error upon config import:

$ magento app:config:import
Processing configurations data from configuration file...
Import failed: Class RedChamps\CleanMenu\Model\Config\Backend\Modules does not exist

The class RedChamps\CleanMenu\Model\Config\Backend\Modules really doesn't exist, but why does it ask for it?

Any idea?

The intent of this PR is to fix many issues:

• if the Amasty_Base is not installed, an error 500 is thrown on the backend because the menu removed is not declared previously
• code quality by reduci'g LLOC and complexity
• remove the advertising code which add extra loaded code and files and is not relevant regarding the module achievement goal (also seen in #19
• support for Magento 2.4
• remove code depreciation

Hi, I'm not a big fan of Amasty, but they make something nice to see to regroup menu.

Actually for example with elastic suite menu, the subtitle are link to dashboard :

There seems to be a compatibility issue with ElasticSuite menu items.

1. Please install https://github.com/Smile-SA/elasticsuite
2. Go to Extensions > ElasticSuite > Search Engine > Search Relevance
3. Menu item will redirect to dashboard with Invalid security or form key. Please refresh the page.
4. The route is smile_elasticsuite/search_request_relevanceconfig/index/

I need to uninstall this module. I've tried bin/magento module:uninstall --clear-static-content --remove-data as well as bin/magento module:disable RedChamps_CleanMenu followed by composer remove redchamps/module-clean-admin-menu. Both commands successfully execute and after running setup:upgrade and clearing cache, I'm left with the following error when I try to load any page on the website:

1 exception(s): Exception #0 (Magento\Framework\Exception\FileSystemException): The contents from the "/var/www/html/vendor/redchamps/module-clean-admin-menu/etc/module.xml" file can't be read. Warning!file_get_contents(/var/www/html/vendor/redchamps/module-clean-admin-menu/etc/module.xml): failed to open stream: No such file or directory Exception #0 (Magento\Framework\Exception\FileSystemException): The contents from the "/var/www/html/vendor/redchamps/module-clean-admin-menu/etc/module.xml" file can't be read. Warning!file_get_contents(/var/www/html/vendor/redchamps/module-clean-admin-menu/etc/module.xml): failed to open stream: No such file or directory #1 Magento\Framework\Module\ModuleList\Loader->getModuleConfigs() called at [vendor/magento/framework/Module/ModuleList/Loader.php:83] #2 Magento\Framework\Module\ModuleList\Loader->load() called at [vendor/magento/framework/Module/ModuleList.php:72] #3 Magento\Framework\Module\ModuleList->getAll() called at [vendor/magento/framework/Module/ModuleList.php:91] #4 Magento\Framework\Module\ModuleList->getOne() called at [vendor/magento/framework/Module/DbVersionInfo.php:144] #5 Magento\Framework\Module\DbVersionInfo->isModuleVersionEqual() called at [vendor/magento/framework/Module/DbVersionInfo.php:59] #6 Magento\Framework\Module\DbVersionInfo->isSchemaUpToDate() called at [vendor/magento/framework/Module/DbVersionInfo.php:103] #7 Magento\Framework\Module\DbVersionInfo->getDbVersionErrors() called at [vendor/magento/framework/Module/Plugin/DbStatusValidator.php:119] #8 Magento\Framework\Module\Plugin\DbStatusValidator->getGroupedDbVersionErrors() called at [vendor/magento/framework/Module/Plugin/DbStatusValidator.php:53] #9 Magento\Framework\Module\Plugin\DbStatusValidator->beforeDispatch() called at [vendor/magento/framework/Interception/Interceptor.php:121] #10 Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}() called at [vendor/amasty/aminvisiblecaptcha/Plugin/Framework/App/FrontControllerInterface/ValidateCaptcha.php:118] #11 Amasty\InvisibleCaptcha\Plugin\Framework\App\FrontControllerInterface\ValidateCaptcha->aroundDispatch() called at [vendor/magento/framework/Interception/Interceptor.php:135] #12 Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}() called at [vendor/magento/module-page-cache/Model/App/FrontController/BuiltinPlugin.php:75] #13 Magento\PageCache\Model\App\FrontController\BuiltinPlugin->aroundDispatch() called at [vendor/magento/framework/Interception/Interceptor.php:135] #14 Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}() called at [vendor/magento/framework/Interception/Interceptor.php:153] #15 Magento\Framework\App\FrontController\Interceptor->___callPlugins() called at [generated/code/Magento/Framework/App/FrontController/Interceptor.php:23] #16 Magento\Framework\App\FrontController\Interceptor->dispatch() called at [vendor/magento/framework/App/Http.php:116] #17 Magento\Framework\App\Http->launch() called at [generated/code/Magento/Framework/App/Http/Interceptor.php:23] #18 Magento\Framework\App\Http\Interceptor->launch() called at [vendor/magento/framework/App/Bootstrap.php:264] #19 Magento\Framework\App\Bootstrap->run() called at [pub/index.php:29]

Please help me. I don't understand why Magento is still looking for this module.... I double checked the setup_module table, composer.json, and composer.lock files, and the module isn't mentioned anywhere in them.

Thanks in advance.

Environment: Magento Open Source 2.3.5-p2 PHP 7.3.28 MAGE_MODE: developer

Steps to reproduce:

• install the extension via composer package manager
• run the bin/magento setup:upgrade command
• Open Magento Admin and observe the result

Actual result:

• An error occurred on the page Exception #0 (Exception): Notice: Undefined index: in vendor/redchamps/module-clean-admin-menu/Model/RuleFactory.php on line 35

Expected result:

• Magento Admin has been successfully loaded without errors.

This PR adds:

Settings:

• Enable/Disable Magento Marketplace menu item
• Move Magento Marketplace menu item to "extensions"

Code:

• IsAllowedModule decorator to manage the Magento_Marketplace case
• Add missing "canRestore" on allowed modules
• Fix typo in virtual types
• Add badges in README.md

When I install the module using I get an exception. Using magento 2.3.7-p1

composer require redchamps/module-clean-admin-menu
bin/magento set:up

Installed version is 1.1.3

1 exception(s):
Exception #0 (Exception): Notice: Undefined index:  in /data/a4h/magento2/vendor/redchamps/module-clean-admin-menu/Model/RuleFactory.php on line 35

Exception #0 (Exception): Notice: Undefined index:  in /data/a4h/magento2/vendor/redchamps/module-clean-admin-menu/Model/RuleFactory.php on line 35
<pre>#1 RedChamps\CleanMenu\Model\RuleFactory->create() called at [vendor/redchamps/module-clean-admin-menu/Model/IsAllowedStrategy.php:46]
#2 RedChamps\CleanMenu\Model\IsAllowedStrategy->isAllowed() called at [vendor/redchamps/module-clean-admin-menu/Model/Config/Structure/Data.php:43]
#3 RedChamps\CleanMenu\Model\Config\Structure\Data->get() called at [generated/code/RedChamps/CleanMenu/Model/Config/Structure/Data/Interceptor.php:24]
#4 RedChamps\CleanMenu\Model\Config\Structure\Data\Interceptor->get() called at [vendor/magento/module-config/Model/Config/Structure.php:127]
#5 Magento\Config\Model\Config\Structure->__construct() called at [generated/code/Magento/Config/Model/Config/Structure/Interceptor.php:14]
#6 Magento\Config\Model\Config\Structure\Interceptor->__construct() called at [vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php:121]
#7 Magento\Framework\ObjectManager\Factory\AbstractFactory->createObject() called at [vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php:66]
#8 Magento\Framework\ObjectManager\Factory\Dynamic\Developer->create() called at [vendor/magento/framework/ObjectManager/ObjectManager.php:70]
#9 Magento\Framework\ObjectManager\ObjectManager->get() called at [vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php:167]
#10 Magento\Framework\ObjectManager\Factory\AbstractFactory->resolveArgument() called at [vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php:273]
#11 Magento\Framework\ObjectManager\Factory\AbstractFactory->getResolvedArgument() called at [vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php:236]
#12 Magento\Framework\ObjectManager\Factory\AbstractFactory->resolveArgumentsInRuntime() called at [vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php:34]
#13 Magento\Framework\ObjectManager\Factory\Dynamic\Developer->_resolveArguments() called at [vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php:59]
#14 Magento\Framework\ObjectManager\Factory\Dynamic\Developer->create() called at [vendor/magento/framework/ObjectManager/ObjectManager.php:56]
#15 Magento\Framework\ObjectManager\ObjectManager->create() called at [vendor/magento/framework/App/ActionFactory.php:44]
#16 Magento\Framework\App\ActionFactory->create() called at [vendor/magento/framework/App/Router/Base.php:306]
#17 Magento\Framework\App\Router\Base->matchAction() called at [vendor/magento/framework/App/Router/Base.php:167]
#18 Magento\Framework\App\Router\Base->match() called at [vendor/magento/framework/App/FrontController.php:115]
#19 Magento\Framework\App\FrontController->dispatch() called at [vendor/magento/framework/Interception/Interceptor.php:58]
#20 Magento\Framework\App\FrontController\Interceptor->___callParent() called at [vendor/magento/framework/Interception/Interceptor.php:138]
#21 Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}() called at [vendor/magento/framework/Interception/Interceptor.php:153]
#22 Magento\Framework\App\FrontController\Interceptor->___callPlugins() called at [generated/code/Magento/Framework/App/FrontController/Interceptor.php:26]
#23 Magento\Framework\App\FrontController\Interceptor->dispatch() called at [vendor/magento/framework/App/Http.php:116]
#24 Magento\Framework\App\Http->launch() called at [vendor/magento/framework/Interception/Interceptor.php:58]
#25 Magento\Framework\App\Http\Interceptor->___callParent() called at [vendor/magento/framework/Interception/Interceptor.php:138]
#26 Magento\Framework\App\Http\Interceptor->Magento\Framework\Interception\{closure}() called at [vendor/msp/adminrestriction/Plugin/AppInterfacePlugin.php:134]
#27 MSP\AdminRestriction\Plugin\AppInterfacePlugin->aroundLaunch() called at [vendor/magento/framework/Interception/Interceptor.php:135]
#28 Magento\Framework\App\Http\Interceptor->Magento\Framework\Interception\{closure}() called at [vendor/justbetter/magento2-sentry/Plugin/GlobalExceptionCatcher.php:43]
#29 JustBetter\Sentry\Plugin\GlobalExceptionCatcher->aroundLaunch() called at [vendor/magento/framework/Interception/Interceptor.php:135]
#30 Magento\Framework\App\Http\Interceptor->Magento\Framework\Interception\{closure}() called at [vendor/magento/framework/Interception/Interceptor.php:153]
#31 Magento\Framework\App\Http\Interceptor->___callPlugins() called at [generated/code/Magento/Framework/App/Http/Interceptor.php:26]
#32 Magento\Framework\App\Http\Interceptor->launch() called at [vendor/magento/framework/App/Bootstrap.php:261]
#33 Magento\Framework\App\Bootstrap->run() called at [pub/index.php:40]
</pre>

As we are using VCS for this package and tags, the "version" argument is not needed in the composer.json. Removing it will be make easier to ship new releases without having to bump the version in composer.json each time.

This PR add the "rule" field in the configuration. The rule will impact the ways the selected items are used in the isAllowed method. Now you can define if the all items are allowed by default, and you select the items you want to denied. Or vice versa and only allowing the selected items. This setting is added for both tabs and menu.

Installed module on M2.3.3 via composer, went to admin and received error in admin. s:up, c:c, c:f did not resolve the issue

1 exception(s):
Exception #0 (Exception): Notice: Undefined index: module in vendor/redchamps/module-clean-admin-menu/Plugin/Model/MenuBuilderCommand.php on line 11

Exception #0 (Exception): Notice: Undefined index: module in vendor/redchamps/module-clean-admin-menu/Plugin/Model/MenuBuilderCommand.php on line 11
<pre>#1 RedChamps\CleanMenu\Plugin\Model\MenuBuilderCommand->afterExecute() called at [vendor/magento/framework/Interception/Interceptor.php:146]
#2 Magento\Backend\Model\Menu\Builder\Command\Remove\Interceptor->Magento\Framework\Interception\{closure}() called at [vendor/magento/framework/Interception/Interceptor.php:153]
#3 Magento\Backend\Model\Menu\Builder\Command\Remove\Interceptor->___callPlugins() called at [generated/code/Magento/Backend/Model/Menu/Builder/Command/Remove/Interceptor.php:52]
#4 Magento\Backend\Model\Menu\Builder\Command\Remove\Interceptor->execute() called at [vendor/magento/module-backend/Model/Menu/Builder.php:65]
#5 Magento\Backend\Model\Menu\Builder->getResult() called at [vendor/magento/framework/Interception/Interceptor.php:58]
#6 Magento\Backend\Model\Menu\Builder\Interceptor->___callParent() called at [vendor/magento/framework/Interception/Interceptor.php:138]
#7 Magento\Backend\Model\Menu\Builder\Interceptor->Magento\Framework\Interception\{closure}() called at [vendor/magento/framework/Interception/Interceptor.php:153]
#8 Magento\Backend\Model\Menu\Builder\Interceptor->___callPlugins() called at [generated/code/Magento/Backend/Model/Menu/Builder/Interceptor.php:39]
#9 Magento\Backend\Model\Menu\Builder\Interceptor->getResult() called at [vendor/magento/module-backend/Model/Menu/Config.php:148]
#10 Magento\Backend\Model\Menu\Config->_initMenu() called at [vendor/magento/module-backend/Model/Menu/Config.php:111]
#11 Magento\Backend\Model\Menu\Config->getMenu() called at [vendor/magento/module-backend/Block/Menu.php:265]
#12 Magento\Backend\Block\Menu->getMenuModel() called at [generated/code/Magento/Backend/Block/Menu/Interceptor.php:50]
#13 Magento\Backend\Block\Menu\Interceptor->getMenuModel() called at [vendor/magento/module-backend/Model/View/Result/Page.php:28]
#14 Magento\Backend\Model\View\Result\Page->setActiveMenu() called at [generated/code/Magento/Backend/Model/View/Result/Page/Interceptor.php:24]
#15 Magento\Backend\Model\View\Result\Page\Interceptor->setActiveMenu() called at [vendor/magento/module-catalog/Controller/Adminhtml/Product/Edit.php:71]
#16 Magento\Catalog\Controller\Adminhtml\Product\Edit->execute() called at [generated/code/Magento/Catalog/Controller/Adminhtml/Product/Edit/Interceptor.php:24]
#17 Magento\Catalog\Controller\Adminhtml\Product\Edit\Interceptor->execute() called at [vendor/magento/framework/App/Action/Action.php:108]
#18 Magento\Framework\App\Action\Action->dispatch() called at [vendor/magento/module-backend/App/AbstractAction.php:231]
#19 Magento\Backend\App\AbstractAction->dispatch() called at [vendor/magento/framework/Interception/Interceptor.php:58]
#20 Magento\Catalog\Controller\Adminhtml\Product\Edit\Interceptor->___callParent() called at [vendor/magento/framework/Interception/Interceptor.php:138]
#21 Magento\Catalog\Controller\Adminhtml\Product\Edit\Interceptor->Magento\Framework\Interception\{closure}() called at [vendor/magento/module-backend/App/Action/Plugin/Authentication.php:143]
#22 Magento\Backend\App\Action\Plugin\Authentication->aroundDispatch() called at [vendor/magento/framework/Interception/Interceptor.php:135]
#23 Magento\Catalog\Controller\Adminhtml\Product\Edit\Interceptor->Magento\Framework\Interception\{closure}() called at [vendor/magento/framework/Interception/Interceptor.php:153]
#24 Magento\Catalog\Controller\Adminhtml\Product\Edit\Interceptor->___callPlugins() called at [generated/code/Magento/Catalog/Controller/Adminhtml/Product/Edit/Interceptor.php:39]
#25 Magento\Catalog\Controller\Adminhtml\Product\Edit\Interceptor->dispatch() called at [vendor/magento/framework/App/FrontController.php:159]
#26 Magento\Framework\App\FrontController->processRequest() called at [vendor/magento/framework/App/FrontController.php:99]
#27 Magento\Framework\App\FrontController->dispatch() called at [vendor/magento/framework/Interception/Interceptor.php:58]
#28 Magento\Framework\App\FrontController\Interceptor->___callParent() called at [vendor/magento/framework/Interception/Interceptor.php:138]
#29 Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}() called at [vendor/magento/framework/Interception/Interceptor.php:153]
#30 Magento\Framework\App\FrontController\Interceptor->___callPlugins() called at [generated/code/Magento/Framework/App/FrontController/Interceptor.php:26]
#31 Magento\Framework\App\FrontController\Interceptor->dispatch() called at [vendor/magento/framework/App/Http.php:137]
#32 Magento\Framework\App\Http->launch() called at [generated/code/Magento/Framework/App/Http/Interceptor.php:24]
#33 Magento\Framework\App\Http\Interceptor->launch() called at [vendor/magento/framework/App/Bootstrap.php:261]
#34 Magento\Framework\App\Bootstrap->run() called at [pub/index.php:40]
</pre>

Extension will produce below error in the 2.4.4 (PHP 8.1) admin panel

Error: Call to undefined method ReflectionUnionType::getName() in /m2/244/vendor/magento/framework/Code/Generator/EntityAbstract.php:335

This is being caused by Magento 2.4.4 core issue reported here https://github.com/magento/magento2/issues/35292 and we are looking for some temporary fix till the time the core issue gets resolved.