Using the --exclude option enables users to exclude files from validation. The regex functionality should save people from having to fill in the complete path to a file.

As I suggested in #9 it would be possible to have two versions of twig-lint to work around the API changes currently breaking with twig >1.16.2

This version is tested with 1.17, if this solution would be a possibility for you, @asm89, I would test all versions in between.

Ideas, suggestions?

With warnings enabled, the the linter often throws a warning due to a missing third argument:

PHP Warning:  Missing argument 3 for Asm89\Twig\Lint\Extension\StubbedCore::getTestNodeClass(), called in /path/to/project/vendor/twig/twig/lib/Twig/Extension/Core.php on line 302 and defined in /path/to/project/vendor/asm89/twig-lint/src/Asm89/Twig/Lint/Extension/StubbedCore.php on line 30

Examining the parent class in twig 1.18, this arg is not even present in the signature. Rather than remove it entirely, I defaulted it to null. It's possible it needs to be dropped altogether for eliminating the strict warning about mismatched method signatures.

Liniter is no longer compatible with twig 1.16.2

Since arguments changed for protected method getTestNodeClass of Twig_Extension_Core https://github.com/asm89/twig-lint/blob/master/src/Asm89/Twig/Lint/Extension/StubbedCore.php#L30 https://github.com/twigphp/Twig/blob/v1.16.2/lib/Twig/Extension/Core.php#L341

Also some tests starts to faling for twig 1.16.2

There is an Atom linter Provider that has twig-lint as prerequisite, so I gave it a try.

But my templates do not report any linter warnings (or Errors), even if i try to do some ugly code.

Calling twig-lint in cmd line makes no difference. I always get OK in path\filename as an answer.

So I have to ask, what rules are checked by the linter?

This package is part of Acquia's BLT framework, but it seems to fail when using the Drupal contributed module twig_tweak. How can I get twig-lint to recognize twig_tweak functions?

There's a syntax error that's on purpose in Symfony/Bridge/Twig/Tests/Fixtures/extractor/syntax_error.twig . Our CI always flags this one, which fails the builds.

Please create an exclude flag that takes one or multiple directories or files and that excludes it from giving errors.

Hi,

Would you mind providing versionned binaries? Something like this would be great:

https://asm89.github.io/d/twig-lint-1.0.1.phar

You can also put binaries in GitHub releases.

Versionned binaries don’t change and can be verified with a checksum. I’d like to write an Homebrew formula for twig-lint, so people would be able to install your program with brew install twig-lint, but I need a versionned URL.

Thanks!

Hi,

Linter doesn't recognize same as alias fot sameas test and it throws exception:

Unexpected token "name" of value "as" ("end of statement block" expected)

http://twig.sensiolabs.org/doc/tests/sameas.html

Linter from symfony doesn't throw this error.

http://asm89.github.com/d/twig-lint.phar leverages old dependencies. I noticed it when I upgraded my app to Twig 1.14 and began using the new 'matches' function in Twig Core. Syntastic started flagging it and I discovered it wasn't linting correctly. I downloaded the source, installed new vendors & updated composer.lock, and then built a new phar with Box against the updates and now it works perfectly.

composer.json requires twig 1.*, but Asm89\Twig\Lint\StubbedEnvironment::__construct calls Twig_Environment::initExtensions which appears to have been first added in Twig 1.12.0-RC1 as of https://github.com/fabpot/Twig/commit/44873875ff6ca50c654e3bd28fe19b7ce5108f42

A minor issue but a possible gotcha.

I'm not sure if/how many people are still using this linter, but it needs some love.

One thing I wonder is what to do about supported twig versions. It seems Twig 1.x, 2.x and 3.x are all supported nowadays?

@lauriii looked at possibly using twig-lint to detect deprecated API use, see https://github.com/lauriii/twig-lint/commit/ce92148c3ed053f4cf4444e01269974b051ec269 -- which is obviously very raw, but we were wondering if you think this would be the right tool for this and if you had better ideas?

Using ?? in a Twig templated is flagged as invalid with the following warning:

Unexpected token "punctuation" of value "?"

It is a default Twig operator (https://twig.symfony.com/doc/2.x/templates.html#other-operators) so it should be valid?

It seems like this should pass, but fails. The template works and looks fine when viewing pages though.

Twig Code:

{% set n = content.field_content_blocks['#items']|length %}
{% set classes = [
                'n-' ~ p,
                n is divisible by (2) ? 'n-twos',
                n is divisible by (3) ? 'n-threes'
        ] %}
        <section class="row crocosmias">
            <div class="col-xs-12 {{ classes|myextensions_join_parts }}">

Lint Error:

[ExecStack] Done in 7.663s
> validate:twig:files
Linting twig files...
Iterating over fileset files.twig...
KO in /www/repos/uwmcms/docroot/themes/custom/cust_theme/templates/node/node--fact-page.html.twig (line 28)
   26             {% set classes = [
   27                     'n-' ~ p,
>> 28                     (n is divisible by (2) ? 'n-twos',
>> An opened parenthesis is not properly closed. Unexpected token "name" of value "by" ("punctuation" expected with value ")"). 
   29                     (n is divisible by (3)) ? 'n-threes'
   30             ] %}

[error]  Executing `'/www/repos/cust_theme/vendor/bin/twig-lint' lint --only-print-errors '%s'` against fileset(s) files.twig returned a non-zero exit code.` 

Here's a PR that will fix all deprecation warnings including Twig_TokenParserBroker. This should help with (https://github.com/asm89/twig-lint/issues/31 & https://github.com/phpro/grumphp/pull/199).

I've dig some things about the deprecation of the Twig_TokenParserBroker (https://github.com/twigphp/Twig/pull/903). One notable change is that Twig 2.x does not offer a way to dynamically add token parser (like it was done with the Twig_TokenParserBroker). Instead, it just look up an array and throws a syntax error. https://github.com/twigphp/Twig/blob/2.x/lib/Twig/Parser.php#L148

Therefore, you have to provide the list of tags to stub.

./bin/twig-lint lint tests/Asm89/Twig/Lint/Test/Fixtures/mixed.twig \
    --stub-tag some_other_block \
    --stub-tag stylesheets \
    --stub-tag meh \
    --stub-tag render \
    --stub-tag trans

Or via the options of the StubbedEnvironment in the constructor.

$twig = new StubbedEnvironment(
     new \Twig_Loader_Array(),
     array(
         'stub_tags' => $stubTagList,
     )
);

This might look like but thinking about it, it makes sense to only allow some tags to be stubbed so that a real "unknown tag" in your code can be detected by the linter.

Additionally, that kind of config would end in the twigcs.yml file, see my other PR.