Hi,

consolidation/robo v2.x is using league/container v2.x, that is using the deprecated package container-interop/container-interop

https://packagist.org/packages/consolidation/robo#2.2.2 https://packagist.org/packages/league/container#2.5.0 https://packagist.org/packages/container-interop/container-interop

is it possible to add the compatibility with consolidation/robo v3.x that is using league/container v3.x, that has replace the deprecated package by psr/container ?

https://packagist.org/packages/consolidation/robo#3.0.3 https://packagist.org/packages/league/container#3.3.5 https://packagist.org/packages/psr/container

thanks,

Laurent

Thanks a lot for phpqa!

Sadly i found an problem with the integration of psalm.

#steps to reproduce:

Installation

    - composer global require edgedesign/phpqa --update-no-dev
    - composer global require jakub-onderka/php-parallel-lint jakub-onderka/php-console-highlighter phpstan/phpstan vimeo/psalm friendsofphp/php-cs-fixer
    - mkdir -p public/phpqa
    - PATH="$PATH:$HOME/.composer/vendor/bin/"
    - phpqa --report --analyzedDirs Packages/Application/PackageName --buildDir public/phpqa --tools phploc,phpcpd,phpcs,pdepend,phpmd,phpmetrics,php-cs-fixer,parallel-lint,phpstan,psalm

.phpqa.yml

phpcs:
    standard: PSR2
    # number of allowed errors is compared with warnings+errors, or just errors from checkstyle.xml
    ignoreWarnings: false
    # https://github.com/squizlabs/PHP_CodeSniffer/wiki/Reporting
    reports:
        cli:
            - full
        #file:
            # checkstyle is always included and overriden
            # checkstyle: checkstyle.xml
            # you can include custom reports (https://github.com/wikidi/codesniffer/blob/master/reports/wikidi/Summary.php#L39)
            # ./vendor/owner/package/src/MySummaryReport.php: phpcs-summary.html

php-cs-fixer:
    # http://cs.sensiolabs.org/#usage
    rules: '@PSR2'
    allowRiskyRules: false
    # by default the tool is runned in dry-run mode (no fixers are applied)
    isDryRun: true

phpstan:
    level: 0

phpunit:
    # binary: vendor/bin/phpunit
    binary: bin/phpunit
    # phpunit.xml
    config: Build/BuildEssentials/PhpUnit/UnitTests.xml
    reports:
        file: []
            # log: [junit, tap, json]
            # testdox: [html, text]
            # coverage: [html, clover, crap4j, php, text, xml] # requires XDebug extension

psalm:
    config: .psalm.xml
    deadCode: true
    threads: 5
    showInfo: true

# Php file extensions to parse.
extensions:
    - php

Result

The result is an exit code larger than zero.

Additionally there is an output in the phpqa.html#psalm which is: DOMDocument::load(): I/O warning : failed to load external entity "/builds/projects/public/phpqa/psalm.xml".

The phpqa/pslam.xml does not exist, BUT there is an psalm-phpqa.xml

Maybe you can either point me to the correct config or accept that as an bug.

Hello,

trying to get PHPQA running in a CI job using GitHub actions. But I am not able to cope with an error message - maybe just an obvious beginner issue.

Here is what I did so far:

Installed version 1.23.2 using composer.

Added a .phpqa.yml file containing:

phpqa.analyzedDirs: ./src/
phpqa.ignoredDirs: vendor
phpqa.report: true
phpqa.output: cli

Running these commands:

php ./vendor/bin/phpqa-extensions.php --add phpa phpca phpmnd

./vendor/bin/phpqa

Which results in this error:

PHP Fatal error:  Uncaught Error: Class 'RoboFile' not found in /home/runner/work/.../vendor/consolidation/robo/src/Runner.php:61
Stack trace:
#0 /home/runner/work/.../vendor/edgedesign/phpqa/phpqa(55): Robo\Runner->execute(Array)
#1 {main}
  thrown in /home/runner/work/.../vendor/consolidation/robo/src/Runner.php on line 61

Originally I had no YAML file, but added the parameters as CLI arguments. Did not change anything, same error occured.

Any idea what I am missing here?

Hello,

On my "circleci" project, i'm launching all the tasks in parallel: => Directory reports: reports/phpcs/phpcs.xml -- reports/phpunit/phpunit.xml -- .....

Example cmd: qa/phpqa --report --buildDir reports/phpmetrics --analyzedDirs ./ --ignoredDirs features,data,scripts,public,vendor --tools=phpmetrics

In the last job "reports" i want to create the dashboard reporting like this (without re-running all tests) based on the custom reports directories: https://edgedesigncz.github.io/phpqa/report/phpqa.html

Any ideas ?

Hi!

I'd like to use Psalm v3 but for now it doesn't works, what can I do to add support of Psalm v3 (ideally with PHPUnit plugin) into phpqa?

Mickaël

Thanks for your awesome project :heart:

When using

phpunit:
     config: phpunit.xml
     reports:
        file:
            coverage: [html]

This creates incorrect command line arguments and menu items for html code coverage

First - the --coverage-html argument takes a directory path, NOT a filename. If you send it a filename it treats it as a directory name Second the men item says "coverage.html" and links to "coverage.html.html" - which is in fact a directory

I've changed the code in Phpunit.php to cover the "weird" use case of coverage in html format with a special path for the coverage format when html is selected. It detects that the format is coverage and the format is html, creates a filename as a directory name for the arguments, and creates a menu item in userReports that links to the index.html in the code coverage directory

            foreach ($this->config->value('phpunit.reports.file') as $report => $formats) {
                foreach ($formats as $format) {
                    if($report == 'coverage' && $format == 'html') {
                        $filename = "{$report}-{$format}";
                        $args["{$report}-{$format}"] = $this->options->toFile($filename);
                        $this->tool->userReports["{$report}.{$format}"] = $this->options->rawFile($filename . '/index.html');
                    } else {
                        $extension = array_key_exists($format, $extensions) ? $extensions[$format] : $format;
                        $filename = "{$report}-{$format}.{$extension}";
                        $args["{$report}-{$format}"] = $this->options->toFile($filename);
                        $this->tool->userReports["{$report}.{$format}"] = $this->options->rawFile($filename);
                    }
                }
            }

I've tested this with all the other code coverage, testdoxs, and log output

composer info | grep phpqa
edgedesign/phpqa                      v1.18.0 Analyze PHP code with one command.

composer info | grep php_code
squizlabs/php_codesniffer             3.2.3   PHP_CodeSniffer tokenizes PHP, JavaScript and CSS files and detects violations of a defined set of coding standards

ignoreWarnings: in my .phpqa.yml seems ignored.

1° set true the output cli show warnings 2° final repport too

+---------------+-------------------+-----------+--------+--+
| Tool          | Allowed exit code | Exit code | Is OK? |  |
+---------------+-------------------+-----------+--------+--+
| phpcs         | 0                 | 1         | x      |  |
| parallel-lint | 0                 | 0         | ✓      |  |
+---------------+-------------------+-----------+--------+--+
| phpqa         |                   | 1         | x      |  |
+---------------+-------------------+-----------+--------+--+

I've solve it

.../vendor/edgedesign/phpqa/src/Tools/Analyzer/Phpcs.php

I've added

        if ($this->tool->errorsType) {
            $args[] = '-n';
        }

in

    protected function buildPhpcs(array $installedStandards)
    {
        $this->tool->errorsType = $this->config->value('phpcs.ignoreWarnings') === true;
        $standard = $this->config->value('phpcs.standard');
        if (!in_array($standard, $installedStandards)) {
            $standard = \Edge\QA\escapePath($this->config->path('phpcs.standard'));
        }
        $args = array(
            '-p',
            'standard' => $standard,
            $this->options->ignore->phpcs(),
            $this->options->getAnalyzedDirs(' '),
            'extensions' => $this->config->csv('extensions')
        );
        if ($this->tool->errorsType) {
            $args[] = '-n';
        }
        if ($this->options->isSavedToFiles) {

https://patch-diff.githubusercontent.com/raw/EdgedesignCZ/phpqa/pull/120.patch

Hi Guys,

first of all thanks for your tool, it's really great ! I encounter an issue with phpcpd running via phpqa. I've trying with parallel and non parallel execution, here the console output.

Output for  /Users/Cyril/.composer/vendor/edgedesign/phpqa/../../bin/phpcpd --progress  --exclude=build --exclude=vendor --exclude=Tests --exclude=scripts --exclude=var --exclude=web "./src" --min-lines 5 --min-tokens 70 --log-pmd "./build/phpcpd.xml" 
phpcpd 2.0.4 by Sebastian Bergmann.




  [Symfony\Component\Console\Exception\InvalidArgumentException]  
  The helper "progress" is not defined.                           


phpcpd [--names NAMES] [--names-exclude NAMES-EXCLUDE] [--exclude EXCLUDE] [--log-pmd LOG-PMD] [--min-lines MIN-LINES] [--min-tokens MIN-TOKENS] [--fuzzy] [--progress] [--] [<values>]...



 [Edge\QA\Task\NonParallelExec]  Exit code 2  Time 68.85s

With phpcpd 2.0.1 with same arguments no problem. Can you help me please ? Thanks Cyril

Phpmd (v2.10.0) fails for a particular reason in this case (issue with trailing commas in function arguments):

ERROR while parsing 
--------------------
Unexpected token: ), line: 56, col: 5, file

The exit code is printed correctly but phpqa considers this a success.

 73/73 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% 
 [Edge\QA\Task\ParallelExec] Output for "/app/vendor/edgedesign/phpqa/../../../vendor/bin/phpmd" "src","tests" xml "/app/phpmd.xml"  --exclude /vendors/,/var/,/tests/_support/_generated/ --suffixes php --reportfile ".phpqa-report/phpmd.xml":


 [Edge\QA\Task\ParallelExec]  Exit code 3  Time 0.447s

[phpqa] 
+---------+----------------+--------------+--------+----------------------------+
| Tool    | Allowed Errors | Errors count | Is OK? | HTML report                |
+---------+----------------+--------------+--------+----------------------------+
| phpcs   | 0              | 0            | ✓      | .phpqa-report/phpcs.html   |
| phpmd   | 0              | 0            | ✓      | .phpqa-report/phpmd.html   |
| phpcpd  | 0              | 0            | ✓      | .phpqa-report/phpcpd.html  |
| phpstan | 0              | 0            | ✓      | .phpqa-report/phpstan.html |
+---------+----------------+--------------+--------+----------------------------+
| phpqa   |                | 0            | ✓      | .phpqa-report/phpqa.html   |
+---------+----------------+--------------+--------+----------------------------+

[phpqa] No failed tools

Recently I had to ugrade phpqa and all its tools to latest. I have noticed when used phpcpd 6.0.3, then my exclude directory patterns were not working as expected. Downgrading phpcd to 5.0.2 solved my problem.

This issue could be related to: https://github.com/sebastianbergmann/phpcpd/issues/192

This might be useful, if you facing with this issue.

Taking this statement

By default --path-mode is set to override, which means, that if you specify the path to a file or a directory via command arguments, then the paths provided to a Finder in config file will be ignored.

from php-cs-fixer documentation into account, your path setting from config file won't be applied if called with path argument at the same time. As phpqa always applied the --analyzedDirs values as path argument, config file was always omitted.

I've tried to run phpqa with phive installed PHPUnit in a Docker container. My setup looks like: Phpqa and phive installed at /phpqa folder. I mount the application to /application folder.

phpqa:
   tools:
      - phpunit
phpunit:
    binary: ../phpqa/tools/phpunit
    config: phpunit.xml
    reports:
        file: 
            coverage: [html, clover, crap4j, xml]
tool:
    phpunit: Edge\QA\Tools\Analyzer\Phpunit

If I tried to run phpunit with absolute path to the binary the tool was not found. I've added a var_dump before https://github.com/EdgedesignCZ/phpqa/blob/master/src/Config.php#L80 And found out it became: string(33) "/application//phpqa/tools/phpunit"

Just a note if someone has a similar issue using custom phar binaries. Keep up the good work. I really love your tool. :)