Hi, thanks for this awesome package. I have plans to include this in a project am working on but I want to understand how can i tweak your code if i want the generated codes to be attached to monetary value. Say how itunes gift card work.

I believe this package is the best in the category. I noticed one anamoly, calling Promocodes::apply($code) doesn't insert into pivot table and so, a user can use a promocode more than once.

While reading the definition of apply method, i think this line isn't working as it must.

$promocode->users()->attach(auth()->user()->id,[ 'used_at' => Carbon::now(), ]);

I'm working to find a fix but I think you would have a better idea.

Now you can do : Promocodes::create($amount, $reward, $data, $expiresIn, false, $amount); $amount is an integer.

You need to make migration if you have already installed laravel-promocodes php artisan vendor:publish php artisan migrate

Unfortunately with this change you have removed an important behaviour:

/** @test */
public function it_throws_exception_coupon_was_used_before()
{
    $this->signIn();

    Coupon::redeem($this->coupon['code']);

    $this->expectException('\Exception');
    $this->expectExceptionMessage(__('vue/checkout.coupon already used'));

    Coupon::redeem($this->coupon['code']);
}

This test is now with the update failing for me. It used to catch the error AlreadyUsedException, but even when is_disposable was set to false.

This is important for this use-case: "Every user gets to use a Promocode, but every user only once'.

The first test and this second test need to be true so that Promocode is working again.

/** @test */
public function multiple_users_can_use_the_same_promocode()
{
    $this->signIn();

    $this->assertInstanceOf('Gabievi\Promocodes\Models\Promocode', Coupon::redeem($this->coupon['code']));

    $this->signIn(); // second user
    
    $this->assertInstanceOf('Gabievi\Promocodes\Models\Promocode', Coupon::redeem($this->coupon['code']));
}

I know that the alternative would be to use isSecondUsageAttempt.

If you don't want to change the code, please update the readme file since it still says Also if authenticated user will try to apply code twice, it will throw an exception

Hello, thank you for the package. What should be done when the user wants to apply the promo code? And the display of errors is intended? I think validation should be added with Laravel https://laravel.com/docs/9.x/validation#custom-validation-rules

https://github.com/zgabievi/laravel-promocodes/blob/cb708ae8c73ee469719c288baf6d12767c89d6d6/migrations/2016_05_17_221000_create_promocodes_table.php#L15

I'm trying to install your package, but get this:

  Problem 1
    - zgabievi/promocodes[8.1.0, ..., 8.1.1] require doctrine/dbal ^2.10 -> found doctrine/dbal[v2.10.0, ..., 2.12.x-dev] but the package is fixed to 3.0.0 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
    - Root composer.json requires zgabievi/promocodes ^8.1 -> satisfiable by zgabievi/promocodes[8.1.0, 8.1.1].

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

Any suggestions ?

Can we enter our own promo codes and as well as pre-generated ones.

Secondly was wondering if you can create the promo codes like LYFT. They give a 50$ coupon, where 5$ is applied per ride till 50 is done so 10 rides.

Or any way you think I can use your packaged to do that ?

And can you please change "Amount" to "number" - I got super confused as to what the diff between amount and reward was

Question: I am using Promocode::check($code) to check if promocode is available or not? But it is throwing InvalidPromocodeException exception, shouldn't it ideally return false, as that is the whole point of this function to check if code is valid or not?

Feature request:

• I don't see an option to let same user use same promo code multiple times say 2 or 3, how we do this?
• How do we generate user specific promocodes? Promo code applicable only for a particular user?

@zgabievi When calling the 'attach' method, the package is explicitly relying that the primary key of 'User' model is 'id'. While in my project, I chose it to be 'user_id', so I think it's better to user 'auth()->id()' to get authenticated user's id.

Hello, @zgabievi!

The package looks nice, but a bit outdated. I faced some problems using it in production, had to override the main class.

What you'll say if I'll send the PR of a more modern typed version of the package, and probably with the option to point out the model to use? It will require PHP 8 and probably Laravel 8.x.

This pull request will fix decrementing on unlimited usages.

After applying the first decrement the value it would be -2 and will break the apply method as it will always show no usage left

Hi,

if you customize users foreign key in the config, create method throws an exception user_id column can not be found.

something like this do the trick:

 return $this->generate()->map(fn(string $code) => app(PromocodeContract::class)->create([
            config('promocodes.models.users.foreign_id') => optional($this->user)->id,
            'code' => $code,
            'usages_left' => $this->unlimited ? -1 : $this->usagesLeft,
            'bound_to_user' => $this->user || $this->boundToUser,
            'multi_use' => $this->multiUse,
            'details' => $this->details,
            'expired_at' => $this->expiredAt,
        ]));

I'm getting this one from composer:

Class Zorb\Promocodes\Promocode\Promocode located in ./vendor/zgabievi/laravel-promocodes/src/Models/Promocode.php does not comply with psr-4 autoloading standard. Skipping.

I want a user to able to create promo code by themselves and allow other users to redeem the promo code

So the user that created the promo code can view the list of promo code he/she has And also know the promo code that have been redeemed by other user

Note - Other user cannot see each other created promo code Except the specific promo code they redeem

Is this possible or already available

Is your feature request related to a problem? Please describe. When users purchase vouchers, the user can use that same voucher more than 1 time (Partial usage of voucher in case cart value is less than voucher value)

Describe the solution you'd like Every time he uses the voucher, the amount will deduct from the voucher and the remaining amount will be stored as the current voucher amount. (gift cards feature)

Describe alternatives you've considered There currently is a solution which requires some coding, but It'd be better if we would be able to achieve this with an easy way

Additional context This feature was originally requested by: @prafful-panwar