I did not find an easy way to add a view to the menu.

I am thinking about using this package and I have some more complicated menu items, that are more than just a link. I store those items in separate views, which is why adding a view as a menu item would be good.

Maybe something like this:

Menu::new()
  ->action('HomeController@index', 'Home')
  ->addView('menu.viewFile', $viewData);

I think currently it would be possible to pass a view('menu.viewFile', $viewData)->render() to the add() method? But I think this would be a nicer way to add it.

Of course I just realise, that setActiveFromRequest would not work with a rendered view, would it? This would possible make it even more useful, as some logic for this could be included.

Got pretty much everything working. Thanks for the package!

One small issue with dropdown using UIKit. When I use ->submenuIf() and have ->wrap('div', ['class' => 'uk-navbar-dropdown']), it adds it around the <a> as well which I don't want. Any way to do that? Tried quite a few different ideas but none worked.

Menu::macro('main', function() {
    $menu = Menu::new()
        ->addClass('uk-navbar-nav')
        ->setActiveClass('uk-active')
        ->route('home', 'Home')
        ->submenuIf($isAdmin, '<a href="#">Admin</a>', function (Spatie\Menu\Laravel\Menu $menu) {
            $menu
                //->wrap('div', ['class' => 'uk-navbar-dropdown'])
                ->addClass('uk-nav uk-navbar-dropdown-nav')
                ->route('admin.item', 'Item')
                ->route('admin.item2', 'Item 2')
            ;
        })
        ->setActiveFromRequest()
    ;

    return $menu;
});

Need this format;

<li>
    <a href="#">Parent</a>
    <div class="uk-navbar-dropdown">
        <ul class="uk-nav uk-navbar-dropdown-nav">
            <li><a href="#">Item</a></li>
            <li><a href="#">Item</a></li>
        </ul>
    </div>
</li>

Hey,

as I am starting to use the package, it noticed that it would be pretty handy to be able to loop over an array. Pretty often menu items will be stored in a config file or a database and retrieved in one set. While it is possible to achieve this by hand or using a macro, I think it would be a valuable addition to the package (probably added to the main package, nor the Laravel version).

To allow for as much flexibility and little code, I would suggest to add a method that takes an array and a callable as parameters, the callable gets the $key and $value and needs to return an Item.

I used the macro function to build a "prototype" but I think it would be much better to include this into the default build.

Menu::macro('addArray', function(array $array, callable $callable){
    foreach($array as $key => $value)
    {
        $this->add($callable($value, $key));
    }
    return $this;
});

// will be use like this:

return Menu::new()
    ->addArray([
        [
            'link' => '/link',
            'name' => 'Link'
        ],
        [
            'link' => '/link-2',
            'name' => '2nd Link'
        ],
    ], function($item){
        return Link::to($item['link'], $item['name']);
    });

• [x] I have read and understood the contributors guide.
• [X] I have checked the pull requests tab for existing solutions/implementations to my issue/suggestion.
• [X] I have checked that the bug-fix I am reporting can be replicated.

Description of the problem

I am struggling to get submenu's working with Bootstrap 3 navbar's. It simply boils down to this: the examples you provide generate submenu's in a separate <li>, while Bootstrap expects you to add a submenu right after the anchor, within the same <li> of the parent.

Laravel-menu generates:

<ul>
    <li>
        <a href="/">Menu</a>
    </li>
    <li>
        <ul>
            <li>
                <a href="/basic-usage/your-first-menu">Your First Menu</a>
            </li>
        </ul>
    </li>
</ul>

While Bootstrap expects:

<ul>
    <li>
        <a href="/">Menu</a>
        <ul>
            <li>
                <a href="/basic-usage/your-first-menu">Your First Menu</a>
            </li>
        </ul>
    </li>
</ul>

In order to generate the second code fragment using laravel-menu, I would expect something like this in PHP:

Menu::new()->add(Link::to('/', 'item'), Menu::new()
    ->add(Link::to('/sub', 'subitem'))
);

Is there something I missed? Or are there any plans in making this work, making Bootstrap submenu's possible?

Steps to reproduce

I have used the submenu code examples from the documentation.

Dear Spatie team,

First of all thank you for all your hard work 👏.

I've been playing with laravel-menu for a bit now and figured out how to add items to the same menu from various sources:

• I added a 'test' link from within the Laravel app
• I added a 'package' link from within a custom Laravel package

I'm wondering if it would be useful, and in the scope of this package, to be able to add a menu item to a tagged position.

Painting a picture: let's say you are building your own docs sidebar menu. You could optionally "tag" a position called "Basic Usage". From anywhere in your code you could fetch your menu with app('menu.docs.sidebar) (pseudo-code) and ->link('random-link', 'Random Link');. This would prepend the "Random Link" item to the sidebar menu, specifically under the "Basic Usage" list.

If this is already possible I've must've skipped the docs on that part. If this is not possible, I'd love to collaborate on the solution and possibly provide a Pull Request, if and when required.

Thank you for looking into this, and I'd love hearing from you.

Tom

Hi there, new to Laravel (5.4)

I've created a basic menu. To test, I placed the code in my HomeController but obviously rendering only works in the view called in the controller.

My blade structure is as follow home.blade -> @extends('layouts.blank') blank.blade -> @include('includes/sidebar') sidebar.blade -> contains {!! Menu::main() !!}

So when I'm using home I can see the menu but any other view that extends blank doesn't render the menu.

Where can I use a basic menu defined like that

$menu = Menu::new([
    Link::to('/', 'Home'),
    Link::to('/about', 'About'),
]);

and have it available in all views? Probably a service controller or a middleware but to be honest since I'm new to Laravel I don't have a clue.

Thanks.

• [x] I have read and understood the contributors guide.
• [x] I have checked that another pull request for this purpose does not exist.
• [x] I have considered, and confirmed that this submission will be valuable to others.
• [x] I have added tests to prove that the code in this PR works.

Description

If the Menu class implements the Illuminate\Contracts\Support\Htmlable interface, it will be possible to use the standard ``{{ $var }}syntax in Blade, as opposed to the{!! $var !!}` syntax.

Which means you may now output the menu by doing...

{{ $menu }}

... which in my opinion looks less hacky.

This is a minor improvement, but a good one (and a simple one), in my opinion.

This PR does three things:

• Adds "implements Htmlable" to the Menu class, plus a use at the top,
• Adds a toHtml method which returns $this->render() to satisfy the Htmlable interface,
• Adds illuminate/contracts to require-dev in the composer.json (so that Travis doesn't fail)
• And adds a test.

Menu::new()
->add(...)
->submenu(
                        Menu::new()
                            ->prepend('<a data-toggle="collapse" href="#safety_management"><i class="ti-lock"></i><p>安全管理<b class="caret"></b></p></a>')
                            ->addClass('collapse nav')
                            ->setAttribute('id', 'safety_management')
                            ->link('/user/change-password', '<span class="sidebar-mini">&nbsp;</span><span class="sidebar-normal">修改密码</span>')
//                            ->setActive('/user/change-password')   //running
                            ->setActive(function (Link $link) {
                               dd($link);    //Not running           

                                return $link->url() === explode('?', Request::getRequestUri())[0];
                            })
                    )

Hey @sebastiandedeyne,

as you might have noticed, I am using views for all my menu items. While I understand that this might not be the case for your projects, I think it is a very likely case for things like:

• profile links with (img) Name
• links prefixed with an inline/use svg
• links which have Additional elements, e.g. a list of links with a delete link on them as well

... and many more.

I do understand you do not want to alter and/or mess up the api, so something like View::create('/link','view.name') is out of the question.

My proposal would be to add a function activateForPath which could be used to set the link that should trigger the activation of a menu item.

The usage would be like this:

View::create('view.name')->activateForPath('/link');

I think, all it would need to do would be the following:

public function activateForPath($path)
{
    if(app('request')->path() === trim($path,'/')){
        $this->setActive();
    }

    return $this;
}

This would solve such a big headache, please, let us implement it. 😃

Originally posted by @themsaid here: https://github.com/spatie/menu/issues/1

Menu::new()
    ->link('/', 'Home')
    ->linkIfCan('/products', 'Products', 'review_products');
    ->linkIfCan('/inventory', 'Inventory', ['check_inventory', 'update_inventory']);

For a dropdown menu I'm using a "javascript:;" as href in a parent item.

Whenever I add a Link method with URL: javascript:; on a Link object:

Link::to("javascript:;", "Demo), I get a Laravel Exception on the setActive() method:

The scheme javascript isn't valid. It should be either http or https

Spatie\Url\Exceptions\InvalidArgument::invalidScheme vendor/spatie/url/src/Exceptions/InvalidArgument.php:11

Is there any way to resolve this matter without having to enter the <a href> via the HTML method?

It would be great if the name and data properties could be exposed.

I've added methods, but maybe it should be:

public function __construct(
        public string $name,
        public array $data = [],
    ) {
        $this->parentAttributes = new Attributes();
    }

To give you an idea why it would be useful:

public function getTab(): ?array
{
        $this->tabs()->each(function (View $tab) {
            if ($tab->getName() === $this->activeTab) {
                 // do something
             }
        });
}

Thanks!