This module assumes, that the images reside in /pub/media. But what about images from /pub/static? E.g. any images from themes. Is this module not supposed to support those files as well?

Hi,

I updated your extension to 2.1.0 and I had problem in the frontend by every category page: (I use Magento Community Edition 2.2.7.)

2019-03-18 09:54:58] main.CRITICAL: Warning: fopen(<<url>>): failed to open stream: HTTP request failed! HTTP/1.1 404 Not Found in <<url>>/src/vendor/staempfli/magento2-module-image-resizer/Model/Resizer.php on line 315 [] []

I think: $filepointer = fopen($file, "rb"); fopen with urls is usaually disallowed on productions servers

With the version 2.0.3 I don't have problem.

Can you fix it?

Best regards, Adam

Hi,

On Windows machines the use of the directory separator in getRelativePathResizedImage() which is called within getResizedImageUrl causes issues as URL's are generated in the following format.

http://domain.com/media/staempfli_imageresizer\cache\wysiwyg\638x372_co_ar_tr_85\filename.jpg

Suggest changing DIRECTORY_SEPARATOR to just use '/' for full OS support.

Shall I do a PR for this?

Yesterday we switched to a CDN (Cloudfront). It works fine but the resized images via this module are wrong. It is always outputting the original image path, which leads to a page speed disaster right now.

Updated to latest version 2.0.2 Magento 2.2.4 PHP7 Varnish Nginx

Expected Output:

<img src="https://d2rblablablaqf.cloudfront.net/staempfli_imageresizer/cache/catalog/category/182x182_co_ar_tr/niceimage.png" >

Actual Output

<img src="https://d2rblablablaqf.cloudfront.net/catalog/category/niceimage.png" />

Resizer doesn't work if you have a media url different from your imageUrl. Example : base site : www.example.com => base of the imageUrl media url : cdn.example.com => strpos fails

fix => use the parse_url function

Any plans to add functionality to change the background color? Default is white in Magento.

https://github.com/magento/magento2/blob/develop/app/code/Magento/Catalog/Helper/Image.php

Staempfli\ImageResizer\Model\Resizer: initRelativeFilenameFromUrl() this gets the image path based relative to the /cache/ folder.

protected function initRelativeFilenameFromUrl(string $imageUrl)
    {
        $this->relativeFilename = false; // reset filename in case there was another value defined
        $mediaUrl = $this->storeManager->getStore()->getBaseUrl(UrlInterface::URL_TYPE_MEDIA);
        $mediaPath = parse_url($mediaUrl, PHP_URL_PATH);
        $imagePath = parse_url($imageUrl, PHP_URL_PATH);

        if (false !== strpos($imagePath, $mediaPath)) {
			
            $this->relativeFilename = str_replace($mediaPath, '', $imagePath);
			if(strstr($this->relativeFilename,"/cache/"))
			{
				list($first,$second) = explode("/cache/",$this->relativeFilename);
				
				$path = explode("/",$second);
				array_shift($path);
				$this->relativeFilename = $first . "/" . implode("/",$path);
			}
				
        }
		
    }

Fixes #25

Simply passes the resizeSettings for the watermark along to the watermark function of the specified image adapter. But only if the imagePath can be found.

Hi, it would be awesome to use the cms syntax for image processing.. some kind of this:

<img src="{{staempflimage src="media/wysiwyg/image.png" image-resize="200x" image-quality="75" }}">

Using this module before with 10 images (Not gif images) took 4 seconds in total. Using this module with this edit it will be able to do this in 1 second.

Those benchmarks were done on images that have already been cached already.

All the file operations are relatively heavy, instead of starting with those do a very simple check if we are even dealing with a gif.

My development setup is based on Valet Plus. Local usage of this module results in this error:

[2020-01-20 09:18:12] main.ERROR: Staempfli_ImageResizer: could not find image: 
Warning: fopen(): SSL operation failed with code 1. OpenSSL Error messages:
error:14090086:SSL routines:ssl3_get_server_certificate:certificate verify failed in vendor/staempfli/magento2-module-image-resizer/Model/Resizer.php on line 318 [] []