As I'm still working with Laravel 5.2, I created a fork of the 2.3.0 version. I found this feature useful, because I wanted to allow a user to sort his comments of a post - so I created a sort_scope to prevent sorting comments of other users.

I'm using eloquent-sortable in my Laravel Admin CRUD table and everything is appearing okay, but when I try to reorder items, I get a success message but the items don't reorder.

I wasn't able to find any guidelines on how the database tables should be set up, so I'm wondering if my order_column isn't set up correctly.

Video Controller

use SortableTrait;

public $sortable = [
    'order_column_name' => 'order',
    'sort_when_creating' => true,
];
...
$grid->order('Order')->orderable()->sortable();

Database The database has a column order with integers, but they aren't unique. Hoping they don't NEED to be because it would be a pain to fix this.

e.g., MyModel::setNewOrder(['09b25ab5-b921-4794-941c-2152982c24a6', 'ca11be8f-6faf-4848-bb9b-fc951193a66d', '09b25ab5-b921-4794-951c-2152982c24a6', 'eee4041c-4aa2-468b-bga0-82d70468409d', '2643003e-2335-4496-ba4d-df6b24caa551'], 10, 'uid');

What do you think about setting a desired order value when for a new model?

$model->setOrder(3);

This should place the given model at position 3 and move current models 3-X one up.

It would be nice to add a method on the trait that allows people to move a specific location.

My proposed method.

$myModel->moveToPosition($postion);

I have created a working implementation and attached it to the PR. Please let me know if there are any questions or concerns.

Hi, after all thanks for the package, it´s super usefull!

One question about destroy models. Is there no method to reset the positions? For example, I have the following models:

[
  0 => [
    "title" => "Item 1",
    "order_column" => "1",
  ],
  1 => [
    "title" => "Item 1",
    "order_column" => "2",
  ],
  2 => [
    "title" => "Item 1",
    "order_column" => "3",
  ],
  3 => [
    "title" => "Item 1",
    "order_column" => "4",
  ],
]

Now, if I destroy Item 3, there are a gap between orders 2 and 4. A method that reset all orders without gap??

Actually, I do this, but I´m not sure if it´s the best option:

public function destroy( Link $link )
{
    $link->delete();

    $orderedLinks = Link::ordered()->pluck('id')->toArray();

    Link::setNewOrder($orderedLinks);

    return redirect()->back();
}

Thank you!!

Hello! I can't make work this behavior with custom pivot model. I have models:

class Questionnaire extends Model
{
    use HasTranslations;

    protected $fillable = [
        'title', 'is_default', 'type', 'company_id'
    ];
    public $translatable = ['title'];

    public function attributes()
    {
        return $this->belongsToMany(Attribute::class, 'questionnaire_attribute')->using(QuestionnaireAttribute::class);
    }
}

class Attribute extends Model
{
    use HasTranslations;

    protected $fillable = [
        'name', 'title', 'type', 'icon', 'is_notify_filter'
    ];
    public $translatable = ['title'];

    public function questionnaires()
    {
        return $this->belongsToMany(Questionnaire::class, 'questionnaire_attribute')->using(QuestionnaireAttribute::class);
    }
}

class QuestionnaireAttribute extends Pivot implements Sortable
{
    use HasTranslations, SortableTrait;

    protected $table = 'questionnaire_attribute';
    public $translatable = ['title'];

    public function questionnaire()
    {
        return $this->belongsTo(Questionnaire::class);
    }

    public function attribute()
    {
        return $this->belongsTo(Attribute::class);
    }
}

And when try to attach, I get this error:

SQLSTATE[HY000]: General error: 1364 Field 'order_column' doesn't have a default value (SQL: insert into `questionnaire_attribute` (`attribute_id`, `is_clearable`, `is_required`, `questionnaire_id`, `title`) values (1, 0, 1, 1, {"en":"Test"}))

Laravel 5.7, MariaDB 10.3.9

This pull request allows to sort models grouped by a given column. You can do this by adding to $sortable array the next params: 'group_column_name' => 'group_column', 'sort_by_group' => true,

I don't know if it is a very concrete use case, but I think it can help for example when ordering intermediate database tables.

Hey guys,

I'm unsure if this is intentional, but I added this to a project that uses unique indexes on the order column, and it caused this package to fail because of that. I removed the unique index and it works perfectly.

Please check this solution as a possible approach to reduce the amount of memory and queries the package uses in the method setNewOrder.

First, we try to reduce the amount of information we load from DB, as the model could be fat and the number of records is unknown. Second, the number of queries is almost reduced in a half.

I'm not sure if it'd be the correct way of doing this, regarding lines 56-59 (I'd like this properties to be static but...).

We could have another way to solve this problem by replacing 61-73 of this PR with just:

foreach ($ids as $id) {
    static::where($primaryKeyColumn, $id)->update([$orderColumnName => $startOrder++]);
}

Thanks!

Argument 1 passed to App\Model::scopeOrdered() must be an instance of Illuminate\Database\Query\Builder, instance of Illuminate\Database\Eloquent\Builder given

I have defined scopes myself in the model and seems I didn't use any typehinting at all for $query. So this could be a possible fix?