Hello there!

I'm really glad to see group support for the package! But I do have some difficulty grasping what would be correct usage for groups.

Currently, I'm attaching tags to some model in a very straightforward way (in this example, I'm storing an article tags):

if (!empty($request->tags)) {
            $article->tag(explode(', ', $request->tags));
        }

And I would of course use retag to article update. Now, of I wanted to have different group of tags, let's say for an articles model, and for a news model. I would go on and create the corresponding groups from the artisan command then... What?

I get that I can easily get the tag in a group (Tag::inGroup('MyTagGroup')->get()) but how should I add a tag to an article, or a news? What is clear is that I should get the tags from the group to suggest to the user, then it would be a no brainer (get the correct tags, send them to the user, then when you save, it's the good ones?), but what if they enter a tag that isn't already created?

Do I really have to get all the tags in the request (like in the use case earlier), check for all of them if they are in the right group, create manually each tags that aren't, then associate tags? It seems a bit counter intuitive, no?

Could we see a, for example, tag() method that accepts a single or multiple tags as first parameters, and a group as second, so we would make sure the asked for tags are the one set for the wanted group, and that new ones are created in the right group?

Or do it already exists? Or am I misunderstanding the wanted usage for groups?

Hi Rob (or anybody else listening),

first: Thanks for the package!

When I follow the steps in the readme the trait does not seem to work out of the box.

Issues:

• After following the readme steps I had to copy the migrations to my migrations folder by hand so the tables are created when calling php artisan migrate (maybe intended to do so but not (yet) in the readme)
• When adding the trait with use Conner\Tagging\TaggableTrait; I get a PHP Fatal error: Trait 'App\Conner\Tagging\TaggableTrait' not found. I worked around it by changing it to use \Conner\Tagging\TaggableTrait;
• after the change I get another error when trying to call e.g. $mymodel->addTag('mytag'); in one of my database seeders stating: [BadMethodCallException] Call to undefined method Illuminate\Database\Query\Builder::addTag()

Now I am stuck. Maybe I do something wrong because I am not very experienced with laravel nor with php. So please excuse any bothering with noob questions ... :-)

Any help would be great. Also I really would like to use your package to save me some time.

Environment: fresh laravel 5 project on homestead. My models live in the App namespace as by default laravel 5 installation.

Regards, Thomas

    public static function existingTags() {
        return Tagged::distinct()
            ->join('tagging_tags', 'tag_slug', '=', 'tagging_tags.slug')
            ->where('taggable_type', '=', get_called_class())
            ->orderBy('tag_slug', 'ASC')
            ->get(array('tag_slug as slug', 'tag_name as name', 'tagging_tags.count as count'));
    }

I'm sure
get_called_class() get value '\App\Models\Article' so can not found any record in database 'taggable_type'='Article'

Updating via composer showed me this message:

Package rtconner/laravel-tagging is abandoned, you should avoid using it. Use spatie/laravel-tags instead. Is rtconner/laravel-tagging is deprecated or moved?

Tag first letter becomes capital even I enter in small letters.

I want tags save as it is in database. if enter capital than save tag as capital in db. if enter small than save tag as small in db.

Can you please help me out for this?

Hi @rtconner ,

Out of curiosity, why in your table "tagging_tagged" do you have the fields "tag_name" and "tag_slug" and not just a reference ID (ex.: tag_id) to the tag in the table "tagging_tags"?

It seems to me that your tables aren't properly normalized because the tags information will be duplicated each time content is tagged.

i find this example but not works. $article->tag('Gardening'); // attach the tag

after i change it to array it works $article->tag(array('Gardening'));

in tag() i found this code will remove the string

    if(!is_array($tagNames)) {
        $tagNames = func_get_args();
        array_shift($tagNames);
    }

I'm installing rtconner/laravel-tagging by composer. And "laravel-tagging/migrations/2014_01_07_073615_create_tagged_table.php" looks different than on github. GitHub version: Schema::create('tagging_tagged', function(Blueprint $table) { $table->increments('id'); if(\Config::get('tagging.primary_keys_type') == 'integer') { $table->integer('taggable_id')->unsigned()->index(); } else { $table->string('taggable_id', 36)->index(); } $table->string('taggable_type', 255)->index(); $table->string('tag_name', 255); $table->string('tag_slug', 255)->index(); });

Composer version: Schema::create('tagging_tagged', function(Blueprint $table) { $table->increments('id'); $table->string('taggable_id', 36)->index(); $table->string('taggable_type', 255)->index(); //$table->morphs('taggable'); $table->string('tag_name', 255); $table->string('tag_slug', 255)->index(); });

What should I do? Or what shoud you do? ) I would be very thankful if you helped me.

Hello,

I'm using this laravel-tagging for the first time and love it so far! I've noticed that when I use untag (e.g. $post->untag($tag);), it doesn't remove it from the tagging_tagged table. Is it supposed to?

Thanks!

Allow setting a property (eg via a form field) to use as basis of retagging or untagging.

// with $autoTagFromProp = 'tag_names'
$model->tag_names = 'foo, bar';
$model->save();

I do something like this sometimes to be able to add the trait to a model and just add a field to a form to implement tagging. This allows me to just set a property of the model and automatically retag or untag it based on that property when just calling Model::save(), rather than calling retag or untag manually.

Thoughts? Concerns?

I'm using withAllTags() on a database with 10000 rows in a table and 53655 rows in tagging_tagged, paginating the results then passing it to the view for me to loop through. It takes around 10 seconds just to return the videos with the specified tags, is there a way to speed this up?

How can we get post from a tag ? Like we can get post tags like : "$post->tags();". My question is "$tag->posts();" get all post by attached tag.

Let me know how can I do it !

First off, THANK YOU, this tagging module is very useful and has been extensively implemented in my projects.

Couple issues I've found and started working on a branch with fixes but got deep in the weeds and realized a few things that I'll just itimize.

1. line 75 of TaggingUtility references 'delimiter' => config('taggable.delimiter', '-'), should be 'delimiter' => config('tagging.delimiter', '-'),

2. Adding support for uppercase tags looks like it was started at line 77 but upon further investigation the relationship model of tagging_tagged and tagging_tags relies on the tag_slug match which could become easily broken if one is manipulated without the other.

3. I changed lowercase to false but in my database the tagging_tagged->tag_slug remains uppercase but tagging_tags->slug becomes Pascal...

I will continue to work on this and hopefully provide a PR unless you immediately know how to support retaining tags as uppercase.

Thanks!!!

Hello. I like the way this package organized, seems it is the most suitable for my intentions. But I encountered with some problems when tried to use it the way I usually build my applications. Most of my API methods vastly use passing IDs of categories, groups, etc. while creating a new entity.

I tried to use Tag::create() with specified tag_group_id and found this field is not present at $fillable. I didn't like the idea of passing the group name or slug instead of it's ID. Also didn't like the way of loading TagGroup from DB by specified tag_group_id and after that pass its' name to the Tag->setGroup() (~~I also see setGroup() can load other group with the same slug, but this is not an issue I am talking here~~). For the moment I bypassed the existing logic with this:

    public function store(StoreTagRequest $request)
    {
        $tag = Tag::query()->create($request->validated());
        if ($groupId = $request->input('tag_group_id')) {
            $tag->mergeFillable(['tag_group_id'])->update(['tag_group_id' => $groupId]);
        }

        $tag->load('group');
        return $this->sendJsonResponse($tag);
    }

The main question: Is there any reason to protect tag_group_id field from assigning right at update() or create()? Something not obvious like any hidden logic about that I do not see at the moment (for example, when record is updated or something like this)?

Thank you for creating this project, it's make the project easier to put tags on my project

I think i found a bug when inserting tags on multiple database on same codebase, i've put use \Conner\Tagging\Taggable; in every model but the tags are stored in only one database with different taggable_type.

I've tried to hard coded the $this->connection on \Conner\Tagging\Model\Tag to un-inserted database and it's work, i guess the problem is how to make $this->connection = config('tagging.connection') dynamically based on parent Model but i still can't find the solution for this.

The expected result are stored in separate database that already specified in protected $connection part in Model.

I hope this information can improve your project.

Thank You