Closes https://github.com/phpstan/phpstan-webmozart-assert/issues/118 Closes https://github.com/phpstan/phpstan-webmozart-assert/issues/119

The problem is that range types are only supported for ints. See also https://phpstan.org/r/4c476dc8-d156-4f32-a733-207ba74133c5

If those assertions would be called with anything else, e.g. a float, the extensions would not add any additional type information and therefore lead to the errors described with strict-rules enabled.

with this plugin, phpstan should be aware about the array shape of the variable involved:

/**
 * @param array{password: mixed, email: mixed} $arr
 */
function a($arr) {
}

$data = $_POST;

Assert::keyExists($data, 'password');
Assert::keyExists($data, 'email');

a($data);

it would be even better if we could verify that the keys are of a certain type, e.g. string in my above example. though it seems this is not even possible with Assert itself, without additional asserts.

With the following code

foreach ($data['sniffs'] as $sniffName) {
     Assert::string($sniffName);
     Assert::classExists($sniffName);
     Assert::implementsInterface($sniffName, SniffInterface::class);

     $ruleSet->addSniff(new $sniffName());
}

I get

Call to static method Webmozart\Assert\Assert::implementsInterface() with class-string and 'TwigCsFixer\\Sniff\\SniffInterface' will always evaluate to false.

i tried to install

"phpstan/phpstan": "1.9.x-dev as 1.9.0",
"phpstan/phpstan-webmozart-assert": "1.2.x-dev as 1.3",

but it doesn't solved anything

I saw you recently work on this method @herndlm (https://github.com/phpstan/phpstan-webmozart-assert/pull/144), any idea what could be wrong here ?

Closes https://github.com/phpstan/phpstan-webmozart-assert/issues/17 Closes https://github.com/phpstan/phpstan-webmozart-assert/issues/18

The idea behind this is amazingly simple. If the $class arg is a known interface we can simply use is_subclass_of to check if the given object or FQCN implements that interface.

This is similar to the refactored all handling. It avoids building the core expression with invalid types by handling this differently. E.g. int|null is valid input for nullOrGreaterThan and we know that the core greaterThan expression would only be called with int. But this was not the case at the moment because it is building the expression and using information from the original type which still has the null. So this PR adapts that and should make the handling of all nullOr asserts safer by getting the right type when building the expression. It, obviously, has to add null back to the type later on, but I think this is more predictable than the current behaviour.

This is related to https://github.com/phpstan/phpstan-webmozart-assert/pull/120 and will help me use a stricter type checking approach there to fix the int-range assertions because I don't have the annoying null anymore.

Downside: I kind of started duplicating parts of SpecifiedTypes::normalize which is not part of the API yet. I don't have a problem with that, but if we want to make it part of the API I could get rid of most of the logic in determineVariableTypeFromSpecifiedTypes.

Hello I just updated phpstan-webmozart-assert to v1.0.7 and my codebase started reporting this error:

Call to static method Webmozart\Assert\Assert::upper() with non-empty-string will always evaluate to true.

It's failing in the following class construct

final class CityCode
{
    private function __construct(private string $cityCode)
    {
    }

    public static function fromString(string $cityCode) : self
    {
        Assert::length($cityCode, 3);
        Assert::upper($cityCode);

        return new self($cityCode);
    }
}

I'm not using the non-empty-string type assertion anywhere so it must be resolved from the length assertion, however that doesn't ensure what upper is doing.

Thank you for looking into this, and all your great work.

Closes #46 by showing that this has been fixed already. I think. If wrong - maybe somebody can point me in the direction to reproduce it to create a failing test?

Closes https://github.com/phpstan/phpstan-webmozart-assert/issues/118 Closes https://github.com/phpstan/phpstan-webmozart-assert/issues/119 Closes https://github.com/phpstan/phpstan-webmozart-assert/issues/130

~~Looks like the rootExpr approach is potentially making problems if the same thing is asserted twice in a row, where previously it would detect the second one as always evaluating to true/false. But this could be related to the all* implementation here too.~~

adds failing test for https://github.com/phpstan/phpstan-webmozart-assert/issues/39

it seems there is already some kind of keyExists handling, but it does not work yet for the added testcase

I bumped from 1.0.9 to 1.1.2 ; I assume it's related to https://github.com/phpstan/phpstan-webmozart-assert/commit/56d7b275770edda6a7c39c2e6135c33a6e8e955b @herndlm

class Foo
{
    /** @var array<int, array{id: string, num_order: string}> */
    protected array $orders = [];

    public function setOrders(array $orders): self
    {
        Assert::allCount($orders, 2);
        Assert::allKeyExists($orders, 'id');
        Assert::allKeyExists($orders, 'num_order');

        $this->orders = $orders;

        return $this;
    }
}

Related to #62 /cc @villfa

$encryptedValue = "some value";
$valueParts = explode(':', $encryptedValue);

Assert::count(
    $valueParts,
    2,
    'Encrypted secret parameter was expected to consist of 2 parts separated by a colon'
);
// Call to static method Webmozart\Assert\Assert::count() with arguments non-empty-array<int, string>, 2 and 'error' will always evaluate to true

This PR contains the following updates:

| Package | Type | Update | Change | |---|---|---|---| | dealerdirect/phpcodesniffer-composer-installer (source) | require-dev | major | ^0.7.0 -> ^1.0.0 |

Release Notes

Configuration

📅 Schedule: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

• [ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

A nested array like:

    /**
     * @param mixed[] $requestData
     *
     * @return array{
     *     accountId: int,
     *     errorColor: string|null,
     *     theme: array{
     *         backgroundColor: string|null,
     *         textColor: string|null,
     *         headerImage: array{id: int}|null,
     *     },
     * }
     */

https://phpstan.org/r/652f74f8-c926-4802-99b9-bab73da329dd

As requested the none webmozart assert implementation: https://phpstan.org/r/f535c1bb-82e3-4e49-a1d6-ee31c25339fe / https://phpstan.org/r/371acae7-1694-46bc-9d4e-2aa2c653134e (more dumps)

Is not possible to be validated as it seems to lost type after:

        Assert::keyExists($requestData['theme'], 'headerImage');
        Assert::nullOrIsArray($requestData['theme']['headerImage']);

        \Phpstan\dumpType($requestData);
        \Phpstan\dumpType($requestData['theme']);
        \Phpstan\dumpType($requestData['theme']['headerImage']);

4     Dumped type: array&hasOffset('errorColor')&hasOffset('theme')
5     Dumped type: mixed
6     Dumped type: mixed

Not sure if this is even possible. I see the complexness and also know that my solution is not the best. And should maybe go with json validation or something like that instead of validating array manually. Still I thought about reporting it.

PS: any possibility to enable Webmozart/Assert on https://phpstan.org/ ?

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

• [ ] Update dependency slevomat/coding-standard to v8.8.0

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• [ ] Update dependency dealerdirect/phpcodesniffer-composer-installer to v1

Detected dependencies

• [ ] Check this box to trigger a request for Renovate to run again on this repository

class A {
	public function __construct(private string $val) {
	}	
}

function foo(A $a) {
    Assert::inArray($a, [new A('a')]);
}

gives:

Call to static method Webmozart\Assert\Assert::inArray() with arguments A and array(A) will always evaluate to true

I released 1.4.0 with some new assertions that should be added here.

• Assert::ip()
• Assert::ipv4()
• Assert::ipv6()
• Assert::notRegex()
• Assert::interfaceExists()
• Assert::isList()
• Assert::isMap()