This PR intends to replace the "Send" and "Forward" buttons by a single action menu ("..." menu) providing these functionalities plus the "Reply all" function

To do

• [x] Position actions at the top right
• [x] Expand the popover menu to a vertical group of buttons

Expected behavior

When foreign characters are in e-mail sender's e-mails , mails are shown in the mailbox's lists.

Actual behavior

When this particular e-mail sender's e-mails are in mail header, app hang and can not show mailbox content (spinner running all the time). Examples (bold characters): struè[email protected], voð[email protected], grað[email protected]...

error log: Caused by OCA\Mail\Exception\ServiceException: Sync failed for 26:INBOX: An exception occurred while executing 'INSERT INTO "oc_mail_recipients" ("message_id", "type", "label", "email") VALUES(?, ?, ?, ?)' with params [634589, 0, "\x73\x74\x72\x75\xe8\x6e\x6f\x67\x40\x69\x70\x7a\x2e\x68\x72", "\x73\x74\x72\x75\xe8\x6e\x6f\x67\x40\x69\x70\x7a\x2e\x68\x72"]: SQLSTATE[22021]: Character not in repertoire: 7 ERROR: invalid byte sequence for encoding "UTF8": 0xe8 0x6e 0x6f

Mail app

Mail app version: 1.33

Mailserver or service: Postfix

Server configuration

Operating system: Debian 9.12

Web server: Apache2 - 2.4.25

Database: PostgreSQL 9.6.17 on x86_64-pc-linux-gnu

PHP version: 7.3.17

Nextcloud Version: 18.0.3

Client configuration

Browser: Google Chrome 81.x

Operating system: Windows 10

Expected behavior

cron should finish without error. The memory_limit in /etc/php/7.4/cli/php.ini is 4096m, so this should be plenty.

Actual behavior

Two times per day, the cronjob gets killed because of exhausting memory. Before I set a memory_limit, I just saw that php was getting killed by the kernel and that nextcloud was down for several minutes. Then, I did set a memory limit and so I started getting the following message twice a day:

PHP Fatal error:  Allowed memory size of 4294967296 bytes exhausted (tried to allocate 262144 bytes) in /var/www/****/cloud.****/apps/mail/lib/IMAP/Threading/Container.php on line 111
PHP Fatal error:  Allowed memory size of 4294967296 bytes exhausted (tried to allocate 262144 bytes) in Unknown on line 0

Mail app

Mail app version: 1.5.0

Mailserver or service: self-hosted dovecot

Server configuration

Operating system: Ubuntu 20.04

Web server: Nginx

Database: MariaDB

PHP version: 7.4

Nextcloud Version: 20.0.0

Client configuration

(doesn't apply here) Operating system: (e.g. Arch Linux)

Expected behavior

Mail should get loaded and displayed when clicking on the header.

Actual behavior

The mail headers are getting loaded after minutes. When selecting an email it takes another 1-2 minutes, then it display "Not found Could not load your message" Occasionally the email get displayed like every 4th try or so.

Same mail account (IMAP account on MXROUTE) works with other mail clients (thunderbird, iPhone) w/o problems.

Mail app

Mail app version: 1.3.0

Mailserver or service: MXRoute (IMAP)

Server configuration

Operating system: Ubuntu server 16.04

Web server: Apache (Nextcloud Docker) and nginx reverse proxy

Database: MySQL 10.0.38

PHP version: 7.3.16

Nextcloud Version: official Nextcloud Docker 18.0.3

Client configuration

Browser: Opera, Google Chrome, Firefox

Operating system: Ubuntu 16.04, Win 10

Logfile content, when it doesn't work: OCA\Mail\Exception\ServiceException: Sync failed: Mail server denied authentication.

/var/www/html/custom_apps/mail/lib/Service/Sync/SyncService.php - line 107:

OCA\Mail\Service\Sync\ImapToDbSynchronizer->sync(OCA\Mail\Account {}, OCA\Mail\Db\Mailbox { id: 74}, 42, [ 40,39,38,3 ... 1], false)

/var/www/html/custom_apps/mail/lib/Controller/FoldersController.php - line 124:

OCA\Mail\Service\Sync\SyncService->syncMailbox(OCA\Mail\Account {}, "INBOX", 42, [ 40,39,38,3 ... 1], true, null)

/var/www/html/lib/private/AppFramework/Http/Dispatcher.php - line 170:

OCA\Mail\Controller\FoldersController->sync(5, "SU5CT1g=", [ 40,39,38,3 ... 1], false, null)

/var/www/html/lib/private/AppFramework/Http/Dispatcher.php - line 99:

OC\AppFramework\Http\Dispatcher->executeController(OCA\Mail\Con ... {}, "sync")

/var/www/html/lib/private/AppFramework/App.php - line 125:

OC\AppFramework\Http\Dispatcher->dispatch(OCA\Mail\Con ... {}, "sync")

/var/www/html/lib/private/AppFramework/Routing/RouteActionHandler.php - line 47:

OC\AppFramework\App::main("OCA\\Mail\\ ... r", "sync", OC\AppFramew ... {}, { accountId: ... "})

<<closure>>

OC\AppFramework\Routing\RouteActionHandler->__invoke({ accountId: ... "})

/var/www/html/lib/private/Route/Router.php - line 299:

call_user_func(OC\AppFramew ... {}, { accountId: ... "})

/var/www/html/lib/base.php - line 1008:

OC\Route\Router->match("/apps/mail/ ... c")

/var/www/html/index.php - line 38:

OC::handleRequest()

Caused by Horde_Imap_Client_Exception: Mail server denied authentication.

/var/www/html/custom_apps/mail/vendor/pear-pear.horde.org/Horde_Imap_Client/Horde/Imap/Client/Base.php - line 838:

Horde_Imap_Client_Socket->_login("*** sensiti ... *")

/var/www/html/custom_apps/mail/vendor/pear-pear.horde.org/Horde_Imap_Client/Horde/Imap/Client/Base.php - line 1598:

Horde_Imap_Client_Base->login("*** sensiti ... *")

/var/www/html/custom_apps/mail/vendor/pear-pear.horde.org/Horde_Imap_Client/Horde/Imap/Client/Base.php - line 4038:

Horde_Imap_Client_Base->status(Horde_Imap_Client_Mailbox {}, 8713)

/var/www/html/custom_apps/mail/vendor/pear-pear.horde.org/Horde_Imap_Client/Horde/Imap/Client/Base.php - line 3632:

Horde_Imap_Client_Base->_syncStatus(Horde_Imap_Client_Mailbox {})

/var/www/html/custom_apps/mail/lib/IMAP/Sync/Synchronizer.php - line 62:

Horde_Imap_Client_Base->sync(Horde_Imap_Client_Mailbox {}, "U41,V1583101203,H89", { criteria: ... }})

/var/www/html/custom_apps/mail/lib/Service/Sync/ImapToDbSynchronizer.php - line 227:

OCA\Mail\IMAP\Sync\Synchronizer->sync(Horde_Imap_C ... e}, OCA\Mail\IMAP\Sync\Request {}, 8)

/var/www/html/custom_apps/mail/lib/Service/Sync/ImapToDbSynchronizer.php - line 148:

OCA\Mail\Service\Sync\ImapToDbSynchronizer->runPartialSync(OCA\Mail\Account {}, OCA\Mail\Db\Mailbox { id: 74}, 42, [ 40,39,38,3 ... 1])

/var/www/html/custom_apps/mail/lib/Service/Sync/SyncService.php - line 107:

OCA\Mail\Service\Sync\ImapToDbSynchronizer->sync(OCA\Mail\Account {}, OCA\Mail\Db\Mailbox { id: 74}, 42, [ 40,39,38,3 ... 1], false)

/var/www/html/custom_apps/mail/lib/Controller/FoldersController.php - line 124:

OCA\Mail\Service\Sync\SyncService->syncMailbox(OCA\Mail\Account {}, "INBOX", 42, [ 40,39,38,3 ... 1], true, null)

/var/www/html/lib/private/AppFramework/Http/Dispatcher.php - line 170:

OCA\Mail\Controller\FoldersController->sync(5, "SU5CT1g=", [ 40,39,38,3 ... 1], false, null)

/var/www/html/lib/private/AppFramework/Http/Dispatcher.php - line 99:

OC\AppFramework\Http\Dispatcher->executeController(OCA\Mail\Con ... {}, "sync")

/var/www/html/lib/private/AppFramework/App.php - line 125:

OC\AppFramework\Http\Dispatcher->dispatch(OCA\Mail\Con ... {}, "sync")

/var/www/html/lib/private/AppFramework/Routing/RouteActionHandler.php - line 47:

OC\AppFramework\App::main("OCA\\Mail\\ ... r", "sync", OC\AppFramew ... {}, { accountId: ... "})

<<closure>>

OC\AppFramework\Routing\RouteActionHandler->__invoke({ accountId: ... "})

/var/www/html/lib/private/Route/Router.php - line 299:

call_user_func(OC\AppFramew ... {}, { accountId: ... "})

/var/www/html/lib/base.php - line 1008:

OC\Route\Router->match("/apps/mail/ ... c")

/var/www/html/index.php - line 38:

OC::handleRequest()

Expected behavior

Writing mail, I should be able to delete text by using delete or backspace key. I also should be able to copy/paste text.

Actual behavior

When I answer a mail, I can delete 1 or 2 chars with backspace and then it stops working and I cannot anymore delete chars (even with delete key). The only solution is to select text with mouse and type another text to overwrite it (though the final result that the recipient will receive may not look the same as what you see).

Copying text to the clipboard doesn't work neither.

Issues are not reproducible in Chromium 84.

Mail app

Mail app version: 1.4.1

Mailserver or service: Personal server (Dovecot + Postfix)

Server configuration

Operating system: Official Docker fpm image

Web server: Nginx

Database: PostgreSQL

PHP version: Official docker image

Nextcloud Version: 19.0.4

Client configuration

Browser: Firefox 83

Operating system: Windows

~~Partially~~ mostly implements #318 Fixes https://github.com/nextcloud/mail/issues/244, #318, https://github.com/nextcloud/mail/issues/335, https://github.com/nextcloud/mail/issues/290

• Sync

  • [x] Use horde sync to get new/changed/vanished messages
  • [x] Implement message mapper (reuse old code if possible)
  • [x] Implement sync mechanism in the client
  • [x] Implement sync for the unified inbox
  • [x] Update unified inbox if individual ones change
  • [x] Implement sync for search mailboxes – should work now fingers crossed
  • [x] Implement pagination for search mailboxes
  • [x] test search

• Pagination

  • [x] Implement date-based cursor-based pagination on the server
  • [x] Implement new pagination on the client
  • [x] Implement pagination for the unified inbox

• Necessary follow-ups

  • Kill background sync. It's extremely buggy in its current form. If the new horde sync approach is fast enough, I'm planning to just let the current folder view refresh its content once a minute. If the folder is a specific inbox, we refresh the unified one. This should cover everything.

Drag'n'Drop support implementation with https://github.com/Vivify-Ideas/vue-draggable

Remaining issues:

• [ ] It seems the code isn't properly initialized: If you load the mail apps from your browser, the drag'n'drop functionality won't work directly. You first have to perform an action (eg: selecting another email than the default one displayed) before the drag'n'drop functionality will work;
• [ ] Shouldn't navigate when the moved message is not tghe one currently displayed
• [ ] Do not expand when folder's account is not the same as envelope account
• [ ] Polishing

• [x] BLOCKED requires a release of @nextcloud/vue that includes https://github.com/nextcloud/nextcloud-vue/pull/1759, e.g. 4.0.0-alpha.5

This pull request adds the capability to resize all columns inside Mail within a certain range that makes sense. Chosen column widths are saved automatically.

Here's a demo GIF (3mb, 40sec):

Implementation

It is using splitpanes for the heavy lifting, which is pretty simple, seems well maintained and Vue3 compatible, if someone ever dares to upgrade... 😉

The settings are stored the same way as the collect-data flag for example and passed into the Vue instance straight from the template. Saving the settings is triggered on an event called resized.

Due to the structure of the components, there are two "stacked" <Splitpanes>, each with two <Pane> elements. The first is in Home.vue and controls the very left mailbox nav column <Navigation> and the main content region <MailboxThread>. The main content region holds the envelope list (middle column) and main thread/mail detail view (right column), which are wrapped by the second <Splitpanes> element in MailboxThread.vue.

There had to be some minor styling changes to existing elements due to the structural change. Visually, nothing should have changed except for the 7px wide column resize bars between the panes.

I chose to store the defaults for size, min and max in a local data object:

paneDefaults: {
	aside: {
		size: 25,
		min: 15,
		max: 40,
	},
	main: {
		size: 75,
		min: 60,
		max: 85,
	}
}

... these could be set as properties on the <Pane> elements directly, but I wanted to have them (comparable) in one spot, which makes changing them a little easier. If that's too verbose for you, we could move it to the <Pane>, that's fine with me.

Note: If you look into the diff of src/components/MailboxThread.vue it seems like there are a lot of changes in the template section, but I actually just wrapped the other components with no changes to them whatsoever. 🤷‍♂️

Related issues: #4098 #567

Fixes https://github.com/nextcloud/mail/issues/3940

Signed-off-by: Johannes Brückner [email protected]

Expected behavior

Everything runs smooth after update of mail-app.

Actual behavior

After app-update to version 1.0.0 the warning "KItinerary binary adapter is not available, can't extract information" shows up in the server-log, twice for each mail I open. Also the white space in the app looks a bit odd (don't know if related).

Mail app

Mail app version: 1.0.0

Mailserver or service: self hosted

Server configuration

Operating system: Ubuntu 18.04

Web server: Apache 2.4.29

Database: mariadb 10.1.43

PHP version: 7.2.24

Nextcloud Version: 17.0.2

Client configuration

Browser: Firefox 72.0.1

Operating system: Ubuntu 18.04

Expected behavior

Mail app loads inboxes of mail accounts

Actual behavior

Mail app shows "Could not open inbox" for every mail account

Description

This is an unfortunate "revival" of the bug fixed here: https://github.com/nextcloud/mail/pull/309 Only this time it's in https://github.com/nextcloud/mail/blob/master/lib/Address.php#L82

Happy to help with a PR, but since it's such a small change it might be faster for an active maintainer to do it 😊 (because I don't know if I have everything set up in regards to commit signing and such...)

Mail app

Mail app version: 1.7.2

Mailserver or service: n/a

Server configuration

Operating system: Alpine

Web server: Nginx

Database: MariaDb

PHP version: 7.4.14

Nextcloud Version: 20.0.4

Client configuration

Browser: n/a

Operating system: n/a

Steps to reproduce

1. Select a Email from the list
2. on the preview it appears an error that the email can't be loaded
3. if i send a new email to the account it appears on the list , but only the preview doesn't work

Mail app

**Mail app version: 0.7.7

Nextcloud version: 12.0.4 Debian Jessie Apache/2.4.10 (Debian) PHP Version: 5.6.33 mysql Version: 5.5.58

Useragent : Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0

Ref https://github.com/nextcloud/groupware/issues/41

Needs:

• [x] https://github.com/nextcloud/mail/pull/7859
• [x] https://github.com/nextcloud/mail/pull/7862
• [x] https://github.com/nextcloud/mail/pull/7860
• [x] https://github.com/nextcloud/mail/pull/7861

After merge:

• [ ] Remove required status for old linter
• [ ] Make new linter required

IpUtils is required to check if a given ip address is withing a range.

To backport the functionality the class was copied from the library to lib/private therefore the different namespace.

Signed-off-by: Daniel Kesselberg [email protected]

fixes: #7095

This is an old bug. Most probably this should be fixed on nc/vue but i dont see which change caused this error there. This error can be caused also from some server css, but so far i failed to find the right change, so pushing this pr till we figured it out. before after

Steps to reproduce

1.create an e-mail 2.start writing something in the e-mail 3.pause for a bit (might be optional) 4.write some more 5.repeat 3-4

Expected behavior

create only one draft in the draft folder

Actual behavior

multiple drafts in the draft folder, I sometimes got 6 drafts with different states of my e-mail writing.

Mail app version

2.2.2.

Mailserver or service

netcup and gmail

Operating system

docker container

PHP engine version

PHP 8.1

Web server

Apache (supported)

Database

MySQL

Additional info

happens for all my useres (all are using netcup) as e-mail provider. Additionally I added a gmail account to make sure, that this is not an issue with netcup, but this also happens with gmail as mail provider.

Is your feature request related to a problem? Please describe.

When changing the Nextcloud instance, the e-mail accounts must be set up again.

Describe the solution you'd like

The ability to export and import e-mail accounts using the User Migration App.

Describe alternatives you've considered

No response

Additional context

Bumps amphp/parallel from 1.4.1 to 1.4.2.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-command.