Due to the recent 2.2.0 update, which added ignition solutions, I can't get your package to work :sweat_smile: At least I think this is the culprit. Here's the stack trace:

Generating optimized autoload files
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover --ansi

   Illuminate\Contracts\Container\BindingResolutionException  : Target [Facade\IgnitionContracts\SolutionProviderRepository] is not instantiable.

  at /opt/vendor/laravel/framework/src/Illuminate/Container/Container.php:979
    975|         } else {
    976|             $message = "Target [$concrete] is not instantiable.";
    977|         }
    978| 
  > 979|         throw new BindingResolutionException($message);
    980|     }
    981| 
    982|     /**
    983|      * Throw an exception for an unresolvable primitive.

  Exception trace:

  1   Illuminate\Container\Container::notInstantiable("Facade\IgnitionContracts\SolutionProviderRepository")
      /opt/vendor/laravel/framework/src/Illuminate/Container/Container.php:813

  2   Illuminate\Container\Container::build("Facade\IgnitionContracts\SolutionProviderRepository")
      /opt/vendor/laravel/framework/src/Illuminate/Container/Container.php:682

  Please use the argument -v to see more details.
Script @php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 1

When I revert to version 2.1.1 the bug goes away.

Hi, I was trying to install your package, but I have an error and your migration and config publish don't work:

Migrating: 2019_03_16_005237_create_permissions_table

Illuminate\Database\QueryException : SQLSTATE[42000]: Syntax error or access violation: 1103 Incorrect table name '' (SQL: create table `` (id int unsigned not null auto_increment primary key, name varchar(255) not null, slug varchar(255) not null, description text not null, deleted_at timestamp null, created_at timestamp null, updated_at timestamp null) default character set utf8mb4 collate 'utf8mb4_unicode_ci')

at C:----- 660| // If an exception occurs when attempting to run a query, we'll format the error 661| // message to include the bindings with SQL, which will make this exception a 662| // lot more helpful to the developer instead of just the database's errors. 663| catch (Exception $e) {

664| throw new QueryException( 665| $query, $this->prepareBindings($bindings), $e 666| ); 667| } 668|

Exception trace:

1 PDOException::("SQLSTATE[42000]: Syntax error or access violation: 1103 Incorrect table name ''") C:-----

2 PDO::prepare("create table `` (id int unsigned not null auto_increment primary key, name varchar(255) not null, slug varchar(255) not null, description text not null, deleted_at timestamp null, created_at timestamp null, updated_at timestamp null) default character set utf8mb4 collate 'utf8mb4_unicode_ci'") C:-----

Please use the argument -v to see more details.

C:------ λ php artisan vendor:publish --provider="Junges\ACL\ACLServiceProvider::class" --tag="config" Publishing complete.

C:------- λ php artisan vendor:publish --provider="Junges\ACL\ACLServiceProvider::class" --tag="config" Publishing complete.

I hope you can help because I want to use your package.

Thank you

Hi @mateusjunges,

This PR adds some solutions for the laravel-acl package.

These are custom solutions for the ignition error page package as requested on issue #137.

The solutions added are as follows:

• Junges\ACL\Solutions\ACLNotInstalledSolution.php
• Junges\ACL\Solutions\AddMissingACLWildcardsTraitSolution.php
• Junges\ACL\Solutions\AddMissingGroupsTraitSolution.php
• Junges\ACL\Solutions\AddMissingPermissionsTraitSolution.php
• Junges\ACL\Solutions\AddMissingUsersTraitSolution.php
• Junges\ACL\Solutions\GroupDoesNotExistSolution.php
• Junges\ACL\Solutions\PermissionDoesNotExistSolution.php

These solutions are all runnable.

The solutions that are runnable are based on the SolutionProvider method as it is able to capture the exception and determine if it should be given a solution. These are registered in the ACLServiceProvider class with registerSolutionProviders()

Also added to some of the Exceptions is a solution that is returned as some of them cannot be fixed by means of a solution.

Please confirm if they are alright for the basic offering of solutions for the package.

The has methods now use eager loaded Groups & Permissions. These methods are heavily used in blade via their respective directives - this is why they should rely on eager loaded relationships when preforming checks. Related to #112

I am getting an error when assigning a permission to my user

My UserController.php file:

        $user = User::create([
            'name' => $data['name'],
            'email' => $data['email'],
            'password' => Hash::make($data['password']),
        ]);
        if ($data['permission']) {
            $permissions = [];
            foreach ($data['permission'] as $key => $value) {
                $permissions[] = $key;
            }
            $user->assignPermissions($permissions);
        }
        if ($data['group']) {
            $user->assignGroup($data['group']);
        }

a permiision with that slug exists in db in permissions table, But it shows an exception: There is no permission with this slug: 'c-order' I didn't change anything in config files

Issue:

When checking for permissions via blade directives, each check results in a new DB query. Granted, these queries take between 200 & 500 μs, but consider the following use-case: I have a sidebar. For each link in that sidebar, I want to check user permissions. How many links I have there equals to how many queries I'll have when rendering each page.

Sugestions:

I tried eager loading permissions and groups.permissions, then I checked the code and figured out that that didn't matter. The hasPermission() makes a new DB query anyway. It would be great if the Junges\ACL\Traits\UsersTrait could be changed to use eager-loaded relations, instead of making new queries. The other solution would be to register a singleton via your service provider, which would query the database at least two times, to load all Permissions & Groups.

1st, i tried to use artisan command with phpstorm, but the command seems to be not registered(no autocomplete). 2nd, when trying to call artisan command programmatically, it cant bypass the confirm function inside the CreateGroup.php(console\commands). also, there is Portuguese language in that confirmation prompt, maybe use English so its easier to understand? PS: i use google translate to understand that prompt message.

the point is, i want to be able to seed my permission database such as admin permissions and regular member/user permissions with different group without the need to manually issuing command to artisan for each and every one of the group or permission.

Laravel v5.8.16 ACL v1.6.0

Is your feature request related to a problem? Please describe.

When permissions are denied using the built-in middlewares, there is no list of denied permissions/groups being passed on with the exception to the custom handler. I would like to catch them along with the 403 denied message.

Example:

Route::middleware('permissions:One', 'permissions:Two', 'permissions:Three')->group(function(){

	Route::get('/', 'IndexController@index')->name('home');

});

When permissions One and Three gets denied, I would like the exception to show them. Currently the exception is like below:

Junges\ACL\Exceptions\UnauthorizedException ~statusCode: 403~headers: Array(0)*message: "This user does not have the necessary permissions to access this route"...
~statusCode: 403
~headers: Array(0)
*message: "This user does not have the necessary permissions to access this route"
~string: ""
*code: 0
*file: "<application-path>\vendor\mateusjunges\laravel-acl\src\Exceptions\UnauthorizedException.php"
*line: 33
~trace: Array(43)
~previous: null

I would like it to be, for the above case : (refer after *message)

Junges\ACL\Exceptions\UnauthorizedException ~statusCode: 403~headers: Array(0)*message: "This user does not have the necessary permissions to access this route"...
~statusCode: 403
~headers: Array(0)
*message: "This user does not have the necessary permissions to access this route"

    * denied : Array [
        0: One
        1: Three
    ]

~string: ""
*code: 0
*file: "<application-path>\vendor\mateusjunges\laravel-acl\src\Exceptions\UnauthorizedException.php"
*line: 33
~trace: Array(43)
~previous: null

Describe the solution you'd like

I have gone this far in catching the denied permissions list

PermissionMiddleware.php

public function handle($request, Closure $next, $permissions)
	{
		if (Auth::guest()) {
			throw UnauthorizedException::notLoggedIn();
		}

                // New Array
		$denied_permissions = [];

		$permissions = is_array($permissions)
			? $permissions
			: explode('|', $permissions);
		foreach ($permissions as $permission) {
			if (Auth::user()->can($permission)) {
				return $next($request);
			} else {
				array_push($denied_permissions, $permission);
			}
		}

		throw UnauthorizedException::forPermissions($denied_permissions);
	}

And, receiving it in

UnauthorizedException.php

public static function forPermissions($denied_permissions): self
	{
		$message = trans('acl::acl.forPermissions');

		$denied = $denied_permissions;

		return new static(Response::HTTP_FORBIDDEN, $message, null, $denied);
	}

But, I am unable to pass it to the Laravel Response.

Describe alternatives you've considered None. I am not sure, this is the right approach. I tried some way to make it work for me. This is my first time contributing in the forum. Pardon if anything is not right.

Additional context Add any other context or screenshots about the feature request here.

When trying to revoke groups from user by passing an array of slugs there is an exception (notice) and group isnt revoked:

$user->revokeGroup(['petty-cash-user'])
PHP Notice:  Trying to get property 'id' of non-object in D:/Proyectos/software/vendor/mateusjunges/laravel-acl/src/Traits/UsersTrait.php on line 200

Line 200 should be return $_group->id instead of return $group->id;

I am testing the $user->syncPermissions(); but when you not send any permission (Null) it giving me:

Argument 1 passed to App\User::syncPermissions() must be of the type array, null given, called in

The problem is this function:

public function syncPermissions(array $permissions) { $permissions = $this->convertToPermissionIds($permissions); if ($permissions->count() == 0) return false; $this->permissions()->sync($permissions); return $this;

}

So I suggest to add null parameter.

Due to migration class name collisions

Laravel-acl v4.x Laravel v9.6.0 PHP v8.0.11

                                                     
  Symfony\Component\ErrorHandler\Error\FatalError                                          
                                                                                            
  Cannot declare class CreatePermissionsTable, because the name is already in use           
                                                                                            
  at C:\laragon\www\...\database\migrations\2022_04_02_070448_create_acl_permissions_table.php
      3▕ use Illuminate\Database\Migrations\Migration;                                      
      4▕ use Illuminate\Database\Schema\Blueprint;                                          
      5▕ use Illuminate\Support\Facades\Schema;                                             
      6▕                                                                                    
      7▕ class CreatePermissionsTable extends Migration                                     
      8▕ {                                                                                  
      9▕     public function up()                                                           
     10▕     {                                                                              
     11▕         $permissionsTable = config('acl.tables.permissions', 'permissions');       
                                                                                            
                                                                                            
   Whoops\Exception\ErrorException                                                          
                                                                                            
  Cannot declare class CreatePermissionsTable, because the name is already in use           

As I read from the https://laravel-news.com/laravel-anonymous-migrations

The Laravel team released Laravel 8.37 with anonymous migration support, which solves a GitHub issue with migration class name collisions. The core of the problem is that if multiple migrations have the same class name, it'll cause issues when trying to recreate the database from scratch.

The anonymous class feature is also backward-compatible with named migration classes to benefit from this feature in Laravel 8!

I have solved the error by changing migration classes into anonymous classes. and it works.

I have updated from Laravel 8 to Laravel 9 but now I get an error that I can't find solutions on the net, I don't know what to do

Error PHP 8.1.6 9.32.0 Cannot assign null to property Junges\ACL\AclRegistrar::$cacheKey of type string