Hi, and thanks for the wonderful module. I've spent some time making the module work on Docker, and I can confirm it's working fine. But I've stumbled upon some issues. The module makes two php calls, which obviously can't work inside a node container, and I don't find it a good idea to use mixed purpose containers (php+node). Fortunately, the calls are really simple so I've just run them and saved the output:
php -r "require 'app/vendor/autoload.php'; foreach ((new \Magento\Framework\Component\ComponentRegistrar)->getPaths('module') as \$m) echo \$m.PHP_EOL;" > modules.cfg
php -r "echo json_encode( require 'app/etc/env.php' ?? []);" > settings.cfg This can be easily run inside the php container and stored in a location of your choice. After that, I've just rewritten the cache-clean.js to use the two saved files. I am not fluent enough with closurescript to do a PR, but it will be a nice option to check first for a static file with configuration, and if not present then proceed with php calls. This will allow some further customizations like having a more fine-grained filter for watch locations. I don't think I need to watch for files inside vendor, or at least not for all of them.

This is kind of a follow-up of #54.

When I switch branches / git stash / git stash pop, I got the following error:

PHP Warning:  require(/var/www/shop/vendor/composer/../namespace/module/registration.php): failed to open stream: No such file or directory in /var/www/shop/vendor/composer/autoload_real.php on line 70
PHP Fatal error:  require(): Failed opening required '/var/www/shop/vendor/composer/../namespace/module/registration.php' (include_path='/var/www/shop/vendor/magento/zendframework1/library:.:/usr/share/php:/var/www/shop/vendor/deployer/recipes:/var/www/shop/vendor/jalogut/magento2-deployer-plus') in /var/www/shop/vendor/composer/autoload_real.php on line 70
11:18:58 ERROR: failed shelling out to php for reading the module list.
11:18:58 ERROR Details: Command failed: php -r "require '/var/www/shop/vendor/autoload.php'; \$bp = strlen(dirname(dirname(realpath('/var/www/shop/vendor/autoload.php')))) + 1; foreach ((new \Magento\Framework\Component\ComponentRegistrar)->getPaths('module') as \$m) echo substr(\$m, \$bp).PHP_EOL;"
PHP Warning:  require(/var/www/shop/vendor/composer/../namespace/module/registration.php): failed to open stream: No such file or directory in /var/www/shop/vendor/composer/autoload_real.php on line 70
PHP Fatal error:  require(): Failed opening required '/var/www/shop/vendor/composer/../namespace/module/registration.php' (include_path='/var/www/shop/vendor/magento/zendframework1/library:.:/usr/share/php:/var/www/shop/vendor/deployer/recipes:/var/www/shop/vendor/jalogut/magento2-deployer-plus') in /var/www/shop/vendor/composer/autoload_real.php on line 70

PHP Warning:  require(/var/www/shop/vendor/composer/../namespace/module/registration.php): failed to open stream: No such file or directory in /var/www/shop/vendor/composer/autoload_real.php on line 70
PHP Fatal error:  require(): Failed opening required '/var/www/shop/vendor/composer/../namespace/module/registration.php' (include_path='/var/www/shop/vendor/magento/zendframework1/library:.:/usr/share/php:/var/www/shop/vendor/deployer/recipes:/var/www/shop/vendor/jalogut/magento2-deployer-plus') in /var/www/shop/vendor/composer/autoload_real.php on line 70
11:18:58 ERROR: failed shelling out to php for reading the theme list.
11:18:58 ERROR Details: Command failed: php -r "require '/var/www/shop/vendor/autoload.php'; \$bp = strlen(dirname(dirname(realpath('/var/www/shop/vendor/autoload.php')))) + 1; foreach ((new \Magento\Framework\Component\ComponentRegistrar)->getPaths('theme') as \$m) echo substr(\$m, \$bp).PHP_EOL;"
PHP Warning:  require(/var/www/shop/vendor/composer/../namespace/module/registration.php): failed to open stream: No such file or directory in /var/www/shop/vendor/composer/autoload_real.php on line 70
PHP Fatal error:  require(): Failed opening required '/var/www/shop/vendor/composer/../namespace/module/registration.php' (include_path='/var/www/shop/vendor/magento/zendframework1/library:.:/usr/share/php:/var/www/shop/vendor/deployer/recipes:/var/www/shop/vendor/jalogut/magento2-deployer-plus') in /var/www/shop/vendor/composer/autoload_real.php on line 70

[ERROR] ENOENT: no such file or directory, watch '/var/www/shop/pub/static/frontend'

Process finished with exit code 1

I see two isses here:

1. The error when switching branches seems to be not fully fixed.
2. There is an error when pub/static/frontend is no directory.
   1. The process should not crash if the directory is missing.
   2. Not sure why this directory is missing. I do not delete it myself. So maybe in some situations the cache clean tool deletes the whole directory?

I m running this in windowns environment and Magento2.2.7 instance so the issue is when try to change in Ui component listing xml file it trigger to remove specific id cache but when i refresh browser it doesn't actually remove cache i have to remove cache using magento command every time. Here is how it run. http://prntscr.com/n4hd3r

Hey,

the watcher crashes right after the start. Maybe my node version is too old? node --version .. v8.11.4

[ERROR] b.setRawMode is not a function npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! [email protected] cache:watch: ./magento/vendor/bin/cache-clean.js -w -d ./magento/ npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the [email protected] cache:watch script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Regards Marcus

Expected Behavior

The cache should be cleared.

Actual Behavior

The following error is thrown:

$ vendor/bin/cache-clean.js
Sponsored by https://www.mage2.tv

Flushing all caches
events.js:167
      throw er; // Unhandled 'error' event
      ^

Error: Redis connection to /tmp/redis.sock:6379 failed - getaddrinfo ENOTFOUND /tmp/redis.sock /tmp/redis.sock:6379
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:57:26)
Emitted 'error' event at:
    at RedisClient.on_error (/Volumes/Development/Sites/mage22/vendor/mage2tv/magento-cache-clean/node_modules/redis/index.js:406:14)
    at Socket.<anonymous> (/Volumes/Development/Sites/mage22/vendor/mage2tv/magento-cache-clean/node_modules/redis/index.js:279:14)
    at Socket.emit (events.js:182:13)
    at emitErrorNT (internal/streams/destroy.js:82:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:50:3)
    at process._tickCallback (internal/process/next_tick.js:63:19)

Steps to Reproduce the Problem

1. Set up Redis to a use a socket
2. Configure Magento to connect to Redis over that socket for Cache, FPC and sessions
3. Run the CLI tool

Specifications

• Magento Version: 2.2.5 (Vanilla, no third-party extensions or themes)
• PHP Version: 7.1.20
• Node.js Version: 10.9.0
• Platform: MacOS 10.13.6

Additional Details

Here is my Redis configuration, which works fine with Magento:

    'session' => [
        'save' => 'redis',
        'redis' => [
            'host' => '/tmp/redis.sock',
            'port' => '6379',
            'password' => '',
            'timeout' => '2.5',
            'persistent_identifier' => '',
            'database' => '3',
            'compression_threshold' => '2048',
            'compression_library' => 'gzip',
            'log_level' => '1',
            'max_concurrency' => '6',
            'break_after_frontend' => '5',
            'break_after_adminhtml' => '30',
            'first_lifetime' => '600',
            'bot_first_lifetime' => '60',
            'bot_lifetime' => '7200',
            'disable_locking' => '0',
            'min_lifetime' => '60',
            'max_lifetime' => '2592000'
        ]
    ],
    'cache' => [
        'frontend' => [
            'default' => [
                'backend' => 'Cm_Cache_Backend_Redis',
                'backend_options' => [
                    'server' => '/tmp/redis.sock',
                    'port' => '6379',
                    'database' => '5'
                ]
            ],
            'page_cache' => [
                'backend' => 'Cm_Cache_Backend_Redis',
                'backend_options' => [
                    'server' => '/tmp/redis.sock',
                    'port' => '6379',
                    'database' => '4',
                    'compress_data' => '0'
                ]
            ]
        ]
    ],

Hey,

when I make changes in the menu.xml only the "config" cache is cleaned. To see my change I need to clean the "block_html" cache as well.

Regards Marcus

Hey Vinai,

I've a problem with your module. The cache is not cleaned as it should. The output of your module is correct. The cache to be cleaned should be "config". After your module finds the change the message "Cleaning cache type(s) config" appears but the cache is not clean. When i run "./bin/magento cache:clean config" .. it works. Any ideas?

Command & Output

./magento/vendor/bin/cache-clean.js -v -w -d ./magento/

Sponsored by https://www.mage2.tv

Magento dir ./magento/
Watcher initialized (Ctrl-C to quit)
Processing /srv/http/xxx/magento/vendor/xxx/xxx/view/adminhtml/ui_component/xxx_order_grid.xml
Cleaning cache type(s) config

Change in file

<column name="filename">
	<settings>
		<label translate="true">Filename</label>
		<filter>text</filter>
	</settings>
</column>

->

<column name="filename">
	<settings>
		<label translate="true">Filename</label>
		<filter>text</filter>
		<bodyTmpl>ui/grid/cells/html</bodyTmpl>
	</settings>
</column>

Config

'cache' => [
        'frontend' => [
            'default' => [
                'backend' => 'Cm_Cache_Backend_Redis',
                'backend_options' => [
                    'server' => '127.0.0.1',
                    'database' => '0',
                    'port' => '6379'
                ]
            ],
            'page_cache' => [
                'backend' => 'Cm_Cache_Backend_Redis',
                'backend_options' => [
                    'server' => '127.0.0.1',
                    'database' => '1',
                    'port' => '6379',
                    'compress_data' => '0'
                ]
            ]
        ]
    ]

Thx Marcus

Description

When developing using docker for mac, the watcher doesn't not notice changes from host. However, if we change a file inside the container, the watcher notices it right away.

Specifications

1. Docker for mac version 18.06.0-ce-mac70
2. Magento community edition 2.2.5

Steps to reproduce

1. Enable watcher docker-compose exec phpfpm vendor/bin/cache-clean.js --watch
2. Modify any .phtml file

NOTE: If you need, I can provide the docker-compose.yml file or help you to reproduce it.

Expected result

Watcher notices the change and clears caches

Actual result

Nothing happens. Even using verbose output, nothing is happening. The watcher does not notice the changes.

NOTE: It works if we edit the file directly inside the container

When making a change to a UI Components layout file, the watcher see's that the file has changed, but the frontend does not reflect the updated config. See attached screenshot where I change the label of the ID field in the layout file.

I have to use the option (a) to clear all cache to get it to reflect the change.

Not yet fully reproducible...

Do you know anything about that?

For example it seems to happen when deleting lots of files, moving stuff around and/or composer reinstalling ...

When I press v button or make a change in a layout xml file I'm getting the error below. No clue as to what it means so I'm posting it here.

> cache-clean.js --watch
Release 1.0.39 sponsored by https://www.mage2.tv

Hot-keys for manual cache cleaning:
[c]onfig [b]lock_html [l]ayout [t]ranslate [f]ull_page [v]iew [a]ll

Clean generated code: [G]
Clean integration test sandboxes: [I]
Clean static content areas: [F]rontend [A]dminhtml

Watcher initialized (Ctrl-C to quit)
10:12:41 Cleaning cache type(s) layout full_page
/Users/rikwillems/.composer/vendor/mage2tv/magento-cache-clean/bin/cache-clean.js:209
g.ea=function(a,b,c){a=0;for(var d=c;;)if(a<this.j){var e=of(this,a);c=e.length;a:for(var f=0;;)if(f<c){var h=e[f];d=b.b?b.b(d,h):b.call(null,d,h);if(hd(d)){e=d;break a}f+=1}else{e=d;break a}if(hd(e))return Xb(e);a+=c;d=e}else return d};g.ma=function(a,b,c){if("number"===typeof b)return this.Vb(b,c);throw Error("Vector's key for assoc must be a number.");};
                                                                                                                                                                                                                                                                                                             ^

Error: Vector's key for assoc must be a number.
    at V.g.ma (/Users/rikwillems/.composer/vendor/mage2tv/magento-cache-clean/bin/cache-clean.js:209:308)
    at Function.Bd.f (/Users/rikwillems/.composer/vendor/mage2tv/magento-cache-clean/bin/cache-clean.js:81:60)
    at hk (/Users/rikwillems/.composer/vendor/mage2tv/magento-cache-clean/bin/cache-clean.js:374:52)
    at $l (/Users/rikwillems/.composer/vendor/mage2tv/magento-cache-clean/bin/cache-clean.js:446:116)
    at /Users/rikwillems/.composer/vendor/mage2tv/magento-cache-clean/bin/cache-clean.js:446:430
    at /Users/rikwillems/.composer/vendor/mage2tv/magento-cache-clean/bin/cache-clean.js:321:275
    at V.g.ea (/Users/rikwillems/.composer/vendor/mage2tv/magento-cache-clean/bin/cache-clean.js:209:133)
    at tb (/Users/rikwillems/.composer/vendor/mage2tv/magento-cache-clean/bin/cache-clean.js:102:350)
    at Rg (/Users/rikwillems/.composer/vendor/mage2tv/magento-cache-clean/bin/cache-clean.js:321:238)
    at am (/Users/rikwillems/.composer/vendor/mage2tv/magento-cache-clean/bin/cache-clean.js:446:408)

Hi,

Thank you so much for this module! Indeed, one of the great paints of the Magento dev experience is all this cache / files cleaning. And the module is a great help.

Not 100% sure, but I'm experiencing that installing a new plugin (before, after, around) doesn't work. I have to manually do all the cleaning with the usual bin/magento commands.

Any ideas, please? Thanks!

Hey Vinai,

I have some custom configuration files and I want your tool to handle them without rebuilding the source.

A rules config file would be nice .. maybe something simple like that: vendor/bin/cache-clean.js -w --custom-rules=rules.json

{
  "/etc/custom\\.xml$": ["config", "block_html"]
}

Or is it already possible?

Regards Marcus

During development I often have the cache-clean watcher running. When I switch branch and do a composer install the watcher registers the file changes, but then keeps cleaning and cleaning. It looks like it registers all file changes and cleans related caches one by one. The only way to stop it is to close the terminal window running the watcher.

If this is the case maybe it is possible to implement a limiter of some sort?

I have a theme under src/Namespace/Themename. ./src/*/* is defined as a local composer repository. When I rename the directory src/Namespace/Themename/Magento_Catalog to src/Namespace/Themename/Magento_Catalog2 (to quickly check if my customisations broke something), the cache is not cleared. I guess it makes sense to clear it in this case as well?