In the README you don't really find the Contributing section, and it is so short one may think I should not really contribute here. Please consider this.

Read discussion below.

Note: previously this issue was about integration with React. But since the conversation on ZeroNet took over, I just renamed this issue.

block.json will be available starting from WordPress 5.8 to register block types. The GraphQL API could read this information and, dynamically, create types for these blocks, to be registered in the schema.

Analyze if this path is doable, advantages and potential problems from implementing this approach.

References:

• Block API Enhancements in WordPress 5.8
• Block Metadata | Block Editor Handbook

Compare approach against:

• 💬 Proposing a new approach for 'Gutenberg and Decoupled Applications'

From https://github.com/leoloso/PoP/blob/f134be00ccf8e4b4ce788dbd4d801e5641834b3a/layers/GraphQLAPIForWP/plugins/graphql-api-for-wp/phpstan.neon.dist#L13

Detailed description

🦕

Global constants return \GRAPHQL_API_DIR; and static properties, functions protected static $instance;

👴

A DI container and an immutable container are the object oriented solutions. Available since early PHP versions.

I let you take the wheel!

Detailed description

Getting a couple PHP Notices when following the composer install steps.

is_singlular

PHP Notice:  is_singular was called <strong>incorrectly</strong>. Conditional query tags do not work before the query is run. Before then, they always return false. Please see <a href="https://wordpress.org/support/article/debugging-in-wordpress/">Debugging in WordPress</a> for more information. (This message was added in version 3.1.0.) in /usr/local/wordpress/wp-includes/functions.php on line 5458
[24-Jun-2021 16:30:32 UTC] PHP Stack trace:
[24-Jun-2021 16:30:32 UTC] PHP   1. {main}() /usr/local/wordpress/wp-admin/admin-ajax.php:0
[24-Jun-2021 16:30:32 UTC] PHP   2. require_once() /usr/local/wordpress/wp-admin/admin-ajax.php:22
[24-Jun-2021 16:30:32 UTC] PHP   3. require_once() /usr/local/wordpress/wp-load.php:50
[24-Jun-2021 16:30:32 UTC] PHP   4. require_once() /usr/local/wordpress/wp-config.php:151
[24-Jun-2021 16:30:32 UTC] PHP   5. do_action($hook_name = 'plugins_loaded') /usr/local/wordpress/wp-settings.php:441
[24-Jun-2021 16:30:32 UTC] PHP   6. WP_Hook->do_action($args = [0 => '']) /usr/local/wordpress/wp-includes/plugin.php:470
[24-Jun-2021 16:30:32 UTC] PHP   7. WP_Hook->apply_filters($value = '', $args = [0 => '']) /usr/local/wordpress/wp-includes/class-wp-hook.php:327
[24-Jun-2021 16:30:32 UTC] PHP   8. GraphQLAPI\GraphQLAPI\Plugin->bootApplication('') /usr/local/wordpress/wp-includes/class-wp-hook.php:303
[24-Jun-2021 16:30:32 UTC] PHP   9. PoP\Root\AppLoader::bootApplication($cacheContainerConfiguration = TRUE, $containerNamespace = '_v0.7.13_1624552110_admin') /usr/local/wordpress/wp-content/plugins/graphql-api-for-wp/src/Plugin.php:280
[24-Jun-2021 16:30:32 UTC] PHP  10. PoP\Engine\AppLoader::bootComponents() /usr/local/wordpress/wp-content/plugins/graphql-api-for-wp/vendor/getpop/root/src/AppLoader.php:173
[24-Jun-2021 16:30:32 UTC] PHP  11. PoP\Root\Managers\ComponentManager::beforeBoot() /usr/local/wordpress/wp-content/plugins/graphql-api-for-wp/vendor/getpop/engine/src/AppLoader.php:19
[24-Jun-2021 16:30:32 UTC] PHP  12. PoP\Root\Component::beforeBoot() /usr/local/wordpress/wp-content/plugins/graphql-api-for-wp/vendor/getpop/root/src/Managers/ComponentManager.php:37
[24-Jun-2021 16:30:32 UTC] PHP  13. PoP\Root\Container\ServiceInstantiator->initializeServices() /usr/local/wordpress/wp-content/plugins/graphql-api-for-wp/vendor/getpop/root/src/Component.php:59
[24-Jun-2021 16:30:32 UTC] PHP  14. GraphQLAPI\GraphQLAPI\ConditionalOnEnvironment\GraphiQLExplorerInCustomEndpointPublicClient\Overrides\Services\Clients\CustomEndpointGraphiQLWithExplorerClient->initialize() /usr/local/wordpress/wp-content/plugins/graphql-api-for-wp/vendor/getpop/root/src/Container/ServiceInstantiator.php:28
[24-Jun-2021 16:30:32 UTC] PHP  15. GraphQLAPI\GraphQLAPI\ConditionalOnEnvironment\GraphiQLExplorerInCustomEndpointPublicClient\Overrides\Services\Clients\CustomEndpointGraphiQLWithExplorerClient->isClientDisabled() /usr/local/wordpress/wp-content/plugins/graphql-api-for-wp/vendor/graphql-by-pop/graphql-clients-for-wp/src/Clients/AbstractClient.php:27
[24-Jun-2021 16:30:32 UTC] PHP  16. is_singular($post_types = 'graphql-endpoint') /usr/local/wordpress/wp-content/plugins/graphql-api-for-wp/src/Clients/CustomEndpointClientTrait.php:18
[24-Jun-2021 16:30:32 UTC] PHP  17. _doing_it_wrong($function = 'is_singular', $message = 'Conditional query tags do not work before the query is run. Before then, they always return false.', $version = '3.1.0') /usr/local/wordpress/wp-includes/query.php:765
[24-Jun-2021 16:30:32 UTC] PHP  18. trigger_error($message = 'is_singular was called <strong>incorrectly</strong>. Conditional query tags do not work before the query is run. Before then, they always return false. Please see <a href="https://wordpress.org/support/article/debugging-in-wordpress/">Debugging in WordPress</a> for more information. (This message was added in version 3.1.0.)', $error_type = 1024) /usr/local/wordpress/wp-includes/functions.php:5458

Undefined index

PHP Notice:  Undefined index:  in /usr/local/wordpress/wp-content/plugins/graphql-api-for-wp/vendor/getpop/migrate-component-model/migrate/kernel/strata/stratum-manager.php on line 42
[24-Jun-2021 16:37:16 UTC] PHP Stack trace:
[24-Jun-2021 16:37:16 UTC] PHP   1. {main}() /usr/local/wordpress/wp-admin/admin-ajax.php:0
[24-Jun-2021 16:37:16 UTC] PHP   2. require_once() /usr/local/wordpress/wp-admin/admin-ajax.php:22
[24-Jun-2021 16:37:16 UTC] PHP   3. require_once() /usr/local/wordpress/wp-load.php:50
[24-Jun-2021 16:37:16 UTC] PHP   4. require_once() /usr/local/wordpress/wp-config.php:151
[24-Jun-2021 16:37:16 UTC] PHP   5. do_action($hook_name = 'wp_loaded') /usr/local/wordpress/wp-settings.php:600
[24-Jun-2021 16:37:16 UTC] PHP   6. WP_Hook->do_action($args = [0 => '']) /usr/local/wordpress/wp-includes/plugin.php:470
[24-Jun-2021 16:37:16 UTC] PHP   7. WP_Hook->apply_filters($value = '', $args = [0 => '']) /usr/local/wordpress/wp-includes/class-wp-hook.php:327
[24-Jun-2021 16:37:16 UTC] PHP   8. PoP\EngineWP\LooseContracts\LooseContractResolutionSet->PoP\EngineWP\LooseContracts\{closure:/usr/local/wordpress/wp-content/plugins/graphql-api-for-wp/vendor/getpop/engine-wp/src/LooseContracts/LooseContractResolutionSet.php:23-25}('') /usr/local/wordpress/wp-includes/class-wp-hook.php:303
[24-Jun-2021 16:37:16 UTC] PHP   9. PoP\HooksWP\HooksAPI->doAction($tag = 'popcms:boot') /usr/local/wordpress/wp-content/plugins/graphql-api-for-wp/vendor/getpop/engine-wp/src/LooseContracts/LooseContractResolutionSet.php:24
[24-Jun-2021 16:37:16 UTC] PHP  10. do_action($hook_name = 'popcms:boot') /usr/local/wordpress/wp-content/plugins/graphql-api-for-wp/vendor/getpop/hooks-wp/src/HooksAPI.php:40
[24-Jun-2021 16:37:16 UTC] PHP  11. WP_Hook->do_action($args = [0 => '']) /usr/local/wordpress/wp-includes/plugin.php:470
[24-Jun-2021 16:37:16 UTC] PHP  12. WP_Hook->apply_filters($value = '', $args = [0 => '']) /usr/local/wordpress/wp-includes/class-wp-hook.php:327
[24-Jun-2021 16:37:16 UTC] PHP  13. PoPSchema\UserStateAccessControl\Hooks\DisableDirectivesIfUserIsLoggedInConfigurableAccessControlForDirectivesInPrivateSchemaHookSet->cmsBoot('') /usr/local/wordpress/wp-includes/class-wp-hook.php:303
[24-Jun-2021 16:37:17 UTC] PHP  14. PoPSchema\UserStateAccessControl\Hooks\DisableDirectivesIfUserIsLoggedInConfigurableAccessControlForDirectivesInPrivateSchemaHookSet->enabled() /usr/local/wordpress/wp-content/plugins/graphql-api-for-wp/vendor/getpop/access-control/src/Hooks/AbstractAccessControlForDirectivesHookSet.php:15
[24-Jun-2021 16:37:17 UTC] PHP  15. PoP\ComponentModel\State\ApplicationState::getVars() /usr/local/wordpress/wp-content/plugins/graphql-api-for-wp/vendor/pop-schema/user-state-access-control/src/Hooks/AbstractUserStateConfigurableAccessControlForDirectivesInPrivateSchemaHookSet.php:14
[24-Jun-2021 16:37:17 UTC] PHP  16. PoP\ComponentModel\StratumManager->getStrata($stratum = NULL) /usr/local/wordpress/wp-content/plugins/graphql-api-for-wp/vendor/getpop/component-model/src/State/ApplicationState.php:96

Context

WP_DEBUG=true

Your environment

Include as many relevant details about the environment you experienced the bug in and how to reproduce it.

| Software | Version | | --- | --- | | GraphQL API plugin | 0.7.13 | | PHP | 7.4 | | WordPress | 5.7.2 | | Gutenberg | NA |

The idea is to initially load assets as small as they can be, containing only what is needed for that page (JS, CSS, Handlebars templates) and nothing more. This way, loading the first page will get a significant performance boost.

The challenge is how to make it work with the "previous session openTabs()" functionality, which allows the user to immediately open many more pages to the current one, possibly from pages cached using Service Workers. This implies that, by the time these pages from the Service Workers cache are loaded (which is pretty much immediately), their assets must also have been pre-loaded.

Can that be achieved using code-splitting? If so, will the code be manageable? (eg: importing all the Handlebars templates one per file is not pretty... it's normally nicer to import them as a bundle.) Does it make sense to implement it?

As a reference, WebPack is doing code-splitting

Most plug-ins need some configuration to be done, which involves creating pages (eg: POPTHEME_WASSUP_PAGE_ADDCONTENT) / categories (eg: POPTHEME_WASSUP_CAT_WEBPOSTS) / etc in the system, and then saving their IDs in a configuration file, such as environment-constants.php.

The creation of these is currently a manual process. It would be awesome to automate it, adding scripts to create the objects in the DB upon installation of the plug-in, and then automatically saving the IDs on the configuration file.

If implementing the approach from #741, the schema may need be regenerated when a WordPress plugin containing blocks is installed, i.e. not under the control of the GraphQL API for WP.

Then, consider to allow users to regenerate the schema manually, by placing a "Regenerate schema" button on the Settings page. When pressed, it must simply delete the container timestamp from the DB, and next time the plugin is accessed, it will be regenerated.

Detailed description

I am running WordPress 5.8 beta 2 and am getting deprecated notices on block_editor_preload_paths

PHP Deprecated:  block_editor_preload_paths is <strong>deprecated</strong> since version 5.8.0! Use block_editor_rest_api_preload_paths instead. in /usr/local/wordpress/wp-includes/functions.php on line 5381
[24-Jun-2021 17:03:38 UTC] PHP Stack trace:
[24-Jun-2021 17:03:38 UTC] PHP   1. {main}() /usr/local/wordpress/wp-admin/post-new.php:0
[24-Jun-2021 17:03:38 UTC] PHP   2. require() /usr/local/wordpress/wp-admin/post-new.php:72
[24-Jun-2021 17:03:38 UTC] PHP   3. block_editor_rest_api_preload($preload_paths = [0 => '/', 1 => '/wp/v2/types?context=edit', 2 => '/wp/v2/taxonomies?per_page=-1&context=edit', 3 => '/wp/v2/themes?status=active', 4 => '/wp/v2/graphql-query/3620893?context=edit', 5 => '/wp/v2/types/graphql-query?context=edit', 6 => '/wp/v2/users/me?post_type=graphql-query&context=edit', 7 => [0 => '/wp/v2/media', 1 => 'OPTIONS'], 8 => [0 => '/wp/v2/blocks', 1 => 'OPTIONS'], 9 => '/wp/v2/graphql-query/3620893/autosaves?context=edit'], $block_editor_context = class WP_Block_Editor_Context { public $post = class WP_Post { public $ID = 3620893; public $post_author = '2'; public $post_date = '2021-06-24 10:03:38'; public $post_date_gmt = '0000-00-00 00:00:00'; public $post_content = ''; public $post_title = ''; public $post_excerpt = ''; public $post_status = 'auto-draft'; public $comment_status = 'closed'; public $ping_status = 'closed'; public $post_password = ''; public $post_name = ''; public $to_ping = ''; public $pinged = ''; public $post_modified = '2021-06-24 10:03:38'; public $post_modified_gmt = '0000-00-00 00:00:00'; public $post_content_filtered = ''; public $post_parent = 0; public $guid = 'https://bodcms.test/?post_type=graphql-query&p=3620893'; public $menu_order = 0; public $post_type = 'graphql-query'; public $post_mime_type = ''; public $comment_count = '0'; public $filter = 'raw' } }) /usr/local/wordpress/wp-admin/edit-form-blocks.php:69
[24-Jun-2021 17:03:38 UTC] PHP   4. apply_filters_deprecated($hook_name = 'block_editor_preload_paths', $args = [0 => [0 => '/', 1 => '/wp/v2/types?context=edit', 2 => '/wp/v2/taxonomies?per_page=-1&context=edit', 3 => '/wp/v2/themes?status=active', 4 => '/wp/v2/graphql-query/3620893?context=edit', 5 => '/wp/v2/types/graphql-query?context=edit', 6 => '/wp/v2/users/me?post_type=graphql-query&context=edit', 7 => [...], 8 => [...], 9 => '/wp/v2/graphql-query/3620893/autosaves?context=edit'], 1 => class WP_Post { public $ID = 3620893; public $post_author = '2'; public $post_date = '2021-06-24 10:03:38'; public $post_date_gmt = '0000-00-00 00:00:00'; public $post_content = ''; public $post_title = ''; public $post_excerpt = ''; public $post_status = 'auto-draft'; public $comment_status = 'closed'; public $ping_status = 'closed'; public $post_password = ''; public $post_name = ''; public $to_ping = ''; public $pinged = ''; public $post_modified = '2021-06-24 10:03:38'; public $post_modified_gmt = '0000-00-00 00:00:00'; public $post_content_filtered = ''; public $post_parent = 0; public $guid = 'https://bodcms.test/?post_type=graphql-query&p=3620893'; public $menu_order = 0; public $post_type = 'graphql-query'; public $post_mime_type = ''; public $comment_count = '0'; public $filter = 'raw' }], $version = '5.8.0', $replacement = 'block_editor_rest_api_preload_paths', $message = *uninitialized*) /usr/local/wordpress/wp-includes/block-editor.php:435
[24-Jun-2021 17:03:38 UTC] PHP   5. _deprecated_hook($hook = 'block_editor_preload_paths', $version = '5.8.0', $replacement = 'block_editor_rest_api_preload_paths', $message = '') /usr/local/wordpress/wp-includes/plugin.php:654
[24-Jun-2021 17:03:38 UTC] PHP   6. trigger_error($message = 'block_editor_preload_paths is <strong>deprecated</strong> since version 5.8.0! Use block_editor_rest_api_preload_paths instead.', $error_type = 16384) /usr/local/wordpress/wp-includes/functions.php:5381
[24-Jun-2021 17:03:39 UTC] PHP Deprecated:  block_categories is <strong>deprecated</strong> since version 5.8.0! Use block_categories_all instead. in /usr/local/wordpress/wp-includes/functions.php on line 5381

Context

Looks like loading of the custom Query pages are broken: /wp-admin/post-new.php?post_type=graphql-query

Your environment

Include as many relevant details about the environment you experienced the bug in and how to reproduce it.

| Software | Version | | --- | --- | | GraphQL API plugin | 0.7.13 | | PHP | 7.4 | | WordPress | 5.8 beta 2 | | Gutenberg | NA |

This query fails:

/?
query=
  __schema.
    type(name:"Root").
      --FullType
&fragments[FullType]=
  name|
  fields(includeDeprecated: true)[@fields].
    name|
    args.
      --InputValue,
  [fields].
    type.
      name
&fragments[InputValue]=
  id

with error Fragment 'InputValue,[fields]' is undefined, so it has been ignored.

The problem happens in --InputValue,[fields]. If we remove any of those subqueries (either the fragment or the bookmark) it works well

The PoP engine can run on any WordPress website, so it makes sense to provide standalone functionalities, independently of the website using a PoP theme or not. Eg:

• Comments
• Front-end editor
• Search/typeahead input
• Media player
• User notifications
• Messaging

These files are currently skipped downgrading:

• vendor/symfony/cache/Traits/Redis6Proxy.php
• vendor/symfony/cache/Traits/RedisCluster6Proxy.php

That's because they produce this error:

------------------------------------------------------------
Parse error: vendor/symfony/cache/Traits/Redis6Proxy.php:103
    101|      */
    102|     public function auth(#[\SensitiveParameter] $credentials)
  > 103|     {
    104|         return $this->lazyObjectReal->auth(...\func_get_args());
    105|     }
Unexpected '{', expecting variable (T_VARIABLE) in vendor/symfony/cache/Traits/Redis6Proxy.php on line 103
------------------------------------------------------------
Parse error: vendor/symfony/cache/Traits/RedisCluster6Proxy.php:38
    36| 
    37|     public function __construct($name, $seeds = null, $timeout = 0, $read_timeout = 0, $persistent = false, #[\SensitiveParameter] $auth = null, $context = null)
  > 38|     {
    39|         return $this->lazyObjectReal->__construct(...\func_get_args());
    40|     }
Unexpected '{', expecting variable (T_VARIABLE) in vendor/symfony/cache/Traits/RedisCluster6Proxy.php on line 38

#[\SensitiveParameter] is a new attribute added to PHP 8.2. Once there's a Rector rule to downgrade it, the 2 files can be added once again.

The new GraphiQL v2.0 has the Explorer already integrated as a plugin:

• https://github.com/graphql/graphiql/tree/main/packages/graphiql
• https://github.com/graphql/graphiql/tree/main/packages/graphiql-plugin-explorer

Upgrade GraphiQL to either v2.0 or v3.0 (where the Explorer will be bundled more natively), and then remove module "GraphiQL Explorer" from the GraphQL API plugin, which will not make sense anymore.

Currently Rector does not fully support downgrading PHP 8.1 Enums (see https://github.com/rectorphp/rector/issues/7013#issuecomment-1228147159).

When full support is provided, continue working on branch Use-Enum-in-EnumTypeResolver.

In the Error result format section of the GraphQL spec it reads:

If an error can be associated to a particular field in the GraphQL result, it must contain an entry with the key path that details the path of the response field which experienced the error. This allows clients to identify whether a null result is intentional or caused by a runtime error.

This field should be a list of path segments starting at the root of the response and ending with the field associated with the error. Path segments that represent fields should be strings, and path segments that represent list indices should be 0-indexed integers. If the error happens in an aliased field, the path to the error should use the aliased name, since it represents a path in the response, not in the request.

Implement this feature.

Important

Please notice that currently there is extensions.path printed in the response, but this points to the AST node where the error happens, whereas the GraphQL spec instead points to the place in the response where the value is printed as null

To avoid confusion, the current extensions.path should be renamed to something else (eg: extensions.astPath).

Implementation

A data structure storing which Fields produced an error must be created and deal with in parallel to $resolvedIDFieldValues. This solution can also support bubbling the null upwards:

• #1457

InstaWP is used to execute integration tests. As the GraphQL API plugin is downgraded to PHP 7.1, we should test against this version, however currently InstaWP only supports PHP 7.2 as its minimum PHP version.

InstaWP founder Vikas Singhal told me it would be ready in 6 to 8 weeks. When this is done, change the InstaWP template to use PHP 7.1.

The GraphQL API has a few features that make it easy to access the data from an external endpoint, manipulate it, and inject it into some other field or mutation, allowing a single GraphQL query to perform complex operations. For instance, it allows importing posts/users/categories/tags/etc from another site (whether it is WordPress or not) into the WordPress site, without the need to write custom resolvers!.

The procedure could be something like this:

• A field rearrangeJSONObjectProperties($input: JSONObject, $fromToPropertyPaths: JSONObject) can manipulate the entries in an input, renaming the keys into the desired output
• Via the "Resolved Field Variable Reference" feature, the output of the previous field can be accessed as an input into another field/mutation
• Using the "Multiple Query Execution" feature we can export a JSONObject that is treated as the expected input type for some mutation (eg: PostInput, UserInput, etc)
• In the subsequent query, check if the data already exists
• If not, create it

For instance, this (potential) query accesses user data from an external REST endpoint, checks if the user exists on the local site and, if not, it creates it:

query ExportUserData
{
  externalData: restData(url: "https://some-other-site.com/rest/users")
  userData: rearrangeJSONObjectProperties(
    # Using "Resolved Field Variable Reference" to access some resolved value as an input to another field
    input: $externalData,
    fromToPropertyPaths: {
      "user.name": "name",
      "user.email": "email"
    }
  )
    # Using "Multiple Query Execution" to export a value
    @export(as: "userInput")
  extract(object: $userData, path: "email")
    @export(as: "userEmail")
}

query CheckUserExists($userEmail: String)
  @dependsOn(operation: "ExportUserData")
{
  userExists(userEmail: $userEmail) @export(as: "doesUserExist")
}

mutation CreateUser($doesUserExist: Boolean, $userInput: UserInput)
  @dependsOn(operation: "CheckUserExists")
  @execute(if: $doesUserExist)
{
  createUser(input: $userInput) {
    id
    name
    email
  }
}

Notice how $userInput is exported as a JSONObject, but is then treated as a UserInput in the following mutation. That casting of the type should already work.

Directives @dependsOn and @execute do not currently exist, but they can be implemented once "operation directives" are supported (currently they are not).

If the external endpoint is REST, a single rest field to get its data may be sufficient. If it is GraphQL, then using a new CPT called ExternalEndpoint might be better as to specify the GraphQL query:

query ExportUserData
{
  externalData: externalEndpointData(cptSlug: "some-graphql-external-endpoint-for-client")
  # ...
}