This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.

Before merging, you need to:

• Checkout the l9-compatibility branch
• Review all comments for additional changes
• Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

I noticed a lot of views that only return a Livewire component, which I think is redundant.

This PR uses Livewire's routing helper to cut out the extra boilerplate code.

PS: There are some CS fixes as well. 😄

There seems to be a problem with the laravel-mix-tailwind package, which in turn also prevents the mix manifest from being generated.

ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: undefined@undefined
npm ERR! Found: [email protected]
npm ERR! node_modules/laravel-mix
npm ERR!   dev laravel-mix@"^5.0.7" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer laravel-mix@"^2.1.7" from [email protected]
npm ERR! node_modules/laravel-mix-tailwind
npm ERR!   laravel-mix-tailwind@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/quentin/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/quentin/.npm/_logs/2020-11-05T10_24_54_803Z-debug.log

Not sure how to work around this.

Hi

Thanks for this package.

I would like to redirect to the previous page when a user login or register just like mentioned in this article:

https://stackoverflow.com/questions/42326430/how-to-redirect-to-previous-page-after-successful-register-in-laravel

how can it be implemented using livewire in the login/register?

I'm using TALL v2.0.0 on Laravel 8, fresh install with auth.

First attempt at logging in via the Login component, I got the following error:

SQLSTATE[42S22]: Column not found: 1054 Unknown column 'remember' in 'where clause' (SQL: select * from users where email = [email protected] and remember = 0 limit 1)

This appears to be due to the validation in the Login component's authenticate() method:

$credentials = $this->validate([
    'email' => ['required', 'email'],
    'password' => ['required'],
]);

It seems $this->validate() will return all public members of the component class, whether they are listed in the validation rules or not. The $remember member therefore gets sent to Auth::attempt() so it adds it into the users query.

If this is desired behaviour by Livewire, then the issue is with the component needing to restrict $credentials to the keys in the rules array only. If this isn't desired behaviour then I guess this is a Livewire bug?

After a fresh install using the command: composer require livewire/livewire laravel-frontend-presets/tall

I can't run the command: php artisan ui tall because I get Could not open input file: artisan

Previously I was able to do it (its not the first time I us TALL)

I don't know if this is something that anyone wants to do because it is incredibly opinionated, but I thought I would PR it anyway.

Tailwind v1.4 has PurgeCSS built-in now, so it's not strictly necessary we use Spatie's package. However, I know Tailwind's implementation does not automatically set up all the directories to scan.

This package will put the burden on the end developer to manage their own directories, but I can foresee an increase in tickets here because "CSS classes are missing".

If there are no objections, I will mark the PR as ready for review so it can be merged. Otherwise, we can close this PR.

When i run "npm install && npm run dev" i get below warnings and errors:

vagrant@homestead:~/code/teamsy$ npm install && npm run dev npm WARN deprecated [email protected]: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2. npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.2.7 (node_modules/chokidar/node_modules/fsevents): npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"}) npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@~2.1.2 (node_modules/watchpack/node_modules/chokidar/node_modules/fsevents): npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"}) npm WARN [email protected] requires a peer of laravel-mix@^2.1.7 but none is installed. You must install peer dependencies yourself.

npm ERR! code ENOENT npm ERR! syscall open npm ERR! path /home/vagrant/code/teamsy/node_modules/webpack-dev-server/node_modules/ansi-regex/package.json.3885035533 npm ERR! errno -2 npm ERR! enoent ENOENT: no such file or directory, open '/home/vagrant/code/teamsy/node_modules/webpack-dev-server/node_modules/ansi-regex/package.json.3885035533' npm ERR! enoent This is related to npm not being able to find a file. npm ERR! enoent

npm ERR! A complete log of this run can be found in: npm ERR! /home/vagrant/.npm/_logs/2020-11-25T13_55_39_251Z-debug.log

And the application fails with error:

"The Mix manifest does not exist"

❯ npm install && npm run dev
npm WARN @tailwindcss/[email protected] requires a peer of tailwindcss@^1.2.0 but none is installed. You must install peer dependencies yourself.

I had tonpm install tailwindcss first. Then the npm run dev ran fine.

Solves #86 (hopefully).

Both @ryangjchandler and I are unable to reproduce the original issue so hopefully bumping all NPM dependencies to their latest versions should help out.

Fresh Laravel v8.5.7 installation on MacOs Big Sur and using ^2.2 of the TALL preset.

Steps to reproduce

laravel new my-app or curl -s https://laravel.build/my-app | bash

composer require livewire/livewire laravel-frontend-presets/tall
php artisan ui tall --auth
npm install

Error

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: undefined@undefined
npm ERR! Found: [email protected]
npm ERR! node_modules/laravel-mix
npm ERR!   dev laravel-mix@"^6.0.6" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer laravel-mix@"^2.1.7" from [email protected]
npm ERR! node_modules/laravel-mix-tailwind
npm ERR!   dev laravel-mix-tailwind@"^0.1.0" from the root project

Solution

npm install --force works but ideally should not error and Tailwind 2.0 should now be the standard..

I think it would be a nice idea to take some screenshots of the important pages in an application that uses this preset and upload them when a pull request is opened so that we can quickly see what things look like.

If we wanted, we could probably do videos as well since GH nows support MP4 files on issues / PRs.

Would you be interested in a --pest option which would convert the existing PHPUnit test suite to Pest tests? I'm converting it on my project anyway, and it would be ideal if the work could be reused by others.

Per #22, this PR adds some extra features on top of the basic preset. Currently, this is just an application layout shell and a stub for an account settings page, but the goal would be to also cover the other things mentioned in the issue.

Right now, it also requires you to use the --auth preset too, as the links in the application shell and account settings page makes no sense without authentication.

Many solutions of laravel are not accessible if you are using this preset (including security features). For example the concern AuthenticatesUsers. It ships with throttling login attempts and choosing a custom username() instead of only email.

Maybe the concerns should be added but then this preset or better laravel/ui cannot be uninstalled because the concerns are implemented there.

While the current preset was made to pretty much a match the existing laravel/ui presets one-to-one, I feel like we could probably go a little bit further for people that want it, to get even closer to a real-world application, and offer some extra utilities out of the box.

Here are some of the things I think this "extra" option could possibly do:

• Include some basic styling for the "app" layout"
• Include a "change password" form for authenticated users
• Include a few basic components/classes for things like form elements
• Include additional tools commonly used in the stack, like Spruce, Alpine Test Utils and implement Tailwind CSS Spinner into the loading states

It may be a little more opinionated than the basic version, without being a full-blown boilerplate.

What do people think of this? Is this something we could consider or is it just out of the scope of this package?

I figured I'd raise this as a discussion point to see what people think so we can come to a consensus before raising anything.

Right now we've got a handful of CSS classes we re-use all over the auth views, in particular for things like <button> styles. In most real applications, I'd personally see this as something I need to commonly reuse, and I'd extract it to either a Blade component <x-button> or CSS class .button

That said, the buttons we have so far are not typical buttons you'd find in an app - there's no primary/secondary/danger/etc. styles and it's not guaranteed people will use these styles again as the button is specifically styled for the auth pages.

Thoughts?