Hi,

The MultiCurl client had a bug where it would hang for ever on new versions. See this comment for an explanation (I think): http://www.php.net/manual/en/function.curl-multi-select.php#110869

In any case, I wanted to be able to process responses as they come back, rather than block for the entire batch to complete. I have therefore rewritten the client completely. It is still fully BC, but you can now pass a callback option that will get invoked as the response becomes available. This changes the interface a bit, since the user land code will then have to call proceed to delegate control back to multi-curl, concurrent style.

Sorry for the missing tests, but then there weren't any on the original code either.

Hi

I am having timeouts in some requests and I would like to control them. Right now, I am checking emptyness in Response Content to detect timeouts, is there a cleaner way to check timeout inside Buzz Library?

I am using Curl as Client.

Best regards

Hi Kris,

in our production code, we are using the version 0.16.1 of your Buzz Browser with the Curl client. Since the timeout handling from version 0.17.0 isn't released yet, we are not able to handle timeouts in our health-check component gently.

Do you have enough capacity to release the try..catch for curl_exec as a hotfix in version 0.16.2.

This would be great.

Otherwise, can you approximate the date of release for version 0.17.0?

Hi

I am trying to get rid of Zend_HTTP_Client in order to use Buzz but I am having this problem. If one of my POST Parameters contains character '+' it gets converted to ' ' instead of passing it correctly.

'+' character is always a dirty bitch on HTTP Requests, if you use it on GET you must pass it urlencoded and in POST it leads to problems most of the times.

I have tried Client\Curl and Client\FileGetContents, both having same problems

Have you got any solution for that? If it is impossible to fix it I will have to switch back to Zend_HTTP_Client as we need the '+' character to be sent.

Thanks for your time

Best regards

We use buzz as part of our BDD process with behat, and we recently noticed a vast slowdown in the time taken to run behat tests of an API implemented in symfony.

We've isolated the cause to the change from buzz 0.13 to 0.14. Our composer.json rule for behat was set to @stable, which has started pulling in 0.14.

When we revert to 0.13, the problem went away. We demonstrated this on a couple of different machines.

I wasn't able to determine the issue. The behat test in question has 158 steps and usually rattles through in roughly a minute, bounded by IO/CPU. With buzz 0.14, then everything still works, but it takes an order of magnitude or more longer to complete the test. Our entire suite of tests usually takes an hour or so, but this change renders the process unworkable.

While running, I can't see very much happening. It's as if it's waiting - cpu is at just about zero, and there's plenty of memory, and the machine is using an SSD (though there's not much io happening anyway). I couldn't see any other signs of something being wrong. Simply reverting to buzz 0.13, and making no other change to the configuration fixed things.

We're running centos 6.6.

Is there anything else we need to tune or setup to make the new version run as quickly as the old?

I'm getting this when I log in with Facebook using HWIAuthBundle

request.CRITICAL: Uncaught PHP Exception Buzz\Exception\ClientException: "Connection timed out after 5000 milliseconds" at /home/website/public_html/vendor/kriswallsmith/buzz/lib/Buzz/Client/Curl.php line 29 {"exception":"[object] (Buzz\\Exception\\ClientException: Connection timed out after 5000 milliseconds at /home/website/public_html/vendor/kriswallsmith/buzz/lib/Buzz/Client/Curl.php:29)"} [] [2014-09-23 15:13:18] security.DEBUG: Write SecurityContext in the session [] []

This PR adds support for CURLOPT_SSL_VERIFYHOST option. Default value is set to 2 according to documentation (http://php.net//manual/pl/function.curl-setopt.php). There should not be any BC issues.

Am making a request. Everything works fine, until there is an other HTTP status than 200, for example 404. This then just returns an empty string. Any chance how to catch the http status?

Here is a code snippet to reproduce:

error_reporting(E_ALL); 
ini_set('display_errors', true); 
$browser = new Buzz\Browser();
$response = $browser->get("https://www.google.com");

Setting the scheme to https instead of http throws the following exception in the browser:

Fatal error: Uncaught exception 'RuntimeException' with message 'file_get_contents(https://www.google.com/): failed to open stream: operation failed' in /www/api/Buzz/lib/Buzz/Client/FileGetContents.php on line 49 RuntimeException: file_get_contents(https://www.google.com/): failed to open stream: operation failed in /www/api/Buzz/lib/Buzz/Client/FileGetContents.php on line 49 Call Stack: 0.0004 662440 1. {main}() /www/api/new_document_test_buzz.php:0 0.0020 748224 2. Buzz\Browser->get() /www/api/new_document_test_buzz.php:30 0.0024 776160 3. Buzz\Browser->call() /www/api/Buzz/lib/Buzz/Browser.php:25 0.0027 788520 4. Buzz\Browser->send() /www/api/Buzz/lib/Buzz/Browser.php:71 0.0028 803168 5. Buzz\Client\FileGetContents->send() /www/api/Buzz/lib/Buzz/Browser.php:114

Do you need to use the CURL client or something different? I wonder if the error message could be more clear about how to remedy the situation.

This PR adds an optional dependency: samson/protocol.

The problem with Curl is that it isn't available on all installations and file_get_contents refuses to actually fetch contents if the return status is any other dan 2xx, meaning you can't get the actual error message for, for example, a 404 or 500 response.

This adds a third client, named Protocol. This one tries to do an HTTP request using bare sockets. The socket classes appear to be more common in PHP installations than CURL, so it should almost always work.

I ran the tests using the server.php script and they work as expected.

Before version 1 (beta) MultiCurl::proceed() was non-blocking, and now it's a blocking call. It waits until all requests finish.

<?php

use Buzz\Client\MultiCurl;
use Nyholm\Psr7\Factory\MessageFactory;
use Nyholm\Psr7\Factory\Psr17Factory;
use Nyholm\Psr7\Request;

require __DIR__.'/vendor/autoload.php';


$client = new MultiCurl(new Psr17Factory());

 $client->sendAsyncRequest($a = new Request('GET', 'http://httpbin.org/delay/1'), ['callback' => function($request, $response, $exception) {
    dump('A');
    dump(time() - $_SERVER['REQUEST_TIME_FLOAT']);
    // echo $response->getBody()->getContents();
}]);

 $client->sendAsyncRequest($a = new Request('GET', 'http://httpbin.org/delay/2'), ['callback' => function($request, $response, $exception) {
    dump('B');
    dump(time() - $_SERVER['REQUEST_TIME_FLOAT']);
    // echo $response->getBody()->getContents();
}]);
 $client->sendAsyncRequest($a = new Request('GET', 'http://httpbin.org/delay/3'), ['callback' => function($request, $response, $exception) {
    dump('C');
    dump(time() - $_SERVER['REQUEST_TIME_FLOAT']);
    // echo $response->getBody()->getContents();
}]);

while (true) {
    $client->proceed();
    echo '.';
    usleep(100000);
}

Hello,

I am using "kriswallsmith/Buzz" package with Amazon SP API SDK. I am getting the following error:

Note: See #2 in log. This line generates the error. This is 5th line in my function financialEvents(Request $request) in code given below the log.

Buzz\Exception\RequestException: SSL certificate problem: unable to get local issuer certificate in file \\amazon-spapi\vendor\kriswallsmith\buzz\lib\Client\AbstractCurl.php on line 228

#0 \\amazon-spapi\vendor\kriswallsmith\buzz\lib\Client\Curl.php(24): Buzz\Client\AbstractCurl->parseError(Object(Nyholm\Psr7\Request), 60, Resource id #45)
#1 \\amazon-spapi\vendor\amazon-php\sp-api-sdk\src\AmazonPHP\SellingPartner\OAuth.php(69): Buzz\Client\Curl->sendRequest(Object(Nyholm\Psr7\Request))
#2 \\amazon-spapi\app\Http\Controllers\API\DataController.php(68): AmazonPHP\SellingPartner\OAuth->exchangeRefreshToken('Atzr|IwEBIIiZuC...')
#3 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Routing\Controller.php(54): App\Http\Controllers\API\DataController->financialEvents(Object(Illuminate\Http\Request))
#4 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Routing\ControllerDispatcher.php(45): Illuminate\Routing\Controller->callAction('financialEvents', Array)
#5 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Routing\Route.php(262): Illuminate\Routing\ControllerDispatcher->dispatch(Object(Illuminate\Routing\Route), Object(App\Http\Controllers\API\DataController), 'financialEvents')
#6 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Routing\Route.php(205): Illuminate\Routing\Route->runController()
#7 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Routing\Router.php(695): Illuminate\Routing\Route->run()
#8 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(128): Illuminate\Routing\Router->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#9 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Routing\Middleware\SubstituteBindings.php(50): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#10 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(167): Illuminate\Routing\Middleware\SubstituteBindings->handle(Object(Illuminate\Http\Request), Object(Closure))
#11 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Routing\Middleware\ThrottleRequests.php(127): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#12 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Routing\Middleware\ThrottleRequests.php(103): Illuminate\Routing\Middleware\ThrottleRequests->handleRequest(Object(Illuminate\Http\Request), Object(Closure), Array)
#13 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Routing\Middleware\ThrottleRequests.php(55): Illuminate\Routing\Middleware\ThrottleRequests->handleRequestUsingNamedLimiter(Object(Illuminate\Http\Request), Object(Closure), 'api', Object(Closure))
#14 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(167): Illuminate\Routing\Middleware\ThrottleRequests->handle(Object(Illuminate\Http\Request), Object(Closure), 'api')
#15 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Auth\Middleware\Authenticate.php(44): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#16 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(167): Illuminate\Auth\Middleware\Authenticate->handle(Object(Illuminate\Http\Request), Object(Closure), 'sanctum')
#17 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(103): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#18 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Routing\Router.php(697): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#19 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Routing\Router.php(672): Illuminate\Routing\Router->runRouteWithinStack(Object(Illuminate\Routing\Route), Object(Illuminate\Http\Request))
#20 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Routing\Router.php(636): Illuminate\Routing\Router->runRoute(Object(Illuminate\Http\Request), Object(Illuminate\Routing\Route))
#21 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Routing\Router.php(625): Illuminate\Routing\Router->dispatchToRoute(Object(Illuminate\Http\Request))
#22 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php(167): Illuminate\Routing\Router->dispatch(Object(Illuminate\Http\Request))
#23 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(128): Illuminate\Foundation\Http\Kernel->Illuminate\Foundation\Http\{closure}(Object(Illuminate\Http\Request))
#24 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\TransformsRequest.php(21): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#25 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull.php(31): Illuminate\Foundation\Http\Middleware\TransformsRequest->handle(Object(Illuminate\Http\Request), Object(Closure))
#26 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(167): Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull->handle(Object(Illuminate\Http\Request), Object(Closure))
#27 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\TransformsRequest.php(21): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#28 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\TrimStrings.php(40): Illuminate\Foundation\Http\Middleware\TransformsRequest->handle(Object(Illuminate\Http\Request), Object(Closure))
#29 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(167): Illuminate\Foundation\Http\Middleware\TrimStrings->handle(Object(Illuminate\Http\Request), Object(Closure))
#30 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\ValidatePostSize.php(27): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#31 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(167): Illuminate\Foundation\Http\Middleware\ValidatePostSize->handle(Object(Illuminate\Http\Request), Object(Closure))
#32 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\PreventRequestsDuringMaintenance.php(86): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#33 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(167): Illuminate\Foundation\Http\Middleware\PreventRequestsDuringMaintenance->handle(Object(Illuminate\Http\Request), Object(Closure))
#34 \\amazon-spapi\vendor\fruitcake\laravel-cors\src\HandleCors.php(52): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#35 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(167): Fruitcake\Cors\HandleCors->handle(Object(Illuminate\Http\Request), Object(Closure))
#36 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Http\Middleware\TrustProxies.php(39): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#37 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(167): Illuminate\Http\Middleware\TrustProxies->handle(Object(Illuminate\Http\Request), Object(Closure))
#38 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(103): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#39 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php(142): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#40 \\amazon-spapi\vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php(111): Illuminate\Foundation\Http\Kernel->sendRequestThroughRouter(Object(Illuminate\Http\Request))
#41 \\amazon-spapi\public\index.php(52): Illuminate\Foundation\Http\Kernel->handle(Object(Illuminate\Http\Request))
#42 {main}

My code is as follows:

<?php

namespace App\Http\Controllers\API;

use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;
use Symfony\Component\HttpFoundation\Response;

use App\Http\Controllers\API\BaseController as BaseController;
use Validator;
//use App\Models\User;
use App\Models\SpApiAdHocData;

use AmazonPHP\SellingPartner\Marketplace;
use AmazonPHP\SellingPartner\Regions;
use AmazonPHP\SellingPartner\SellingPartnerSDK;
use Buzz\Client\Curl;
use AmazonPHP\SellingPartner\Exception\ApiException;
use AmazonPHP\SellingPartner\Configuration;
use App\Http\Controllers\AmazonAuthController;
use Monolog\Handler\StreamHandler;
use Monolog\Logger;
use Nyholm\Psr7\Factory\Psr17Factory;

//require_once __DIR__ . '/vendor/autoload.php';

class DataController extends BaseController
{
    private $factory;
    private $client;
    private $configuration;
    private $logger;
    private $sdk;

    /**
     * DataController constructor.
     */
    public function __construct()
    {
        $this->factory = new Psr17Factory();
        $this->client = new Curl($this->factory);
        
        $this->configuration = Configuration::forIAMUser(
            AmazonAuthController::CLIENT_ID,
            AmazonAuthController::CLIENT_SECRET,
            AmazonAuthController::AWS_ACCESS_KEY,
            AmazonAuthController::AWS_SECRET_KEY
        );
        
        $this->logger = new Logger('name');
        $this->logger->pushHandler(new StreamHandler(__DIR__ . '/sp-api-php.log', Logger::DEBUG));
        
        $this->sdk = SellingPartnerSDK::create(
            $this->client,
            $this->factory,
            $this->factory,
            $this->configuration,
            $this->logger
        );
    }

    public function financialEvents(Request $request)
    {
        $authUser = Auth::user();
        //return $this->sendResponse([ 'email' => $authUser->email], 'You are OK!', Response::HTTP_OK);
        $row = SpApiAdHocData::where('email', $authUser->email)->get()->first();
        $refreshToken = $row['refresh_token'];
        $accessToken = $this->sdk->oAuth()->exchangeRefreshToken($refreshToken);

        try {
            $item = $this->sdk->finances()->listFinancialEvents(
                $accessToken,
                Regions::EUROPE,
                100,
                new \DateTimeImmutable('2022-01-01T00:00:00.00+0530'),
                new \DateTimeImmutable('2022-03-01T00:00:00.00+0530')
            );
            dump($item);
        } catch (ApiException $exception) {
            dump($exception->getMessage());
        }

        return $this->sendResponse([ 'row' => $row], 'You are OK!', Response::HTTP_OK);
    }
}

Kindly guide.

Thank you.

Rupesh

https://github.com/kriswallsmith/Buzz/pull/421 PHP Fatal error: Array and string offset access syntax with curly braces is no longer supported in /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/src/Config.php on line 399

I was experimenting with using this library as http client for stripe-php, via psr18-adapter/stripe-php that I'm working on now, but had to go back to Guzzle, as Buzz is broken there. You see, stripe library defines lowercased HTTP methods names everywhere, but their servers do not accept those:

❯ curl -XGET "https://api.stripe.com/v1/customers"

{
  "error": {
    "message": "You did not provide an API key. You need to provide your API key in the Authorization header, using Bearer auth (e.g. 'Authorization: Bearer YOUR_SECRET_KEY'). See https://stripe.com/docs/api#authentication for details, or we can help at https://support.stripe.com/.",
    "type": "invalid_request_error"
  }
}
❯ curl -Xget "https://api.stripe.com/v1/customers"
<html>
<head><title>400 Bad Request</title></head>
<body>
<center><h1>400 Bad Request</h1></center>
<hr><center>nginx</center>
</body>
</html>

I think you might want to make this library uppercase method names as well, like other libraries do. After all, you do that in some places already