$client = new Amp\Artax\DefaultClient;

I want to stop all the client requests with 1s, if they not completed.

Is it possible ? and could you suggest the best way?

I'm not sure, but I don't think the async client is for this. But how do you do a simple asynchronous GET, POST, PUT or DELETE. That is, simply sending the request, but not caring about the retrieval or waiting for the retrieval?

Spotted at https://github.com/symfony/symfony/pull/35115#issuecomment-572057741

The following script adapted from the examples doesn't multiplex the requests. Note that we limit to one single connection. If we remove this limit, one connection per request is made and all works concurrently - but then this is no different than using HTTP/1.1.

<?php

use Amp\Http\Client\Connection\LimitedConnectionPool;
use Amp\Http\Client\Connection\UnlimitedConnectionPool;
use Amp\Http\Client\HttpClientBuilder;
use Amp\Http\Client\HttpException;
use Amp\Http\Client\Request;
use Amp\Http\Client\Response;
use Amp\Loop;
use Amp\Sync\LocalKeyedSemaphore;

require __DIR__ . '/vendor/autoload.php';

Loop::run(static function () use ($argv) {
    $uris = [];

    for ($i = 0; $i < 379; ++$i) {
        $uris[] = "https://http2.akamai.com/demo/tile-$i.png";
    }

    // Instantiate the HTTP client
    $pool = LimitedConnectionPool::byHost(new UnlimitedConnectionPool, new LocalKeyedSemaphore(1));
    $client = (new HttpClientBuilder)
            ->usingPool($pool)
            ->build();

    $requestHandler = static function (string $uri) use ($client) {
        /** @var Response $response */
        $response = yield $client->request(new Request($uri));

        return yield $response->getBody()->buffer();
    };

    try {
        $promises = [];

        foreach ($uris as $uri) {
            $promises[$uri] = Amp\call($requestHandler, $uri);
        }

        $bodies = yield $promises;

        foreach ($bodies as $uri => $body) {
            print $uri . " - " . \strlen($body) . " bytes" . PHP_EOL;
        }
    } catch (HttpException $error) {
        // If something goes wrong Amp will throw the exception where the promise was yielded.
        // The HttpClient::request() method itself will never throw directly, but returns a promise.
        echo $error;
    }
});

Can't pin down what's causing the segmentation fault, but here's all of the available information for a possible diagnosis. It seems to happen with responses that have JSON bodies of 1KB+.

This URL is has a large response: https://gist.github.com/2upmedia/5e6dd469237a652f43703ccd964d9d0e#file-amp-concurrency-test-php-L94

This one is small: https://gist.github.com/2upmedia/5e6dd469237a652f43703ccd964d9d0e#file-amp-concurrency-test-php-L95

You may have to run it several times to see the problem with the following command:

RUN_WITHOUT_BENCH=1 php70 -d xdebug.auto_trace=ON -d xdebug.trace_output_dir=/tmp/xdebug_trace amp-concurrent-test.php && echo $?

https://gist.github.com/2upmedia/5e6dd469237a652f43703ccd964d9d0e

_{PHP 7.4.12 / Amphp 4.5.2}

This is not a leak, but a stable excessive (10x+) memory usage in https vs http. There should be some overhead, but 10x+ is likely due to something wrong and very avoidable.

This is the minimal code to replicate the problem (make sure there is no cache):

use Amp\Http\Client\HttpClientBuilder;
use Amp\Http\Client\Request;
use Amp\Loop;


Loop::run(function () {
    /**
     *   http      2-4 MB RAM, depending on OS.
     *   https   40-48 MB RAM, depending on OS
     *
     *   Try both below:
     *   (example.com is an actual working server)
     */

    $url = 'https://example.com';

    $client   = HttpClientBuilder::buildDefault();
    $promise  = $client->request(new Request($url));
    $response = yield $promise;
    $body     = yield $response->getBody()->buffer();

    echo 'Mem: ' . memory_get_usage(true) / 1048576 . ' MB';
});

Hi guys, I have a problem similar to the issue #138 but it happens in a very weird manner so I don't think is related to that issue but the error message is the same: Socket disconnected prior to response completion (Parser state: 0). I'll explain the whole story.

I have a Mac Book Pro as a development machine and I have a simply Apache + PHP + MySQL setup. I have to work on several projects so to speedup the setup of every new project I configured Apache with VirtualDocumentRoot directive (here an example of my configuration http://roberto-montero.com/blog/how-setup-xampp-use-virtualdocumentroot-mac-os-x). I have also a virtual host configured for localhost whose document root is the root of my workspace (the directory which contains all of my projects, ~/Work/Projects). So if go to http://localhost/phpinfo.php, I get the phpinfo located in the root of all my projects (~/Work/Projects/phpinfo.php). Instead if I go to http://myproject.dev/phpinfo.php I get the phpinfo located in the directory of "myproject" (~/Work/Projects/myproject/phpinfo.php).

Ok, given this scenario, I wanted to use this async HTTP client to perform HTTP requests against a project which I'm working on.

So I installed artax using composer and simply copy & pasted your example n. 1 (https://github.com/amphp/artax/blob/master/examples/1-get-request.php) to perform a simple GET request.

First I tried with the URL provided in the example (https://httpbin.org/user-agent) and it worked. But then, I tried with my local project using the URL http://myproject.dev/phpinfo.php, and this last trial didn't work. I got the error Socket disconnected prior to response completion (Parser state: 0). After several trials I figured out that if I use http://localhost/phpinfo.php it works. So I tried with several different request to other resources/projects and the pattern that I found is that:

• Requests to resources under http://localhost/ are working
• Requests to resources under VirtualDocumentRoot virtual hosts (like http://myproject.dev/) are not working.

Please note that all of them are served from my dev machine (so Apache is the same, PHP is the same, etc...) and all my trials are with the same sample script.

So it seems (but I would like to confirm) that there is some weird circumstance that cause that error only if use a VirtualDocumentRoot virtual host.

Now, I would like to understand what the f**k is going on but I have no idea where to start. Do you guys have any suggestion? 😄

Thank you.

Not sure on the name, suggestions welcome.

Should we deprecate LimitedConnectionPool or rename it (with an alias of the old name) to SingleStreamConnectionPool or leave it as-is?

Closes #252.

When using RecordHarAttributes sometimes after a response completes the attribute amp.http.client.har.timings.complete is missing.

I cannot reproduce this consistently. It seems to be random.

This is what i use:

$builder = (new HttpClientBuilder)
            ->interceptNetwork(new DecompressResponse());

$client = $builder->build();

$promise = call(function () use ($client, $url) {
    $request = new Request($url);
    $request->addEventListener(new RecordHarAttributes());

    $response = yield $client->request($request);
    yield $response->getBody()->buffer();

    ///   Symfony\Component\Debug\Exception\FatalThrowableError  : The requested attribute 'amp.http.client.har.timings.complete' does not exist
     $responseTime = $response->getOriginalRequest()->getAttribute(HarAttributes::TIME_COMPLETE) - $response->getOriginalRequest()->getAttribute(HarAttributes::TIME_START);

});
$responses = wait(all([$promise]));

It is possible that its related to redirects, some of the domains i try do have redirects, but it still happens randomly

Sometimes requests hang infinetely (or until socket is closed remotely). Insights so far: Request hangs in read loop in DefaultClient::doRead after header is received. Normally it hangs in the last response chunk. Symptom before hang: 0 bytes are read from reader stream (ResourceInputStream) and then the socket never becomes readable again.

Script to reproduce:

https://gist.github.com/brstgt/3533deadce54dac4d1807a01de6f2d82

Problem normally appears after 10-200 iterations.

IMPORTANT: Problem does NOT occur if connection is not keep-alive (header 'Connection: close') OR if the NativeDriver is used

I am using Artax to replace Guzzle for non-blocking async requests. everything works fine but I found that the memory usage is increased rapidly.

$request = new Artax\Request($url, $method);

switch ($method) {
	case "POST":
		$request = $request->withHeader('Content-Type', 'application/json');
		$request = $request->withBody(json_encode($data));
		break;
}

$client = new Artax\DefaultClient;
$client->setOption(Artax\Client::OP_TRANSFER_TIMEOUT, 5000);
$response = yield $client->request($request);
$body = yield $response->getBody();

codes used

$promises[$URI] = Amp\call(function () use ($client, $URI) {
                    // "yield" inside a coroutine awaits the resolution of the promise
                    // returned from Client::request(). The generator is then continued.
                    $response = yield $client->request($URI);

                    // Same for the body here. Yielding an Amp\ByteStream\Message
                    // buffers the entire message.
                    $body = yield $response->getStatus();

                    return $body;
                });

            $responses = Amp\Promise\wait(Amp\Promise\all($promises));

below is error output

Fatal error: Uncaught Amp\Socket\CryptoException: Crypto negotiation failed: stream_socket_enable_crypto(): SSL operation failed with code 1. OpenSSL Error messages:
error:1414D172:SSL routines:tls12_check_peer_sigalg:wrong signature type in /var/www/html/vendor/amphp/socket/src/Internal/functions.php:118
Stack trace:
#0 /var/www/html/vendor/amphp/amp/lib/Loop/NativeDriver.php(172): Amp\Socket\Internal\{closure}('am', Resource id #293, Object(Amp\Deferred))
#1 /var/www/html/vendor/amphp/amp/lib/Loop/NativeDriver.php(68): Amp\Loop\NativeDriver->selectStreams(Array, Array, 4.782)
#2 /var/www/html/vendor/amphp/amp/lib/Loop/Driver.php(130): Amp\Loop\NativeDriver->dispatch(true)
#3 /var/www/html/vendor/amphp/amp/lib/Loop/Driver.php(70): Amp\Loop\Driver->tick()
#4 /var/www/html/vendor/amphp/amp/lib/Loop.php(76): Amp\Loop\Driver->run()
#5 /var/www/html/vendor/amphp/amp/lib/functions.php(158): Amp\Loop::run(Object(Closure))
#6 /var/www/html/parseradvance.php(77): Amp\Promise\wait(Object(Amp\Internal\PrivatePromise))
#7 {main}
  t in /var/www/html/vendor/amphp/socket/src/Internal/functions.php on line 118

192.168.1.187:8888 is a http proxy provide by tinyproxy, I use amphp/http-tunnel to use http proxy, often see this error:

[2023-01-04 00:01:24 715] Amp\Http\Client\Connection\Http2ConnectionException: The HTTP/2 connection from '192.168.1.60:48006' to '192.168.1.187:8888' closed in /home/web/apps/t-task-wind/releases/96/vendor/amphp/http-client/src/Connection/Internal/Http2ConnectionProcessor.php:1281
Stack trace:
#0 [internal function]: Amp\Http\Client\Connection\Internal\Http2ConnectionProcessor->run()
#1 /home/web/apps/t-task-wind/releases/96/vendor/amphp/amp/lib/Coroutine.php(118): Generator->send()
#2 /home/web/apps/t-task-wind/releases/96/vendor/amphp/amp/lib/Internal/Placeholder.php(149): Amp\Coroutine->Amp\{closure}()
#3 /home/web/apps/t-task-wind/releases/96/vendor/amphp/amp/lib/Deferred.php(53): Amp\Promise@anonymous->resolve()
#4 /home/web/apps/t-task-wind/releases/96/vendor/amphp/byte-stream/lib/ResourceInputStream.php(101): Amp\Deferred->resolve()
#5 /home/web/apps/t-task-wind/releases/96/vendor/amphp/amp/lib/Loop/EvDriver.php(59): Amp\ByteStream\ResourceInputStream::Amp\ByteStream\{closure}()
#6 [internal function]: Amp\Loop\EvDriver->Amp\Loop\{closure}()
#7 /home/web/apps/t-task-wind/releases/96/vendor/amphp/amp/lib/Loop/EvDriver.php(234): EvLoop->run()
#8 /home/web/apps/t-task-wind/releases/96/vendor/amphp/amp/lib/Loop/Driver.php(138): Amp\Loop\EvDriver->dispatch()
#9 /home/web/apps/t-task-wind/releases/96/vendor/amphp/amp/lib/Loop/Driver.php(72): Amp\Loop\Driver->tick()
#10 /home/web/apps/t-task-wind/releases/96/vendor/amphp/amp/lib/Loop/EvDriver.php(186): Amp\Loop\Driver->run()
#11 /home/web/apps/t-task-wind/releases/96/vendor/amphp/amp/lib/Loop.php(95): Amp\Loop\EvDriver->run()
...

And this is the log of tinyproxy at 00:01:24:

INFO      Jan 04 00:01:11 [2273380]: Closed connection between local client (fd:7) and remote client (fd:8)
CONNECT   Jan 04 00:01:24 [2291398]: Connect (file descriptor 7): 192.168.1.60 [192.168.1.60] at [192.168.1.187]
CONNECT   Jan 04 00:01:24 [2291398]: Request (file descriptor 7): CONNECT example.com:443 HTTP/1.1
INFO      Jan 04 00:01:24 [2291398]: No upstream proxy for example.com
INFO      Jan 04 00:01:24 [2291398]: opensock: opening connection to example.com:443
INFO      Jan 04 00:01:24 [2291398]: opensock: getaddrinfo returned for example.com:443
CONNECT   Jan 04 00:01:24 [2291398]: Established connection to host "example.com" using file descriptor 8.
INFO      Jan 04 00:01:24 [2291398]: Not sending client headers to remote machine
CONNECT   Jan 04 00:01:24 [2291819]: Connect (file descriptor 7): 192.168.1.60 [192.168.1.60] at [192.168.1.187]
CONNECT   Jan 04 00:01:24 [2291819]: Request (file descriptor 7): CONNECT login.example.com:443 HTTP/1.1
INFO      Jan 04 00:01:24 [2291819]: No upstream proxy for login.example.com
INFO      Jan 04 00:01:24 [2291819]: opensock: opening connection to login.example.com:443
INFO      Jan 04 00:01:24 [2291819]: opensock: getaddrinfo returned for login.example.com:443
CONNECT   Jan 04 00:01:24 [2291819]: Established connection to host "login.example.com" using file descriptor 8.
INFO      Jan 04 00:01:24 [2291819]: Not sending client headers to remote machine
INFO      Jan 04 00:01:24 [2291819]: Closed connection between local client (fd:7) and remote client (fd:8)
CONNECT   Jan 04 00:01:24 [2304987]: Connect (file descriptor 7): 192.168.1.60 [192.168.1.60] at [192.168.1.187]
CONNECT   Jan 04 00:01:24 [2304987]: Request (file descriptor 7): CONNECT login.example.com:443 HTTP/1.1
INFO      Jan 04 00:01:24 [2304987]: No upstream proxy for login.example.com
INFO      Jan 04 00:01:24 [2304987]: opensock: opening connection to login.example.com:443
INFO      Jan 04 00:01:24 [2304987]: opensock: getaddrinfo returned for login.example.com:443
CONNECT   Jan 04 00:01:24 [2304987]: Established connection to host "login.example.com" using file descriptor 8.
INFO      Jan 04 00:01:24 [2304987]: Not sending client headers to remote machine
INFO      Jan 04 00:01:24 [2304987]: Closed connection between local client (fd:7) and remote client (fd:8)
CONNECT   Jan 04 00:01:24 [2297292]: Connect (file descriptor 7): 192.168.1.60 [192.168.1.60] at [192.168.1.187]
CONNECT   Jan 04 00:01:24 [2297292]: Request (file descriptor 7): CONNECT login.example.com:443 HTTP/1.1
INFO      Jan 04 00:01:24 [2297292]: No upstream proxy for login.example.com
INFO      Jan 04 00:01:24 [2297292]: opensock: opening connection to login.example.com:443
INFO      Jan 04 00:01:24 [2297292]: opensock: getaddrinfo returned for login.example.com:443
CONNECT   Jan 04 00:01:24 [2297292]: Established connection to host "login.example.com" using file descriptor 8.
INFO      Jan 04 00:01:24 [2297292]: Not sending client headers to remote machine
INFO      Jan 04 00:01:24 [2297292]: Closed connection between local client (fd:7) and remote client (fd:8)
CONNECT   Jan 04 00:01:27 [2283968]: Connect (file descriptor 7): 192.168.1.60 [192.168.1.60] at [192.168.1.188]

I have try to change proxy to socks5 by microsocks, and use this example https://github.com/amphp/http-client/blob/master/examples/proxy/socks5.php to use socks5 proxy, the error still happend sometimes.

The following script sometimes throws "Segmentation fault" GDB shows this error when running the same script:

alpine: Program received signal SIGPIPE, Broken pipe. 0x00007fafa0dc44a3 in ?? () from /lib/ld-musl-x86_64.so.1

wheezy: Program received signal SIGPIPE, Broken pipe. 0x00007f5757905fb3 in __libc_write (fd=8, buf=0x560a390f44d3, nbytes=24) at ../sysdeps/unix/sysv/linux/write.c:26

<?php

use Amp\Future;
use Amp\Http\Client\HttpClientBuilder;
use Amp\Http\Client\HttpException;
use Amp\Http\Client\Request;
use function Amp\async;

require(__DIR__. "/../../vendor/autoload.php");

$uris = [
    "https://google.com/",
    "https://jsonplaceholder.typicode.com/todos/1",
    "https://nonexistingdomainwtfisthis.com",
];

// Instantiate the HTTP client
$client = HttpClientBuilder::buildDefault();

$requestHandler = static function (string $uri) use ($client): string {
    $request = new Request($uri);
    $request->setHeader("User-Agent", "Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/81.0");

    $response = $client->request($request);
    return $response->getBody()->buffer();
};

try {
    $startGlobal = microtime(true);

    $futures = [];
    foreach ($uris as $uri) {
        $futures[$uri] = async(function () use ($requestHandler, $uri) {
            try {
                $start = microtime(true);
                $future = async(fn() => $requestHandler($uri));
                $response = $future->await();
                $end = microtime(true) - $start;

                print $uri . " - " . strlen($response) . " bytes after $end seconds" . PHP_EOL;
            } catch (\Exception $error) {
                printf("%s: %s\n", "test", $error->getMessage());
            }
        });
    }

    $ignore = Future\await($futures);

    $endGlobal = microtime(true) - $startGlobal;
    print "Finished after $endGlobal seconds" . PHP_EOL;
} catch (HttpException $error) {
    // If something goes wrong Amp will throw the exception where the promise was yielded.
    // The HttpClient::request() method itself will never throw directly, but returns a promise.
    var_dump($error);
}

bash-5.1# php -v
PHP 8.1.12 (cli) (built: Nov 16 2022 20:54:15) (ZTS)
Copyright (c) The PHP Group
Zend Engine v4.1.12, Copyright (c) Zend Technologies
    with Zend OPcache v8.1.12, Copyright (c), by Zend Technologies
bash-5.1# php -m
[PHP Modules]
Core
ctype
curl
date
dom
fileinfo
filter
ftp
hash
iconv
json
libxml
mbstring
mysqlnd
openssl
pcntl
pcre
PDO
pdo_mysql
pdo_sqlite
Phar
posix
readline
redis
Reflection
session
SimpleXML
sodium
SPL
sqlite3
standard
tokenizer
xml
xmlreader
xmlwriter
Zend OPcache
zlib

[Zend Modules]
Zend OPcache

v5 Request::setBody should accept null because it did in v4. Also, WTF is up with int and float?

https://github.com/amphp/http-client/blob/92b60c132de57708a0255bdf05e9b2974f4a5047/src/Request.php#L222-L230

Thanks to fibers, the amphp/http-client v5 has a "sync" interface: it gets rid of promises & generators. It is now possible to implement the PSR-18: HTTP Client.

Benefits:

• Any sdk that requires a psr/http-client-implementation could become asynchronous when used with AMP.
• Any PSR-18 middleware could be used

I'm noticing a weird behaviour with startRequest event being called multiple times for a single request.

I'm using an event handler based on RecordHarAttributes and I was going to count the number of requests in addition to timings. When I incremented requests count in startRequest() I noticed the number is very high and it turned out startRequest() is called 9 times with the same URI/Request object. Is that by design?

Also, is completeReceivingResponse() called for failed requests as well? If yes, it might be the best place to increment requests count. For now I'm incrementing it in startSendingRequest().

function fetch(Request $request, HttpClient $client, LocalSemaphore $semaphore, HttpRequestTimings $timings): string
{
    $lock = $semaphore->acquire();
    $request->addEventListener($timings);
    $response = $client->request($request);

    if ($response->getStatus() !== 200) {
        throw new \Exception($response->getStatus() . " " . $response->getReason());
    }

    $body = $response->getBody()->buffer();

    $lock->release();

    return $body;
}