• [x] deal with LocalFileSystem, extending tests coverage to the remaining lines
• [x] integration test for include tag with an actual file
• [x] basic test for extends tag
• [x] full test case for extends tag
• [x] test case for Template::getCache when used in extends and include tags

Refactor TagAssign to use a Variable instance in the value assignment instead of a string. Remove QUOTED_STRING config from the TestCase as it was different from the default config for no reason that I could see.

I have issue

{{ settings.my_key }}

My mean is echo property my_key in settings object. If my_key is exists, it return well, but when my_key no exists, it return all property in settings object. I think it have to return null

Please check. Sorry my bad english

I have 6 different types of exceptions depending on the case :

• CacheException for cache configuration errors. (extends Liquid\LiquiException)
• NotFoundException in case of file not found exception (extends FilesystemException)
• FilesystemException in case of errors with the filesystem. (extends Liquid\LiquiException)
• ParseException in case of parsing errors (extends Liquid\LiquiException)
• RenderException in case of render errors (extends Liquid\LiquiException)
• WrongArgumentException for wrong arguments passed to filterBank::addFilter (extends Liquid\LiquiException)

Let me know what you think.

Resolves https://github.com/kalimatas/php-liquid/issues/74

• [x] I've run the tests with vendor/bin/phpunit
• [x] None of the tests were found failing
• [x] I've seen the coverage report at build/coverage/index.html
• [x] Not a single line left uncovered by tests
• [x] Any coding standards issues were fixed with vendor/bin/php-cs-fixer fix
• [x] Hotfix-type commits were squashed with git rebase -i or git commit --amend
• [x] All my work wasn't smushed into one large commit without necessity

• [x] I've run the tests with vendor/bin/phpunit
• [x] None of the tests were found failing
• [x] I've seen the coverage report at build/coverage/index.html
• [x] Not a single line left uncovered by tests
• [x] Any coding standards issues were fixed with vendor/bin/php-cs-fixer fix
• [x] Hotfix-type commits were squashed with git rebase -i or git commit --amend
• [x] All my work wasn't smushed into one large commit without necessity

Let's say you get a template name wrong. This can happen for any number of reasons. In my case, I didn't realize there was a default _ prefixing includes.

You initialize Liquid with

$renderer = new \Liquid\Template(__DIR__ . '/templates/');
$renderer->parse(file_get_contents(__DIR__ . '/templates/'));
echo $renderer->render([]);

The template looks like this:

{% include 'header' %}
Hello
{% include 'footer' %}

Inside LocalFileSystem $fullPath is set to /src/project/templates/_header.liquid, which does not exist.

The following exception is then thrown:

Details
Type: Liquid\LiquidException
Message: Illegal template path ''
File: C:\src\project\vendor\liquid\liquid\src\Liquid\LocalFileSystem.php
Line: 84

This isn't really that helpful. PHP's docs on realpath state that for a missing file, realpath will return false. So as far as I can tell, there is no case when the current thrown exception will give a useful error message.

Is there a reason that realpath is being called here?

Add supporting PSR-2 method namign Replace satooshi/php-coveralls to php-coveralls/php-coveralls

• [X] I've run the tests with vendor/bin/phpunit
• [X] None of the tests were found failing
• [X] I've seen the coverage report at build/coverage/index.html
• [X] Not a single line left uncovered by tests
• [X] Any coding standards issues were fixed with vendor/bin/php-cs-fixer fix

Hello! We're a big fan of this package -- thank you very much for creating and maintaining!

One of our clients tried to implement white space control. Example:

{%- assign my_variable = "tomato" -%}

However, when creating tags with a dash "-", we're experiencing a "Tag not properly terminated error".

Liquid \ Exception \ ParseException
Tag {%- assign my_variable = "tomato" -%} was not properly terminated

We're using version 1.4.8.

Is this something you're intending to support in future builds?

Thank you very much in advance! -Rich

• [x] I've run the tests with vendor/bin/phpunit
• [x] None of the tests were found failing
• [x] I've seen the coverage report at build/coverage/index.html
• [x] Not a single line left uncovered by tests
• [x] Any coding standards issues were fixed with vendor/bin/php-cs-fixer fix

Array first and last. If you have an expression whose value is an array, you can follow it with .first or .last to resolve to its first or last element. https://github.com/Shopify/liquid/wiki/Liquid-for-Designers

Try:

{{"now"|date }} or {{ 4 | plus }}

and you get:

Type error: Too few arguments to function Liquid\StandardFilters::date(), 1 passed and exactly 2 expected 

An LiquidException should be thrown.

Ending pagination still paginates outside of the paginate block.

For example in a blog where you want to paginate posts but also have a sidebar that reuses the same data.

`{% paginate blog.articles by 4 %} {% for article in blog.articles %} {{ article.title }} {% endfor %} {% endpaginate %}

{% for article in blog.articles %} {{ article.title }} {% endfor %}`

We have a magento 2 function that calls your package. We are upgrading to PHP8.1 and the function strftime is deprecated

Full error message Deprecated Functionality: Function strftime() is deprecated in /app/vendor/liquid/liquid/src/Liquid/StandardFilters.php on line 81

Do you know of a way to use something different than strftime.

Thanks!

If i the following scenario, which is used often in the project i work with. $template = new Template; $template->parse("Hello, {{ name.1 }}!") $template->render(array('name.1'=> 'Kennet')) it will output "Hello, !" so if the array key has a . in it it does not replace the tag correctly

If i remove the . from both the parse and render function call, it works as expected, but as 'name.1' is a valid name for a php array key, i think it should work the same. Or have i missed something? :)

Hi!

I have an issue what I cant seem to solve. I have a for loop and I want to echo something every 4th iteration of the for loop.

Normaly I would something like index % 4 === 1 that echo that thing but this is not working.

Anyone know how I can solve this?

I'm working on a Liquid-to-Twig converter, and am very appreciative of this library, thanks for all the work you've done on it.

If the source is

{% comment %} This is the child template. {% endcomment %}
{% extends "blocks/child.tpl" %}

{% block content %}
    	<h2>Entry one</h2>
    <p>This is my first entry.</p>
{% endblock %}

and I run

                $liquidTemplate = $liquid->parse($liquidSource);
               dump($liquidTemplate->getRoot()->getNodelist());

I don't get the "TagBlock" element.

Is there a way to access it?

I saw in Jekyll (I'm writing a small PHP SSG inspired in it, thanks to this project) and other .liquid implementations that there's a filter called where useful to filter out an array of data. Apparently in a recent version, Jekyll also added it as a filter in a for iteration (but I didn't see it in Shopify's version).

I didn't see it in php-liquid, so here's my initial take on this filter. Tried it on a single level array, need to check it out for multidimensional cases.

Note: if available under another name in the project, please disregard. Thanks!

{% assign developers = team | where: "job","Developer" %}

  /**
   * Where filter
   */
   public function where($array,$field,$value) {

        $r = array_filter($array, function($v, $k) use ($field,$value) {
                if (is_array($v)) {
                    return (isset($v[$field]) && $v[$field] == $value);
                } else {
                    return true;
                }
            }, ARRAY_FILTER_USE_BOTH);

        return $r;
   }