Source code of Ice framework

Hi @mruz,

I've found that the version 1.6 is available through apecl channel :+1:

However, using pecl install ice (I'm on a docker), I have :

/bin/bash /tmp/pear/temp/pear-build-defaultuserqn3XAf/ice-1.6.0/libtool --mode=compile cc  -I. -I/tmp/pear/temp/ice -DPHP_ATOM_INC -I/tmp/pear/temp/pear-build-defaultuserqn3XAf/ice-1.6.0/include -I/tmp/pear/temp/pear-build-defaultuserqn3XAf/ice-1.6.0/main -I/tmp/pear/temp/ice -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib  -DHAVE_CONFIG_H  -g -O2   -c /tmp/pear/temp/ice/ice.c -o ice.lo
mkdir .libs
 cc -I. -I/tmp/pear/temp/ice -DPHP_ATOM_INC -I/tmp/pear/temp/pear-build-defaultuserqn3XAf/ice-1.6.0/include -I/tmp/pear/temp/pear-build-defaultuserqn3XAf/ice-1.6.0/main -I/tmp/pear/temp/ice -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib -DHAVE_CONFIG_H -g -O2 -c /tmp/pear/temp/ice/ice.c  -fPIC -DPIC -o .libs/ice.o
/bin/bash /tmp/pear/temp/pear-build-defaultuserqn3XAf/ice-1.6.0/libtool --mode=compile cc  -I. -I/tmp/pear/temp/ice -DPHP_ATOM_INC -I/tmp/pear/temp/pear-build-defaultuserqn3XAf/ice-1.6.0/include -I/tmp/pear/temp/pear-build-defaultuserqn3XAf/ice-1.6.0/main -I/tmp/pear/temp/ice -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib  -DHAVE_CONFIG_H  -g -O2   -c /tmp/pear/temp/ice/kernel/main.c -o kernel/main.lo
/tmp/pear/temp/pear-build-defaultuserqn3XAf/ice-1.6.0/libtool: line 1283: kernel/main.loT: No such file or directory
mkdir kernel/.libs
mkdir: cannot create directory 'kernel/.libs': No such file or directory
make: *** [Makefile:194: kernel/main.lo] Error 1
ERROR: `make' failed

Regards,

I'm getting error exception after sign in with remember me option:

ErrorException[8]: unserialize(): Error at offset 0 of 34 bytes

It occurs on one app, but not with another. Looks like error with fcache (works before this commit) or zephir latest changes.

Strange trace:

#0 [internal function]: unserialize('Ice\\Auth\\Driver\\Model\\Users\\Tokens')
#1 [internal function]: Ice\Mvc\Model->unserialize('Ice\\Auth\\Driver\\Model\\Users\\Tokens')

#0 [internal function]: unserialize('echo')
#1 [internal function]: Ice\Mvc\Model->unserialize('echo')

#0 [internal function]: unserialize('1\x00\x00\x00\x00\x00\x00\x001\x00\x00\x00\x00\x00\x00')
#1 [internal function]: Ice\Mvc\Model->unserialize(Array)
#2 [internal function]: Ice\Auth\Driver\Model->getUser()

It may be related with the crypt.zep#L100, because auth/driver/model.zep#L185 launches cookies.zep#L102 during remember me option. Auth and Crypt uses unserialize function but with diferent data.

If I change serialize/unserialize to json_encode/json_decode in the mvc/model.zep#L622 or disable cookies encrypt it works. I'm trying to add code to reproduce this issue.

it'll be very convenient to access DI instance when ModuleInterface::registerAutoloaders() is changed to ModuleInterface::registerAutoloaders(variable $di).

    public function registerAutoloaders()
    {
        (new Loader())
            ->addNamespace(__NAMESPACE__ . '\Controllers', __DIR__ . '/controllers/')
            ->register();
    }

VS

    // better performance
    public function registerAutoloaders(Di $di)
    {
        $di->loader->addNamespace(__NAMESPACE__ . '\Controllers', __DIR__ . '/controllers/');
    }

$loader->addNamespace('', __DIR__ . '/Vendor/Parsedown') or $loader->addNamespace('/', __DIR__ . '/Vendor/Parsedown') or $loader->addNamespace("\\", __DIR__ . '/Vendor/Parsedown') doesn't work for Parsedown class dropped in __DIR__ . '/Vendor/Parsedown' directory.

$mk = new Parsedown; // class not found

please fix line 78，these is no \ in the class name

1. no exception when create model by filters, you can test if it exists in db by (new iModel(['id' => 9]))->exists()
2. fixed fineOne initial order: onConstruct --> load data from service --> initialize. the original order is: onConstruct --> initialize --> load data from service.
3. only reset primary key after insert if the primary key is autoincrement
4. minus enhancements
5. disallow empty filters for loadOne
6. fixed getRules('zzz') will return all rules
7. getRelated filter with options works for has_one

Handler Class with application/Controllers/ doesn't work.

ice-php/
.. application/
.. .. Controllers/
.. .. ..

Any idea?

I think this framework so simple than Phalcon but need more documentation like Bootstrap, Routing, Controller, Models, and other basics. And I have'nt found forum.

Sorry for My English, thanks!

Hi,

Following https://github.com/dependabot/dependabot-core/issues/1990, you meqan @mruz that composer, with

{
  "require": {
    "iceframework/framework": "~1.8.0"
  }
}

could handle ice compilation

That's not what I have using composer install --no-dev --prefer-dist --classmap-authoritative (I'm using https://github.com/the-benchmarker/web-frameworks to try this).

Regards,

Trying to build with GCC 10

/usr/bin/ld: kernel/.libs/main.o:/builddir/build/BUILD/php-pecl-ice-1.6.0/ZTS/./php_ice.h:56: multiple definition of `tsrm_ls'; .libs/ice.o:/builddir/build/BUILD/php-pecl-ice-1.6.0/ZTS/php_ice.h:56: first defi
ned here
/usr/bin/ld: kernel/.libs/memory.o:/builddir/build/BUILD/php-pecl-ice-1.6.0/ZTS/./php_ice.h:56: multiple definition of `tsrm_ls'; .libs/ice.o:/builddir/build/BUILD/php-pecl-ice-1.6.0/ZTS/php_ice.h:56: first de
fined here
/usr/bin/ld: kernel/.libs/exception.o:/builddir/build/BUILD/php-pecl-ice-1.6.0/ZTS/./php_ice.h:56: multiple definition of `tsrm_ls'; .libs/ice.o:/builddir/build/BUILD/php-pecl-ice-1.6.0/ZTS/php_ice.h:56: first
 defined here
/usr/bin/ld: kernel/.libs/debug.o:/builddir/build/BUILD/php-pecl-ice-1.6.0/ZTS/./php_ice.h:56: multiple definition of `tsrm_ls'; .libs/ice.o:/builddir/build/BUILD/php-pecl-ice-1.6.0/ZTS/php_ice.h:56: first def
ined here
/usr/bin/ld: kernel/.libs/object.o:/builddir/build/BUILD/php-pecl-ice-1.6.0/ZTS/./php_ice.h:56: multiple definition of `tsrm_ls'; .libs/ice.o:/builddir/build/BUILD/php-pecl-ice-1.6.0/ZTS/php_ice.h:56: first defined here
/usr/bin/ld: kernel/.libs/array.o:/builddir/build/BUILD/php-pecl-ice-1.6.0/ZTS/./php_ice.h:56: multiple definition of `tsrm_ls'; .libs/ice.o:/builddir/build/BUILD/php-pecl-ice-1.6.0/ZTS/php_ice.h:56: first defined here
/usr/bin/ld: kernel/.libs/string.o:/builddir/build/BUILD/php-pecl-ice-1.6.0/ZTS/./php_ice.h:56: multiple definition of `tsrm_ls'; .libs/ice.o:/builddir/build/BUILD/php-pecl-ice-1.6.0/ZTS/php_ice.h:56: first defined here
/usr/bin/ld: kernel/.libs/fcall.o:/builddir/build/BUILD/php-pecl-ice-1.6.0/ZTS/./php_ice.h:56: multiple definition of `tsrm_ls'; .libs/ice.o:/builddir/build/BUILD/php-pecl-ice-1.6.0/ZTS/php_ice.h:56: first defined here
/usr/bin/ld: kernel/.libs/require.o:/builddir/build/BUILD/php-pecl-ice-1.6.0/ZTS/./php_ice.h:56: multiple definition of `tsrm_ls'; .libs/ice.o:/builddir/build/BUILD/php-pecl-ice-1.6.0/ZTS/php_ice.h:56: first defined here
/usr/bin/ld: kernel/.libs/file.o:/builddir/build/BUILD/php-pecl-ice-1.6.0/ZTS/./php_ice.h:56: multiple definition of `tsrm_ls'; .libs/ice.o:/builddir/build/BUILD/php-pecl-ice-1.6.0/ZTS/php_ice.h:56: first defined here
/usr/bin/ld: kernel/.libs/operators.o:/builddir/build/BUILD/php-pecl-ice-1.6.0/ZTS/./php_ice.h:56: multiple definition of `tsrm_ls'; .libs/ice.o:/builddir/build/BUILD/php-pecl-ice-1.6.0/ZTS/php_ice.h:56: first defined here
/usr/bin/ld: kernel/.libs/math.o:/builddir/build/BUILD/php-pecl-ice-1.6.0/ZTS/./php_ice.h:56: multiple definition of `tsrm_ls'; .libs/ice.o:/builddir/build/BUILD/php-pecl-ice-1.6.0/ZTS/php_ice.h:56: first defi
...

Use PHP 7 ZEND_TSRMLS_CACHE way instead (tsrm_ls is no more needed)

PHP Warning: PHP Startup: Unable to load dynamic library '/usr/lib64/php/modules/ice.so' - /usr/lib64/php/modules/ice.so: undefined symbol: zval_used_for_init in Unknown on line 0 include_path => .:/usr/share/pear:/usr/share/php => .:/usr/share/pear:/usr/share/php

php version 7.1.21 Centos 7.5

I want to use an IN clause as the following example.

Users::find(['status' => ['NOT IN' => [0, 1]], 'deleted_at' => ['IS' => null]]);

Users::find(['status' => ['IN' => [2, 3]], 'deleted_at' => ['IS' => null]]);

Hi @mruz,

To build ice on alpine, we need libexecinfo-dev.

This package has been retired and will not be included in alpine anymore https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/36722

Is there any workaround ?

Regards,

Assets loading with themes and skins supported. assume that different apps (or plugins) are independent with each others but share the same basic modules and public resources

A) asset cases: there are stylesheet files in public css share by all apps and app specific stylesheet locate in its directory. e.g.

• public/css/style.css
• public/min/css/style.min.css
• app/account/skin/default/css/account.css
• public/min/css/account.min.css

B) loading source and target

1. load the min file
   • a) load from public: /css/style.css ===> public/min/css/style.min.css minify public/css/style.css to public/min/css/style.min.css
   • b) load from app dir: css/account.css ===> public/min/css/account.min.css minify account/default/css/account.css to public/min/css/account.min.css
2. load the raw file
   • a) load from public: /css/style.css ===> public/css/style.css
   • b) load from app dir: default/css/account.css ===> public/default/css/account.css
     • i) if public/default/css/account.css not exists, copy account/default/css/account.css to public/default/css/
     • ii) else update account/default/css/account.css to public/default/css/

C) implement

1. if uri is start with /, it'll try to load asset from document root

$mySkin = 'Default';

// Register specific services for the module
public function registerServices(Di $di)
{
    $di->assets->setOptions([
            'source' => __DIR__ . '/Skin/' . $mySkin . '/',
            'target' => 'min/',
            'minify' => 3
        ]);
}

// css used by specific module
// load from module dir/Skin/Default/css/account.css
$this->assets->addCss(['css/account.css']); 

// css shared by all modules
// load from document_root/Skin/Default/css/style.css
$this->assets->addCss(['/Skin/' . $mySkin . '/css/style.css']); 

2. always store the min files in the document_root/target dir

ONE MORE THING

type parameter change from text/css or text/javascript to css or js

$assets->addCss(['css/style.css', 'type' => 'css'])
->addCss(['js/script.js', 'type' => 'js'])

but not

$assets->addCss(['css/style.css', 'type' => 'text/css'])
->addCss(['js/script.js', 'type' => 'text/javascript'])

Hello.

I'm finding some PHP7 frameworks and see some benchmark pages. This framework looks like so fast. amazing. but I don't know other features...

So what key points of this framework? now I'm planning use to lumen because I'll make not too big product.