Initial commit fixing wrong return value in Database/BaseConnection:query. When underlying resultID if false, this function should return false as described in #4069. This is a preliminary (and trivial) correction. In order for this change to be run, the db must be configured with DBDebug=false (e.g., in production mode).

NOTE that this code change is based on the CI 3 behavior. This may seem like a fundamental change but I truly believe that returning a Result object when the query failed was a mistake because these cast to true. I have been unable to detect any change in the behavior of the phpunit tests from this one change, so it's my guess that the phpunit tests do not ever run with DBDebug=false. I've constructed a phpunit test, BadQueryTest which seems to work on my machine, but I have added this line to my .env file:

database.tests.DBDebug = false

I suspect my BadQueryTest might have trouble with the automate tests that will run, and would ask help (@kenjis ? @michalsn ?) in massaging things here to achieve the right test and make sure this isn't a breaking change. I've only made this change to try and make sure CI4 behaves as the documentation says it will. There are no changes required to the user docs. On the contrary, there is probably still more work to be done to the code to make sure it behaves as the documentation says it does. In particular, the code will not currently return true under any circumstances.

Description I changed one line (line 680) to return false instead of a Result object. This conforms both to CI3 behavior but also to the behavior described in the CI4 documentation. I added a BadQueryTest which probably needs work.

Checklist:

• [x] Securely signed commits
• [x] Component(s) with PHPdocs
• [x] Unit testing, with >80% coverage
• [ ] User guide updated
• [x] Conforms to style guide

Description I wanted to use CodeIgniter4 in an Oracle environment. Also, it was determined that support would be provided because ORACLE was described in the document.

Checklist:

• [x] Securely signed commits
• [x] Component(s) with PHPdocs
• [ ] Unit testing, with >80% coverage
• [x] User guide updated
• [x] Conforms to style guide

The design of the program to get the insertId of this PR is not so good.

Please good solution.

See #6170

Checklist:

• [x] Securely signed commits
• [ ] Component(s) with PHPDoc blocks, only if necessary or adds value
• [ ] Unit testing, with >80% coverage
• [ ] User guide updated
• [ ] Conforms to style guide

name: Bug report about: Help us improve the framework by reporting bugs!

Describe the bug There are two issues with the redirect() method.

1. I am not able to use return redirect()->to('/'); so I have to follow it up with an exit to make it work. e.g.

public function hello() {
//this won't work;
return redirect()->to('/');
//this works
redirect()->to('/');
exit;
}

2. The other issue is none of the redirects are working now since approximately after yesterday (17 nov 2018) evening. To make sure, I haven't accidently broken it, I just downloaded a new copy of CI4-develop and after setup I could see welcome message to confirm everything working fine. Then I made these modifications below to the Home controller. If I try mylocalsite/home/daljit it just shows a blank page.

 namespace App\Controllers;

use CodeIgniter\Controller;

class Home extends Controller
{
	public function index()
	{
		return view('welcome_message');
	}

	//--------------------------------------------------------------------
    public function daljit()
    {
        return redirect()->to("/home/hello");
    }

    public function hello()
    {
        echo "Hello!";
    }
}

CodeIgniter 4 version CodeIgniter 4 develop branch.

Looking for someone familiar with PHP_CodeSniffer to create a ruleset matching our style guide. This is initially intended for use inside an IDE, and ultimately perhaps as part of our travis-ci build.

Added unit tests/system/Database/Live/GetNumRowsTest.php for this newly added method. Added an entry in the user docs for getNumRows method. Tweaks MockResult to fix phpstan problem and class definition conflict. This is my signed initial commit.

Description Per Lonnie Ezell's message in #109, I have attempted my first CodeIgniter fork/branch/pull request here. It adds a getNumRows method to the ResultInterface and the various DBMS classes that extend it. This pull request supercedes a couple of messy ones (for which I apologize).

Checklist:

• [X] Securely signed commits
• [X] Component(s) with PHPdocs
• [X] Unit testing, with >80% coverage
• [X] User guide updated
• [X] Conforms to style guide

Description

Many devices and applications have a "dark mode" nowadays. I use it on my computer, and I develop applications with this feature.

When I use the current debug bar, it sometimes gives a contrast which is tiring for the eyes. So I thought it might be interesting to add this feature, which ultimately requires only a few lines of code.

Colors are similar to Chrome's console, using dark mode on Mac OS.

Checklist:

• [x] Securely signed commits
• [x] Unit testing, with >80% coverage
• [x] User guide updated
• [x] Conforms to style guide
• [x] Component(s) with PHPdocs (N/A)

Bug Description Impossible to perform migrations through spark (experienced in versions 4.0.2 to 4.0.4)

Although DB credentials are set in .env and/orin app/Config/Database.php and successful query results obtained through Controller classes,

php spark migrate causes CodeIgniter\Database\Exceptions\DatabaseException

Exact command line output:

CodeIgniter CLI Tool - Version 4.0.4 - Server-Time: 2020-07-19 05:22:57am

Running all new migrations...
An uncaught Exception was encountered

Type:        CodeIgniter\Database\Exceptions\DatabaseException
Message:     Unable to connect to the database.
Filename:    /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/Database/BaseConnection.php
Line Number: 425

	Backtrace:
						-646 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/Database/BaseConnection.php::initialize
								-1548 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/Database/BaseConnection.php::query
								-1591 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/Database/BaseConnection.php::listTables
								-945 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/Database/MigrationRunner.php::tableExists
								-193 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/Database/MigrationRunner.php::ensureTable
								-128 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/Commands/Database/Migrate.php::latest
								-100 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/CLI/Commands.php::run
								-107 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/CLI/CommandRunner.php::run
								-85 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/CLI/CommandRunner.php::index
								-914 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/CodeIgniter.php::_remap
								-404 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/CodeIgniter.php::runController
								-312 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/CodeIgniter.php::handleRequest
								-86 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/CLI/Console.php::run
								-57 - /Applications/MAMP/ci4projs/deneme/spark::run

CodeIgniter 4 version Last gotten in v4.0.4 release

Affected module(s) spark

Expected behavior All migrations performed successfully (without exceptions).

Steps to reproduce

1. Open up a Terminal / command line window
2. Change to the directory to the grand-parent level of your webserver's htdocs where htdocs will be substituted with the public directory of CI4
3. composer create-project codeigniter4/appstarter deneme
4. Open the project in your code editor and edit the .env file to set CI_ENVIRONMENT = development (duplicate it first from the file named 'env' if it doesn't exist - i.e. cp env .env)
5. Perform one or both of steps 6 and 7:
6. Enter DB credentials for MySQL in .env file (with database.default.DBDriver = MySQLi)
7. Enter DB credentials in app/Config/Database.php
8. Go back to the command line and run the following commands (in my example proj name is 'deneme': 9: cd deneme
9. php spark migrate:create AddBlog
10. (Optional) Go back to your code editor and open the file whose name is resembles "2020_mm_dd_hhmmss_AddBlog.php" from app/Database/Migrations
11. (Optional) Replace the contents of up() and down() methods with example from https://codeigniter.com/user_guide/dbmgmt/migration.html
12. Go back to the command line and while still in the root directory of the CI4 project run
13. php spark migrate
14. Compare your Terminal output to the following output:

CodeIgniter CLI Tool - Version 4.0.4 - Server-Time: 2020-07-19 05:42:10am

Running all new migrations...
An uncaught Exception was encountered

Type:        CodeIgniter\Database\Exceptions\DatabaseException
Message:     Unable to connect to the database.
Filename:    /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/Database/BaseConnection.php
Line Number: 425

	Backtrace:
						-646 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/Database/BaseConnection.php::initialize
								-1548 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/Database/BaseConnection.php::query
								-1591 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/Database/BaseConnection.php::listTables
								-945 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/Database/MigrationRunner.php::tableExists
								-193 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/Database/MigrationRunner.php::ensureTable
								-128 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/Commands/Database/Migrate.php::latest
								-100 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/CLI/Commands.php::run
								-107 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/CLI/CommandRunner.php::run
								-85 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/CLI/CommandRunner.php::index
								-914 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/CodeIgniter.php::_remap
								-404 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/CodeIgniter.php::runController
								-312 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/CodeIgniter.php::handleRequest
								-86 - /Applications/MAMP/ci4projs/deneme/vendor/codeigniter4/framework/system/CLI/Console.php::run
								-57 - /Applications/MAMP/ci4projs/deneme/spark::run

Context

• OS: Experienced in macOS 10.3
• Web server: Apache 2.x (in MAMP 5.4)
• PHP version 7.3.7
• MySQL 5.7

Fixing #2812 . In postgresql, somehow, call via API with Resource Controller and is_unique/is_not_unique validation make query id != {id} not work. While in mysql work. This check if ignoreValue doesn't has { prefix and } suffix.

Checklist:

• [x] Securely signed commits
• [x] Unit testing, with >80% coverage

Description It is not necessary that the update() method be able to update all records without WHERE clause. Updating all records is a risky operation and should not be mixed with update method with id(s).

The current API is not good design because it is easily to create a vulnerability that allows all records to be updated if you accidentally forget to validate the $id. See https://forum.codeigniter.com/showthread.php?tid=84833

• [BC] disallow Model::update() without WHERE clause (throws Exception).
• disallow $id as bool for update()/delete() (throws Exception).
• ~~add Model::updateAll($data) for UPDATE without WHERE clause.~~
• add tests for Model::detete(). DELETE without WHERE clause is already not allowed.

Checklist:

• [x] Securely signed commits
• [x] Component(s) with PHPDoc blocks, only if necessary or adds value
• [ ] Unit testing, with >80% coverage
• [x] User guide updated
• [x] Conforms to style guide

I have changed the namespace from Config\App to BackEnd\Config\App

it gives me an error in the core here. called in /path/system/CodeIgniter.php on line 571

Some of configuration files i can't use on BackEnd and FrontEnd simultaneously.

How can i make this work without changing core ?

This issue come from #3434

database-live-tests (8.0, OCI8, 5.7) / Database Live Tests

There was 1 failure:

1) CodeIgniter\Models\InsertModelTest::testInsertBatchSetsDatetimeTimestamps
Failed asserting that 2 is equal to 1 or is less than 1.

/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/CIUnitTestCase.php:436
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Models/InsertModelTest.php:125

Description

• replace migration classname at runtime

See https://github.com/codeigniter4/CodeIgniter4/pull/7038#issuecomment-1367178671

How to Test

$ php spark make:migration KenjisTest
$ php spark make:migration KenjisTest
$ php spark migrate
$ php spark migrate:refresh

Checklist:

• [x] Securely signed commits
• [ ] Component(s) with PHPDoc blocks, only if necessary or adds value
• [ ] Unit testing, with >80% coverage
• [ ] User guide updated
• [x] Conforms to style guide

Description

• add docs for 4.2.12

Checklist:

• [x] Securely signed commits
• [] Component(s) with PHPDoc blocks, only if necessary or adds value
• [] Unit testing, with >80% coverage
• [x] User guide updated
• [] Conforms to style guide

Description From https://forum.codeigniter.com/showthread.php?tid=85960

• fix bug
• add Config\Honeypot::$containerId

How to Test

diff --git a/app/Config/App.php b/app/Config/App.php
index 0a23462b6..e8f314371 100644
--- a/app/Config/App.php
+++ b/app/Config/App.php
@@ -446,5 +446,5 @@ class App extends BaseConfig
      * @see http://www.html5rocks.com/en/tutorials/security/content-security-policy/
      * @see http://www.w3.org/TR/CSP/
      */
-    public bool $CSPEnabled = false;
+    public bool $CSPEnabled = true;
 }
diff --git a/app/Config/Filters.php b/app/Config/Filters.php
index 7b70c4fb3..12bb9619c 100644
--- a/app/Config/Filters.php
+++ b/app/Config/Filters.php
@@ -29,13 +29,13 @@ class Filters extends BaseConfig
      */
     public array $globals = [
         'before' => [
-            // 'honeypot',
+            'honeypot',
             // 'csrf',
             // 'invalidchars',
         ],
         'after' => [
             'toolbar',
-            // 'honeypot',
+            'honeypot',
             // 'secureheaders',
         ],
     ];
diff --git a/app/Controllers/Home.php b/app/Controllers/Home.php
index 7f867e95f..c451f5302 100644
--- a/app/Controllers/Home.php
+++ b/app/Controllers/Home.php
@@ -6,6 +6,6 @@ class Home extends BaseController
 {
     public function index()
     {
-        return view('welcome_message');
+        return '<head></head><form></form>';
     }
 }

You will see Fill This Field before this PR.

Checklist:

• [x] Securely signed commits
• [x] Component(s) with PHPDoc blocks, only if necessary or adds value
• [ ] Unit testing, with >80% coverage
• [x] User guide updated
• [x] Conforms to style guide

Description Ref: twbs/bootstrap#36325 PHP-CS-Fixer/PHP-CS-Fixer#6644

Checklist:

• [x] Securely signed commits
• [ ] Component(s) with PHPDoc blocks, only if necessary or adds value
• [ ] Unit testing, with >80% coverage
• [ ] User guide updated
• [ ] Conforms to style guide

Description See https://github.com/codeigniter4/CodeIgniter4/pull/7000#issuecomment-1364524729

• update backward_compatibility_notes.rst

At least Autoloader::loadLegacy() was removed in 4.1.0. See https://codeigniter4.github.io/CodeIgniter4/installation/upgrade_410.html#breaking-changes

Checklist:

• [x] Securely signed commits
• [] Component(s) with PHPDoc blocks, only if necessary or adds value
• [] Unit testing, with >80% coverage
• [x] User guide updated
• [] Conforms to style guide