PHP versions 5.6 and 7.0 are officially unsupported now. Should we stop supporting them as well?

In my PR #19, I made some changes to be compatible with the latest versions of PHP and phpunit, but it broke PHP 7.0 and 5.6 compatibility. It would be easier overall to stop supporting the older versions, but I don't know, is anyone still using this library with an old PHP version?

Changed log

• Fix issue #11.
• It's related to this PR #12.
• Create this PR because the PR #12 seems to be inactive.
• Upgrade the PHPUnit version and support the multiple PHP versions in Travis CI build.
• To be compatible with the stable PHPUnit version, using the class-based PHPUnit namespace.
• Add the ext-mbstring in require key because the mb_strlen function is used in this repository.

Throws different errors...

Fatal error: Uncaught HJSON\HJSONException: End of input while parsing an array (did you forget a closing ']'?) at line 19, 30 >>>9,

Fixes #14

It looks like everything was built with utf8 strings in mind, but the parser implementation always counted in bytes, not characters. With this fix, $this->ch can now be a multi-byte utf8 character, but $this->at still counts up bytes. I've hopefully fixed the next(), peek(), and error(), and I think that's all that needs to be fixed, but I would like someone else to go over my changes as well.

Something to note about this code is that the php function mb_substr counts in characters whereas mb_strcut counts (safely) in bytes. So in several places I will use mb_substr(mb_strcut($str, $pos), 0, $len) where $pos is in bytes and $len is in characters.

Add the () in the constructor call for consistency (and follow PHP standards too).

Reference to the standard: https://www.php-fig.org/per/coding-style/#4-classes-properties-and-methods.

{
  :0
}

causes Fatal error: Cannot access empty property in .../src/HJSON/HJSONParser.php on line 204 instead of a exception with message Error: Found ':' but no key name

Thank you for a great library.

I found an issue. The string

{products: [
  {name:'Knife', price: 2.25},
  {name:'Spoon', price: 2.50},
  {name:'Fork', price: 2.99},
]}

works when I use http://hjson.org/try.html but not when using this library.

HJSONStringifier->quote has a check at the beginning which returns an empty quoted string if the string is falsy:

private function quote($string = null, $gap = null, $hasComment = null, $isRootObject = null)
    {
        if (!$string) {
            return '""';
        }
...}

This means that if the string is falsy, such as if it contains just "0", it won't be serialized correctly:

php > echo (new HJSON\HJSONStringifier)->stringify(["A", "0"]);
[
  A
  ""
]

The fix is simply changing the !$string test to $string === ''. As HJSONStringifier->quote is a private function and, as far as I can see, there is no way for it to be called with anything other than a string, this should not affect anything else.

This example code:

$hjsonParser->parse(
	'{
		content:
			\'\'\'
			←→±≠Я
			\'\'\'
	}'
);

Throws:

Bad multiline string at line 5, 1 >>> ''' } ...

PS C:\xampp\htdocs\ulicms> composer require HJSON/HJSON


  [InvalidArgumentException]
  Could not find package HJSON/HJSON at any version for your minimum-stability (stable). Check the package spelling or
   your minimum-stability

I tried this but got the same error

{
	"minimum-stability" : "dev"
}

Hi, Cannot have any kind and anywhere the "0" (zero) char in a multiline string. it does give me each time: HJSONException: Bad multiline string at line x, y

Other "numbers" are working fine :-) Thanks

Hi, could you please provide an option to completely disable using hash (#) as a special symbol for comments?

'#' is a widespread symbol among the web and it is not convenient to enclose a string in quotes should it start with hash.

Thanks.

The PHP implementation of Hjson was kindly contributed by @iainhallam and @jawb.

As they are occupied elsewhere we are in need of a contributor. If you know PHP and would like to help out please let us know!