Hello Everyone,

Yesterday I had a couple of emails with @AkenRoberts, we talked about the future of this project.

As you know, the package is very hard to maintain, and would desperately need refreshment.

I'm on the side of a complete rewrite, @AkenRoberts is also leaning towards that. 1 package per component and a metapackage as the main package is also very appealing.

I created a concept, I would like to ask your opinion about it.

https://github.com/Padam87/sluggable2

this repo currently contains common files, a sluggable extension, and it is just for demo / POC purposes

I started by extending the metadata factory https://github.com/Padam87/sluggable2/blob/master/src/Metadata/ExtendedClassMetadataFactory.php

and created an extended metadata class to hold our data https://github.com/Padam87/sluggable2/blob/master/src/Metadata/ExtendedClassMetadata.php

extended the annotation driver to allow extensions to hook up to it https://github.com/Padam87/sluggable2/blob/master/src/Metadata/Driver/AnnotationDriver.php

sluggable extension https://github.com/Padam87/sluggable2/blob/master/src/Metadata/Driver/SluggableDriverExtension.php

and the listener accessing the data from the extended metadata class https://github.com/Padam87/sluggable2/blob/master/src/Listener/SluggableListener.php

As you know, doctrine 3 is also on the way, so I had a short chat with @guilhermeblanco about the long-term viability of this concept. He said it may need some adjustments once V3 is out, but it should hold up.

There are some other good models for store hierarchical structures, like closure table http://www.slideshare.net/billkarwin/sql-antipatterns-strike-back - slide 68. I think that tree-extension may support differ models.

When using Sluggable extension, slug aren't created, i have an empty value ' '.

phpunit result:

macbook-julbou:tests julbou$ phpunit Gedmo/Sluggable/SluggableDocumentTest.php
PHPUnit 3.5.13 by Sebastian Bergmann.

FF

Time: 1 second, Memory: 12.00Mb

There were 2 failures:

1) Gedmo\Sluggable\SluggableDocumentTest::testSlugGeneration
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-my-title-the-code
+

/Users/julbou/Sites/resowl2/src/vendor/DoctrineExtensions/tests/Gedmo/Sluggable/SluggableDocumentTest.php:72

2) Gedmo\Sluggable\SluggableDocumentTest::testUniqueSlugGeneration
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
--1
+my-title-the-code-1

/Users/julbou/Sites/resowl2/src/vendor/DoctrineExtensions/tests/Gedmo/Sluggable/SluggableDocumentTest.php:95

FAILURES!
Tests: 2, Assertions: 2, Failures: 2.

Before updating gedmo tree worked like a charm! :)

After updating the code (gedmo & other vendors) and using new annotations in entity files I got 500 Internal Server Error - ErrorException:

 Notice: Undefined index: strategy in D:\My Dropbox\Symfony\vendor\gedmo-doctrine-extensions\lib\Gedmo\Tree\TreeListener.php line 72

It does not look like a bug on my side :)

Part of the stack trace:

    in D:\My Dropbox\Symfony\app\bootstrap.php.cache at line 382    

    at ErrorHandler ->handle ('8', 'Undefined index: strategy', 'D:\My Dropbox\Symfony\vendor\gedmo-doctrine-extensions\lib\Gedmo\Tree\TreeListener.php', '72', array('om' => object(EntityManager), 'class' => 'Company\ProjectBundle\Entity\Category', 'config' => array('left' => 'lft', 'level' => 'lvl', 'right' => 'rgt', 'parent' => 'parent', 'useObjectClass' => 'Company\ProjectBundle\Entity\Category'), 'managerName' => 'ORM', 'this' => object(TreeListener))) 
    in D:\My Dropbox\Symfony\vendor\gedmo-doctrine-extensions\lib\Gedmo\Tree\TreeListener.php at line 72    

    at TreeListener ->getStrategy (object(EntityManager), 'Company\ProjectBundle\Entity\Category') 
    in D:\My Dropbox\Symfony\vendor\gedmo-doctrine-extensions\lib\Gedmo\Tree\TreeListener.php at line 197    

    at TreeListener ->loadClassMetadata (object(LoadClassMetadataEventArgs)) 
    in D:\My Dropbox\Symfony\vendor\doctrine-common\lib\Doctrine\Common\EventManager.php at line 64    

    (...)

Btw. thanks for great work!

Hi guys,

I've been working on this for a few days. I've added a missing functionality for the Closure strategy and Materialized Path: the buildTree method. Another missing feature for the Closure strategy I've added is the "level" property. I'm not sure if I've implemented this in the best way, so I'd like to hear comments about it.

A last thing I want to work on is on documentation for Closure strategy. I think that after finishing all these things we'll have these two strategies a little more "robust", similar to nested set.

Thanks.

Hi Everyone,

First of all, I would like to thank @l3pp4rd for his work on this project. He has spent an amazing amount of his free time working on this, and still, to this day he contributes the most to this project.

I think we have reached a point where this project is at a decision point. It would need a major overhaul to make it up to date again.

I propose deprecating the library, and limiting contributions to vital fixes only.

I would like to propose a solution too:

• Create a new organization responsible for this project.
• Use a modular approach, with each extension having its own repository and package.
• Save as much of the current mapping schemas as possible, update code to PHP 7.1+, drop support for older deps.

I think this approach would breathe new life into this project.

• More people would be willing to contribute.
• Extensions could be installed separately.
• Extensions could break BC on their own, allowing a greater pace for development.

We should also cut some extensions entirely. I propose completely dropping Uploadable (in favor of Vich), and adapting KNP's version of Translatable.

Just as a POC I've started the work with Timestampable. The tests are running, but I have not tried it for real as of yet.

https://github.com/doctrine-extensions

This is of course a huge amount of work, which I cannot accomplish alone, and I think no one should do it alone. We should make sure that the project has enough contributors first. A backer company would also be nice... but I guess that is just a dream.

So, thats about it... what do you think?

Adam

I'm looking for a way to fetch a whole mapped tree. I have found nothing in the documentation, the code or the GitHub issues. This seems to be unsupported at the moment. Basically I'm looking for a method like childrenHierarchy that returns mapped entities instead of an array.

Could this be achieved with a custom hydrator? Has anyone tried this before?

I'm guessing that there's some kind of limitation since this has not been implemented?

When using soft deletes, and entity object is not actually being deleted, thus no cascades trigger down to associated objects.

My original email with @l3pp4rd and @comfortablynumb:

I'm using the soft delete feature, and its working well. In the relationship defined below, I have soft delete set up on both the Event entity (where this association is defined), as well as the associated entity, EventMetaDataValue.

I'd like to include on-delete="CASCADE" so that the associated EventMetadataValue's deletedAt timestamp also gets updated, however this doesn't seem to trigger. Presumably this is because I'm not actually deleting the Event entity, since I'm using soft delete.

My question is, is there a way to have that behavior take place (i.e., cascade the soft-delete down to the associated table)? Scouring the net didn't lead me to anything useful, and your docs don't reference a situation like that. I was hoping there was a syntactical way to carry out this operation, and that I won't have to write a listener to take care of it.

    <entity name="Cms\CoreBundle\Entity\Event" table="event">
         ...
        <many-to-many field="eventMetadataValues" target-entity="EventMetadataValue">
            <join-table name="event_metadata">
                <join-columns>
                    <join-column name="event_id" referenced-column-name="id" />
                </join-columns>
                <inverse-join-columns>
                    <join-column name="event_metadata_value_id" referenced-column-name="id" />
                </inverse-join-columns>
            </join-table>
        </many-to-many>
         ...
    </entity>

And Gustavo's response:

You're right, since entities which are not explicitly removed from the entity manager don't trigger any events, they are not handled by softdeleteable. One way would be to use cascade delete. But, of course, this avoids the perfomance boost of using normal db cascade delete.

We could detect, however, an entity which is being deleted and, if it has a configuration in its join columns with cascade delete, we could softdelete its children.

This error drives me crazy! Sorry - I'm new with this.

My composer:

// composer.json
{
    "minimum-stability": "dev",
    "require": {
        "php": ">=5.3.3",
        "zendframework/zendframework": "2.2.2",
        "doctrine/doctrine-orm-module": "0.8.*@dev",
        "hounddog/doctrine-data-fixture-module": "dev-master",
        "zendframework/zftool": "dev-master",
        "gedmo/doctrine-extensions": "2.3.*",
        "phploc/phploc": "*",
        "phpmd/phpmd": "dev-master",
        "sebastian/phpcpd": "2.0.*@dev",
        "pdepend/pdepend" : "dev-master",
        "ruflin/elastica": "0.20.5.*@dev",
        "zendframework/zend-developer-tools": "dev-master"
    }
}

My setup:

zendframework/zendframework: 2.2.2
doctrine/annotations: dev-master (316b956)
doctrine/common: 2.4.x-dev (9a7e20e)
doctrine/doctrine-module: 0.8.0
doctrine/doctrine-orm-module: 0.8.0
doctrine/orm: dev-master (927d69b)
gedmo/doctrine-extensions: dev-master (ff48eb0)

Trying to make Nested Tree by documentation tutorial.

Error after this:

$food= new Category;
$food->setTitle('Food');
$em->persist($food);
$em->flush();

Gedmo\Exception\UnexpectedValueException: Root cannot be changed manually, change parent instead in /var/www/domains/zfb2.local/data/vendor/gedmo/doctrine-extensions/lib/Gedmo/Tree/Strategy/ORM/Nested.php on line 143

So I've added this for debug

var_dump($food);
object(Application\Entity\Category)[377]
  private 'id' => null
  private 'title' => string 'Food' (length=4)
  private 'lft' => null
  private 'lvl' => null
  private 'rgt' => null
  private 'root' => null
  private 'parent' => null
  private 'children' => null

and

// line #142 Nested.php
var_dump($config, $changeSet);

array (size=9)
  'strategy' => string 'nested' (length=6)
  'activate_locking' => boolean false
  'locking_timeout' => int 3
  'left' => string 'lft' (length=3)
  'level' => string 'lvl' (length=3)
  'right' => string 'rgt' (length=3)
  'root' => string 'root' (length=4)
  'parent' => string 'parent' (length=6)
  'useObjectClass' => string 'Application\Entity\Category' (length=27)

array (size=6)
  'title' => 
    array (size=2)
      0 => null
      1 => string 'Food' (length=4)
  'lft' => 
    array (size=2)
      0 => null
      1 => int 0
  'lvl' => 
    array (size=2)
      0 => null
      1 => int 0
  'rgt' => 
    array (size=2)
      0 => null
      1 => int 0
  'root' => 
    array (size=2)
      0 => null
      1 => int 0
  'parent' => 
    array (size=2)
      0 => null
      1 => null

So exception here

# Nested.php #143
        if (isset($config['root']) && isset($changeSet[$config['root']])) {
            throw new \Gedmo\Exception\UnexpectedValueException("Root cannot be changed manually, change parent instead");
        }

I can't understand how to fix this.

Plz any help! Thx

Hello,

I'm using personal translations and a sluggable field. When I insert a record I get the slug only for default locale. The slug for other locales is not created. How is it supposed to work?

Thanks.

Look at:

https://github.com/comfortablynumb/DoctrineExtensions/blob/uploadable/doc/uploadable.md

Features:

• Handling of file moving and removal automatically.
• Setting of properties with information about mime type, size, etc.
• Options to allow overwrite, append a number to the file name if it already exists, etc.
• It optionally allows to give a path for each class or even individual file using a method instead of hardcoding the path in the class.
• Not limited to file uploading. It could handle files that already exist on the server (not implemented yet)
• Each of the upload errors has a custom exception
• Ability to set a callback after file is moved to the configured path
• Creating different implementations of FileInfoInterface allows to use not only uploaded files, but files from an URL, etc.
• Possibility to generate filenames. Two generators included, and an interface to implement your own generator.
• Size and mime type validation

Gedmo\Mapping\ExtensionMetadataFactory will handle pushing a reader into the mapping driver when it's working with an attribute or annotation reader. When an attribute driver is detected, it tries to provide a Gedmo\Mapping\Driver\AttributeAnnotationReader with the injected reader. However, the second argument of the Gedmo\Mapping\Driver\AttributeAnnotationReader constructor requires a Doctrine\Common\Annotations\Reader. So if the extension metadata factory is instantiated with a Gedmo\Mapping\Driver\AttributeReader passed through its constructor, things fail with a type error:

Gedmo\Mapping\Driver\AttributeAnnotationReader::__construct(): Argument #2 ($annotationReader) must be of type Doctrine\Common\Annotations\Reader, Gedmo\Mapping\Driver\AttributeReader given, called in /app/vendor/gedmo/doctrine-extensions/src/Mapping/ExtensionMetadataFactory.php on line 208

This adds a check to determine if the reader needs to be wrapped; if a Gedmo\Mapping\Driver\AttributeReader was provided, then we don't need to wrap the reader.

Hi, We get not-null sql violation from time to time when one specific entity is created. It is happening randomly without any obvious pattern.

Entity is table inheritance with

#[ORM\InheritanceType(value: 'SINGLE_TABLE')]
#[ORM\DiscriminatorColumn(name: 'discr', type: Types::STRING)]
#[ORM\DiscriminatorMap([.....])

//...

 #[ORM\Column(name: 'created_at', type: Types::DATETIMETZ_IMMUTABLE, nullable: false)]
    #[Gedmo\Timestampable(on: 'create')]
    private DateTimeImmutable $createdAt;

    #[ORM\Column(name: 'updated_at', type: Types::DATETIMETZ_IMMUTABLE, nullable: false)]
    #[Gedmo\Timestampable(on: 'update')]
    private DateTimeImmutable $updatedAt;

It happen on production with following prod specific config for doctrine (i think it is default for symfony 6.x):

when@prod:
    doctrine:
        orm:
            auto_generate_proxy_classes: false
            proxy_dir: '%kernel.build_dir%/doctrine/orm/Proxies'
            metadata_cache_driver:
                type: pool
                pool: cache.doctrine_metadata
            query_cache_driver:
                type: pool
                pool: cache.doctrine_query
            result_cache_driver:
                type: pool
                pool: cache.doctrine_result

i recall it started after switching to php attributes with Symfony 5.3+-. Right now app is Symfony 6.2 and it continue to appear as randomly as before.

Fix which i apply is to flush redis database holding prod caches + execute CLI commands which should do the same + restart all messenger workers so they get new cache / empty cache.

I have no idea what is wrong or where to start debug for last 6+ months.

Database is postgresql 14.x

Symfony 4.4 is now only getting security fixes and 5.4 is the next LTS. This will drop support for Symfony 4.4 and 5.3 in the handful of components that are used.

Hi,

It seems doctrine/orm with version 2.14 deprecates the use of the class Doctrine\ORM\Event\LifecycleEventArgs. It will be removed in ORM 3.0. (see changelog)

I think it will affect the SoftDeleteable behavior. Right?

Thanks,

Mickaël

Ref: #2554

I'm not totally sure I like making the Gedmo\DoctrineExtensions class stateful, but without ballooning the class full of rather lengthy method names or some other kind of refactoring, this is probably the easiest way to start easing the hard coupling to annotations out of this class.

This will add two state-setting methods to the Gedmo\DoctrineExtensions class:

• withAttributes - Configures the register helpers to use an attribute reader
• withAnnotations - Configures the register helpers to use an annotation reader

For B/C, the class continues to use annotations by default, but calling Gedmo\DoctrineExtensions::withAttributes() will toggle everything to attributes. The withAnnotations method is kept to have a way to toggle back to annotations for whatever reason without having to resort to reflection.

For demonstration purposes, the example app is updated to include attribute mapping as well as annotations and conditionally enables attributes when running on PHP 8. Running php example/bin/console app:print-category-translation-tree should work the same.

I've added @template T of object and @template-extends EntityRepository<T> annotations to the Tree repositories.

In my code I can do:

/**
 * @template-extends \Doctrine\ORM\EntityRepository<Foo>
 */
class FooRepository extends \Doctrine\ORM\EntityRepository
{

This is because EntityRepository has a @template annotation: https://github.com/doctrine/orm/blob/f8bf84d1aa8b67f13f9a5c1c538938eb77e66bd6/lib/Doctrine/ORM/EntityRepository.php#L36

Now static analysis and type hints can evaluate that $fooRepository->find(123) will return a Foo object.

But I can't do the same in my code for any repository extending a Tree repository:

/**
 * @template-extends \Gedmo\Tree\Entity\Repository\NestedTreeRepository<Foo>
 */
class FooRepository extends \Gedmo\Tree\Entity\Repository\NestedTreeRepository
{

These changes enable that. If you think this is a good idea, then I could also add @phpstan-return ?list<T> on children() for example to indicate that it will return an array of T.